[GitHub] [iceberg] nastra commented on a diff in pull request #6168: Build: Bump jackson from 2.11.4 to 2.14.1

2022-12-04 Thread GitBox
nastra commented on code in PR #6168: URL: https://github.com/apache/iceberg/pull/6168#discussion_r1039264542 ## core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java: ## @@ -87,7 +88,41 @@ public static void registerAll(ObjectMapper mapper) { mapper.registerModul

[GitHub] [iceberg] nastra closed issue #6263: Unable to create Iceberg Table using HIVE

2022-12-04 Thread GitBox
nastra closed issue #6263: Unable to create Iceberg Table using HIVE URL: https://github.com/apache/iceberg/issues/6263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [iceberg] kowshikdremio commented on issue #6263: Unable to create Iceberg Table using HIVE

2022-12-04 Thread GitBox
kowshikdremio commented on issue #6263: URL: https://github.com/apache/iceberg/issues/6263#issuecomment-1336829158 Hi, I added the below jars to the HIVE lib directory and it all works fine now. 1.iceberg-hive-runtime-1.2.0-SNAPSHOT.jar ( Got it by running ./gradlew build -x te

[GitHub] [iceberg] aajisaka opened a new pull request, #6358: AWS: Print debug log when Glue optimistic locking is used

2022-12-04 Thread GitBox
aajisaka opened a new pull request, #6358: URL: https://github.com/apache/iceberg/pull/6358 ### Background Glue optimistic locking is automatically enabled if aws-java-sdk version is >= 2.17.131, however, users sometimes cannot check what version of aws-java-sdk is actually used in t

[GitHub] [iceberg] hililiwei commented on a diff in pull request #5967: Flink: Support read options in flink source

2022-12-04 Thread GitBox
hililiwei commented on code in PR #5967: URL: https://github.com/apache/iceberg/pull/5967#discussion_r1039172223 ## docs/flink-getting-started.md: ## @@ -683,7 +683,47 @@ env.execute("Test Iceberg DataStream"); OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the

[GitHub] [iceberg] hililiwei commented on a diff in pull request #5967: Flink: Support read options in flink source

2022-12-04 Thread GitBox
hililiwei commented on code in PR #5967: URL: https://github.com/apache/iceberg/pull/5967#discussion_r1039158054 ## flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java: ## @@ -349,6 +401,8 @@ public IcebergSource build() { throw new Unchec

[GitHub] [iceberg] hililiwei commented on a diff in pull request #5967: Flink: Support read options in flink source

2022-12-04 Thread GitBox
hililiwei commented on code in PR #5967: URL: https://github.com/apache/iceberg/pull/5967#discussion_r1039153740 ## flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java: ## @@ -335,8 +365,30 @@ public Builder exposeLocality(boolean newExposeLocalit

[GitHub] [iceberg] hililiwei commented on a diff in pull request #5967: Flink: Support read options in flink source

2022-12-04 Thread GitBox
hililiwei commented on code in PR #5967: URL: https://github.com/apache/iceberg/pull/5967#discussion_r1039153155 ## flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java: ## @@ -335,8 +365,30 @@ public Builder exposeLocality(boolean newExposeLocalit

[GitHub] [iceberg] hililiwei commented on a diff in pull request #5967: Flink: Support read options in flink source

2022-12-04 Thread GitBox
hililiwei commented on code in PR #5967: URL: https://github.com/apache/iceberg/pull/5967#discussion_r1039152100 ## flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java: ## @@ -427,25 +386,25 @@ public Builder maxPlanningSnapshotCount(int newMaxPlann

[GitHub] [iceberg] hililiwei commented on a diff in pull request #5967: Flink: Support read options in flink source

2022-12-04 Thread GitBox
hililiwei commented on code in PR #5967: URL: https://github.com/apache/iceberg/pull/5967#discussion_r1039148936 ## docs/flink-getting-started.md: ## @@ -683,7 +683,47 @@ env.execute("Test Iceberg DataStream"); OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the

[GitHub] [iceberg] hililiwei commented on a diff in pull request #5967: Flink: Support read options in flink source

2022-12-04 Thread GitBox
hililiwei commented on code in PR #5967: URL: https://github.com/apache/iceberg/pull/5967#discussion_r1039148512 ## docs/flink-getting-started.md: ## @@ -683,7 +683,47 @@ env.execute("Test Iceberg DataStream"); OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the

[GitHub] [iceberg] gong commented on pull request #2680: Core: Add RocksDBStructLikeMap

2022-12-04 Thread GitBox
gong commented on PR #2680: URL: https://github.com/apache/iceberg/pull/2680#issuecomment-1336717074 > > For example, we have a TiDB table that has six hundred million records. If we use flink streaming mode, it will cost too much time > > @coolderli Are you using the latest flink cdc

[GitHub] [iceberg] gong commented on pull request #2680: Core: Add RocksDBStructLikeMap

2022-12-04 Thread GitBox
gong commented on PR #2680: URL: https://github.com/apache/iceberg/pull/2680#issuecomment-1336715567 > @openinx Hello, Will not OOM be triggered if we use mysql-cdc2.0? Because mysql-cdc2.0 checkpoint in chunk level ? -- This is an automated message from the Apache Git Service. To

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6335: Core: Avoid generating a large ManifestFile when committing

2022-12-04 Thread GitBox
amogh-jahagirdar commented on code in PR #6335: URL: https://github.com/apache/iceberg/pull/6335#discussion_r1039115360 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -948,13 +949,10 @@ private List newDeleteFilesAsManifests() { (specId,

[GitHub] [iceberg] rdblue opened a new pull request, #6357: Core: Remove TableOperations from metadata tables.

2022-12-04 Thread GitBox
rdblue opened a new pull request, #6357: URL: https://github.com/apache/iceberg/pull/6357 This removes the use of `TableOperations` from metadata tables. Where `TableMetadata` is needed, operations is fetched from the `Table` instance instead of passing the ops explicitly. This is in prepar

[GitHub] [iceberg] stevenzwu commented on pull request #6305: API: Override `equals` and `hashCode` methods for primitive types

2022-12-04 Thread GitBox
stevenzwu commented on PR #6305: URL: https://github.com/apache/iceberg/pull/6305#issuecomment-1336556429 thanks @smallx for the contribution and @pvary for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [iceberg] stevenzwu merged pull request #6305: API: Override `equals` and `hashCode` methods for primitive types

2022-12-04 Thread GitBox
stevenzwu merged PR #6305: URL: https://github.com/apache/iceberg/pull/6305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6299: Flink: support split discovery throttling for streaming read

2022-12-04 Thread GitBox
stevenzwu commented on code in PR #6299: URL: https://github.com/apache/iceberg/pull/6299#discussion_r1039049527 ## flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/enumerator/EnumerationHistory.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [iceberg] Fokko merged pull request #6346: Python: Fix PyArrow Type conversion

2022-12-04 Thread GitBox
Fokko merged PR #6346: URL: https://github.com/apache/iceberg/pull/6346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

[GitHub] [iceberg] rdblue commented on a diff in pull request #6168: Build: Bump jackson from 2.11.4 to 2.14.1

2022-12-04 Thread GitBox
rdblue commented on code in PR #6168: URL: https://github.com/apache/iceberg/pull/6168#discussion_r1039013799 ## core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java: ## @@ -87,7 +88,41 @@ public static void registerAll(ObjectMapper mapper) { mapper.registerModul