hililiwei commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1039153155
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -335,8 +365,30 @@ public Builder<T> exposeLocality(boolean
newExposeLocality) {
return this;
}
+ /**
+ * Set the read properties for Flink source. View the supported properties
in {@link
+ * FlinkReadOptions}
+ */
+ public Builder<T> set(String property, String value) {
+ readOptions.put(property, value);
+ return this;
+ }
+
+ /**
+ * Set the read properties for Flink source. View the supported properties
in {@link
+ * FlinkReadOptions}
+ */
+ public Builder<T> setAll(Map<String, String> properties) {
Review Comment:
To keep consistent with the sink style, `setAll` is retained and
`properties` is marked as deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
