rdblue commented on code in PR #6168:
URL: https://github.com/apache/iceberg/pull/6168#discussion_r1039013799


##########
core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java:
##########
@@ -87,7 +88,41 @@ public static void registerAll(ObjectMapper mapper) {
     mapper.registerModule(module);
   }
 
-  public static class UpdateRequirementDeserializer extends 
JsonDeserializer<UpdateRequirement> {
+  // 
https://github.com/FasterXML/jackson-databind/commit/da339636d6a1db6fd618f1e59816fab3bb6d38d4
+  // added JacksonException to the throws declaration of 
JsonDeserializer#deserialize*(...)
+  // The purpose of this class is so that we don't propagate this API-breaking 
throws-change to any
+  // Iceberg clients

Review Comment:
   Can we suppress the revapi issue to avoid adding unnecessary code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to