On Friday, December 31, 2010 14:22:31 Enrico Weigelt wrote:
> * Mike Frysinger schrieb:
> > On Friday, December 31, 2010 09:16:27 Enrico Weigelt wrote:
> > > * Mike Frysinger schrieb:
> > > > sounds like overkill. people will file bugs and they'll get fixed.
> > > > once it goes fatal, people wil
> "MF" == Mike Frysinger writes:
MF> along those lines, we should start rejecting relative paths. we
MF> cant auto- skip the leading elements since relative paths could
MF> appear anywhere.
You do not need .. or . in a path for it to be a relative path.
:; diff -uNr a/foo b/foo
generates
* Mike Frysinger schrieb:
> On Friday, December 31, 2010 09:16:27 Enrico Weigelt wrote:
> > * Mike Frysinger schrieb:
> > > sounds like overkill. people will file bugs and they'll get fixed. once
> > > it goes fatal, people will fix even faster. i dont plan on making it
> > > fatal anytime soo
On Friday, December 31, 2010 09:16:27 Enrico Weigelt wrote:
> * Mike Frysinger schrieb:
> > sounds like overkill. people will file bugs and they'll get fixed. once
> > it goes fatal, people will fix even faster. i dont plan on making it
> > fatal anytime soon.
>
> An option to make it fatal wo
* Mike Frysinger schrieb:
> sounds like overkill. people will file bugs and they'll get fixed. once it
> goes fatal, people will fix even faster. i dont plan on making it fatal
> anytime soon.
An option to make it fatal would be helpful.
cu
--
On Friday, December 31, 2010 02:02:40 Robin H. Johnson wrote:
> On Fri, Dec 31, 2010 at 12:17:26AM -0500, Mike Frysinger wrote:
> > http://dev.gentoo.org/~vapier/clean-patches
>
> Nice document. Just two contradictory points that I've noticed been
> useful:
> 1. Sometimes I've been given patch
On Fri, Dec 31, 2010 at 12:17:26AM -0500, Mike Frysinger wrote:
> On Thursday, December 30, 2010 21:03:54 Enrico Weigelt wrote:
> > * Mike Frysinger schrieb:
> > > On Thursday, December 30, 2010 20:05:01 Enrico Weigelt wrote:
> > > > IMHO, in longer terms, all patches should normalized, created w/
On Thursday, December 30, 2010 21:01:49 Markos Chandras wrote:
> On Thu, Dec 30, 2010 at 08:28:42PM -0500, Mike Frysinger wrote:
> > + eqawarn "QA Notice: Your patch has relative paths."
> > + eqawarn " In the future this will cause a failure."
>
> Maybe we shou
On Thursday, December 30, 2010 21:03:54 Enrico Weigelt wrote:
> * Mike Frysinger schrieb:
> > On Thursday, December 30, 2010 20:05:01 Enrico Weigelt wrote:
> > > IMHO, in longer terms, all patches should normalized, created w/
> > > diff -ruN and applied w/ -p1. Thats how most people do it, so
> >
* Mike Frysinger schrieb:
> On Thursday, December 30, 2010 20:05:01 Enrico Weigelt wrote:
> > IMHO, in longer terms, all patches should normalized, created w/
> > diff -ruN and applied w/ -p1. Thats how most people do it, so
> > a kind of semi-standard.
>
> not worth developer's time to force it
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 12/30/2010 07:28 PM, Mike Frysinger wrote:
> On Thursday, December 30, 2010 19:42:35 Robin H. Johnson wrote:
>> On Thu, Dec 30, 2010 at 07:04:25PM -0500, Mike Frysinger wrote:
>>> epatch was changed to auto-skip the first path element when it is
>>>
On Thu, Dec 30, 2010 at 08:28:42PM -0500, Mike Frysinger wrote:
> On Thursday, December 30, 2010 19:42:35 Robin H. Johnson wrote:
> > On Thu, Dec 30, 2010 at 07:04:25PM -0500, Mike Frysinger wrote:
> > > epatch was changed to auto-skip the first path element when it is
> > > absolute (starts with a
On Thursday, December 30, 2010 19:42:35 Robin H. Johnson wrote:
> On Thu, Dec 30, 2010 at 07:04:25PM -0500, Mike Frysinger wrote:
> > epatch was changed to auto-skip the first path element when it is
> > absolute (starts with a slash). the reason was to avoid issues with
> > patches touching files
On Thursday, December 30, 2010 20:05:01 Enrico Weigelt wrote:
> IMHO, in longer terms, all patches should normalized, created w/
> diff -ruN and applied w/ -p1. Thats how most people do it, so
> a kind of semi-standard.
not worth developer's time to force it since it poses no practical positive
b
* Robin H. Johnson schrieb:
> On Thu, Dec 30, 2010 at 07:04:25PM -0500, Mike Frysinger wrote:
> > epatch was changed to auto-skip the first path element when it is absolute
> > (starts with a slash). the reason was to avoid issues with patches touching
> > files outside of $PWD (which is bad if s
On Thu, Dec 30, 2010 at 07:04:25PM -0500, Mike Frysinger wrote:
> epatch was changed to auto-skip the first path element when it is absolute
> (starts with a slash). the reason was to avoid issues with patches touching
> files outside of $PWD (which is bad if sandbox is disabled).
+1 from me, but
epatch was changed to auto-skip the first path element when it is absolute
(starts with a slash). the reason was to avoid issues with patches touching
files outside of $PWD (which is bad if sandbox is disabled).
along those lines, we should start rejecting relative paths. we cant auto-
skip the
17 matches
Mail list logo
