On Fri, Dec 31, 2010 at 12:17:26AM -0500, Mike Frysinger wrote: > On Thursday, December 30, 2010 21:03:54 Enrico Weigelt wrote: > > * Mike Frysinger <vap...@gentoo.org> schrieb: > > > On Thursday, December 30, 2010 20:05:01 Enrico Weigelt wrote: > > > > IMHO, in longer terms, all patches should normalized, created w/ > > > > diff -ruN and applied w/ -p1. Thats how most people do it, so > > > > a kind of semi-standard. > > > > > > not worth developer's time to force it since it poses no practical > > > positive benefit to us > > > > It makes it easier for everyone who'll want to work on these > > patches (eg. people besides the actual ebuild maintainers). > > > > BTW: I'm not proposing to rework all the patches right now, > > just set a policy for new ones. > > suggestions are fine, but these arent a requirement we're going to force on > developers. i already put together a list of suggestions for people long ago: > http://dev.gentoo.org/~vapier/clean-patches Nice document. Just two contradictory points that I've noticed been useful: 1. Sometimes I've been given patches without information as to which version they apply to. The timestamp on the --- line was critical to tracing that, because it matched the source timestamp in the SCM. 2. The .orig suffix on the --- line has been very useful in seeing that somebody accidentally reversed the patch when generating it.
One additional request: Using RFC822-style headers for patch text data. Nice example in many of our MySQL patches, like this one: ==== Gentoo-Bug: 238487 Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=238487 MySQL-Bug-URL: http://bugs.mysql.com/bug.php?id=39288 MySQL-Bug: 39288 MySQL-Lists-URL: http://lists.mysql.com/internals/35947 X-Patch-URL: http://bugs.gentoo.org/attachment.cgi?id=188019&action=view Signed-off-by: Jorge Manuel B. S. Vicetto <jmbsvice...@gentoo.org> Signed-off-by: Robin H. Johnson <robb...@gentoo.org> Signed-off-by: Kristian Nielsen <kniel...@knielsen-hq.org> ==== The above taken from: http://git.overlays.gentoo.org/gitweb/?p=proj/mysql-extras.git;a=blob_plain;f=02040_all_embedded-library-shared-maria-5.1.50.patch;hb=499f0f3c94f6d4dc1c46adafc622e9583ee6a315 -- Robin Hugh Johnson Gentoo Linux: Developer, Trustee & Infrastructure Lead E-Mail : robb...@gentoo.org GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
