On Friday, December 31, 2010 02:02:40 Robin H. Johnson wrote:
> On Fri, Dec 31, 2010 at 12:17:26AM -0500, Mike Frysinger wrote:
> >     http://dev.gentoo.org/~vapier/clean-patches
> 
> Nice document. Just two contradictory points that I've noticed been
> useful:
> 1. Sometimes I've been given patches without information as to which
> version they apply to. The timestamp on the --- line was critical to
> tracing that, because it matched the source timestamp in the SCM.

i wouldnt say it's contradictory ... if my advice was followed, this sleuthing 
wouldnt have been necessary, and thus the timestamp is still useless.

> 2. The .orig suffix on the --- line has been very useful in seeing that
> somebody accidentally reversed the patch when generating it.

meh.  i think this is minor/rare enough to ignore.

> One additional request: Using RFC822-style headers for patch text data.

i'll add these tips inline with the other stuff
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to