On 2021-07-13 18:35, William Hubbs wrote:
>> are there any non-cosmetic reasons for doing this?
Consistency with the rest of the tree. If you do a "git grep _R0" on the
eclass directory, the lua eclasses are the only ones that have this in
the names of the guard variables, and the eclasses the
On Mon, Jul 12, 2021 at 11:24:42AM +0100, Marek Szuba wrote:
> On 2021-07-10 22:55, William Hubbs wrote:
>
> > Change the _R0 suffix on these variable names to _ECLASS.
>
> Since my question in response to the previous round of this has yet to
> be answered, I repeat: are there any non-cosmetic
On 2021-07-10 22:55, William Hubbs wrote:
Change the _R0 suffix on these variable names to _ECLASS.
Since my question in response to the previous round of this has yet to
be answered, I repeat: are there any non-cosmetic reasons for doing this?
--
Marecki
OpenPGP_signature
Description: O
Change the _R0 suffix on these variable names to _ECLASS.
Signed-off-by: William Hubbs
---
eclass/lua-single.eclass | 10 +++---
eclass/lua-utils.eclass | 8
eclass/lua.eclass| 12 +---
3 files changed, 12 insertions(+), 18 deletions(-)
diff --git a/eclass/lua-sing
On 2021-07-06 22:59, William Hubbs wrote:
Change the _R0 suffix on these variable names to _ECLASS.
Any non-cosmetic reasons for doing this?
--
Marecki
OpenPGP_signature
Description: OpenPGP digital signature
> On Tue, 06 Jul 2021, William Hubbs wrote:
> -_LUA_SINGLE_R0=1
> +_LUA_SINGLE_ECLASS=1
> fi
These should be assigned immediately after the test near the top of the
eclass, before any inherit statement. Otherwise, circular inheritance
won't be prevented.
Ulrich
signature.asc
Description:
> On 6 Jul 2021, at 22:59, William Hubbs wrote:
>
> Change the _R0 suffix on these variable names to _ECLASS.
> Signed-off-by: William Hubbs
Seems good, thanks William!
> [snip]
best,
sam
signature.asc
Description: Message signed with OpenPGP
Change the _R0 suffix on these variable names to _ECLASS.
Signed-off-by: William Hubbs
---
eclass/lua-single.eclass | 8
eclass/lua-utils.eclass | 8
eclass/lua.eclass| 8
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/eclass/lua-single.eclass
