On 2021-07-13 18:35, William Hubbs wrote: >> are there any non-cosmetic reasons for doing this?
Consistency with the rest of the tree. If you do a "git grep _R0" on the eclass directory, the lua eclasses are the only ones that have this in the names of the guard variables, and the eclasses themselves aren't named lua-r0.eclass etc. What will break if I do this?
Nothing should, given that eclass guard variables should have no interactions with anything other than respective eclasses themselves. Of course that means this change *is* purely cosmetic... especially considering that while _FOO_ECLASS is currently the most common format in the tree it is by no means the only one, and that revision 0 is technically speaking a real thing that we just happen to treat as default and omit from names for brevity.
I've got no preference either way as long as guard variables can easily be searched for in eclass code, so if you haven't got anything more important to work on in Gentoo go ahead.
-- Marecki
OpenPGP_signature
Description: OpenPGP digital signature
