[Patch, aarch64] Issue warning/error for mixing functions with/without aarch64_vector_pcs attribute

2019-02-13 Thread Steve Ellcey
r an error because the testsuite adds -pedantic- errors to the compile line. Without this you would just get a warning, but that is consistent with any mixing of different function types in a function pointer assignment. Tested with a bootstrap build and test run on aarch64. OK for checkin? Steve E

Re: Fortran vector math header

2019-02-14 Thread Steve Ellcey
multilib_abi_name target function for that platform. Everything seemed to work fine for me and I did not have any problems or see any regressions when using your patch. I hope it gets approved and checked in soon. Steve Ellcey sell...@marvell.com

Re: [PATCH PR79868 ][aarch64] Fix error calls in aarch64 code so they can be translated (version 2)

2017-10-24 Thread Steve Ellcey
Thanks for looking at this Frederic,  I don't see your name in the MAINTAINERS list so I assume I still need approval from one of the diagnostic message maintainers (Dodji or David) or maybe an Aarch64 maintainer or a global maintainer. Ping? Steve Ellcey sell...@cavium.com On Sun, 2017-

Re: [PATCH][aarch64] Put vector fnma instruction into canonical form for better code generation.

2017-10-24 Thread Steve Ellcey
Ping. Steve Ellcey On Fri, 2017-10-06 at 14:01 -0700, Steve Ellcey wrote: > This patch is a follow up to a discussion at: > > https://gcc.gnu.org/ml/gcc/2017-06/msg00126.html > > For some reason the simd version of fnma in aarch64-simd.md > is not in the canonical form

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-10-24 Thread Steve Ellcey
Ping. Steve Ellcey sell...@cavium.com On Tue, 2017-10-03 at 11:57 -0700, Steve Ellcey wrote: > On Mon, 2017-10-02 at 15:38 +0100, Szabolcs Nagy wrote: > > > >   > > looks good to me, but i cannot approve. > > > > (this will make libatomic depend on ifuncs on aa

Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-10-24 Thread Steve Ellcey
Re-ping. Steve Ellcey sell...@cavium.com On Mon, 2017-09-25 at 10:36 -0700, Steve Ellcey wrote: > Ping. > > Steve Ellcey > sell...@cavium.com > > > On Fri, 2017-09-15 at 11:22 -0700, Steve Ellcey wrote: > > > > PR 81356 points out that doing a __bui

Re: [PATCH][aarch64] Fix target/pr77729 - missed optimization related to zero extension

2017-10-24 Thread Steve Ellcey
Ping.  There was discussion of larger fixes for this including a type promotion pass but this patch seems small, safe, and in line with other platforms (like arm32). Steve Ellcey sell...@cavium.com On Thu, 2017-09-14 at 11:43 -0700, Steve Ellcey wrote: > On Thu, 2017-09-14 at 11:53 -0600, J

Re: [PATCH PR79868 ][aarch64] Fix error calls in aarch64 code so they can be translated (version 2)

2017-10-30 Thread Steve Ellcey
hlighting it's > trivial to tell which subcase of usage is being referred to. > > R. I have no problem with that.  Here is a version that uses "pragma or attribute". Tested on ToT with no regressions.  Ok to checkin? Steve Ellcey sell...@cavium.com ChangeLog:

Re: [PATCH PR79868 ][aarch64] Fix error calls in aarch64 code so they can be translated (version 2)

2017-10-31 Thread Steve Ellcey
sted by Martin in that same thread at: https://gcc.gnu.org/ml/gcc-patches/2017-09/msg01277.html https://gcc.gnu.org/ml/gcc-patches/2017-09/msg01469.html as being more consistent with other usage (mainly config/i386/i386.c). Steve Ellcey sell...@cavium.com

ToT build failure?

2017-07-06 Thread Steve Ellcey
ble-shared --disable-decimal-float --disable-libsanitizer --disable-bootstrap This is an x86 to aarch64 cross compiler. Steve Ellcey sell...@cavium.com

[PING][PATCH][aarch64] Enable ifunc resolver attribute by default

2017-07-21 Thread Steve Ellcey
This is a ping for my patch to enable the ifunc resolver by default for aarch64. https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00806.html Steve Ellcey sell...@cavium.com

[Patch] Testsuite fixes for failures caused by patch for PR 80925 - loop peeling and alignment

2017-07-27 Thread Steve Ellcey
s not mention peeling, but it was affected by the same checkins as the others. Any comments from the power and/or vectorizer folks? Steve Ellcey sell...@cavium.com 2017-07-27  Steve Ellcey   PR tree-optimization/80925 * gcc.dg/vect/no-section-anchors-vect-69.c: Add vect_peel_

Re: [Patch] Testsuite fixes for failures caused by patch for PR 80925 - loop peeling and alignment

2017-07-28 Thread Steve Ellcey
On Fri, 2017-07-28 at 09:47 +0200, Richard Biener wrote: > On Fri, Jul 28, 2017 at 12:16 AM, Steve Ellcey wrote: > >  > > Any comments from the power and/or vectorizer folks? > On one side I'm inclined to simplify the testsuite by adding > --param vect-max-peeling-for-

[Patch] Testsuite fixes for failures caused by patch for PR 80925 (part deux)

2017-07-31 Thread Steve Ellcey
Here is a second set of patches to fix tests that started failing with the patch for PR 80925.  It uses the same testsuite changes I did for no-section-anchors-vect-69.c and section-anchors-vect-69.c on new set of gcc.dg/vect/vect-* tests. 2017-07-31  Steve Ellcey   PR tree-optimization

Re: c-family PATCH to improve and simplify -Wmultistatement-macros (PR c/81448, c/81306)

2017-08-02 Thread Steve Ellcey
esent). I have built and tested the latest glibc with the latest gcc and after removing the warnings from the Makefile, everything ran fine.  There were no build problems. Since the mainline is now open I will go ahead and check in this patch. Steve Ellcey sell...@cavium.com 2017-08-02  Steve Ellce

[Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-08-07 Thread Steve Ellcey
it is useful, both for testing and for end users. Tested on aarch64, OK for checkin? Steve Ellcey sell...@cavium.com 2017-08-07  Steve Ellcey   * Makefile.am (ARCH_AARCH64_LINUX_LSE): Add IFUNC_OPTIONS and libatomic_la_LIBADD. * config/linux/aarch64/host-config.h: New

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-08-07 Thread Steve Ellcey
It would probably help if I included the patch. Steve Ellcey sell...@cavium.com 2017-08-07  Steve Ellcey   * Makefile.am (ARCH_AARCH64_LINUX_LSE): Add IFUNC_OPTIONS and libatomic_la_LIBADD. * config/linux/aarch64/host-config.h: New file. * config/linux/aarch64

Re: [Patch] Testsuite fixes for failures caused by patch for PR 80925 - loop peeling and alignment

2017-08-07 Thread Steve Ellcey
t reproduce the error using that.  I am not sure why. Steve Ellcey sell...@cavium.com On Fri, 2017-08-04 at 16:27 +0200, Rainer Orth wrote: > Richard Biener writes: > > > > > On Fri, Jul 28, 2017 at 8:22 PM, Steve Ellcey > > wrote: > > > > > >

[Patch][AARCH64] Fix PR 81643 by modifying test case.

2017-08-10 Thread Steve Ellcey
x27;t think it is worth the time to find it and so I would like to just remove the check so that the testcase no longer fails. OK for checkin? Tested on aarch64. Steve Ellcey sell...@cavium.com 2017-08-10 Steve Ellcey PR target/81643 * gcc.target/aarch64/long_branch_1.c: R

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-08-24 Thread Steve Ellcey
Ping. > 2017-08-07  Steve Ellcey   > > * Makefile.am (ARCH_AARCH64_LINUX_LSE): Add IFUNC_OPTIONS and > libatomic_la_LIBADD. > * config/linux/aarch64/host-config.h: New file. > * config/linux/aarch64/init.c: New file. > * configure.ac (AC_CHEC

[PATCH] Fix fortran vector tests on powerpc and aarch64, PR tree-optimization/80925

2017-08-25 Thread Steve Ellcey
My earlier patch to update tests and resolve PR tree-optimization/80925 did not include FORTRAN, just C and C++.  This patch makes the same changes as the earlier patches but for FORTRAN.  Tested on aarch64. OK to checkin? Steve Ellcey sell...@cavium.com Orginal patches/discussion is at: https

[PATCH] Fix fortran tests to not print out non-ascii characters

2017-08-25 Thread Steve Ellcey
the problem to these 3 tests that are printing out 0 valued character variables.  The variables are supposed to be 0, because that is what the test is checking for, so my fix is to print out the ichar value of the character variable instead of the variable itself. Steve Ellcey sell...@cavium.com

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-08-28 Thread Steve Ellcey
res; } __asm__ (".type " "__libc_memcpy" ", %gnu_indirect_function"); extern __typeof (__libc_memcpy) memcpy __attribute__ ((alias ("__libc_memcpy"))); Steve Ellcey sell...@cavium.com

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-08-30 Thread Steve Ellcey
ill have to update the libatomic configure.tgt script as well to set the resolver arg type when I resbumit the gcc libatomic patch so that we can have the correct prototype in libatomic_i.h. Steve Ellcey sell...@cavium.com

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-08-31 Thread Steve Ellcey
to access it they can change the type if necessary. Steve Ellcey sell...@cavium.com 2017-08-31  Steve Ellcey   * Makefile.am (ARCH_AARCH64_LINUX_LSE): Add IFUNC_OPTIONS and libatomic_la_LIBADD. * config/linux/aarch64/host-config.h: New file. * configure.a

Ping on three small aarch64 patches

2017-08-31 Thread Steve Ellcey
) Steve Ellcey sell...@cavium.com

Re: [PATCH][aarch64] Enable ifunc resolver attribute by default

2017-09-05 Thread Steve Ellcey
e setting of default_gnu_indirect_function, but I don't think I changed any defaults. Steve Ellcey sell...@cavium.com 2017-09-05  Steve Ellcey   * config.gcc: Add new case statement to set default_gnu_indirect_function.  Remove it from x86_64-*-linux*,

[PATCH] Fix PR 81096 (ttest failures)

2017-09-11 Thread Steve Ellcey
This patch fixes the ttest failures on aarch64 by adding AM_CFLAGS to the test options, like btest already does and as Wilco says works for him in Comment #4 of the bug report. Tested by me on aarch64.  Ok to checkin? Steve Ellcey sell...@cavium.com 2017-09-11  Steve Ellcey   PR other

[PATCH] Alias analysis of zero sized arrays

2017-04-25 Thread Steve Ellcey
, store, load, store and that was working.  With this patch, both versions (-UFLEX and -DFLEX) generate the load, store, load, store sequence. OK for checkin? Steve Ellcey sell...@cavium.com 2017-04-25  Steve Ellcey   * tree-dfa.c (get_ref_base_and_extent): Treat zero size array like

Re: [PATCH] Alias analysis of zero sized arrays

2017-04-26 Thread Steve Ellcey
de though both versions worked OK. I did a full bootstrap and gcc testsuite run on aarch64 with no regressions.  Will you check this in or do you want me to do a submission and checkin? Steve Ellcey sell...@cavium.com

Re: [PATCH] Alias analysis of zero sized arrays

2017-04-26 Thread Steve Ellcey
kely requires -fschedule-insns to trigger. > > Richard. I created bug 80533.  The problem was found on the gcc-5 branch and is also on the gcc-6 and gcc-7 branches. Steve Ellcey

[PATCH/AARCH64] Improve aarch64 conditional compare usage

2017-05-01 Thread Steve Ellcey
ate a ccmp instruction with the change.  I ran the SPEC2006 int tests and got a .02 increase in the SPECmark on a ThunderX box. The biggest increases were in mcf and astar.  One test, xlancbmk, did slow down but the overall SPEC result was a speedup. OK for checkin? Steve Ellcey sell...@cavium

[PATCH] Fix -fopt-info documentation in invoke.texi

2017-05-03 Thread Steve Ellcey
Steve Ellcey sell...@cavium.com 2017-05-03  Steve Ellcey   * doc/invoke.texi (-fopt-info): Fix description of default behavour. Explicitly say order of options included in -fopt-info does not matter. diff --git a/gcc/doc/optinfo.texi b/gcc/doc/optinfo.texi index e17cb37..f4

Re: [PATCH] Fix -fopt-info documentation in invoke.texi

2017-05-04 Thread Steve Ellcey
were) I will go ahead and check this in tomorrow unless there are objections. Steve Ellcey sell...@cavium.com 2017-05-05  Steve Ellcey   * doc/invoke.texi (-fopt-info): Explicitly say order of options included in -fopt-info does not matter. * doc/optinfo.texi (-fopt-info

Re: [PATCH] Fix PR 81096 (ttest failures)

2017-09-12 Thread Steve Ellcey
On Tue, 2017-09-12 at 09:39 -0700, Ian Lance Taylor wrote: > On Tue, Sep 12, 2017 at 3:59 AM, Wilco Dijkstra om> wrote: > > > > Steve Ellcey wrote: > > > > > > This patch fixes the ttest failures on aarch64 by adding > > > AM_CFLAGS to > >

Re: [PATCH] Fix PR 81096 (ttest failures)

2017-09-12 Thread Steve Ellcey
On Tue, 2017-09-12 at 09:39 -0700, Ian Lance Taylor wrote: > On Tue, Sep 12, 2017 at 3:59 AM, Wilco Dijkstra om> wrote: > > > > Steve Ellcey wrote: > > > > > > This patch fixes the ttest failures on aarch64 by adding > > > AM_CFLAGS to > >

Re: [PATCH] Fix fortran vector tests on powerpc and aarch64, PR tree-optimization/80925

2017-09-12 Thread Steve Ellcey
Ping,  also adding fort...@gcc.gnu.org which I seem to left out when sending this to gcc-patches@gcc.gnu.org. Steve On Fri, 2017-08-25 at 09:46 -0700, Steve Ellcey wrote: > My earlier patch to update tests and resolve PR tree- > optimization/80925 > did not include FORTRAN, jus

[PATCH][aarch64] Fix target/pr77729 - missed optimization related to zero extension

2017-09-13 Thread Steve Ellcey
with a bootstrap and testsuite run that had no regressions. OK to checkin? 2017-09-13  Steve Ellcey   PR target/77729 * config/aarch64/aarch64.c (aarch64_rtx_costs): Handle cost of *iorqi3_uxtw instruction. * config/aarch64/aarch64.md (*iorqi3_uxtw): New ins

[PATCH] Fix PR target/82066 - target pragma and attribute documentation for ARM, AArch64, and S/390

2017-09-13 Thread Steve Ellcey
This patch fixes the documentation issues pointed out in PR target/82066. It may be considered obvious enough to just check in but I'd rather have someone look it over to make sure I didn't mess something up. Steve Ellcey sell...@cavium.com 2017-09-13  Steve Ellcey   PR ta

Re: [PATCH][aarch64] Fix target/pr77729 - missed optimization related to zero extension

2017-09-13 Thread Steve Ellcey
but for aarch64 I only know that I set the bottom 8 bits and I don't know anything about the higher bits, meaning I have to keep the AND instruction to mask out the upper bits on aarch64. I think we should change the movqi/movhi expansions on aarch64 to recognize that the ldrb/ldrh instructions

Re: [PATCH][aarch64] Fix target/pr77729 - missed optimization related to zero extension

2017-09-13 Thread Steve Ellcey
On Wed, 2017-09-13 at 22:39 +, Wilco Dijkstra wrote: > Steve Ellcey wrote: > > > And in aarch64 rtl expansion I see: > > > > (insn 10 9 11 (set (reg:QI 81) > > (mem:QI (reg/v/f:DI 80 [ string ]) [0 *string_9(D)+0 S1 > A8])) "pr77729.c":3

Re: [PATCH][aarch64] Fix target/pr77729 - missed optimization related to zero extension

2017-09-14 Thread Steve Ellcey
On Thu, 2017-09-14 at 09:03 -0600, Jeff Law wrote: > On 09/13/2017 03:46 PM, Steve Ellcey wrote: > >  > > In arm32 rtl expansion, when reading the QI memory location, I see > > these instructions get generated: > > > > (insn 10 3 11 2 (set (reg:SI 119) > >

Re: [PATCH][aarch64] Fix target/pr77729 - missed optimization related to zero extension

2017-09-14 Thread Steve Ellcey
e on aarch64 but I thought it helped make it clear what we were doing and the compiler should optimize it away anyway. OK to checkin this fix while we consider longer term options? Steve Ellcey sell...@cavium.com 2017-09-14  Steve Ellcey   PR target/77729 * config/aarch64/aa

[PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-09-15 Thread Steve Ellcey
option as well. Bootstrapped and tested without regressions, OK to checkin? Steve Ellcey sell...@cavium.com 2017-09-15  Steve Ellcey   PR target/81356 * config/aarch64/aarch64.c (aarch64_use_by_pieces_infrastructure_p): Remove. (TARGET_USE_BY_PIECES_INFRAS

[PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-18 Thread Steve Ellcey
ederic Marchal found in my original patch. OK to checkin? Steve Ellcey sell...@cavium.com 2017-09-18  Steve Ellcey   PR target/79868 * config/aarch64/aarch64-c.c (aarch64_pragma_target_parse): Change argument type on aarch64_process_target_attr call.

Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-19 Thread Steve Ellcey
<...%>' described somewhere?  These aren't normal printf options are they?  I don't think I have ever used them before.  I am also not sure why you have '%s=' means vs. '%s'.  Is it even worth breaking the word 'arch' out of the string vs. having something like: error (is_pragma ? G_("missing name in %<#pragma target \"arch\"%>) : G_("missing name in % attribute")); Steve Ellcey sell...@cavium.com

Re: [PATCH] detect incompatible aliases (PR c/81854)

2017-09-20 Thread Steve Ellcey
h. > Done in r252976. > > Thanks > Martin This patch is causing my gcc/glibc ToT build to fail on aarch64.  I am not sure if everything should be working at this point or not or if there is more that needs to be done.  The problem is with the memcpy, memmove, etc. ifuncs on aarch64.

Re: [PATCH] detect incompatible aliases (PR c/81854)

2017-09-20 Thread Steve Ellcey
On Wed, 2017-09-20 at 10:17 -0600, Martin Sebor wrote: >  > The comment copied below from sysdeps/aarch64/multiarch/memmove.c > suggests this might be deliberate: > > /* Redefine memmove so that the compiler won't complain about the > type > mismatch with the IFUNC selector in strong_alias, be

Re: [PATCH] detect incompatible aliases (PR c/81854)

2017-09-20 Thread Steve Ellcey
Interesting new data point.  aarch64 GCC does not enable the resolver/indirect function feature by default (--enable-gnu-indirect- function is not set by default).  If I enable this on the GCC build then GCC can build glibc.  Without it, the glibc build fails. Steve Ellcey sell...@cavium.com On

Re: [PATCH] detect incompatible aliases (PR c/81854)

2017-09-20 Thread Steve Ellcey
_gcc_indirect_function" != xyes &&    test x"$multi_arch" = xyes; then   AC_MSG_WARN([--enable-multi-arch support recommends a gcc with gnu- indirect-function support. Please use a gcc which supports it by default or configure gcc with -- enable-gnu-indirect-function]) fi Steve Ellcey sell...@cavium.com

Re: [PATCH] detect incompatible aliases (PR c/81854)

2017-09-20 Thread Steve Ellcey
7-09/msg00285.html Steve Ellcey sell...@cavium.com

Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-20 Thread Steve Ellcey
On Tue, 2017-09-19 at 10:49 -0600, Martin Sebor wrote: > On 09/19/2017 09:54 AM, Steve Ellcey wrote: > > On Tue, 2017-09-19 at 09:50 +0200, Frédéric Marchal wrote: > > >  > > > > > > > >    error (is_pragma > > > >

Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-22 Thread Steve Ellcey
rch64/target_attr_17.c But I thought we should try and get some agreement on the format of the messages before updating the tests.  If we think these changes look good I can submit a final patch that includes the testsuite changes. Steve Ellcey sell...@cavium.com 2017-09-22  Steve Ellcey  

Re: [PATCH][aarch64] Enable ifunc resolver attribute by default

2017-09-22 Thread Steve Ellcey
On Thu, 2017-09-21 at 12:37 +, Joseph Myers wrote: > On Tue, 5 Sep 2017, Steve Ellcey wrote: > > > > > 2017-09-05  Steve Ellcey   > > > > * config.gcc: Add new case statement to set > > default_gnu_indirect_function.  Remove it from x86

Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-09-25 Thread Steve Ellcey
Ping. Steve Ellcey sell...@cavium.com On Fri, 2017-09-15 at 11:22 -0700, Steve Ellcey wrote: > PR 81356 points out that doing a __builtin_strcpy of an empty string on > aarch64 does a copy from memory instead of just writing out a zero byte. > In looking at this I found that it was b

[PATCH PR79868 ][aarch64] Fix error calls in aarch64 code so they can be translated (version 2)

2017-09-25 Thread Steve Ellcey
other GCC errors.  This was worked out with help from Martin Sebor.  I also had to fix some tests to match the new error string formats. Tested on Aarch64 with no regressions, OK to checkin? Steve Ellcey sell...@cavium.com 2017-09-25  Steve Ellcey   PR target/79868 * config/aarch64

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-09-27 Thread Steve Ellcey
Ping. Steve Ellcey sell...@cavium.com On Thu, 2017-08-31 at 10:24 -0700, Steve Ellcey wrote: > On Tue, 2017-08-29 at 12:25 +0100, Szabolcs Nagy wrote: > > > >   > > in glibc the hwcap is not used, because it has accesses to > > cached dispatch info, but in libatomic u

Re: [reviewed] qsort comparator consistency checking

2017-09-29 Thread Steve Ellcey
ranking heuristic is still wrong if > multi_mem_insn_p > may be true; please try this patch. > > * haifa-sched.c (autopref_rank_data): Remove. > (autopref_rank_for_schedule): Only use min_offset difference. This fixed the build for me on aarch64.  I am still running the testsuite. Steve Ellcey sell...@cavium.com

Re: [reviewed] qsort comparator consistency checking

2017-09-29 Thread Steve Ellcey
On Fri, 2017-09-29 at 21:43 +0200, Christophe Lyon wrote: > On 29 September 2017 at 21:39, Steve Ellcey > wrote: > > > > On Fri, 2017-09-29 at 21:14 +0300, Alexander Monakov wrote: > > > > > > On Fri, 29 Sep 2017, Andrew Pinski wrote: > > > > >

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-09-29 Thread Steve Ellcey
s, and changed HWCAP_TYPE to IFUNC_RESOLVER_ARGS. Here is the new patch, tested with no regressions. Steve Ellcey sell...@cavium.com 2017-09-29  Steve Ellcey   * Makefile.am (ARCH_AARCH64_LINUX): Add IFUNC_OPTIONS and libatomic_la_LIBADD. * config/linux/aarch64/host-config.

Re: [PATCH] detect incompatible aliases (PR c/81854)

2017-10-02 Thread Steve Ellcey
On Wed, 2017-09-20 at 08:37 -0700, Steve Ellcey wrote: > On Tue, 2017-09-19 at 09:16 -0600, Martin Sebor wrote: > > On 09/18/2017 03:44 PM, Joseph Myers wrote: > > > On Mon, 18 Sep 2017, Martin Sebor wrote: > > > > It's meant as an escape hatch.  It all

Re: [PATCH] avoid ifunc warnings in libatomic configure

2017-10-02 Thread Steve Ellcey
.h changes I can take > mine out. > > Martin I haven't submitted anything for this problem.  This patch fixed things for my aarch64 build.  I definitely needed the libatomic_i.h changes as well as the configure change. Steve Ellcey sell...@cavium.com

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-10-03 Thread Steve Ellcey
the ifunc check in libatomic to fail.  That problem has been fixed but it involved a change to libatomic/ibatomic_i.h that conflicted with this patch so I am including an updated version that will apply cleanly to the top of tree.  Only libatomic_i.h changed. Steve Ellcey sell...@cavium.com 20

Re: [PATCH][AArch64] Add BIC-imm and ORR-imm SIMD pattern

2017-10-04 Thread Steve Ellcey
On Wed, 2017-10-04 at 16:41 +0100, Richard Earnshaw (lists) wrote: > On 02/10/17 10:05, Sudi Das wrote: > >  > > 2017-10-02 Sudakshina Das   > > > > * config/aarch64/aarch64-protos.h (enum simd_immediate_check): New > > check type > > for aarch64_simd_valid_immediate. > > (aarch64_out

Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output

2017-10-05 Thread Steve Ellcey
heduler maintainers to the CC list on this email to see if one on them can review/approve Wilco's patch which was applied and then reverted.  If not, can one of the global maintainers revert the original patch that broke the bootstrap? Steve Ellcey sell...@cavium.com

Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output

2017-10-05 Thread Steve Ellcey
ing of multi_mem_insns.  Would please interested parties help me > test it? > > Comments? This patch is not applying to my ToT.  The code in autopref_rank_for_schedule doesn't seem to match what I have in my tree. Steve Ellcey

[PATCH][aarch64] Put vector fnma instruction into canonical form for better code generation.

2017-10-06 Thread Steve Ellcey
code generation (an extra dup instruction). I have moved the 'neg', rebuilt GCC and retested with this patch There were no regressions.  OK to checkin? 2017-10-06  Steve Ellcey   * config/aarch64/aarch64-simd.md (fnma4): Move neg operator to canonical location. di

Re: [PATCH PR79868 ][aarch64] Fix error calls in aarch64 code so they can be translated (version 2)

2017-10-06 Thread Steve Ellcey
Ping. Steve Ellcey sell...@cavium.com On Mon, 2017-09-25 at 16:25 -0700, Steve Ellcey wrote: > This is a new version of my patch to fix PR target/79868, where some > error messages are impossible to translate correctly due to how the > strings are dynamically constructed.  It also incl

[PATCH] Improve aarch64 conditional compare usage

2017-02-02 Thread Steve Ellcey
is set and TARGET_GEN_CCMP_FIRST is only set for aarch64 this change will only affect aarch64. Tested with no regressions and a new test is added to verify that we generate a ccmp instruction with the change. OK for checkin after 7.0? Steve Ellcey sell...@cavium.com GCC ChangeLog: 2017-02-02  St

[PATCH] Fix exception handling for ILP32 aarch64

2017-02-07 Thread Steve Ellcey
his patch where ASSUME_EXTENDED_UNWIND_CONTEXT is changed so that change could be left out out by setting it to 0 in the new aarch64 value-unwind.h header file if we thought there was a reason to do that. Steve Ellcey sell...@cavium.com 2017-02-07  Andrew Pinski   * config/aarch64/value-unw

RE: [Patch, MIPS] MIPS specific optimization for o32 ABI

2015-08-18 Thread Steve Ellcey
sure how this would work. It seems better to just not allocate the space if it is not needed and then LRA can separately allocate whatever it needs for its own use (if any). I'll add Robert to the cc list on this in case he has any ideas since he did the LRA implementation for MIPS. Steve Ellcey sell...@imgtec.com

Re: [Patch] Add to the libgfortran/newlib bodge to "detect" ftruncate support in ARM/AArch64/SH

2015-08-20 Thread Steve Ellcey
On Thu, 2015-08-20 at 09:31 +0100, James Greenhalgh wrote: > I'd appreciate your help Steve to check that this patch works with > your build system. > > Thanks, > James Yes, this patch works fine with my builds for MIPS. Steve Ellcey sell...@imgtec.com

[PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-09-03 Thread Steve Ellcey
h the mips-mti-linux-gnu, OK for checkin? Steve Ellcey sell...@imgtec.com 2015-09-03 Steve Ellcey * config.gcc (mips*-*-*): Add frame-header-opt.o to extra_objs. * frame-header-opt.c: New file. * config/mips/mips-proto.h (mips_register_frame_header_opt): Add prot

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-09-11 Thread Steve Ellcey
ed the frame header. I also used your example to add 3 tests in order to verify when the optimization does and does not happen. Steve Ellcey sell...@imgtec.com 2015-09-11 Steve Ellcey * config.gcc (mips*-*-*): Add frame-header-opt.o to extra_objs. * frame-header-opt.c: New

Re: [Patch, MIPS] Remove definition of TARGET_PROMOTE_PROTOTYPES

2015-12-11 Thread Steve Ellcey
Patch ping. Steve Ellcey sell...@imgtec.com On Tue, 2015-11-10 at 15:57 -0800, Steve Ellcey wrote: > This patch removes the definition of TARGET_PROMOTE_PROTOTYPES from MIPS, > where it was defined as true, so that it now defaults to false. > > Currently MIPS does prototype prom

Re: [RFC] Request for comments on ivopts patch

2015-12-11 Thread Steve Ellcey
patch but by checking different features. Basically, for machines with no autoinc/autodec it has a preference for IVs that don't change during loop (i.e. var_before == var_after). What do you think about this approach? Steve Ellcey sell...@imgtec.com 2015-12-11 Steve Ellcey * t

Re: [RFC] Request for comments on ivopts patch

2015-12-14 Thread Steve Ellcey
some point] > > Richard. I like the idea of a target hook to modify IV costs. What do you think about this? I had to move some structures from tree-ssa-loop-ivopts.c to tree-ssa-loop-ivopts.h in order to give a target hooks access to information on the IV candidates. Steve Ellcey se

RE: [Patch] Fix for MIPS PR target/65604

2015-12-15 Thread Steve Ellcey
On Tue, 2015-12-15 at 15:13 +, Moore, Catherine wrote: > > HI Steve, The patch is OK. Will you please add a test case and repost? > Thanks, > Catherine Here is the patch with a test case. 2015-12-15 Steve Ellcey PR target/65604 * config

[Patch] Fix libstdc++ build when using uclibc instead of glibc

2016-01-05 Thread Steve Ellcey
egressions. OK to checkin? Steve Ellcey sell...@imgtec.com 2016-01-05 Steve Ellcey * include/ext/random.tcc: Use __builtin_finite instead of std::isfinite. diff --git a/libstdc++-v3/include/ext/random.tcc b/libstdc++-v3/include/ext/random.tcc index a9c5a2b..3467823 100644 ---

Re: [Patch] Fix libstdc++ build when using uclibc instead of glibc

2016-01-06 Thread Steve Ellcey
On Wed, 2016-01-06 at 20:34 +, Jonathan Wakely wrote: > On 05/01/16 14:43 -0800, Steve Ellcey wrote: > >While trying to build GCC with uclibc instead of glibc I ran into a build > >failure in libstdc++. uclibc doesn't seem to provide the isfinite function > >lik

Re: [Patch] Fix libstdc++ build when using uclibc instead of glibc

2016-01-07 Thread Steve Ellcey
On Thu, 2016-01-07 at 20:56 +0100, Bernhard Reutner-Fischer wrote: > On January 7, 2016 12:23:49 PM GMT+01:00, Jonathan Wakely > wrote: > >On 07/01/16 07:28 +0100, Marc Glisse wrote: > >>On Wed, 6 Jan 2016, Jonathan Wakely wrote: > >> > >>>On 06/01/16

Re: [Patch] Improving jump-thread pass for PR 54742

2014-12-08 Thread Steve Ellcey
-fno-thread-jumps' then I still see this optimization. Is that expected? Should this test also check flag_thread_jumps? Or should that be getting checked somewhere else? Steve Ellcey

[Patch, MIPS] Remove some multilibs from mips-mti-linux-gnu target

2014-12-24 Thread Steve Ellcey
-Werror mean that the warning GCC gives is treated as an error and that glibc will not build with these flag combinations so I would like to remove them from the GCC mips-mti-linux-gnu multilib list. This does not affect any GCC target other then mips-mti-linux.gnu. OK to checkin? Steve Ellcey sell

RE: [Patch, MIPS] Remove some multilibs from mips-mti-linux-gnu target

2014-12-29 Thread Steve Ellcey
> From: Matthew Fortune > > 2014-12-24 Steve Ellcey > > > > * config/mips/t-mti-linux (MULTILIB_EXCEPTIONS): Add exceptions > > for mips32[r1] and mips64[r1] with -mnan=2008. > This is OK, but I think it may be best to fix t-mti-elf at the same >

[patch, lra, pr55103, committed] Save lra_int struct.

2012-11-01 Thread Steve Ellcey
I checked in this patch as obvious. It fixes PR 55103 which is a compiler abort on MIPS with the -mips16 flag. After committing I realized I forgot to put the bug number in the ChangeLog, I will update PR 55103 by hand. Steve Ellcey sell...@mips.com 2012-11-01 Steve Ellcey

[patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
The test gcc.dg/torture/mips-sdata-1.c fails when compiled with -fno-fat-lto-objects because when that option is used no assembly code is output and thus the scan does not find the '.sdata' line. Checked with the mips-mti-elf target. OK to checkin? Steve Ellcey sell...@mips.com

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
On Mon, 2012-11-05 at 20:38 +, Richard Sandiford wrote: > This sort of thing should usually be handled automatically by > scan-assembler, and is for me: > > /foo/gcc/xgcc -B/foo/gcc/ /bar/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c > -fno-diagnostics-show-caret > -O2 -flto -fuse-linker-plu

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
ight set ENABLE_LTO to '0' and cause check_effective_target_lto to return FALSE and cause the -ffat-lto-objects flag to not be added. Of course this raises the question of why it is trying to do lto testing if I didn't configure it in. I will add 'lto' to my configure lin

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
On Mon, 2012-11-05 at 13:40 -0800, Steve Ellcey wrote: > Hm, I configured GCC with '--enable-languages=c,c++', I think this might > set ENABLE_LTO to '0' and cause check_effective_target_lto to return > FALSE and cause the -ffat-lto-objects flag to not be added.

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
On Mon, 2012-11-05 at 22:55 +, Richard Sandiford wrote: > Steve Ellcey writes: > > I am not sure how ld is supposed to find crt0.o in the uninstalled > > setup, it exists in obj-mips-mti-elf/newlib/mips-mti-elf/libgloss/mips. > > The newlib and libgloss flags are usually

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
g things but with the lto test run by the *.exp script we don't have that. Steve Ellcey sell...@mips.com

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-06 Thread Steve Ellcey
t and --with-build-sysroot took care of the problem so my patch is not needed. Steve Ellcey sell...@mips.com

[patch, mips] Do not make -Os the default with mips-mti-elf target.

2012-11-07 Thread Steve Ellcey
existing --enable-target-optspace configure option to get it. This patch creates config/mt-mti that is like mt-sde but without -Os and changes the mips*-mti-elf* target to use that include file instead of mt-sde. Tested with the mips-mti-elf target. OK to checkin? Steve Ellcey sell...@mips.com

[patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Steve Ellcey
e that promoted mode in the temp that we are creating for the conditional move. Tested on mips-mti-elf with no regressions. OK for checkin? Steve Ellcey sell...@mips.com 2012-11-14 Steve Ellcey * expr.c (expand_cond_expr_using_cmove): Use promoted mode for temp. diff --git a/g

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Steve Ellcey
ithout my patch you will see fewer 'andi' instructions with 0x are generated after my patch is applied. Steve Ellcey sell...@mips.com unsigned short foo(unsigned short a1, unsigned short a2) { unsigned short i, x; for (i = 0; i < 8; i++) { x = (a1 & 1) ^ (a2 &

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Steve Ellcey
xori$5,$5,0x1 movz$2,$4,$5 When it should just do: andi$5,$5,0x1 movn$2,$4,$5 Steve Ellcey sell...@mips.com

[patch, pch] Fix pch failure on mips-mti-linux-gnu

2012-11-21 Thread Steve Ellcey
es and pfile->all_files->next_file and it fixes the problem for me. I tested it on mips-mti-linux-gnu and had no regressions. OK to checkin? Steve Ellcey sell...@mips.com 2012-11-21 Steve Ellcey PR pch/55399 * files.c (pch_open_file): Fix check for implicit_preinclude.

Re: ping - Re: [patch] [ia64] add multiarch definitions for ia64-linux-gnu

2012-11-21 Thread Steve Ellcey
gcc. > > > > thanks for the pointer. updated patch attached below. OK for ia64. Steve Ellcey sell...@mips.com

[patch, libgcc] Bug in fp-bit.c when NO_NANS is defined

2012-11-30 Thread Steve Ellcey
. isinf is always going to be false when NO_NANS is defined so it is only a question of what to do for iszero(a) that we need to worry about. b at this point may or may not be zero. OK to checkin or should I return something else? Steve Ellcey sell...@mips.com 2012-11-30 Steve Ellcey

Re: [IA-64] Fix dynamic allocation in leaf functions

2012-12-04 Thread Steve Ellcey
fset): Adjust offsets to above change. > > Ping: http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01617.html > > Thanks in advance. Eric, this looks OK to me. As for back porting it, that is OK with me too as long as it is OK with the release/branch managers. Steve Ellcey sell...@mips.com

<    1   2   3   4   5   6   7   >