On Tue, 2017-10-31 at 09:57 +0000, Richard Earnshaw (lists) wrote:
>
> This is looking better...
>
> I may have missed some discussion on this topic, but what's the
> reasoning behind changing the quoting around the 'str' parameter
> value in
>
> - error ("unknown value %qs for 'cpu' target %s", str,
> pragma_or_attr);
> + error ("invalid name (\"%s\") in %<target(\"cpu=\")%> pragma
> or
> attribute", str);
>
> And also with the new generic message does the %<target(\"cpu=\")%>
> still make sense? My feeling is that the original text here is perhaps
> more appropriate. Similarly for other messages.
>
> R.
%qs uses single quotes vs. double quotes, changing that was suggested
by Martin Sebor in this comment:
https://gcc.gnu.org/ml/gcc-patches/2017-09/msg01569.html
using '%<target(\"cpu=\")%>' was also suggested by Martin in that
same thread at:
https://gcc.gnu.org/ml/gcc-patches/2017-09/msg01277.html
https://gcc.gnu.org/ml/gcc-patches/2017-09/msg01469.html
as being more consistent with other usage (mainly config/i386/i386.c).
Steve Ellcey
[email protected]
