On Tue, 2017-09-12 at 09:39 -0700, Ian Lance Taylor wrote: > On Tue, Sep 12, 2017 at 3:59 AM, Wilco Dijkstra <Wilco.Dijkstra@arm.c > om> wrote: > > > > Steve Ellcey wrote: > > > > > > This patch fixes the ttest failures on aarch64 by adding > > > AM_CFLAGS to > > > the test options, like btest already does and as Wilco says works > > > for > > > him in Comment #4 of the bug report. > > Thanks for picking this up, this looks OK. > > > > > > > > Tested by me on aarch64. Ok to checkin? > > This counts as an obvious fix, so you can commit it. > Wait, what? This patch is at best incomplete. Makefile.in is a > generated file. You need to change Makefile.am and re-run automake. > > Ian
OK, here is the new patch that I will checkin. I verified that after running automake on Makefile.am, the Makefile.in I got was identical to what I checked in earlier. Steve Ellcey sell...@cavium.com 2017-09-12 Steve Ellcey <sell...@cavium.com> PR other/81096 * Makefile.am (ttest_CFLAGS): Add $(AM_CFLAGS) * Makefile.in: Regenerate. diff --git a/libbacktrace/Makefile.am b/libbacktrace/Makefile.am index b91d6bc..120beb1 100644 --- a/libbacktrace/Makefile.am +++ b/libbacktrace/Makefile.am @@ -117,7 +117,7 @@ if HAVE_PTHREAD check_PROGRAMS += ttest ttest_SOURCES = ttest.c testlib.c -ttest_CFLAGS = -pthread +ttest_CFLAGS = $(AM_CFLAGS) -pthread ttest_LDADD = libbacktrace.la endif HAVE_PTHREAD
