Data Recovery Services and Hardware Repair Services

2015-03-07 Thread Lance
game consoles, cameras, mp3 players, and most any other electronic gadget you can throw at us. We strive to create solutions where there weren’t any before. Best regards, Lance Email: drdatab...@tom.com

Re: [PATCH] libiberty: Use posix_spawn in pex-unix when available.

2023-10-02 Thread Ian Lance Taylor
On Fri, Sep 29, 2023 at 12:18 PM Brendan Shanks wrote: > > + #define ERR_ON_FAILURE(ret, func) \ > +do { if (ret) { *err = ret; *errmsg = func; goto exit; } else {} } while > (0) Thanks, but please don't use a macro that changes control flow. Ian

Re: [PATCH v2] libiberty: Use posix_spawn in pex-unix when available.

2023-10-03 Thread Ian Lance Taylor
On Tue, Oct 3, 2023 at 12:04 PM Brendan Shanks wrote: > > + ret = posix_spawnattr_init (&attr); > + if (ret) { *err = ret; *errmsg = "posix_spawnattr_init"; goto exit; } Sorry, but let's keep the formatting used in the rest of the file. if (ret != 0) { *err = ret; *errmsg = "posix_sp

libgo patch committed: Check return value as well as error from waitid

2018-07-02 Thread Ian Lance Taylor
This libgo patch checks the return value as well as the error from waitid. https://gcc.gnu.org/PR86331 indicates that if a signal handler runs it is possible for syscall.Syscall6 to return a non-zero errno value even if no error occurs. That is a problem in general, but this fix will let us work a

Go patch committed: Fix double evaluation when using interface field expression

2018-07-09 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang fixes the compiler to avoid a double evaluation of an interface field expression. In Interface_field_reference_expression, the interface expression is used in two places, so a temporary variable is used. Previously, we used a Set_and_use_temporary_exp

Go patch committed: Fix evaluation order of LHS index expressions

2018-07-11 Thread Ian Lance Taylor
The Go spec says that when an index expression appears on the left hand side of an assignment, the operands should be evaluated. The gofrontend code was assuming that that only referred to the index operand. But discussion of https://golang.org/issue/23188 has clarified that this means both the sli

Go patch committed: Build a single backend type for a type alias

2018-07-11 Thread Ian Lance Taylor
A type alias and its underlying type are identical. This patch to the Go frontend by Cherry Zhang builds a single backend type for them. Previously we build two backend types, which sometimes confuse the backend's type system. Also don't include type aliases into the list of named type declaratio

Go patch commited: Fix parsing of composite literals with omitted pointer types

2018-07-13 Thread Ian Lance Taylor
This patch to the Go frontend fixes parsing of composite literals with omitted pointer types. The frontend could parse omitted pointer typess at the end of the type, but not in the middle, so code like []*[][]int{{{1}}} failed. A test case is in https://golang.org/cl/123477. This fixes https://g

libgo patch committed: Skip zero-sized fields in structs when converting to libffi CIF

2018-07-13 Thread Ian Lance Taylor
The libffi library doesn't understand zero-sized objects. This patch to libgo fixes it so that when we see a zero-sized field in a struct, we just skip it when converting to the libffi data structures. There is no value to pass in any case, so not telling libffi about the field doesn't affect anyt

Go patch committed: Connect the concrete type and the placeholder for circular types

2018-07-17 Thread Ian Lance Taylor
This patch by Cherry Zhang changes the Go frontend to more clearly connect the concrete type and the placeholder for circular types. Previously, when creating the backend representation of a circular type, we resolved the placeholder to a circular_pointer_type. The backend didn't know what the con

Go patch committed: Don't set btype_ field too early for an alias type

2018-07-17 Thread Ian Lance Taylor
This patch by Cherry Zhang fixes a problem in the Go frontend introduced by https://golang.org/cl/123362. A type's btype_ field should not be set before named types are converted if it is a placeholder. For alias type, it iwas set too early. That could result in unresolved placeholders. This pa

Go patch committed: Fix order of evaluation of boolean expressions

2018-07-20 Thread Ian Lance Taylor
This patch by Cherry Zhang changes the Go frontend to run the order_evaluations before the remove_shortcuts pass. In remove_shortcuts, the shortcut expressions (&&, ||) are rewritten to if statements, which are lifted out before the statement containing the shortcut expression. If the containing

libgo patch committed: Prune sighandler frames in runtime.sigprof

2018-07-27 Thread Ian Lance Taylor
This libgo patch by Than McIntosh prunes sighandler frames in runtime.sigprof. When writing stack frames to the pprof CPU profile machinery, it is very important to insure that the frames emitted do not contain any frames corresponding to artifacts of the profiling process itself (signal handlers,

Re: [PATCH] Make GO string literals properly NUL terminated

2018-07-31 Thread Ian Lance Taylor
On Tue, Jul 31, 2018 at 5:14 AM, Bernd Edlinger wrote: > > could someone please review this patch and check it in into the GO FE? I don't understand why the change is correct, and you didn't explain it. Go strings are not NUL terminated. Go strings always have an associated length. Ian

Re: [PATCH] Make GO string literals properly NUL terminated

2018-07-31 Thread Ian Lance Taylor
On Tue, Jul 31, 2018 at 9:19 AM, Bernd Edlinger wrote: > On 07/31/18 16:40, Ian Lance Taylor wrote: >> On Tue, Jul 31, 2018 at 5:14 AM, Bernd Edlinger >> wrote: >>> >>> could someone please review this patch and check it in into the GO FE? >> >> I do

Merge from trunk to gccgo branch

2018-07-31 Thread Ian Lance Taylor
I've merged trunk revision 263114 to the gccgo branch. Ian

libgo patch committed: Use poll rather than pollset on AIX

2018-07-31 Thread Ian Lance Taylor
This patch by Tony Reix changes libgo's poller support on AIX to use poll rather than pollset. This may fixes https://golang.org/issue/26634. Bootstrapped and ran Go testsuite on x86_64-pc-linux, not that that proves much. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE ==

Go patch committed: pass Gogo to more passes

2023-10-22 Thread Ian Lance Taylor
This patch to the G frontend passes a pointer to the Gogo IR to the determine types pass and the type verification pass. This is a straight refactoring that does not change the compiler behavior. This is in preparation for future CLs that rearrange the pass ordering. This introduces one new call

Go patch committed: Remove name_ field from Type_switch_statement

2023-10-22 Thread Ian Lance Taylor
This patch to the Go frontend removes the name_ field from the Type_switch_statement class. It's not used for anything. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian 1a1fba1e25779247a4969789885ce80b7b4a2359 diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofr

Go patch committed: Remove the traverse_assignments code

2023-10-22 Thread Ian Lance Taylor
This patch to the Go frontend removes the traverse_assignments support. The last caller was removed in https://go.dev/cl/18261 in 2016. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian a6e74b0b3316f3f0b2096d6a175c31bed58ae4ed diff --git a/gcc/go/gofrontend/MER

libgo patch committed: Add missing type conversion

2023-10-23 Thread Ian Lance Taylor
This libgo patch adds a missing type conversion. The gofrontend incorrectly accepted code that was missing a type conversion. The test case for this is bug518.go in https://go.dev/cl/536537. Future CLs in this series will detect the type error. Bootstrapped and ran Go testsuite on x86_64-pc-lin

Go patch committed: Add Expression::is_untyped method

2023-10-23 Thread Ian Lance Taylor
This Go frontend patches adds an Expression::is_untyped method. This method is not currently used by anything, but it will be used by later changes in this series. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian ac50e9b72bf9bb6d5b28096bb164fb050db6e290 diff

Go patch committed: Pass Gogo to Runtime::make_call

2023-10-23 Thread Ian Lance Taylor
This Go frontend patches passes the Gogo IR pointer to Runtime::make_call. This is a boilerplate change that doesn't affect compiler output. It's not currently used but will be used by later CLs in this series. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ia

Go patch committed: Make xx_constant_value methods non-const

2023-10-23 Thread Ian Lance Taylor
This patch to the Go frontend changes the Expression {numeric,string,boolean}_constant_value methods to be non-const. This does not affect anything immediately, but will be useful for later CLs in this series. The only real effect is to Builtin_call_expression::do_export, which remains const and

Go patch committed: Move Selector_expression up in file

2023-10-23 Thread Ian Lance Taylor
This patch to the Go frontend just moves Selector_expression up in file. This is a mechanical change to expressions.cc. This will make Selector_expression visible to Builtin_call_expression for later work. This produces a very large "git --diff", but "git diff --minimal" is clear. Bootstrapped a

Re: [PATCH] testsuite: Fix _BitInt in gcc.misc-tests/godump-1.c

2023-10-25 Thread Ian Lance Taylor
On Tue, Oct 24, 2023, 11:03 AM Jeff Law wrote: > > > On 10/24/23 09:26, Stefan Schulze Frielinghaus wrote: > > Currently _BitInt is only supported on x86_64 which means that for other > > targets all tests fail with e.g. > > > > gcc.misc-tests/godump-1.c:237:1: sorry, unimplemented: '_BitInt(32)'

libstdc++ patch RFA: Fix dl_iterate_phdr configury for libbacktrace

2023-11-02 Thread Ian Lance Taylor
The libbacktrace sources, as used by libstdc++-v3, fail to correctly determine whether the system supports dl_iterate_phdr. The issue is that the libbacktrace configure assumes that _GNU_SOURCE is defined during compilation, but the libstdc++-v3 configure does not do that. This configury failure i

Re: [PATCH][stage1] Remove conditionals around free()

2023-03-01 Thread Ian Lance Taylor
Bernhard Reutner-Fischer writes: > libgo/runtime/go-setenv.c|6 ++ > libgo/runtime/go-unsetenv.c |3 +-- Files in the libgo directory are mirrored from upstream sources, as described in libgo/README.gcc. Please don't change them in the gcc repository. Thanks. Ian

Re: Patch ping: Re: [PATCH] libgcc, i386, optabs, v2: Add __float{, un}tibf to libgcc and expand BF -> integral through SF intermediate [PR107703]

2023-03-10 Thread Ian Lance Taylor
Jakub Jelinek writes: > On Wed, Mar 01, 2023 at 01:32:43PM +0100, Jakub Jelinek via Gcc-patches wrote: >> On Wed, Nov 16, 2022 at 12:51:14PM +0100, Jakub Jelinek via Gcc-patches >> wrote: >> > On Wed, Nov 16, 2022 at 10:06:17AM +0100, Jakub Jelinek via >> > Gcc-patches wrote: >> > > Thoughts on

Re: ***SPAM*** [PATCH] libgcc: allocate extra space for morestack expansion

2021-02-10 Thread Ian Lance Taylor
Rain Mark writes: > After enabling -fsplit-stack, dynamic stack expansion of the coroutine > is realized, but calling functions without -fsplit-stack will directly > expand the space by 1M, which is too wasteful for a system with a large > number of coroutines running under the 128K stack size. W

GCC 9 Patch committed: Don't inline numeric expressions with named types

2019-10-25 Thread Ian Lance Taylor
In the gofrontend we've encountered problems with numeric expressions that have named types, as shown at https://golang.org/issue/34577. Those problems are fixed on trunk, but the fixes there rely on other machinery that has been added since the GCC 9 branch. This patch fixes the same problems on

Merge from trunk to gccgo branch

2019-10-25 Thread Ian Lance Taylor
I merged trunk revision 277462 to the gccgo branch. Ian

Re: [golang-dev] [PATCH 0/4] Fix library testsuite compilation for build sysroot

2019-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2019 at 10:15 AM Ulderico Cirello wrote: > > Go's project doesn't take mail patches for changes. Please use gerrit ( > https://go-review.googlesource.com/ ). These patches are for gccgo, not the gc toolchain. They should probably have been sent to gofrontend-dev rather than gola

Re: [golang-dev] [PATCH 0/4] Fix library testsuite compilation for build sysroot

2019-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2019 at 10:31 AM Kaz Kylheku (libffi) <382-725-6...@kylheku.com> wrote: > > On 2019-11-11 10:15, Ulderico Cirello wrote: > > Hi Maciej, > > > > Go's project doesn't take mail patches for changes. > > Is it that they'd have to read man pages and learn how to use common > utilities? >

Re: [golang-dev] [PATCH 0/4] Fix library testsuite compilation for build sysroot

2019-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2019 at 10:44 AM Maciej W. Rozycki wrote: > > On Mon, 11 Nov 2019, Ian Lance Taylor wrote: > > > > Go's project doesn't take mail patches for changes. Please use gerrit ( > > > https://go-review.googlesource.com/ ). > > > > These p

Re: [golang-dev] [PATCH 3/4] libgo/test: Fix compilation for build sysroot

2019-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2019 at 10:12 AM Maciej W. Rozycki wrote: > > Fix a problem with the libgo testsuite using a method to determine the > compiler to use resulting in the tool being different from one the > library has been built with, and causing a catastrophic failure from the > lack of a suitable

Re: [golang-dev] [PATCH] libgo/test: Add flags to find libgcc_s in build-tree testing

2019-11-11 Thread Ian Lance Taylor
[ moving from golang-dev to gofrontend-dev ] On Mon, Nov 11, 2019 at 7:48 AM Maciej W. Rozycki wrote: > > Add a setting for the dynamic loader to find the shared libgcc_s library > in build-tree testing, fixing a catastrophic libgo testsuite failure in > cross-compilation where the library cannot

Re: [C++ coroutines 6/7] libiberty demangler update.

2020-01-09 Thread Ian Lance Taylor
Iain Sandoe writes: > The coroutines implementation introduces a new operator with a > mangling of 'aw'. This patch adds that to libiberty's demangler. > > Although this is presented as part of the coroutines patch series > it could stand alone, since clang and EDG-based compilers are > already

Go patch committed: Don't add composite literal keys to package bindings

2020-01-09 Thread Ian Lance Taylor
This patch to the Go frontend avoids adding composite literal keys to the package bindings. Doing this gets confusing when it is combined with dot imports. The test case showing the resulting compilation failure is https://golang.org/cl/213899. Fix this by adding a new expression type to hold co

Go patch committed: Don't localize names in export data

2020-01-09 Thread Ian Lance Taylor
This patch changes the Go frontend to not localize names in export data. Localizing these names causes the compiler output to change depending on the LANG environment variable, so don't do it. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofr

libgo patch committed: Compile examples in _test packages

2020-01-09 Thread Ian Lance Taylor
This libgo patch compiles examples in _test packages. Previously if the only names defined by _test packages were examples, the gotest script would emit an incorrect _testmain.go file. I worked around that by marking the example_test.go files +build ignored. This CL changes the gotest script to

Go patch committed: Permit duplicate methods from embedded interfaces

2020-01-10 Thread Ian Lance Taylor
This patch to the Go frontend permits duplicate methods from embedded interfaces. This is a language change for Go 1.14. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE ==

Re: libgo patch committed: Compile examples in _test packages

2020-01-10 Thread Ian Lance Taylor
On Fri, Jan 10, 2020 at 5:40 AM Rainer Orth wrote: > > > This libgo patch compiles examples in _test packages. Previously if > > the only names defined by _test packages were examples, the gotest > > script would emit an incorrect _testmain.go file. I worked around > > that by marking the examp

Re: [C++ coroutines 7/7] libiberty demangler update.

2020-01-11 Thread Ian Lance Taylor
Iain Sandoe writes: > Ian Lance Taylor wrote: > >> Iain Sandoe writes: > >>> 2020-01-09 Iain Sandoe >>> >>> * cp-demangle.c (cplus_demangle_operators): Add the co_await >>> operator. >> >> Please add something to li

Re: RFA: Fix libiberty testsuite failure

2020-01-20 Thread Ian Lance Taylor
Nick Clifton writes: > Hi Ian, > > The libiberty testsuite in the gcc mainline is currently failing on > the last test: > > FAIL at line 1452, options : > in: _Z3fooILPv0EEvPN9enable_ifIXeqT_LDnEEvE4typeE > out: void foo<(void*)0>(enable_if<((void*)0)==(decltype(nullptr)), > voi

Re: RFA: Fix libiberty testsuite failure

2020-01-20 Thread Ian Lance Taylor
kamlesh kumar writes: > yes, current expected entry is wrong and > Nick's patch corrects that. Thanks. Nick, the patch is OK. Ian > On Mon, Jan 20, 2020 at 9:29 PM Ian Lance Taylor wrote: > >> Nick Clifton writes: >> >> > Hi Ian, >> > >&g

Re: [PATCH v3] Add `--with-toolexeclibdir=' configuration option

2020-01-20 Thread Ian Lance Taylor
On Mon, Jan 20, 2020 at 6:46 PM Maciej W. Rozycki wrote: > > Ian: Can we please coordinate this somehow? The libgo/ part, like all, > relies on config/toolexeclibdir.m4, so I can either: > > 1. push the whole change all at once and you'll push the libgo/ part to >your repo independently, whi

libgo patch committed: Update to Go1.14beta1

2020-01-21 Thread Ian Lance Taylor
n gotools/ChangeLog: 2020-01-21 Ian Lance Taylor * Makefile.am (gofmt$(EXEEXT)): Link against $(LIBGOTOOL). (check-go-tool): Copy some vendor directories. * Makefile.in: Regenerate. diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index a6127013783..dff5fb5bc70 100644 --- a/gcc/go/gofron

libgo patch committed: Update runtime_nanotime call

2020-01-22 Thread Ian Lance Taylor
In the update of libgo to Go1.14beta1, the function runtime_nanotime was renamed to runtime_nanotime1. I missed one reference that is not compiled on x86 code. This patch fixes that. This fixes https://golang.org/issue/36694. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed

libgo patch commited: Fix arm64be build

2020-01-22 Thread Ian Lance Taylor
This patch from Andrew Pinski fixes the libgo arm64be build, by using internal/syscall/unix/getrandom_linux_generic.go on arm64be. Committed to mainline. Ian diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index 61f01d739ff..544c6e66e0d 100644 --- a/gcc/go/gofrontend/MERGE +++ b/gcc

libgo patch committed: Fix Solaris build

2020-01-22 Thread Ian Lance Taylor
This libgo patch fixes the build on Solaris after the 1.14beta upgrade. It adds a runtime.osinit function, and drops a duplicate runtime.getncpu function. Bootstrapped and tested on x86_64-pc-solaris2.11. Committed to mainline. Ian 9e16359ce8db7180264fd5f047ca137ead8356dd diff --git a/gcc/go/go

Re: libgo patch committed: Update to Go1.14beta1

2020-01-22 Thread Ian Lance Taylor
On Wed, Jan 22, 2020 at 12:18 PM Rainer Orth wrote: > > > I've committed a patch to update libgo to Go 1.14beta1. As usual with > > these updates the patch is far too large to include in this e-mail > > message. I've included the diffs for gccgo-specific files. > > Bootstrapped and ran Go tests

Merge from trunk to gccgo branch

2020-01-22 Thread Ian Lance Taylor
I merged trunk revision 9e16359ce8db7180264fd5f047ca137ead8356dd to the gccgo branch. Ian

libgo patch committed: Skip type descriptors in testsuite script

2020-01-22 Thread Ian Lance Taylor
This libgo patch changes the testsuite script to explicitly skip type descriptors. Type descriptors are normally weak and GNU nm will report them as V, so we will skip them when collecting the list of symbols. But when not using GNU nm, they may be reported as D, so also skip them in symstogo. T

Re: libgo patch committed: Update to Go1.14beta1

2020-01-23 Thread Ian Lance Taylor
On Thu, Jan 23, 2020 at 11:32 AM Maciej W. Rozycki wrote: > > On Tue, 21 Jan 2020, Ian Lance Taylor wrote: > > > I've committed a patch to update libgo to Go 1.14beta1. As usual with > > these updates the patch is far too large to include in this e-mail > > messa

Re: [committed v4] Add `--with-toolexeclibdir=' configuration option

2020-01-24 Thread Ian Lance Taylor
would otherwise be installed in. > > In the presence of the `--enable-version-specific-runtime-libs' option > and for configurations building native GCC the option is ignored. > > --- > On Mon, 20 Jan 2020, Ian Lance Taylor wrote: > > > > 2. push all the bits sans th

Go patch committed: Cleanups for MPFR 3.1.0

2020-01-27 Thread Ian Lance Taylor
This patch to the Go frontend adds cleanups now that MPFR 3.1.0 is required. For MPFR functions, change from GMP_RND* to MPFR_RND*. Also change mp_exp_t to mpfr_expt_t. This fixes GCC PR 92463. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu (with MPFR 4.0.2). Committed to mainline. Ia

libgo patch committed: Update netpoll_hurd for Go 1.14beta1 changes

2020-01-29 Thread Ian Lance Taylor
This patch by Svante Signell updates runtime/netpoll_hurd.go for the changes in the Go 1.14beta1 release. Bootstrapped on x86_64-pc-linux-gnu. Committed to mainline. Ian 58d788fafbc4cc8cc25ca432e8127e1effdc0672 diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index 49312fa10f7..8d0

libgo patch committed: Add a couple of hurd build tags

2020-01-29 Thread Ian Lance Taylor
This libgo patch by Svante Signell adds a couple of hurd build to the runtime and syscall packages. Bootstrapped on x86_64-pc-linux-gnu. Committed to mainline. Ian 66af5a226acd0edfbafcbcac76ed268cee0612ed diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index 8d08e91211d..40529518b2

libbacktrace patch committed: Always build tests with -g

2020-02-03 Thread Ian Lance Taylor
. Committed to mainline. Ian 2020-02-03 Ian Lance Taylor * Makefile.am (libbacktrace_TEST_CFLAGS): Define. (test_elf32_CFLAGS): Use $(libbacktrace_test_CFLAGS). (test_elf_64_CFLAGS, test_xcoff_32_CFLAGS): Likewise. (test_xcoff_64_CFLAGS, test_pecoff_CFLAGS): Likewise. (test_unknown_CFLAGS

Re: libgo patch committed: Update to Go1.14beta1

2020-02-03 Thread Ian Lance Taylor
On Sat, Feb 1, 2020 at 5:38 AM Andreas Schwab wrote: > > ../../../libgo/go/syscall/syscall_linux_riscv64.go:7:14: error: imported and > not used: unsafe > 7 | import "unsafe" > | ^ > ../../../libgo/go/syscall/syscall_linux_riscv64.go:13:1: error: redefinition > of 'SetLen'

Re: libgo patch committed: Update to Go1.14beta1

2020-02-03 Thread Ian Lance Taylor
On Sun, Feb 2, 2020 at 2:27 AM Andreas Schwab wrote: > > I'm getting these errors on aarch64 with -mabi=ilp32: > > ../../../../libgo/go/runtime/mpagealloc.go:226:38: error: shift count overflow > 226 | chunks [1 << pallocChunksL1Bits]*[1 << pallocChunksL2Bits]pallocData > |

libgo patch committed: On 32-bit systems, limit default GOMAXPROCS to 32

2020-02-15 Thread Ian Lance Taylor
This libgo patch limits the default value of GOMAXPROCS to 32 on 32-bit systems. Otherwise we can easily run out of stack space for threads. The user can still override by setting GOMAXPROCS. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian a339c239a7ed8af25e

libgo patch committed: Update to 1.14rc1

2020-02-15 Thread Ian Lance Taylor
I've committed a patch to update libgo to the 1.14rc1 release (this is a release candidate for the 1.14 Go release). Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian patch.txt.bz2 Description: application/bzip

libbacktrace patch committed: Update test file

2020-02-15 Thread Ian Lance Taylor
Ian Lance Taylor * ztest.c (test_large): Update file to current libgo test file. diff --git a/libbacktrace/ztest.c b/libbacktrace/ztest.c index 40f9c389a2a..2663c90061a 100644 --- a/libbacktrace/ztest.c +++ b/libbacktrace/ztest.c @@ -315,8 +315,8 @@ test_large (struct backtrace_state *state

libgo patch committed: Install internal/reflectlite.gox

2020-02-16 Thread Ian Lance Taylor
This patch to libgo arranges to install internal/reflectlite.gox. This makes it possible to use gccgo to bootstrap Go 1.14. If we don't install this, gccgo can't compile the sort package, which expects to be able to import this internal package. This fixes GCC PR go/93679. Bootstrapped on x86_64-

libbacktrace patch committed: Simplify DWARF section handling

2019-12-04 Thread Ian Lance Taylor
This libbacktrace patch simplifies the DWARF section handling. This is in preparation for DWARF 5 support, as DWARF 5 requires us to read more sections. Bootstrapped and ran libbacktrace and Go tests on x86_64-pc-linux-gnu. Committed to mainline. Ian 2019-12-04 Ian Lance Taylor

libbacktrace patch committed: Declare test1 in edtest.c with noclone

2019-12-04 Thread Ian Lance Taylor
This libbacktrace patch adds the noclone attribute to the version of test1 in edtest.c, to correspond to other versions of test1. Bootstrapped and ran libbacktrace tests on x86_64-pc-linux-gnu. Committed to mainline. Ian 2019-12-04 Ian Lance Taylor * edtest.c (test1): Add noclone attribute

libgo patch committed: Always mark assembly file as non-executable stack

2019-12-05 Thread Ian Lance Taylor
This libgo patch arranges for go-context.S to always be marked as using a non-executable stack. This is not required for all targets, but should do little harm. Bootstrapped on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

libgo patch committed: Recognize aarch64_be as arm64be

2019-12-05 Thread Ian Lance Taylor
This libgo patch recognizes aarch64_be as arm64be. I don't know if anything else is needed for aarch64_be support, but this at least is required. This is for GCC PR 92810. Bootstrapped on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE ===

libgo patch committed: Update HURD support for embedded mOS

2019-12-06 Thread Ian Lance Taylor
In the update to 1.13 the mOS field of an m was embedded rather than named. This patch updates the HURD support for that change. This should fix GCC PR 92842. I built the code on x86_64-pc-linux-gnu, but that doesn't actually test this. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

Re: libgo patch committed: Always mark assembly file as non-executable stack

2019-12-06 Thread Ian Lance Taylor
Thanks, rather than try to make this work everywhere, I decided to only build the file for x86 GNU/Linux for now, since that is the only place it is currently used. This patch bootstrapped on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE =

libgo patch committed: Hurd fix

2019-12-08 Thread Ian Lance Taylor
I've committed this Hurd fix by Samuel Thibault for GCC PR 92861. Ian Index: gcc/go/gofrontend/MERGE === --- gcc/go/gofrontend/MERGE (revision 279063) +++ gcc/go/gofrontend/MERGE (working copy) @@ -1,4 +1,4 @@ -15c7bc9f0a432bc

Re: libgo patch committed: Hurd fix

2019-12-09 Thread Ian Lance Taylor
On Sun, Dec 8, 2019 at 7:43 PM Ian Lance Taylor wrote: > > I've committed this Hurd fix by Samuel Thibault for GCC PR 92861. And a followup patch, also by Samuel Thibault. Committed to mainline. Ian Index: gcc/go/gofro

libbacktrace patch committed: Remove duplication of address handling

2019-12-09 Thread Ian Lance Taylor
Before this patch libbacktrace duplicated the handling of DW_AT_low_pc, DW_AT_high_pc, and DW_AT_ranges, once to build a mapping from addresses to compilation units, and then again to build a mapping from addresses to functions within a compilation unit. This patch removes the duplication into a p

Go patch committed: Build type descriptor for alias in other package

2019-12-10 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang generates type descriptors for pointers to aliases defined in other packages. When a type descriptor is needed (for e.g. interface conversion), if the type is a pointer to a named type defined in another package, we don't generate the definition of the

libbacktrace patch committed: Add DWARF 5 support

2019-12-13 Thread Ian Lance Taylor
This patch to libbacktrace adds DWARF 5 support. I tested this with GCC 8, GCC tip, and clang 8, using the -gdwarf-5 option. Bootstrapped and ran libbacktrace and libgo tests on x86_64-pc-linux-gnu. Committed to mainline. Ian 2019-12-13 Ian Lance Taylor Add DWARF 5 support. * dwarf.c

gccgo branch updated

2019-12-13 Thread Ian Lance Taylor
I've updated the gccgo branch to revision 279380 of trunk. Ian

Re: gccgo branch updated

2019-12-18 Thread Ian Lance Taylor
I've updated the gccgo branch to revision 279561 of trunk. Ian

libgo patch committed: Hurd portability patches

2019-12-23 Thread Ian Lance Taylor
This libgo patch by Svante Signell adds some Hurd portability patches to libgo. These are from GCC PR 93020. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE === --

Go patch committed: Split writing of equal and hash functions for types

2020-01-02 Thread Ian Lance Taylor
This patch to the Go frontend splits the writing of equal and hash functions for types, rather than doing them in a single operation. This is almost entirely a pure refactoring in preparation for generating hash functions only for types that are map keys. The only change in generated code is that

Go patch committed: Generate hash functions only for map keys

2020-01-02 Thread Ian Lance Taylor
This patch to the Go frontend and libgo changes the compiler to only generate hash functions for types used as map keys. Right now we generate hash functions for all types, just in case they are used as map keys. That's a lot of wasted effort and binary size for types which will never be used as a

Go patch committed: Avoid a couple of compiler crashes

2020-01-07 Thread Ian Lance Taylor
This patch to the Go frontend avoids a couple of compiler crashes. These came up while building 1.14beta1 while the code was still invalid. The general policy is to not bother committing invalid test cases that cause compiler crashes. Bootstrapped and ran Go tests on x86_64-pc-linux-gnu. Committ

Go patch committed: Avoid write barrier for a[i] = a[i][:v]

2020-01-07 Thread Ian Lance Taylor
This patch to the Go frontend avoids generating a write barrier for code that appears in the Go1.14beta1 runtime package in (*pageAlloc).sysGrow: s.summary[l] = s.summary[l][:needIdxLimit] Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofro

Go patch committed: Stop using __go_runtime_error

2020-01-07 Thread Ian Lance Taylor
This patch to the Go frontend and libgo stops using __go_runtime_error. We use specific panic functions instead, which are mostly already in the runtime package. We also correct "defer nil" to panic when we execute the defer, rather than throw when we queue it. Bootstrapped and ran Go testsuite

Go patch committed: Fix loopdepth tracking in array slice

2020-01-07 Thread Ian Lance Taylor
This Go frontend patch by Cherry Zhang fixes the loopdepth tracking in array slicing expressions in escape analysis. In the gc compiler, for slicing an array, its AST has an implicit address operation node. There isn't such a node in the gofrontend AST. During escape analysis, we create a fake no

Re: [PATCH] tree-ssa-dse: Fix up go.test/test/fixedbugs/issue16095.go miscompilation [PR100382]

2021-05-03 Thread Ian Lance Taylor
Jakub Jelinek writes: > The new DCE code inside of tree DSE removes in -fnon-call-exceptions > go code a load from NULL pointer the testcase relies on throwing an > exception and so the test hangs. > > The following patch just repeats a check that e.g. tree-ssa-dce.c > uses to prevent this. Than

libbacktrace patch committed: Read symbol table of debuginfo file

2024-02-29 Thread Ian Lance Taylor
This patch to libbacktrace reads symbol tables from debuginfo files. These become another symbol table to search. This is needed if people use --strip-all rather than --strip-debug when adding a debuglink section. This fixes https://github.com/ianlancetaylor/libbacktrace/issues/113. Bootstrapped

Re: libbacktrace patch committed: Read symbol table of debuginfo file

2024-03-01 Thread Ian Lance Taylor
On Thu, Feb 29, 2024 at 7:47 PM Ian Lance Taylor wrote: > > This patch to libbacktrace reads symbol tables from debuginfo files. > These become another symbol table to search. This is needed if people > use --strip-all rather than --strip-debug when adding a debuglink > secti

libbacktrace patch committed: Skip all LZMA block header padding bytes

2024-03-02 Thread Ian Lance Taylor
This patch to libbacktrace corrects the LZMA block header parsing to skip all the padding bytes, verifying that they are zero. This fixes https://github.com/ianlancetaylor/libbacktrace/issues/118. Bootstrapped and ran libbacktrace tests on x86_64-pc-linux-gnu. I was able to verify that the proble

libbacktrace patch committed: Link test programs with -no-install

2024-03-02 Thread Ian Lance Taylor
Some of the libbacktrace tests link a program and then modify the debug info in some way. When configured with --enable-shared the linking, using libtool, generates a shell script. That causes the tests to fail because they can't modify the debug info of a shell script. This patch, originally by

libbacktrace patch committed: Don't assume compressed section aligned

2024-03-08 Thread Ian Lance Taylor
Reportedly when lld compresses debug sections, it fails to set the alignment of the compressed section such that the compressed header can be read directly. To me this seems like a bug in lld. However, libbacktrace needs to work around it. This patch, originally by the GitHub user ubyte, does th

Re: No rule to make target '../libbacktrace/libbacktrace.la', needed by 'libgo.la'. [PR106472]

2024-03-25 Thread Ian Lance Taylor
On Sat, Mar 23, 2024 at 4:32 AM Дилян Палаузов wrote: > > Can the build experts say what needs to be changed? The dependencies I added > are missing in the build configuration (@if gcc-bootstrap). > > I cannot say if libbacktrace should or should not be a bootstrap=true module. I don't count as

Re: No rule to make target '../libbacktrace/libbacktrace.la', needed by 'libgo.la'. [PR106472]

2024-03-26 Thread Ian Lance Taylor
pp; bootstrap=true; }; // since 4f4e53dd8517c0b2 > - year 2004 Yes. I was just trying to answer your question. Ian > Am 25. März 2024 23:59:52 UTC schrieb Ian Lance Taylor : >> >> On Sat, Mar 23, 2024 at 4:32 AM Дилян Палаузов >> wrote: >>> >>> >>>

Go patch committed: initialize local variable in lower_method_expression

2024-03-27 Thread Ian Lance Taylor
This patch to the Go frontend fixes an uninitialized variables in lower_method_expression. This fixes GCC PR 114463. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian 7b2a24f3964509bd5b74c4579c7ea5684e82aee1 diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofron

Go patch committed: Update issue16016 test

2024-03-27 Thread Ian Lance Taylor
This patch to the Go testsuite updates issue16016.go. This backports https://go.dev/cl/574536 into the GCC testsuite. This fixes PR go/114453. Bootstrapped and ran test. Committed to mainline. Ian 5b6f599670994bef957bd15c683102468a7104f1 diff --git a/gcc/testsuite/go.test/test/fixedbugs/issue1

Go patch committed: Use correct check for index value overflow

2024-03-27 Thread Ian Lance Taylor
This patch to the Go frontend uses the correct size and comparison when doing an index value overflow check. This has apparently been wrong since I introduced the code ten years ago. This fixes GCC PR 114500. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian 1

Re: [PATCH] go: Add go.install-dvi rule in go/Make-lang.in

2024-04-04 Thread Ian Lance Taylor
On Thu, Apr 4, 2024 at 9:27 AM Christophe Lyon wrote: > > go has a go.dvi build rule, but lacks the go.install-dvi one. > > 2024-04-04 Christophe Lyon > > gcc/go/ > * Make-lang.in (go.install-dvi): New rule. This is OK. Thanks. Ian

Go patch committed: Export the type "any" as a builtin

2024-02-02 Thread Ian Lance Taylor
This patch to the Go frontend exports the type "any" as a builtin. Otherwise we can't tell the difference between builtin type "any" and a locally defined type "any". This will require updates to the gccgo export data parsers in the main Go repo and the x/tools repo. These updates are https://go.

libgo patch committed: Better error messages for unsupported target

2024-02-02 Thread Ian Lance Taylor
This libgo patch generates better error messages then the Go GOARCH and GOOS values can't be determined from the target. This indicates that the target is not supported. This is for GCC PR 113530. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian cfc6d9ae8143c

  1   2   3   4   5   6   7   8   9   10   >