Re: [PATCH v2] libiberty: Use posix_spawn in pex-unix when available.

[Ian Lance Taylor]

On Tue, Oct 3, 2023 at 12:04 PM Brendan Shanks <bsha...@codeweavers.com> wrote:
>
> +  ret = posix_spawnattr_init (&attr);
> +  if (ret) { *err = ret; *errmsg = "posix_spawnattr_init"; goto exit; }

Sorry, but let's keep the formatting used in the rest of the file.

if (ret != 0)
  {
    *err = ret;
    *errmsg = "posix_spawnattr_init";
    goto exit;
  }



> +  if (in != STDIN_FILE_NO)
> +    close (in);
> +  if (out != STDOUT_FILE_NO)
> +    close (out);
> +  if (errdes != STDERR_FILE_NO)
> +    close (errdes);

Not a big deal, but the other version of this function checks the
error result of close.

Ian