On Mon, Nov 11, 2019 at 10:12 AM Maciej W. Rozycki <ma...@wdc.com> wrote: > > Fix a problem with the libgo testsuite using a method to determine the > compiler to use resulting in the tool being different from one the > library has been built with, and causing a catastrophic failure from the > lack of a suitable `--sysroot=' option where the `--with-build-sysroot=' > configuration option has been used to build the compiler resulting in > the inability to link executables. > > Address this problem by providing a DejaGNU configuration file defining > the compiler to use, via the GOC_UNDER_TEST TCL variable, set from $GOC > by autoconf, which will have all the required options set for the target > compiler to build executables in the environment configured, removing > failures like: > > .../bin/riscv64-linux-gnu-ld: cannot find crt1.o: No such file or directory > .../bin/riscv64-linux-gnu-ld: cannot find -lm > .../bin/riscv64-linux-gnu-ld: cannot find -lc > collect2: error: ld returned 1 exit status > compiler exited with status 1 > > No summary comparison, because the libgo testsuite does not provide one > in this configuration for some reason, however this change improves > overall test results for the `riscv64-linux-gnu' target (here with the > `x86_64-linux-gnu' host and RISC-V QEMU in the Linux user emulation mode > as the target board) from 0 PASSes and 159 FAILs to 133 PASSes and 26 > FAILs. > > libgo/ > * configure.ac: Add testsuite/libgo-test-support.exp to output > files. > * configure: Regenerate. > * testsuite/libgo-test-support.exp.in: New file. > * testsuite/Makefile.am (EXTRA_DEJAGNU_SITE_CONFIG): New > variable. > * testsuite/Makefile.in: Regenerate. > * testsuite/lib/libgo.exp: Don't override GOC_UNDER_TEST > previously set.
Thanks. Committed to mainline. Ian
