Ping. This patch
<http://gcc.gnu.org/ml/gcc-patches/2012-08/msg00182.html> is pending
review.
--
Joseph S. Myers
jos...@codesourcery.com
c headers
aren't yet present, inhibit_libc should be defined anyway to disable those
libgcc features depending on system headers from libc.)
--
Joseph S. Myers
jos...@codesourcery.com
ld go into gcc/testsuite/gcc.target/i386/
And restricting the target to x86_64-*-* is wrong anyway, since any such
test should also be run for i?86-*-* -m64. Use { target { ! { ia32 } } }
instead if you want to disable just -m32 testing, { target lp64 } if you
only want -m64 testing but not -m32 or -mx32.
--
Joseph S. Myers
jos...@codesourcery.com
ng down a pointer to a location alongside
&sizeof_arg).
--
Joseph S. Myers
jos...@codesourcery.com
ine. Delaying evaluating sizeof is hard simply because
of the expectation that integer constant expressions in general are
evaluated early.
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 15 Aug 2012, David Edelsohn wrote:
> Does GCC "own" longlong.h, or is that part of GMP or some other project?
It is right now in sync between glibc and GCC; changes should be applied
in both places. It hasn't been in sync with GMP's version for many years.
Ping^2. This patch
<http://gcc.gnu.org/ml/gcc-patches/2012-08/msg00182.html> is still pending
review.
--
Joseph S. Myers
jos...@codesourcery.com
> +#ifdef ENABLE_NLS
I'm not sure it's safe to assume libintl.h exists on all hosts (e.g.
MinGW) unless ENABLE_NLS. (If ENABLE_NLS, the intl/ directory will have
built that header if the host didn't have it.)
--
Joseph S. Myers
jos...@codesourcery.com
On Thu, 16 Aug 2012, Jakub Jelinek wrote:
> Hi!
>
> On Wed, Aug 15, 2012 at 04:29:55PM +0000, Joseph S. Myers wrote:
> > On Wed, 15 Aug 2012, Jakub Jelinek wrote:
> >
> > > I was mainly interested in whether such an approach is acceptable, or
> > > whether
lding any supported target. (Of
course greater levels of testing are possible, e.g. building binutils and
seeing if libgcc builds, but getting cc1 building cleanly would be a good
first step.)
--
Joseph S. Myers
jos...@codesourcery.com
OPT_* for Fortran options only exist when the Fortran front-end is in the
source tree (whether or not enabled). I think we try to avoid knowingly
breaking use cases where people remove some front ends from the source
tree, although we don't actively test them and no longer provide split-up
ore than once for the bootstrap to converge. */
+# define USE_PT_GNU_EH_FRAME
+#endif
+
#if defined(EH_FRAME_SECTION_NAME) && !defined(USE_PT_GNU_EH_FRAME)
# define USE_EH_FRAME_REGISTRY
#endif
--
Joseph S. Myers
jos...@codesourcery.com
bootstrap process. Build the same crt*.o as would be
+ built with headers present, so that it is not necessary to build
+ glibc more than once for the bootstrap to converge. */
+# define USE_PT_GNU_EH_FRAME
+#endif
+
#if defined(EH_FRAME_SECTION_NAME) && !defined(USE_PT_GNU_EH_FRAME)
# define USE_EH_FRAME_REGISTRY
#endif
--
Joseph S. Myers
jos...@codesourcery.com
[
+ free basename getopt clock getpagesize ffs gcc_UNLOCKED_FUNCS, , ,[
#include "ansidecl.h"
#include "system.h"])
--
Joseph S. Myers
jos...@codesourcery.com
; > tree, although we don't actively test them and no longer provide split-up
> > source tarballs.
>
> Thanks for the update. Which fix should move forwards?
I think the approach using a new option flag is the way to go, though the
patch needs (at least) documentation for th
es}.
I don't think there's any need for special --help support for options with
this flag; this flag is really an implementation detail. (Thus, I think
all the opts.c changes are unnecessary.)
--
Joseph S. Myers
jos...@codesourcery.com
(base)$(objext): $o $(base).vis
+ $(gcc_compile) -c -xassembler-with-cpp -include $*.vis $<
+$(base).vis: $(base)_s$(objext)
+ $(gen-hide-list)
+
+$(base)_s$(objext): $o
+ $(gcc_s_compile) -c -xassembler-with-cpp $<
+
endif
--
Joseph S. Myers
jos...@codesourcery.com
Style_Checks (Off).
OK.
--
Joseph S. Myers
jos...@codesourcery.com
Ping^3. This patch
<http://gcc.gnu.org/ml/gcc-patches/2012-08/msg00182.html> is still pending
review.
--
Joseph S. Myers
jos...@codesourcery.com
n is in the doc string in
target.def rather than in tm.texi.in. (If you wish to move *existing*
text from tm.texi.in to such a doc string in target.def, CC me or Diego or
Gerald on the patch and ask for docstring relicensing review.)
--
Joseph S. Myers
jos...@codesourcery.com
.)
Other hosts may or may not have such interfaces. In the presence of
inlining, such interfaces may give less helpful results - and in any case
they seem unlikely to give source line numbers, just function names.
--
Joseph S. Myers
jos...@codesourcery.com
k (switch_flags): Add NoDWARFRecord.
> * doc/options.texi: Document NoDWARFRecord option flag.
>
> gcc/fortran/ChangeLog
> 2012-08-24 Simon Baldwin
>
> * lang.opt (-cpp=): Mark flag NoDWARFRecord.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
* gcc.dg/pr54355.c: New test.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
ach here (allowing COMPOUND_LITERAL_EXPRs to
use anything that would be a valid initializer for the relevant type).
--
Joseph S. Myers
jos...@codesourcery.com
rget != host? I know in my cross compiler, I think
Certainly not. The configuration of the compiler for any given target
should not depend on the host, and existing instances of such things are
bugs.
--
Joseph S. Myers
jos...@codesourcery.com
Ping^4. This patch
<http://gcc.gnu.org/ml/gcc-patches/2012-08/msg00182.html> is still pending
review.
--
Joseph S. Myers
jos...@codesourcery.com
MAIN_VARIANT check from
> COMPLEX_TYPE -> COMPLEX_TYPE conversion.
>
> * gcc.c-torture/compile/pr54428.c: New test.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
? Given recent issues relating to how Ada uses
system.h, I think any such changes need testing for Ada.
--
Joseph S. Myers
jos...@codesourcery.com
os with/without
explicit locations, please use the forms with explicit locations (e.g.
build2_loc instead of build2), and try to link the locations to particular
source code tokens and pass those locations down explicitly to each
function as needed.
There may be more issues; I'll await a r
articular I'll need to review whether
the entirety of the actual implementation is sufficiently covered by
testcases once a revised implementation patch is available.
--
Joseph S. Myers
jos...@codesourcery.com
tion compiled
> for. All I am doing is to map that information to the appropriate "arch"
> attribute. I didn't think it had any back end pecularity.
Concepts such as "pentium_4" are architecture-specific and have no place
in front-end files. This whole mapping from on
similar issue appeared in a draft of the IEEE 758-2008 bindings, all C
function calls are through function pointers - that's how the C standard
defines them - so you need to say (in the specification, not here) what's
meant in actual C standard terms, and make sure the implementation
or longlong.h to have actual support for VLE rather
than just disabling the present code, or is such support much harder to do
than the present code? (Using built-in functions, e.g. __builtin_clz if
that expands inline for VLE, is fine.)
--
Joseph S. Myers
jos...@codesourcery.com
at rather than -Wformat=0.
The same comments apply several times in the patch.
> +@option{-shared}, @option{-nodefaultlibs}, nor @option{static} are found.
@option{-static} (missing '-'). Likewise elsewhere in the patch.
--
Joseph S. Myers
jos...@codesourcery.com
nk all this belongs in gnu-user.h.
> --- a/gcc/config/i386/linux.h 2011-06-03 20:30:39.0 +0200
Likewise.
> +#if def ENABLE_ESPF
Stray space inside #ifdef.
--
Joseph S. Myers
jos...@codesourcery.com
On Fri, 7 Sep 2012, Magnus Granberg wrote:
> Patch: config.in.patch
> Add ENABLE_ESPF*
You don't patch config.in manually. You regenerate it with autoheader
after editing configure.ac.
--
Joseph S. Myers
jos...@codesourcery.com
the code is written how
it is is that no-argument formats such as %< and %> may appear in msg and
need interpreting).
--
Joseph S. Myers
jos...@codesourcery.com
y has its own ChangeLog.
> + int plen;
Use size_t rather than int for this length.
> +plen = strlen(ada_specs_parent) + 1;
Missing space before '('.
> +strcpy(res, ada_specs_parent);
Likewise.
> +res [plen - 1] = '.';
Stray space before '['
all parts have changed in a particular revision.
--
Joseph S. Myers
jos...@codesourcery.com
in together is available for
review.
--
Joseph S. Myers
jos...@codesourcery.com
er itself,
as well as the target copy.)
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 12 Sep 2012, Ian Lance Taylor wrote:
> On Wed, Sep 12, 2012 at 9:23 AM, Joseph S. Myers
> wrote:
> > On Tue, 11 Sep 2012, Ian Lance Taylor wrote:
> >
> >> The configury is fairly standard. Note that libbacktrace is built as
> >> both a host library (
x and i686-linux,
> ok for trunk/4.7?
>
> 2012-09-13 Jakub Jelinek
>
> PR c/54559
> * c-typeck.c (c_finish_return): Do convert to BOOLEAN_TYPE or
> COMPLEX_TYPE with in_late_binary_op set temporarily to true.
>
> * gcc.c-torture/compi
version for tools with glibc
targets, and the --enable-gnu-unique-object test should be changed to use
the version from the headers like other tests do.
--
Joseph S. Myers
jos...@codesourcery.com
*/
- /* { dg-error "3:not an integer constant" "constant" { target *-*-* } 24 } */
+ /* { dg-error "8:not an integer constant" "constant" { target *-*-* } 24 } */
E7 = INT_MIN % -1 /* Not an overflow. */
};
--
Joseph S. Myers
jos...@codesourcery.com
oid
+f (void)
+{
+ unsigned n = 10;
+
+ typedef double T[n];
+ (double (*)[n])((unsigned char (*)[sizeof (T)]){ 0 });
+}
--
Joseph S. Myers
jos...@codesourcery.com
IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE. */
>
> +#define _GNU_SOURCE
I think AC_USE_SYSTEM_EXTENSIONS is preferred to defining _GNU_SOURCE in
individual source files.
--
Joseph S. Myers
jos...@codesourcery.com
m. That is, rather than just mapping to an array of values with those
values used in different ways for different source code constructs, it
should be possible to tell that a given location_t is mapping to certain
locations as corresponding to first and second operands of an binary
operator (for example).
--
Joseph S. Myers
jos...@codesourcery.com
nt to insert a third location in
the middle (the location of the operator, say) then you don't need to
change everything that referred to locations symbolically.
--
Joseph S. Myers
jos...@codesourcery.com
l is_sec_implicit_index_fn (tree);
+void array_notation_init_builtins (void);
in a source file (array-notation-common.c), either make them static or
declare them in an appropriate header included everywhere needing those
declarations.
There may also be other issues.)
--
Joseph S. Myers
jos...@codesourcery.com
On Thu, 27 Sep 2012, Vladimir Makarov wrote:
> * target.h: Include tm.h.
That's a backward step; we'd like parts of the compiler that aren't using
target macros directly not to end up including tm.h. Why do you need
this?
--
Joseph S. Myers
jos...@codesourcery.com
On Thu, 27 Sep 2012, Vladimir Makarov wrote:
> Hook spill_class returns a value of enum reg_class which is defined in
> target-depend include file.
That's what reg_class_t is for: avoiding enum reg_class in hook
interfaces.
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 13 Jun 2012, Diego Novillo wrote:
> The LTO bits are fine. I would prefer if an FE maintainer takes a second look
> over the other bits. Jason, Joseph?
The c-decl.c changes are fine with me.
--
Joseph S. Myers
jos...@codesourcery.com
You have to use the non-typedef versions, with the keywords in the correct
order - see the documentation of SIZE_TYPE in tm.texi for details.
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 13 Jun 2012, Richard Henderson wrote:
> On 2012-06-12 12:44, Joseph S. Myers wrote:
> > I'd rather have a macro HOST_WIDE_INT_C in hwint.h (like INTMAX_C etc. in
> > stdint.h). HOST_WIDE_INT_1 is already defined in hwint.h to either 1L or
> > 1LL; I'd s
as known incomplete. Anyway, check for
open "testsuite" bugs for the issues you are fixing.
--
Joseph S. Myers
jos...@codesourcery.com
rent, or use "-Dwith_PCH" and "-Dwithout_PCH" in the flags
> that will appear in the test summary. Do you have a preference?
I have no preference here.
--
Joseph S. Myers
jos...@codesourcery.com
same processing.
Does this fix bug 864? If so, you should mention
PR ada/864
in the ChangeLog entry, and resolve that bug as fixed.
--
Joseph S. Myers
jos...@codesourcery.com
Please resubmit a self-contained patch submission to gcc-patches.
--
Joseph S. Myers
jos...@codesourcery.com
t; then
HOST_WIDE_INT is what we have at present. If it's "fast on the host, but
size doesn't matter", then HOST_WIDEST_FAST_INT.
--
Joseph S. Myers
jos...@codesourcery.com
GCC - that it is an integer or size existing in
some way on the target - and code needs to address the human reader, not
just the compiler compiling it.
--
Joseph S. Myers
jos...@codesourcery.com
On Fri, 15 Jun 2012, Mike Stump wrote:
> On Jun 15, 2012, at 2:46 PM, Joseph S. Myers wrote:
> > HOST_WIDE_INT is an abstraction about the *target*; the target determines
> > the required properties. The salient properties include:
> >
> > * At least as wide as tar
ible. Marc, could you have a
> look at this, please?
What targets (such as AIX?) did not explicitly undefine it, but did not
get a definition from any header they used either? It's quite likely some
such targets *should* have had NO_IMPLICIT_EXTERN_C defined, but not
necessarily all of them.
--
Joseph S. Myers
jos...@codesourcery.com
me to convert return values from main into whatever form the
underlying platform expects, rather than for the compiler to generate
something different from what "return 0;" would do.
--
Joseph S. Myers
jos...@codesourcery.com
testsuite.patch.gz
> http://www.gdcproject.org/files/gdc_gcc.patch.gz
Please provide GNU ChangeLog entries for each patch, for each relevant
ChangeLog file. It would be best to post those in plain text to the list,
even if the patches themselves are too big.
--
Joseph S. Myers
jos...@codesourcery.com
trib.texi in this patch.
I'd also expect contrib/gcc_update to be updated to handle timestamp
ordering for generated files in libphobos.
Are you volunteering to be appointed maintainer for this front end by the
SC?
--
Joseph S. Myers
jos...@codesourcery.com
ver for D.
> +$(D_DRIVER_NAME)$(exeext): $(D_GCC_OBJS) $(D_DRIVER_OBJS) $(EXTRA_GCC_OBJS)
> $(D_EXTRA_SPEC_LIBS) $(LIBDEPS)
> + $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ \
I think you mean +$(LINKER) not $(CC). The '+' is I think related to LTO,
the use of $(LINKER) is needed to link appropriately with host libstdc++
in the presence of various options for building as C++.
I don't see d.pdf or d.html targets in your Make-lang.in - make sure
you're up to date with the full current set of hooks front ends should
define.
> diff -Naur gcc-4.8-20120617/gcc/d/rdmd.1 gcc-4.8/gcc/d/rdmd.1
Same comments as above.
--
Joseph S. Myers
jos...@codesourcery.com
27;s not. No runtime libraries should go under gcc/ any more at all.
> +dnl Copied from libstdc++-v3/acinclude.m4. Indeed, multilib will not work
Refactor into the config/ directory, don't copy.
> \ No newline at end of file
Add any missing newlines to text files in all patches.
--
Joseph S. Myers
jos...@codesourcery.com
On Mon, 18 Jun 2012, Iain Buclaw wrote:
> http://www.gdcproject.org/files/gdc_testsuite.patch.gz
I have no comments on this patch for now.
--
Joseph S. Myers
jos...@codesourcery.com
mr %0,%1
{l%U1%X1|lwz%U1%X1} %0,%1")
+(define_insn "*mov_si_e500_subreg4_elf_low"
+ [(set (subreg:SI (match_operand:SPE64TF 0 "register_operand" "+r") 4)
+ (lo_sum:SI (match_operand:SI 1 "gpc_reg_operand" "r")
+ (match_operand 2 "" "")))]
+ "((TARGET_E500_DOUBLE && (mode == DFmode || mode == TFmode))
+|| (TARGET_SPE && mode != DFmode && mode != TFmode))
+ && TARGET_ELF && !TARGET_64BIT"
+ "{ai|addic} %0,%1,%K2")
+
(define_insn "*mov_si_e500_subreg4_2"
[(set (match_operand:SI 0 "rs6000_nonimmediate_operand" "+r,m")
(subreg:SI (match_operand:SPE64TF 1 "register_operand" "r,r") 4))]
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 20 Jun 2012, Steven Bosscher wrote:
> This patch was bootstrapped&tested on powerpc64-unknown-linux-gnu.
> The issues with #ident have already been addressed, and this patch
> adds a new test case, to make sure...
>
> OK for trunk?
OK.
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 20 Jun 2012, Meador Inge wrote:
> P.S. If it is OK, then can someone commit for me (I don't have write access)?
This is OK. You should have write-after-approval access. Overseers,
please add user meadori to group gcc.
--
Joseph S. Myers
jos...@codesourcery.com
, this looks like the right approach. I'm not aware of other things;
"special" directories such as c-family need special treatment in
po/exgettext, but that doesn't apply to normal front-end directories
containing a config-lang.in.
--
Joseph S. Myers
jos...@codesourcery.com
).
> and a ping (you see now what I meant).
I advise CC:ing pings to relevant maintainers (in this case, build-system
maintainers).
--
Joseph S. Myers
jos...@codesourcery.com
s generally operations with floating-point results that raise
exceptions only for signaling NaN operands.
--
Joseph S. Myers
jos...@codesourcery.com
submit without those
changes, and submit them separately with their own rationale if needed.
--
Joseph S. Myers
jos...@codesourcery.com
On Mon, 25 Jun 2012, Christophe Lyon wrote:
> Ping?
I advise CCing appropriate maintainers (in this case, build system
maintainers) on pings.
--
Joseph S. Myers
jos...@codesourcery.com
by one space.
> > +
> > +
> > +
> > +Indent class members by two spaces.
Do all the listed indentation rules correspond to what a will do by
default when editing C++ code in GNU Emacs? If not, we have conflicting
notions of GNU C++ indentation conventions.
--
Joseph S. Myers
jos...@codesourcery.com
out of this general
thread. Then, to add individual features to the list we can discuss those
features and standards for them separately.
--
Joseph S. Myers
jos...@codesourcery.com
the ChangeLog typo fixed.
--
Joseph S. Myers
jos...@codesourcery.com
xternal shared repository (with all changes going to the
external repository first); Ian Taylor may have some automation for that
issue for Go.
--
Joseph S. Myers
jos...@codesourcery.com
erbatim) I
think that would work (importing from releases / release branches in the
upstream repository rather than always the development mainline).
Likewise any other directories taken verbatim from some external
repository shared between D compilers.
--
Joseph S. Myers
jos...@codesourcery.com
soft-fp if both soft-fp and fp-bit are configured, it would seem
cleaner for the fragments to configure only the relevant one.
--
Joseph S. Myers
jos...@codesourcery.com
namespaces are a useful feature to use in GCC (with a
namespace for the gcc/ directory, or as you imply separate ones for the
driver and the compilers proper, one for libcpp, one for each front end,
etc.).
--
Joseph S. Myers
jos...@codesourcery.com
Try CC:ing Gerald as the most likely maintainer to review this.
--
Joseph S. Myers
jos...@codesourcery.com
;make install".
> OK for trunk?
OK, though "Skin" in the ChangeLog entries looks like a typo.
--
Joseph S. Myers
jos...@codesourcery.com
ery year in the range,
+inclusive, is a copyrightable year that could otherwise be listed
+individually.
--
Joseph S. Myers
jos...@codesourcery.com
ention - only about which of the GNU options we use. The simplest
is -2012 (for any value of 1987 or later) and so
I am proposing we move to that (make this change to README to allow it,
allow converting files when 2012 is added to the copyright years, as is
now done in glibc, allow a bulk conversion if anyone wishes to do one).
--
Joseph S. Myers
jos...@codesourcery.com
the dash format are why the GNU
instructions require a statement in a README file about the use of that
notation.
--
Joseph S. Myers
jos...@codesourcery.com
ource
file including tree-flow.h should have included coretypes.h before
tree-flow.h. (That is, I think any include of coretypes.h from another .h
file, except probably for the special case of gcc-plugin.h, is suspect
unless we decide to change the convention.)
--
Joseph S. Myer
nly target macros or macros
predefined by the compiler.
--
Joseph S. Myers
jos...@codesourcery.com
sts all work for it. It would seem advisable to add tests
covering pure integer operations for the new type (all the C integer
operations), for both constants and runtime evaluation, as well.
--
Joseph S. Myers
jos...@codesourcery.com
the various special-width integer types, used on whichever targets
support those widths. If you have a 24-bit type now it might be good to
extend the floating-point / integer conversion tests I mentioned to cover
it
--
Joseph S. Myers
jos...@codesourcery.com
r modes on the target can be
used for integer types and replacing code using those globals by something
iterating over integer modes, would be a good first step. It shouldn't be
that hard to move on to making the existence of TImode target-specific
(I'd guess there would be a common .def file used by all targets that have
TImode).
--
Joseph S. Myers
jos...@codesourcery.com
ch tests
would both help validate that a reworking of __int128 support does not
cause regressions, as well as being a possible basis to add tests of
__int256.
--
Joseph S. Myers
jos...@codesourcery.com
I have now committed this patch to allow the use of ranges.
--
Joseph S. Myers
jos...@codesourcery.com
iew to make sure that the changes for that
architecture won't end up using an inappropriate multiarch name for some
configure options, and thus it's best to get the basic support in first
then handle each architecture individually with a separate patch.
--
Joseph S. Myers
jos...@codesourcery.com
gt; about how to
approach the change more incrementally, at least get the benefits of
whatever changes don't trigger the bug, and if the bug does reappear then
understand properly what is required to make it appear.
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 25 Jul 2012, Andrew Pinski wrote:
> * config/mips/linux-common.h (TARGET_ASM_FILE_END): Define.
Do you also need to change libgcc/config/mips/*.S to include the
appropriate note?
--
Joseph S. Myers
jos...@codesourcery.com
Do you handle how, in certain syntactic locations, a C++11 attribute binds
differently to a GNU attribute? (I haven't studied the patch, so feel
free to point me to testcases it adds that verify such differences, if
applicable.)
--
Joseph S. Myers
jos...@codesourcery.com
901 - 1000 of 1676 matches
Mail list logo
