On Wed, 5 Sep 2012, Iyer, Balaji V wrote:
> Hello Everyone,
> Attached, please find a patch that will add regression test cases
> for elemental function implementation in C.
Can the tests be arranged so that all functionality that isn't
intrinsically target-specific is tested for all targets - or at least, so
it's easy for testsuite support for extra targets to be added without
needing to duplicate lots of tests?
You do:
# For 64 bit architectures, we can run both 32 bit and 64 bit tests.
if { [istarget x86_64-*-*] } then {
This is the wrong approach. i?86-*-* targets can also support 64-bit
while defaulting to 32-bit. Instead, leave it up to the user to specify
the multilib options with which to test - if they wish to run both 32-bit
and 64-bit tests, they can run the whole testsuite in both modes.
Again, there may be more issues; in particular I'll need to review whether
the entirety of the actual implementation is sufficiently covered by
testcases once a revised implementation patch is available.
--
Joseph S. Myers
[email protected]
