avr-*-* case that is too general, matching
nonsensical targets such as AVR Linux rather than just avr-*-none /
avr-*-elf.
--
Joseph S. Myers
jos...@codesourcery.com
oals) without JavaScript, for example.
--
Joseph S. Myers
jos...@codesourcery.com
linker
and cc1 to search in those paths, and how multiple relevant options get
processed by the linker and cc1 after being passed to them, would be
needed to justify that a particular patch does achieve the desired search
order.
--
Joseph S. Myers
jos...@codesourcery.com
r cases, exhaustive searches may
be needed to determine when the conversion is safe.
(Actually, this code appears to deal with cases with up to three types
involved - the operand, the result and the function that's called. This
complicates the analysis a bit, but the same principles
old folder). So, I think you should detect this at some point in the
GIMPLE optimizations rather than changing fold-const at all (and as a
consequence, you then shouldn't need to change front-end pretty-printers).
--
Joseph S. Myers
jos...@codesourcery.com
e.
(ARM does support having processes with both endiannesses - indeed, a
process can change its own endianness with the unprivileged SETEND
instruction (deprecated in ARMv8) - although the Linux kernel has no
support for this the last time I checked, and big-endian ARM is rarely
used.)
--
Joseph S. Myers
jos...@codesourcery.com
ses after the patch. (I realise such a test may only be
able to run for a subset of targets.)
--
Joseph S. Myers
jos...@codesourcery.com
On Fri, 23 Aug 2013, Alan Modra wrote:
> I'd like to import upstream libtool into gcc to support powerpc64le,
Has the sysroot semantics issue been resolved in upstream libtool, or do
you mean "import with 3334f7ed5851ef1e96b052f2984c4acdbf39e20c reverted"?
--
J
ake_file rather than override it.
>
> B. Do nothing. On the general principle that if it ain't broke don't fix
> it.
>
> C. Draw up another patch that restricts the AVR patterns in config.gcc to
> -none and -elf.
A and C - I think both changes should be applied.
--
Joseph S. Myers
jos...@codesourcery.com
On Fri, 23 Aug 2013, Zoran Jovanovic wrote:
> New test case involving unions is added.
Tests for unions should include *execution* tests that the relevant bits
have the right values after the sequence of assignments.
--
Joseph S. Myers
jos...@codesourcery.com
On Sun, 25 Aug 2013, Gabriel Dos Reis wrote:
> Instead of defining the same macro several times in different
> translation units, we can just make it a function and use it where
> needed.
Have you made sure that po/exgettext still extracts the relevant messages
for translation (I'm not sure how
not that I am found of the conditional, but only by curiosity.)
Previously, each string was inside a separate call to M_() - the strings
themselves were the msgid parameters. Now, the msgid parameter is not a
single string but a more complicated expression and xgettext may not
handle such expressions properly the way it handles having just a single
string as parameter.
--
Joseph S. Myers
jos...@codesourcery.com
his sort of
conditional expression.
--
Joseph S. Myers
jos...@codesourcery.com
, consider whether the
code is actually correct to be using BITS_PER_UNIT at all - whether it's
the RTL-level QImode that is really what's relevant to the code.
--
Joseph S. Myers
jos...@codesourcery.com
In convert_arguments I think you should be comparing TYPE_MAIN_VARIANT
(valtype) against double_type_node and long_double_type_node, rather than
just valtype.
This is PR c/35649 (so include that number in your ChangeLog entry and
close that bug as fixed).
--
Joseph S. Myers
jos
ose
targets, it's probably time to deprecate them (and then freely check in
changes that break them by requiring those types to be defined).
--
Joseph S. Myers
jos...@codesourcery.com
headers and compute target_header_dir that way, to
the extent that the target headers need examining to determine
configuration of the compiler proper.
--
Joseph S. Myers
jos...@codesourcery.com
to have ignored my explanation of the necessary and
sufficient condition on the precisions of the respective types. The
conversion is not safe for sqrt if the two types are double and long
double and long double is x86 extended, for example.
--
Joseph S. Myers
jos...@codesourcery.com
ith current git glibc. The existence of a
bug in some old library is not relevant here.
(c) I always advise writing such tests as *valid C code* using hex floats
(or if really necessary, unions), not *invalid C code* with aliasing
violations.
--
Joseph S. Myers
jos...@codesourcery.com
o name in
#define, #ifdef etc., and does not get converted to 0 in #if conditions
but is interpreted as an operator there. (The status of "new" and
"delete" in this regard is less clear; see
<http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#369>.)
--
Joseph S. Myers
jos...@codesourcery.com
antics for non-packed structures as well - AAPCS
strict-volatile-bitfields is only compatible with --param
allow-store-data-races=1, which is not the default for any language
variant accepted by GCC (and I say that the default language semantics
here should not depend on the target arch
tile-bitfields implies --param allow-store-data-races=1.
And my concern is specifically about the defaults - the default for ARM
should be the same C/C++ language as on other targets - rather than what
happens if someone specifies -fstrict-volatile-bitfields explicitly.
--
Joseph S. Myers
jos...@codesourcery.com
ating point to produce the more general
analysis. But in any case, it's for the patch submitter to give the full
explanation.)
--
Joseph S. Myers
jos...@codesourcery.com
DE (double_type_node)) &&
> +!flag_unsafe_math_optimizations)
> + break;
Please reread my previous messages on this subject and try again, with
regard to both the patch itself and the accompanying analysis.
--
Joseph S. Myers
jos...@codesourcery.com
e four types, but not
with long_double_type_node directly).
The patch submission will need to include a proper analysis to justify to
the reader why the particular inequality with particular types from those
four is correct in all cases where the relevant code may be executed.
--
Joseph S. Myers
jos...@codesourcery.com
would
seem better to have __SIZE_MAX__ in the test (or a macro defined in the
test that defaults to __SIZE_MAX__ but is overridden for particular
targets, if some targets need it overridden).
--
Joseph S. Myers
jos...@codesourcery.com
--enable-data-races and require it to be used along with
--disable-threads, or something like that.
--
Joseph S. Myers
jos...@codesourcery.com
as below.
This patch submission still fails to pay attention to various of my
comments.
--
Joseph S. Myers
jos...@codesourcery.com
re. I've certainly
spent longer than that on review in this thread. It's normal for a patch
involving anything at all tricky to take hours to write up (and also
normal for one to discover, in the course of writing the detailed coherent
analysis for people who aren
y headers if those are available when
the compiler is configured, it only supports checking the default multilib
and not headers for other multilibs.
--
Joseph S. Myers
jos...@codesourcery.com
x27;t
think it's a priority.)
--
Joseph S. Myers
jos...@codesourcery.com
ourse it becomes more
complicated to identify which front-end files are still including tm.h, as
they may include it indirectly.)
--
Joseph S. Myers
jos...@codesourcery.com
e
well-defined source code feature lacking GCC support, or exceeding
implementation limits in GCC).
--
Joseph S. Myers
jos...@codesourcery.com
On Mon, 9 Sep 2013, Mike Stump wrote:
> On Sep 9, 2013, at 3:48 PM, "Joseph S. Myers" wrote:
> > On Mon, 9 Sep 2013, Mike Stump wrote:
> >
> >> Presently gcc just dies with a crash for an unhanded operation, the
> >> below handles it better.
> &g
be the relocated prefix rather than
the unrelocated one.
If there is a bug, I'd say it's in whatever code is calling update_path
without having first done the make_relative_prefix relocation on the path
being passed to update_path. Thus, it is that caller that you need to
fix.
--
Joseph S. Myers
jos...@codesourcery.com
ar design - a clear understanding of what sort of paths should be used
where and what interfaces should translate them to other kinds of paths -
rather than just locally changing the paths used in one particular place
without a basis for arguing that the change fits a coherent design and so
won't cause problems elsewhere.
--
Joseph S. Myers
jos...@codesourcery.com
ix targets with non-GNU system assembler/linker, it can be
made unconditional.)
So only targets where TLS support was a recent addition to the GNU
assembler, or those supporting a non-GNU assembler where TLS may or may
not be supported, would need such a test at all.
--
Joseph S. Myers
jos...@codesourcery.com
hould be
> discussed on gcc@ before having the actual patch reviewed?
I'm thinking of this as a build-system change rather than a driver one.
--
Joseph S. Myers
jos...@codesourcery.com
On Thu, 12 Sep 2013, Joseph S. Myers wrote:
> (Actually, I believe sizes (in bytes) greater than target PTRDIFF_MAX, not
> just SIZE_MAX, should be caught, because pointer subtraction cannot work
> reliably with larger objects. So it's not just when the size or
> multip
believe sizes (in bytes) greater than target PTRDIFF_MAX, not
just SIZE_MAX, should be caught, because pointer subtraction cannot work
reliably with larger objects. So it's not just when the size or
multiplication overflow size_t, but when they overflow ptrdiff_t.)
--
Joseph S. Myers
jos...@codesourcery.com
he entry should go there without the initial
c/ in the file name in the ChangeLog entry.
The patch is OK with the addition of the testcase you gave to
gcc.target/i386/.
--
Joseph S. Myers
jos...@codesourcery.com
-ftree-slp-vectorize -fno-tree-vectorize
Should mean -ftree-slp-vectorize.
--
Joseph S. Myers
jos...@codesourcery.com
On Fri, 13 Sep 2013, Marek Polacek wrote:
> On Thu, Sep 12, 2013 at 04:05:48PM +0000, Joseph S. Myers wrote:
> > cause stack overflow that doesn't get detected by the kernel. So maybe
> > ubsan should imply -fstack-check or similar.
>
> Well, I have a patch for that,
xpression if we can prove it is correct.
Shouldn't the conditions used here for an expression being proved correct
match those for instrumentation, i.e. depend on flag_isoc99 and on
(cxx_dialect == cxx11 || cxx_dialect == cxx1y)?
--
Joseph S. Myers
jos...@codesourcery.com
On Mon, 16 Sep 2013, Marek Polacek wrote:
> On Fri, Sep 13, 2013 at 07:18:24PM +0000, Joseph S. Myers wrote:
> > On Fri, 13 Sep 2013, Marek Polacek wrote:
> >
> > > This is kind of fugly, but don't have anything better at the moment.
> > > 2013-09-13 Marek
; significantly simpler.
>
> Joseph, any comments on this?
No comments here.
--
Joseph S. Myers
jos...@codesourcery.com
eneric rules to be used (my understanding
was that the auto-deps patch series made lots of such changes to the
locations of .o files in the build tree to avoid needing special
compilation rules for particular files)?
--
Joseph S. Myers
jos...@codesourcery.com
undation, Inc.
+ 2009, 2010, 2011, 2012 Free Software Foundation, Inc.
Contributed by Per Bothner, 1994-95.
Based on CCCP program by Paul Rubin, June 1986
Adapted to ANSI C, Richard Stallman, Jan 1987
@@ -593,7 +593,7 @@ cpp_read_main_file (cpp_reader *pfile, const char
}
pfile->main_file
-= _cpp_find_file (pfile, fname, &pfile->no_search_path, false, 0);
+= _cpp_find_file (pfile, fname, &pfile->no_search_path, false, 0, false);
if (_cpp_find_failed (pfile->main_file))
return NULL;
Index: libcpp/internal.h
===
--- libcpp/internal.h (revision 191711)
+++ libcpp/internal.h (working copy)
@@ -117,7 +117,7 @@ extern unsigned char *_cpp_unaligned_alloc (cpp_re
#define BUFF_LIMIT(BUFF) ((BUFF)->limit)
/* #include types. */
-enum include_type {IT_INCLUDE, IT_INCLUDE_NEXT, IT_IMPORT, IT_CMDLINE};
+enum include_type {IT_INCLUDE, IT_INCLUDE_NEXT, IT_IMPORT, IT_CMDLINE,
IT_DEFAULT};
union utoken
{
@@ -625,7 +625,7 @@ extern void _cpp_destroy_hashtable (cpp_reader *);
/* In files.c */
typedef struct _cpp_file _cpp_file;
extern _cpp_file *_cpp_find_file (cpp_reader *, const char *, cpp_dir *,
- bool, int);
+ bool, int, bool);
extern bool _cpp_find_failed (_cpp_file *);
extern void _cpp_mark_file_once_only (cpp_reader *, struct _cpp_file *);
extern void _cpp_fake_include (cpp_reader *, const char *);
--
Joseph S. Myers
jos...@codesourcery.com
nce at the revised specification was that
it was much improved, but some issues would probably still require further
work on the specification - and once those had been resolved, then a
detailed review of the patch would make sense.
--
Joseph S. Myers
jos...@codesourcery.com
so of copyrightable text in the
GCC interface code has an assignment on file with the FSF. But whatever
the arrangement is, it should be approved by the FSF.)
--
Joseph S. Myers
jos...@codesourcery.com
code in some other way that does not involve
splitting up those files so code can be shared?
--
Joseph S. Myers
jos...@codesourcery.com
in your
patch posting why you think it's the right way to refactor this code so it
can be shared.
--
Joseph S. Myers
jos...@codesourcery.com
an e.g. needing special handling in xm-mingw32.h
like is done for HOST_LONG_LONG_FORMAT).
--
Joseph S. Myers
jos...@codesourcery.com
Ping. This patch
<http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01907.html> (non-C parts) is
pending review.
--
Joseph S. Myers
jos...@codesourcery.com
.c's
internal datastructures for multilibs, as output by genmultilib, might
look like).
I am unconvinced that directly adding to the drivers' internal
datastructures like this is a sensible interface for specifying multilib
choice in target makefile fragments.
--
Joseph S. Myers
jos...@codesourcery.com
and i686-linux, ok for trunk?
The C front-end changes are OK.
--
Joseph S. Myers
jos...@codesourcery.com
ere is some autoconf configuration about whether to
include a header, it's generally preferred to keep down the number of
places with such a conditional on host features (encapsulating whatever
features the header provides in some way so that other code can use them
unconditionally).
--
Joseph S. Myers
jos...@codesourcery.com
fused with -gdwarf-2. I don't think such cryptic forms should be
encouraged.
> Wstrict-aliasing 2
Ambiguous with the existing -Wstrict-aliasing option followed by a linker
input file called 2.
--
Joseph S. Myers
jos...@codesourcery.com
ION_* for such bits.
I don't know if with C++ it's possible to keep the names the same *and*
ensure that compile time errors occur if bits from different variables are
used together or a bit is used with the wrong variable *and* avoid any
other issues occurring as a consequence of such changes.
--
Joseph S. Myers
jos...@codesourcery.com
Ping^2. This patch
<http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01907.html> (non-C parts) is
still pending review.
--
Joseph S. Myers
jos...@codesourcery.com
cks that return early for C (if needed).
--
Joseph S. Myers
jos...@codesourcery.com
Tested on x86_64-suse-linux, OK for mainline?
OK.
--
Joseph S. Myers
jos...@codesourcery.com
On Mon, 15 Oct 2012, Gary Funck wrote:
> On 10/15/12 17:06:28, Joseph S. Myers wrote:
> > On Mon, 15 Oct 2012, Gary Funck wrote:
> > > Various UPC language related checks and operations
> > > are called in the "C" front-end and middle-end.
> > &g
rangement to be an option to the C front end, I
expect you shouldn't need upc/Make-lang.in either.)
--
Joseph S. Myers
jos...@codesourcery.com
indentation also looks suspicious - look at
the @@ -8859,6 +9048,23 @@ declspecs_add_qual hunk, for example, where
inconsistent indentation reveals that you are indenting with spaces in
some places, except for one line using a TAB (all new lines should be
indented with TABs for every 8 spaces).
--
Joseph S. Myers
jos...@codesourcery.com
* Target changes, split out per target.
* Changes to existing C front-end files (including c-family).
* Changes to any other front ends, split out by front end.
* New front-end files.
* Changes to the language and target independent compiler (including build
system code).
* Library.
* Compil
.c (c_common_handle_option): Do not set them here. Add
> comment.
> (c_common_post_options): Likewise.
> testsuite/
> * gcc.dg/Wstrict-overflow-24.c: New.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
t-set-parameter): Use EnabledBy.
> (Wunused-parameter): Likewise.
> * opts.c (finish_options): Do not handle them explicitly.
> * opt-functions.awk (search_var_name): New.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
et_flags that refer to global
options to end up not being lvalues at all. That helps ensure that option
settings are only modified in limited places that have options pointers.
It would be nice eventually for such things as "optimize" and "target"
attributes to be able to swap options structures, and to work closer to
how options on the command line are processed - for that, you want careful
control on what places actually modify options at all.
--
Joseph S. Myers
jos...@codesourcery.com
options.
Given that existing practice is passing pointers around, I'd think that's
appropriate for any new such functions / macros, unless and until we have
some clear notion of when functionality should or should not be a member
function of gcc_options.
--
Joseph S. Myers
jos...@codesourcery.com
pilers without any need to
link in any stubs.
> The few additional tree nodes needed for UPC are defined
> in a language dependent tree definition file. The UPC-specific
Whatever those get gimplified to needs to be language-independent (that
is, handled after gimplification entirely by language-independent parts of
the compiler).
--
Joseph S. Myers
jos...@codesourcery.com
zers. But since the _set structures generally correspond to what
was set directly, whereas implicit setting by another option also replaces
the -1 value, this might only work given the extension of _set structures
to record the distance between the option passed by the user and the one
set, no
at=
should take an arbitrary integer level (of which at present all those
above 2 are equivalent to 2, just as -O for n > 3 is equivalent to
-O3).
--
Joseph S. Myers
jos...@codesourcery.com
an error with -Werror=return-local-addr. I've added
> two tests checking the -Werror form works.
The C front-end changes are OK.
--
Joseph S. Myers
jos...@codesourcery.com
later point is at
which you check for such errors - but in any case, you need testcases for
these diagnostics on those cases to show that they aren't being lost.
In invoke.texi you have:
+@opindex flag_enable_cilkplus
But @opindex is for the user-visible options, not for internal variables.
Ping^3. This patch
<http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01907.html> (non-C parts) is
still pending review.
--
Joseph S. Myers
jos...@codesourcery.com
ically or dynamically linked. This model is not fully implemented and
> +mostly treated as "small".
Say @samp{small} instead of using "" quotes in Texinfo sources.
--
Joseph S. Myers
jos...@codesourcery.com
On Tue, 23 Oct 2012, Manuel López-Ibáñez wrote:
> The problem is how to represent that Wformat-y2k is enabled by
> -Wformat=X with X >= 2, while Wformat-zero-length is enabled by X >=1.
>
> One possiblity is to allow to specify a condition directly:
I guess that's re
On Tue, 23 Oct 2012, Joern Rennecke wrote:
> + tm_file="dbxelf.h elfos.h linux.h ${tm_file}"
Should be using gnu-user.h linux.h glibc-stdint.h, not linux.h on its own.
--
Joseph S. Myers
jos...@codesourcery.com
ize limit is 400 kB, not 100 kB. Hopefully that means you don't need
to compress so many bits and can attach more as plain patches for future
revisions.
--
Joseph S. Myers
jos...@codesourcery.com
Diagnostics should not end with '.' (or '\n', in some cases here); also
avoid starting with a capital letter in cases such as "Operand".
--
Joseph S. Myers
jos...@codesourcery.com
Same diagnostic comment regarding one fatal_error call here; in addition,
diagnostic functions should not be called directly from .md files at all,
because .md files aren't processed by exgettext to extract messages for
translation.
--
Joseph S. Myers
jos...@codesourcery.com
If you need special t-* logit for fp-bit.c / dp-bit.c, rather than being
able to use t-fdpbit, then you need comments explaining why the special
logic rather than the generic code is used.
--
Joseph S. Myers
jos...@codesourcery.com
your ASM_SPEC and LINK_SPEC, such as
%{v}, %{version:-v}, %{b}, %{Wl,*:%*}., %{!dynamic-linker:...}. Remove
them.
--
Joseph S. Myers
jos...@codesourcery.com
t not int to measure that size. If you were measuring something
on the target, you might need HOST_WIDE_INT (for example, a compiler on a
32-bit host can reasonably build objects for a 64-bit target that declare
arrays with more than 2^31 elements, so size_t is not the right type to
use i
handled as
such, and include that header in the testcase; there are several existing
examples of this in gcc.dg.
--
Joseph S. Myers
jos...@codesourcery.com
On Tue, 30 Oct 2012, Tom Tromey wrote:
> This patch adds a @direntry for gcov.
>
> I noticed that it was missing today, when I tried to find the gcov
> manual from the info "dir" node. Then I found out that I had filed PR
> 50899 for this ages ago.
>
> Ok
should include the changes to
install.texi to document those options for people building GCC.
--
Joseph S. Myers
jos...@codesourcery.com
m glibc as well - strtod in particular has had major changes in
glibc since it was last updated.
--
Joseph S. Myers
jos...@codesourcery.com
l
still make sense for non-glibc or older-glibc systems, but hopefully the
implementations can be closer to the glibc versions then. And supporting
the various parts of the floating-point TS in glibc would be a lot of
work.)
--
Joseph S. Myers
jos...@codesourcery.com
test macros that are only properly effective if defined
before any system headers are included, and these macros (affecting such
things as the size of off_t) need to be consistent throughout GCC.
--
Joseph S. Myers
jos...@codesourcery.com
development version in public
version control, as well as snapshots and non-FSF releases. The effect is
that if the first copyright year in a GCC source file is 1987 or later, a
single range -2013 can be used.
--
Joseph S. Myers
jos...@codesourcery.com
something opened with
open_memstream, while a larger cleanup would narrow the interface to
writing such text as far as possible (to well-defined diagnostic and
dumping interfaces that don't directly take a FILE *, eliminating all ad
hoc calls to fprintf etc.).
--
Joseph S. Myers
jos...@codesourcery.com
ion of float to long double is trivially equivalent to a conversion
involving an intermediate "double" type, so it reduces to a case for which
the standard formula involving precisions of just two types applies.)
--
Joseph S. Myers
jos...@codesourcery.com
mbler in some
cases (e.g. for large blocks of debug info) rather than generating and
then parsing text. (So some asm_out methods would gain implementations
passing such data instead of generating text.)
--
Joseph S. Myers
jos...@codesourcery.com
should be submitted separately, as cleanups that can
be proposed on their own merits.
Note that casts use spaces, "(type) expr", as detailed at
<http://gcc.gnu.org/codingconventions.html#C_Formatting>.
--
Joseph S. Myers
jos...@codesourcery.com
Also note that this patch needs to add testcases to the testsuite
(gcc/testsuite/c-c++-common/, probably) testing what cases generate
warnings with the new option and what cases don't.
--
Joseph S. Myers
jos...@codesourcery.com
particularly useful
at the stage where it just means PIC rather than actual shared libraries).
--
Joseph S. Myers
jos...@codesourcery.com
My only comment is that you change the parameters to
c_parser_binary_expression, but don't change the comment above that
function documenting what they are.
--
Joseph S. Myers
jos...@codesourcery.com
len" which sounds like
implementation terminology; this is the user manual and needs to describe
things in user terms, not in terms of the implementation.
--
Joseph S. Myers
jos...@codesourcery.com
1 - 100 of 1676 matches
Mail list logo
