Re: [PATCH, Pointer Bounds Checker 27/x] Strlen

2014-06-11 Thread Ilya Enkovich
2014-06-11 12:55 GMT+04:00 Jakub Jelinek : > On Wed, Jun 11, 2014 at 12:44:29PM +0400, Ilya Enkovich wrote: >> 2014-06-11 12:22 GMT+04:00 Jakub Jelinek : >> > On Wed, Jun 11, 2014 at 12:14:14PM +0400, Ilya Enkovich wrote: >> >> This patch adds instrumented code s

Re: [PATCH, Pointer Bounds Checker 27/x] Strlen

2014-06-11 Thread Ilya Enkovich
2014-06-11 13:00 GMT+04:00 Marek Polacek : > On Wed, Jun 11, 2014 at 12:14:14PM +0400, Ilya Enkovich wrote: >> This patch adds instrumented code support for strlen optimization. >> >> Bootstrapped and tested on linux-x86_64. >> >> Does it look OK? > > I have

Re: [PATCH, Pointer Bounds Checker 28/x] IPA CP

2014-06-11 Thread Ilya Enkovich
2014-06-11 13:45 GMT+04:00 Martin Jambor : > Hi, > > On Wed, Jun 11, 2014 at 12:24:57PM +0400, Ilya Enkovich wrote: >> Hi, >> >> This patch fixes IPA CP pass to handle instrumented code correctly. >> >> Bootstrapped and tested on linux-x86_64. >> >

Re: [PATCH, Pointer Bounds Checker 28/x] IPA CP

2014-06-11 Thread Ilya Enkovich
On 11 Jun 15:07, Ilya Enkovich wrote: > 2014-06-11 13:45 GMT+04:00 Martin Jambor : > > Hi, > > > > On Wed, Jun 11, 2014 at 12:24:57PM +0400, Ilya Enkovich wrote: > >> Hi, > >> > >> This patch fixes IPA CP pass to handle instrumented code correctly. &

[PATCH, i386, Pointer Bounds Checker 32/x] Pointer Bounds Checker hooks for i386 target

2014-06-11 Thread Ilya Enkovich
Hi, This patch adds i386 target hooks for Pointer Bounds Checker. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-06-11 Ilya Enkovich * config/i386/i386.c: Include tree-iterator.h. (ix86_function_value_bounds): New. (ix86_builtin_mpx_function

[PATCH, i386, Pointer Bounds Checker 33/x] MPX ABI

2014-06-11 Thread Ilya Enkovich
Hi, This patch adds MPX ABI support for i386 target. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-06-11 Ilya Enkovich * config/i386/i386.c (ix86_option_override_internal): Do not support x32 with MPX. is not available

[PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-06-11 Thread Ilya Enkovich
Hi, This patch adds i386 target builtins for Pointer Bounds Checker. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-06-11 Ilya Enkovich * config/i386/i386-builtin-types.def (BND): New. (ULONG): New. (BND_FTYPE_PCVOID_ULONG): New

[PATCH, i386, Pointer Bounds Checker 34/x] Vararg functions support

2014-06-11 Thread Ilya Enkovich
Hi, This patch introduces initialization of incoming bounds for vararg function on i386 target. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-06-11 Ilya Enkovich * config/i386/i386.c (ix86_setup_incoming_varargs): New. (ix86_va_start): Initialize

[PATCH, Pointer Bounds Checker 35/x] Fix object size emitted for structures with flexible arrays

2014-06-11 Thread Ilya Enkovich
false bounds violations. Following patch uses DECL_SIZE_UNIT instead of type size and works well for me. Does it look OK? Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-06-11 Ilya Enkovich * config/elfos.h (ASM_DECLARE_OBJECT_NAME): Use decl size

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-11 Thread Ilya Enkovich
On 11 Jun 14:59, Uros Bizjak wrote: > On Tue, Jun 10, 2014 at 3:45 PM, Dominique Dhumieres > wrote: > >> This patch fixes PR61446. ... > > > > Confirmed, it also allows to bootstrap Core* targets. > > Could it be reviewed and committed ASAP? > > > 20

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-11 Thread Ilya Enkovich
sion. Ilya -- gcc/ 2014-06-11 Ilya Enkovich PR 61446 * ree.c (find_and_remove_re): Narrow mode for register copy if required. gcc/testsuite/ 2014-06-11 Ilya Enkovich * gcc.target/i386/pr61446.c : New. diff --git a/gcc/ree.c b/gcc/ree.c index ade413e..6d3

Re: [PATCH, Pointer Bounds Checker 35/x] Fix object size emitted for structures with flexible arrays

2014-06-12 Thread Ilya Enkovich
2014-06-12 11:55 GMT+04:00 Richard Biener : > On Wed, Jun 11, 2014 at 6:08 PM, Ilya Enkovich wrote: >> Hi, >> >> This patch fixes problem with size emitted for static structures with >> flexible array. I found a couple of trackers in guzilla for this problem >&

Re: [PATCH, Pointer Bounds Checker 35/x] Fix object size emitted for structures with flexible arrays

2014-06-16 Thread Ilya Enkovich
2014-06-13 19:40 GMT+04:00 Jeff Law : > On 06/12/14 17:38, Ilya Enkovich wrote: >>> >>> It looks ok to me - did you test with all languages? In particular did >>> you test Ada? >> >> >> I configure compiler with no language disabling and then r

Re: [PATCH, Pointer Bounds Checker 3/x] Target hooks for Pointer Bounds Checker

2014-06-27 Thread Ilya Enkovich
Ping 2014-05-06 16:11 GMT+04:00 Ilya Enkovich : > PING > > 2014-04-16 15:52 GMT+04:00 Ilya Enkovich : >> Hi, >> >> This patch introduces target hooks to be used by Pointer Bounds Checker. >> Hooks set is different from what was approved for 4.9 (and later reve

Re: [PATCH, Pointer Bounds Checker 4/x] Built-in functions

2014-06-27 Thread Ilya Enkovich
Ping 2014-05-06 16:11 GMT+04:00 Ilya Enkovich : > PING > > 2014-04-16 16:19 GMT+04:00 Ilya Enkovich : >> Hi, >> >> This patch introduces built-in functions used by Pointer Bounds Checker. It >> is mostly similar to what was reverted from 4.9, I just added typ

Re: [PATCH, Pointer Bounds Checker 9/x] Cgraph extension

2014-06-27 Thread Ilya Enkovich
Ping 2014-05-06 16:13 GMT+04:00 Ilya Enkovich : > Ping > > 2014-04-16 18:03 GMT+04:00 Ilya Enkovich : >> Hi, >> >> This patch introduces changes in call graph for Pointer Bounds Checker. >> >> New fields instrumented_version, instrumentation_clone and

[PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-07-02 Thread Ilya Enkovich
% Bootstrapped and tested on linux-x86_64. Does it look OK for trunk? Thanks, Ilya -- gcc/ 2014-07-02 Ilya Enkovich * config/i386/constraints.md (Yr): New. * config/i386/i386.h (reg_class): Add NO_REX_SSE_REGS. (REG_CLASS_NAMES): Likewise. (REG_CLASS_CONTENTS

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-07-03 Thread Ilya Enkovich
nificant >> gains caused by >> this patch (tested on Avoton on -O3). > >> 2014-07-02 Ilya Enkovich > >> * config/i386/constraints.md (Yr): New. >> * config/i386/i386.h (reg_class): Add NO_REX_SSE_REGS. >> (REG_CLASS_NAMES): Likewise. >> (REG_

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-07-03 Thread Ilya Enkovich
2014-07-02 20:21 GMT+04:00 Andi Kleen : > Ilya Enkovich writes: > >> Silvermont processors have penalty for instructions having 4+ bytes of >> prefixes (including escape bytes in opcode). This situation happens >> when REX prefix is used in SSE4 instructions. This patc

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-07-03 Thread Ilya Enkovich
2014-07-02 20:27 GMT+04:00 Jakub Jelinek : > On Wed, Jul 02, 2014 at 09:21:25AM -0700, Andi Kleen wrote: >> Ilya Enkovich writes: >> >> > Silvermont processors have penalty for instructions having 4+ bytes of >> > prefixes (including escape bytes in opcode). Thi

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-07-03 Thread Ilya Enkovich
2014-07-03 14:56 GMT+04:00 Jakub Jelinek : > On Thu, Jul 03, 2014 at 02:49:10PM +0400, Ilya Enkovich wrote: >> 2014-07-02 20:21 GMT+04:00 Andi Kleen : >> > Ilya Enkovich writes: >> > >> >> Silvermont processors have penalty for instructions having 4+ by

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-07-03 Thread Ilya Enkovich
2014-07-03 15:11 GMT+04:00 Uros Bizjak : > On Thu, Jul 3, 2014 at 12:45 PM, Ilya Enkovich wrote: > >>>> Silvermont processors have penalty for instructions having 4+ bytes of >>>> prefixes (including escape >>>> bytes in opcode). This situati

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-07-03 Thread Ilya Enkovich
2014-07-03 16:07 GMT+04:00 Uros Bizjak : > On Thu, Jul 3, 2014 at 1:50 PM, Ilya Enkovich wrote: > >> I didn't find a nice way to fix peephole2 patterns to take register >> constraints into account. Is there any way to do it? > > Use REX_SSE_REGNO_P (REGNO (operands[..

[PATCH, i386, PR target/66048] Fix mode switching ICE for functions returning bounds

2015-05-12 Thread Ilya Enkovich
, Ilya -- gcc/ 2015-05-12 Ilya Enkovich * function.c (diddle_return_value_1): Process bounds first. * config/i38/i386.c (ix86_function_value_regno_p): Add bnd1 register. gcc/testsuite/ 2015-05-12 Ilya Enkovich * gcc.target/i386/mpx/pr66048.cc: New. diff

[PATCH, CHKP] Hardcode wrapper names

2015-05-12 Thread Ilya Enkovich
hanks, Ilya -- gcc/ 2015-05-12 Ilya Enkovich * ipa-chkp.h (chkp_wrap_function): New. * ipa-chkp.c (chkp_wrap_function): Remove 'static'. (chkp_wrap_function_name): New. (chkp_build_instrumented_fndecl): Use chkp_wrap_function_name to g

Re: [PATCH, PR target/65103, 3/3] Change rtx cost for i386 address constants

2015-05-12 Thread Ilya Enkovich
Ping 2015-03-10 19:14 GMT+03:00 Ilya Enkovich : > On 10 Mar 18:11, Ilya Enkovich wrote: >> Hi, >> >> This patch changes rtx cost for address constants to 0 similar to what we >> have in address cost hook beacuse we expect them to be propagated into >> address

Re: [PATCH, PR target/65103, 3/3] Change rtx cost for i386 address constants

2015-05-13 Thread Ilya Enkovich
On 12 May 17:33, Uros Bizjak wrote: > Hello! > > >> 2015-03-10 Ilya Enkovich > >> > >> PR target/65103 > >> * config/i386/i386.c (ix86_rtx_costs): We want to propagate > >> link time constants into adress express

[PATCH, PR middle-end/66134] Fix coalescing for bounds used in abnormal phi

2015-05-15 Thread Ilya Enkovich
Hi, This patch fixes misuse of abnormal bounds copy to avoid coalescing issue. Bootstrapped and regtested for x86_64-unknown-linux-gnu. Applied to trunk. Is it OK for gcc-5? Thanks, Ilya -- gcc/ 2015-05-15 Ilya Enkovich PR middle-end/66134 * tree-chkp.c

Re: [PATCH, PR middle-end/66134] Fix coalescing for bounds used in abnormal phi

2015-05-18 Thread Ilya Enkovich
2015-05-18 12:48 GMT+03:00 Richard Biener : > On Fri, May 15, 2015 at 11:43 AM, Ilya Enkovich > wrote: >> Hi, >> >> This patch fixes misuse of abnormal bounds copy to avoid coalescing issue. >> Bootstrapped and regtested for x86_64-unknown-linux-gnu. Applied to

Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-05-19 Thread Ilya Enkovich
Ping 2015-05-05 11:05 GMT+03:00 Ilya Enkovich : > Ping > > 2015-04-14 17:35 GMT+03:00 Ilya Enkovich : >> On 10 Apr 03:27, Jan Hubicka wrote: >>> > >>> > + /* We might propagate instrumented function pointer into >>> > + not instrumented func

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-05-19 Thread Ilya Enkovich
Ping 2015-05-05 11:06 GMT+03:00 Ilya Enkovich : > Ping > > 2015-04-14 12:14 GMT+03:00 Ilya Enkovich : >> On 10 Apr 03:15, Jan Hubicka wrote: >>> > >>> > References are not streamed out for nodes which are referenced in a >>> > partition but don&

[PATCH, CHKP] Clean-up redundant gimple_build_nop calls

2015-05-20 Thread Ilya Enkovich
Hi, This patch removes redundant gimple_build_nop calls from tree-chkp.c. MPX-bootstrapped and regtested for x86_64-unknown-linux-gnu. Applied to trunk. Thanks, Ilya -- 2015-05-20 Ilya Enkovich * tree-chkp.c (chkp_maybe_copy_and_register_bounds): Remove useless

[PATCH, CHKP] Fix PR middle-end/66221: lto1: error: type variant has different TYPE_ARG_TYPES

2015-05-21 Thread Ilya Enkovich
Hi, This patch fixes PR66221 by using build_distinct_type_copy instead of copy_node to copy a function type for instrumented function. Bootstrapped and regtested for x86_64-unknown-linux-gnu. Applied to trunk. Is it OK for gcc-5? Thanks, Ilya -- gcc/ 2015-05-21 Ilya Enkovich PR

Re: [PATCH, PR target/65103, 2/3] Propagate address constants into loops for i386

2015-05-21 Thread Ilya Enkovich
Ping 2015-05-05 14:05 GMT+03:00 Ilya Enkovich : > 2015-04-21 8:52 GMT+03:00 Jeff Law : >> On 04/17/2015 02:34 AM, Ilya Enkovich wrote: >>> >>> On 15 Apr 14:07, Ilya Enkovich wrote: >>>> >>>> 2015-04-14 8:22 GMT+03:00 Jeff Law : >>

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-05-26 Thread Ilya Enkovich
On 06 Apr 09:28, Jeff Law wrote: > On 04/06/2015 09:17 AM, Ilya Enkovich wrote: > >> > >>To tell the truth, I can't figure out what this means from a user > >>perspective. How does a user know whether the linker option is > >>being ignored, or if t

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-05-26 Thread Ilya Enkovich
Ping 2015-05-19 12:40 GMT+03:00 Ilya Enkovich : > Ping > > 2015-05-05 11:06 GMT+03:00 Ilya Enkovich : >> Ping >> >> 2015-04-14 12:14 GMT+03:00 Ilya Enkovich : >>> On 10 Apr 03:15, Jan Hubicka wrote: >>>> > >>>> > References are not

Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-05-26 Thread Ilya Enkovich
Ping 2015-05-19 12:39 GMT+03:00 Ilya Enkovich : > Ping > > 2015-05-05 11:05 GMT+03:00 Ilya Enkovich : >> Ping >> >> 2015-04-14 17:35 GMT+03:00 Ilya Enkovich : >>> On 10 Apr 03:27, Jan Hubicka wrote: >>>> > >>>> > + /* We m

Re: [PATCH, PR target/65103, 2/3] Propagate address constants into loops for i386

2015-06-01 Thread Ilya Enkovich
2015-05-29 1:15 GMT+03:00 Jeff Law : > > Right, but you're blindly propagating. The right thing to do is look at > some kind of metric to estimate when it's profitable to propagate the > constant back in vs leave it hoisted out. No, the patch is not to blindly propagate but to let loop invariant

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-06-03 Thread Ilya Enkovich
2015-05-27 18:19 GMT+03:00 Jeff Law : > On 05/26/2015 03:13 AM, Ilya Enkovich wrote: >> >> On 06 Apr 09:28, Jeff Law wrote: >>> >>> On 04/06/2015 09:17 AM, Ilya Enkovich wrote: >>>>> >>>>> >>>>> To tell the truth, I ca

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-06-03 Thread Ilya Enkovich
2015-06-03 18:25 GMT+03:00 Joseph Myers : > On Wed, 3 Jun 2015, Ilya Enkovich wrote: > >> Spec files are not scanned by translator. I tried to split this spec >> into two parts to move message into a header file but with no success. >> Any ideas how it can be done? > >

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-06-04 Thread Ilya Enkovich
2015-06-03 18:59 GMT+03:00 Joseph Myers : > You could, for example, have > > #if SOMETHING > #define MSG "%nsome msg" > #else > #define MSG "" > #endif > > and have another spec using MSG - that should work. In this case I should define SOMETHING in configure of gcc, not in configure of libmpx, ri

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-06-05 Thread Ilya Enkovich
On 04 Jun 15:53, Joseph Myers wrote: > On Thu, 4 Jun 2015, Ilya Enkovich wrote: > > > 2015-06-03 18:59 GMT+03:00 Joseph Myers : > > > You could, for example, have > > > > > > #if SOMETHING > > > #define MSG "%nsome msg" > > > #

Re: [PATCH, PR target/65103, 2/3] Propagate address constants into loops for i386

2015-04-17 Thread Ilya Enkovich
On 15 Apr 14:07, Ilya Enkovich wrote: > 2015-04-14 8:22 GMT+03:00 Jeff Law : > > On 03/15/2015 02:30 PM, Richard Sandiford wrote: > >> > >> Ilya Enkovich writes: > >>> > >>> This patch allows propagation of loop invariants for i386 if propaga

[PATCH, CHKP] Don't require IPA_REF_CHKP reference for nodes other than instrumentation thunks

2015-04-17 Thread Ilya Enkovich
gnu. Will apply to trunk and later to gcc_5 if no objections appear. Thanks, Ilya -- gcc/ 2015-04-16 Ilya Enkovich * cgraph.c (cgraph_node::verify_node): Require IPA_CHKP_REF for instrumentation thunks only. gcc/testsuite/ 2015-04-16 Ilya Enkovich * gcc.target/i38

Fwd: [PATCH, CHKP] Don't require IPA_REF_CHKP reference for nodes other than instrumentation thunks

2015-04-17 Thread Ilya Enkovich
y to trunk and later to gcc_5 if no objections appear. Thanks, Ilya -- gcc/ 2015-04-16 Ilya Enkovich * cgraph.c (cgraph_node::verify_node): Require IPA_CHKP_REF for instrumentation thunks only. gcc/testsuite/ 2015-04-16 Ilya Enkovich * gcc.target/i386/mpx/chkp-ref

Re: [PATCH] libmpx: remove AC_PROG_CXX/GCC_LIBSTDCXX_RAW_CXX_FLAGS from configure.ac

2015-04-27 Thread Ilya Enkovich
2015-04-23 12:53 GMT+03:00 Steven Noonan : > This causes libmpx to fail the configure stage on my build hosts because > 'xg++' > was invoked with the bogus '-funconfigured-libstdc++-v3' flag, and the > fallback > preprocessor '/lib/cpp' did not exist on my systems. > > Since libmpx has no C++ cod

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-05-05 Thread Ilya Enkovich
Ping 2015-04-14 12:14 GMT+03:00 Ilya Enkovich : > On 10 Apr 03:15, Jan Hubicka wrote: >> > >> > References are not streamed out for nodes which are referenced in a >> > partition but don't belong to it ('continue' condition in output_refs >>

Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-05-05 Thread Ilya Enkovich
Ping 2015-04-14 17:35 GMT+03:00 Ilya Enkovich : > On 10 Apr 03:27, Jan Hubicka wrote: >> > >> > + /* We might propagate instrumented function pointer into >> > + not instrumented function and vice versa. In such a >> > + case we nee

Re: [PATCH, PR target/65103, 2/3] Propagate address constants into loops for i386

2015-05-05 Thread Ilya Enkovich
2015-04-21 8:52 GMT+03:00 Jeff Law : > On 04/17/2015 02:34 AM, Ilya Enkovich wrote: >> >> On 15 Apr 14:07, Ilya Enkovich wrote: >>> >>> 2015-04-14 8:22 GMT+03:00 Jeff Law : >>>> >>>> On 03/15/2015 02:30 PM, Richard Sandiford wrote: >>&

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-13 Thread Ilya Enkovich
2014-11-13 2:03 GMT+03:00 Joseph Myers : > On Thu, 13 Nov 2014, Ilya Enkovich wrote: > >> It's hard to decide which of runtime functionality should be >> considered as basic and how it should be used. We may say that the >> only basic thing is hardware enabling

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 2/5] Instrument builtin calls

2014-11-14 Thread Ilya Enkovich
2014-11-14 9:49 GMT+03:00 Jeff Law : > On 11/06/14 05:10, Ilya Enkovich wrote: >> >> Hi, >> >> This patch enables instrumentation of chosen builtin calls. >> >> Thanks, >> Ilya >> -- >> 2014-11-06 Ilya Enkovich >> >

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 1/5] Builtin codes and decls

2014-11-14 Thread Ilya Enkovich
2014-11-14 9:43 GMT+03:00 Jeff Law : > On 11/06/14 04:48, Ilya Enkovich wrote: >> >> -- >> 2014-11-06 Ilya Enkovich >> >> * tree-core.h (built_in_class): Add builtin codes to be used >> by Pointer Bounds Checker for instrumented builtin fun

[PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-11-14 Thread Ilya Enkovich
Enkovich * gcc.c (MPX_SPEC): Add wrappers library. libmpx/ 2014-11-14 Ilya Enkovich * Makefile.am (SUBDIRS): New. (MAKEOVERRIDES): New. * Makefile.in: Regenerate. * configure.ac: Add mpxintr/Makefile to config files. * configure

[PATCH, MPX wrappers 2/3] Replace some function calls with wrapper calls during instrumentation

2014-11-14 Thread Ilya Enkovich
Hi, This patch adds wrapper calls. It's simply achieved by using proper name for builtin clones. Patches apply over builtins instrumentation series. Thanks, Ilya -- 2014-11-14 Ilya Enkovich * c-family/c.opt (fchkp-use-wrappers): New. * ipa-c

[PATCH, MPX wrappers 3/3] Tests

2014-11-14 Thread Ilya Enkovich
Hi, Here are few tests for MPX wrappers. Will add more in case patches #1,2 are OK. Thanks, Ilya -- 2014-11-14 Ilya Enkovich * lib/mpx-dg.exp (mpx_link_flags): Set path to wrappers library. * gcc.target/i386/mpx/calloc-1-lbv.c: New. * gcc.target/i386/mpx/calloc-1

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 1/5] Builtin codes and decls

2014-11-17 Thread Ilya Enkovich
On 15 Nov 00:03, Jeff Law wrote: > On 11/14/14 01:22, Ilya Enkovich wrote: > > > >I don't think I'm hiding some problem here. Builtin function calls > >may be removed during various optimizations. Therefore we may remove > >all calls to some instrumented b

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 2/5] Instrument builtin calls

2014-11-17 Thread Ilya Enkovich
On 14 Nov 23:58, Jeff Law wrote: > On 11/14/14 01:06, Ilya Enkovich wrote: > > >>>- /* Avoid instrumented builtin functions for now. Due to IPA > >>>- it also means we have to avoid instrumentation of indirect > >>>- calls. */ > &g

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 5/5] Support instrumented calls in strlen pass

2014-11-17 Thread Ilya Enkovich
On 14 Nov 23:40, Jeff Law wrote: > On 11/06/14 05:39, Ilya Enkovich wrote: > >Hi, > > > >This patch adds support of instrumented function calls into strlen pass. > > > >Whole series pass bootstrap and check on linux-x86_64. OK for trunk? > > > >Th

Re: [BUILDROBOT] Build breakage in builtin.c (was: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls)

2014-11-17 Thread Ilya Enkovich
On 17 Nov 16:12, Jan-Benedict Glaw wrote: > On Mon, 2014-11-17 15:59:41 +0100, Markus Trippelsdorf > wrote: > > On 2014.11.17 at 15:52 +0100, Jan-Benedict Glaw wrote: > > > On Thu, 2014-11-06 15:24:59 +0300, Ilya Enkovich > > > wrote: > [...] > > > It

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls

2014-11-17 Thread Ilya Enkovich
2014-11-17 21:22 GMT+03:00 David Edelsohn : > Ilya, > > Thanks for fixing the reference to BNDmode. > > However, the patch causes another problem that breaks bootstrap on > AIX. All of the builtins are emitted as an enum in debug information > and the CHKP enums now cause an overflow in the debug

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls

2014-11-17 Thread Ilya Enkovich
2014-11-17 21:41 GMT+03:00 Jeff Law : > On 11/17/14 11:22, David Edelsohn wrote: >> >> However, the patch causes another problem that breaks bootstrap on >> AIX. All of the builtins are emitted as an enum in debug information >> and the CHKP enums now cause an overflow in the debug data on AIX. >>

Re: [PATCH] Fix for PR63766 (handle removed functions in do_per_function_toporder)

2014-11-17 Thread Ilya Enkovich
On 17 Nov 13:32, Richard Biener wrote: > On Mon, Nov 10, 2014 at 4:48 PM, Ilya Enkovich wrote: > > Hi, > > > > Here is a fix for PR63766. Currently all functions are transformed into > > SSA before local optimizations and it allows function to be inlined and > &g

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls

2014-11-18 Thread Ilya Enkovich
2014-11-18 5:56 GMT+03:00 Jeff Law : > On 11/17/14 13:43, Ilya Enkovich wrote: > >> >> I don't fully understand how this problem appears. Is it fully AIX >> specific and doesn't affect any other target? May we put all _CHKP >> codes to the end of enum an

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls

2014-11-18 Thread Ilya Enkovich
2014-11-18 15:04 GMT+03:00 Richard Biener : > On Tue, Nov 18, 2014 at 11:51 AM, Ilya Enkovich > wrote: >> 2014-11-18 5:56 GMT+03:00 Jeff Law : >>> On 11/17/14 13:43, Ilya Enkovich wrote: >>> >>>> >>>> I don't fully understand how this

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls

2014-11-18 Thread Ilya Enkovich
2014-11-18 15:18 GMT+03:00 Richard Biener : > On Tue, Nov 18, 2014 at 1:13 PM, Ilya Enkovich wrote: >> 2014-11-18 15:04 GMT+03:00 Richard Biener : >>> On Tue, Nov 18, 2014 at 11:51 AM, Ilya Enkovich >>> wrote: >>>> 2014-11-18 5:56 GMT+03:00 Jeff Law :

Re: [PATCH, MPX wrappers 2/3] Replace some function calls with wrapper calls during instrumentation

2014-11-18 Thread Ilya Enkovich
On 15 Nov 00:16, Jeff Law wrote: > On 11/14/14 10:29, Ilya Enkovich wrote: > >Hi, > > > >This patch adds wrapper calls. It's simply achieved by using proper name > >for builtin clones. Patches apply over builtins instrumentation series. > > > >Thanks

Re: [PATCH, MPX wrappers 2/3] Replace some function calls with wrapper calls during instrumentation

2014-11-18 Thread Ilya Enkovich
On 18 Nov 16:23, Joseph Myers wrote: > On Tue, 18 Nov 2014, Ilya Enkovich wrote: > > > +@item -fcheck-pointer-bounds > > +@opindex fcheck-pointer-bounds > > +@opindex fno-check-pointer-bounds > > +Enable Pointer Bounds Checker instrumentation. Each memory refer

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-11-18 Thread Ilya Enkovich
On 15 Nov 00:10, Jeff Law wrote: > On 11/14/14 10:26, Ilya Enkovich wrote: > >Hi, > > > >This patch introduces a simple library with several wrappers to be used with > >MPX and Pointer Bounds Checker. Wrappers allow to obtain, copy and just > >keep alive bounds

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-19 Thread Ilya Enkovich
On 13 Nov 20:56, Joseph Myers wrote: > On Thu, 13 Nov 2014, Ilya Enkovich wrote: > > > > You can leave it as a single library - it's just that imposes libgcc-like > > > constraints on what the library does and how it does things, so as to be > > > usable for

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-19 Thread Ilya Enkovich
2014-11-19 20:55 GMT+03:00 Jeff Law : > On 11/19/14 07:15, Ilya Enkovich wrote: > >> -- >> 2014-11-19 Ilya Enkovich >> >> * Makefile.def: Add libmpx. >> * configure.ac: Add libmpx. >> * Makefile.in: Regenerate. >> *

[PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-20 Thread Ilya Enkovich
Ilya -- gcc/ 2014-11-20 Ilya Enkovich * config/i386/cpuid.h (bit_MPX): New. (bit_BNDREGS): New. (bit_BNDCSR): New. * config/i386/i386.c (processor_features): Add F_XSAVE, F_OSXSAVE, F_MPX, F_BNDREGS, F_BNDCSR. (isa_names_table): Likewise.

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-21 Thread Ilya Enkovich
On 19 Nov 21:11, Ilya Enkovich wrote: > 2014-11-19 20:55 GMT+03:00 Jeff Law : > > On 11/19/14 07:15, Ilya Enkovich wrote: > > > >> -- > >> 2014-11-19 Ilya Enkovich > >> > >> * Makefile.def: Add libmpx. > >> * conf

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-11-21 Thread Ilya Enkovich
On 18 Nov 14:15, Jeff Law wrote: > On 11/18/14 09:48, Ilya Enkovich wrote: > >On 15 Nov 00:10, Jeff Law wrote: > >>On 11/14/14 10:26, Ilya Enkovich wrote: > >>>Hi, > >>> > >>>This patch introduces a simple library with several wrapper

Re: [PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-21 Thread Ilya Enkovich
2014-11-21 20:45 GMT+03:00 Jeff Law : > On 11/20/14 09:40, Jakub Jelinek wrote: >> >> On Thu, Nov 20, 2014 at 07:36:03PM +0300, Ilya Enkovich wrote: >>> >>> Hi, >>> >>> MPX runtime checks some feature bits in order to check MPX is fully >>&g

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-24 Thread Ilya Enkovich
On 21 Nov 23:20, Joseph Myers wrote: > On Fri, 21 Nov 2014, Ilya Enkovich wrote: > > > +# Disable libmpx on unsupported systems. > > +if test -d ${srcdir}/libmpx; then > > +if test x$enable_libmpx = x; then > > + AC_MSG_CHECKING([for libmpx support]) &

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-11-24 Thread Ilya Enkovich
On 21 Nov 23:32, Joseph Myers wrote: > On Fri, 21 Nov 2014, Ilya Enkovich wrote: > > > * c-family/c.opt (static-libmpxwrappers): New. > > New options need documenting in invoke.texi. This includes driver > options. > I'll include it into patch with all check

Re: [PATCH, MPX wrappers 2/3] Replace some function calls with wrapper calls during instrumentation

2014-11-24 Thread Ilya Enkovich
On 18 Nov 19:42, Ilya Enkovich wrote: > On 18 Nov 16:23, Joseph Myers wrote: > > On Tue, 18 Nov 2014, Ilya Enkovich wrote: > > > > > +@item -fcheck-pointer-bounds > > > +@opindex fcheck-pointer-bounds > > > +@opindex fno-check-pointer-bounds > >

[PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-25 Thread Ilya Enkovich
Hi, This patch partly fixes PR bootstrap/63995 by avoiding duplicating static bounds vars. With this fix bootstrap still fails at stage 2 and 3 comparison. Bootstrapped and checked on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2014-11-25 Ilya Enkovich PR

[PATCH, PR64056, i386] Fix chkp tests requiring mempcpy

2014-11-25 Thread Ilya Enkovich
Hi, This patch adds check for mempcpy availability for tests requiring it. Checked with RUNTESTFLAGS="--target_board='unix{-m32,}' i386.exp=chkp-*". OK for trunk? Thanks, Ilya -- 2014-11-25 Ilya Enkovich PR target/64056 * gcc.target/i386/chkp-strlen-4.c

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-25 Thread Ilya Enkovich
2014-11-25 12:43 GMT+03:00 Richard Biener : > On Tue, Nov 25, 2014 at 9:45 AM, Ilya Enkovich wrote: >> Hi, >> >> This patch partly fixes PR bootstrap/63995 by avoiding duplicating static >> bounds vars. With this fix bootstrap still fails at stage 2 and 3 >> c

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-25 Thread Ilya Enkovich
2014-11-25 14:11 GMT+03:00 Richard Biener : > On Tue, Nov 25, 2014 at 11:19 AM, Ilya Enkovich > wrote: >> 2014-11-25 12:43 GMT+03:00 Richard Biener : >>> On Tue, Nov 25, 2014 at 9:45 AM, Ilya Enkovich >>> wrote: >>>> Hi, >>>> >&

[PATCH] Fix PR lto/64075

2014-11-26 Thread Ilya Enkovich
Hi, This patch fixes LTO streamers which were not adjusted when function_code field was extended up to 12 bits. OK for trunk after bootstrap and check? Thanks, Ilya -- gcc/ 2014-11-26 Ilya Enkovich * tree-streamer-in.c (unpack_ts_function_decl_value_fields): Use proper

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-26 Thread Ilya Enkovich
On 25 Nov 15:03, Ilya Enkovich wrote: > 2014-11-25 14:11 GMT+03:00 Richard Biener : > > On Tue, Nov 25, 2014 at 11:19 AM, Ilya Enkovich > > wrote: > > > > Ok, then it's get_for_asmname (). That said - the above loops look > > bogus to me. Honza -

[PATCH] Fix PR bootstrap/63995

2014-11-26 Thread Ilya Enkovich
Hi, This patch makes optimization for bounds lifetime reduction to ignore debug stetments. This fixes stage2 and stage3 comparision for instrumented boostrap. OK for trunk? Thanks, Ilya -- 2014-11-26 Ilya Enkovich PR bootstrap/63995 * tree-chkp-opt.c

Re: [PATCH] Fix PR bootstrap/63995

2014-11-26 Thread Ilya Enkovich
On 26 Nov 13:46, Jakub Jelinek wrote: > On Wed, Nov 26, 2014 at 03:41:46PM +0300, Ilya Enkovich wrote: > > Hi, > > > > This patch makes optimization for bounds lifetime reduction to ignore > > debug stetments. This fixes stage2 and stage3 comparision for > > ins

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-26 Thread Ilya Enkovich
2014-11-26 19:07 GMT+03:00 Jan Hubicka : >> On 25 Nov 15:03, Ilya Enkovich wrote: >> > 2014-11-25 14:11 GMT+03:00 Richard Biener : >> > > On Tue, Nov 25, 2014 at 11:19 AM, Ilya Enkovich >> > > wrote: >> > > >> > > Ok, then it'

Re: [PATCH] Fix PR lto/64075

2014-11-27 Thread Ilya Enkovich
2014-11-27 19:55 GMT+03:00 Mike Stump : > On Nov 26, 2014, at 1:35 AM, Ilya Enkovich wrote: >> This patch fixes LTO streamers which were not adjusted when function_code >> field was extended up to 12 bits. >> >> OK for trunk after bootstrap and check? > > Please

[PATCH] Fix PR target/64055

2014-12-01 Thread Ilya Enkovich
Hi, This patch fixes ICE in chkp_find_bound_slots_1 by checking for non constant values in array domain. Bootstrapped on x86_64-unknown-linux-gnu with Ada. gnat.dg/derived_aggregate.adb is a new pass. OK for trunk? Thanks, Ilya -- 2014-12-01 Ilya Enkovich PR target/64055

Re: [PATCH] Fix PR target/64055

2014-12-01 Thread Ilya Enkovich
2014-12-01 14:11 GMT+03:00 Richard Biener : > On Mon, Dec 1, 2014 at 10:33 AM, Ilya Enkovich wrote: >> Hi, >> >> This patch fixes ICE in chkp_find_bound_slots_1 by checking for non constant >> values in array domain. Bootstrapped on x86_64-unknown-linux

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-12-02 Thread Ilya Enkovich
On 05 Nov 11:00, Uros Bizjak wrote: > On Wed, Nov 5, 2014 at 10:35 AM, Ilya Enkovich wrote: > > Hi, > > > > Having stage1 close to end, may we make some decision regarding this > > patch? Having a couple of working variants, may we choose and use one > > of them

[PATCH, CHKP] Don't generate bndret for not instrumented calls

2014-12-02 Thread Ilya Enkovich
lya -- gcc/ 2014-12-02 Ilya Enkovich * tree-chkp.c (chkp_call_returns_bounds_p): New. (chkp_build_returned_bound): Use zero bounds as returned by calls not returning bounds. gcc/testsuite/ 2014-12-02 Ilya Enkovich * gcc.target/i386/chkp-bnd

[PATCH, CHKP] Don't try to optimize bounds returned by strchr

2014-12-02 Thread Ilya Enkovich
Hi, For strchr calls bounds of the first argument are considered as returned which is wrong because NULL may be returned. This patch fixes that. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- 2014-12-02 Ilya Enkovich * tree-chkp.c

[PATCH, CHKP] Keep instrumentation references consistency when merging cgraph nodes

2014-12-02 Thread Ilya Enkovich
to -fcheck-pointer-bounds -mmpx'. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- 2014-12-02 Ilya Enkovich * lto-cgraph.c (input_cgraph_1): Don't break existing instrumentation clone references. * lto/lto-symtab.c (lto

[PATCH, CHKP] Fix instrumentation clones privatization

2014-12-02 Thread Ilya Enkovich
Ilya -- gcc/ 2014-12-02 Ilya Enkovich * lto/lto-partition.c (privatize_symbol_name): Correctly privatize instrumentation clones. gcc/testsuite/ 2014-12-02 Ilya Enkovich * gcc.dg/lto/lto.exp: Load mpx-dg.exp. * gcc.dg/lto/chkp-privatize_0.c: New. * g

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-12-03 Thread Ilya Enkovich
2014-12-02 0:16 GMT+03:00 Jeff Law : > On 11/24/14 07:06, Ilya Enkovich wrote: >>> >>> Normally GCC target libraries assigned to the FSF would use GPL+exception >>> rather than LGPL (especially if the library might be linked in >>> statically), to keep predi

[PATCH, CHKP, PR target/65183] Avoid wrong pass local data usage

2015-02-25 Thread Ilya Enkovich
Hi, This patch fixes a case when outdated checker local data is used to process external calls. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-02-25 Ilya Enkovich PR target/65183 * tree-chkp.c (chkp_check_lower): Don't

[PATCH, CHKP, i386, PR target/65167] Avoid motion of bounds args during scheduling

2015-02-25 Thread Ilya Enkovich
Hi, This patch adds support for bounds registers into args recognition mechanism used by scheduler. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-02-25 Ilya Enkovich PR target/65167 * gcc/config/i386/i386.c

[PATCH, CHKP, i386, PR target/65184] Fix pass_by_reference for MS ABI for bounds

2015-02-25 Thread Ilya Enkovich
Hi, Currenly ix86_pass_by_reference may return 1 for bounds if MS ABI is used. This patch explicitly says bounds are never passed by reference. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-02-25 Ilya Enkovich PR target/65184

[committed] add new roles to MAINTAINERS

2015-03-02 Thread Ilya Enkovich
Hi, I've checked in this patch adding new roles for myself. Thanks, Ilya -- 2015-03-02 Ilya Enkovich * MAINTAINERS (Various Maintainers): Add myself as libmpx, pointer bounds checker and i386 MPX maintainer. Index: MAINTA

Re: [PATCH, CHKP, PR target/65044] Restrict pointer bounds checker with Sanitizer

2015-03-02 Thread Ilya Enkovich
Ping 2015-02-16 20:15 GMT+03:00 Ilya Enkovich : > On 16 Feb 17:01, Jakub Jelinek wrote: >> On Mon, Feb 16, 2015 at 06:56:45PM +0300, Ilya Enkovich wrote: >> > On 16 Feb 16:31, Jakub Jelinek wrote: >> > > On Mon, Feb 16, 2015 at 06:20:59PM +0300, Ilya Enkovich wrote:

<    1   2   3   4   5   6   7   8   9   10   >