Re: [PATCH] Handle timeout warnings in dg-extract-results

2019-01-26 Thread Iain Sandoe
Hi Christophe, > On 23 Jan 2019, at 13:16, Christophe Lyon wrote: > dg-extract-results currently moves lines like > WARNING: program timed out > at the end of each .exp section when it generates .sum files. > > This is because it sorts its output based on the 2nd field, which is > normally the

Re: [PATCH] Handle timeout warnings in dg-extract-results

2019-01-29 Thread Iain Sandoe
Hi Christophe, > On 29 Jan 2019, at 09:58, Christophe Lyon wrote: > > On Sat, 26 Jan 2019 at 17:43, Iain Sandoe wrote: >> >> Hi Christophe, >> >>> On 23 Jan 2019, at 13:16, Christophe Lyon >>> wrote: >> >>> dg-extract-resul

Re: [PATCH] Handle timeout warnings in dg-extract-results

2019-01-31 Thread Iain Sandoe
> On 29 Jan 2019, at 10:22, Christophe Lyon wrote: > > On Tue, 29 Jan 2019 at 11:12, Iain Sandoe wrote: >> >>> Did it work for you? >> >> So far it’s looking nice… (anything that makes the dg output more stable is >> Good in my book) >> &

Re: [PATCH] Handle timeout warnings in dg-extract-results

2019-02-04 Thread Iain Sandoe
> On 4 Feb 2019, at 08:55, Christophe Lyon wrote: > > On Sat, 2 Feb 2019 at 00:13, Mike Stump wrote: >> >> On Jan 23, 2019, at 5:16 AM, Christophe Lyon >> wrote: >>> What do people think about this? >> >> Seems reasonable. > > Thanks, committed as r268511. There are a few improvements we

Re: [RS6000] Set uses_pic_offset_table on sysv secure-plt calls and tls.

2019-02-06 Thread Iain Sandoe
> On 6 Feb 2019, at 11:45, Segher Boessenkool > wrote: > > On Wed, Feb 06, 2019 at 04:43:18PM +1030, Alan Modra wrote: >> Segher, you'll recognize these as your patches from pr88343. All I've >> done here is give you a testcase for the legitimize_tls_address change >> (which you said you had

Re: [RS6000] Correct save_reg_p

2019-02-08 Thread Iain Sandoe
> On 8 Feb 2019, at 16:16, Segher Boessenkool > wrote: > > On Fri, Feb 08, 2019 at 10:19:40PM +1030, Alan Modra wrote: >> That one regressed gcc.dg/20020312-2.c, due to my "cleverness" in >> simplifying the ABI_V4 case. This one passes regression testing. >> OK to apply? > > I think this is

Re: [PATCH 2/3] rs6000: Use LR_REGNO instead of constant 65

2016-09-01 Thread Iain Sandoe
of LR in restore_world. Darwin had an additional use of LR in the restore_world machinery. This patch removes it from the pattern in altivec.md and the relevant predicate. Many thanks to Segher for detailed pointers to the solutions. 2016-09-01 Iain Sandoe Segher Boessenkool * conf

Re: Deprecate DBX/stabs?

2017-07-21 Thread Iain Sandoe
test something more quickly than my really ancient G4s can manage. > The 64_BIT x86 darwin question likely can be be flipped to default to dwarf; > so, even that isn't an issue. It ought to be already, in fact anything (powerpc*/x86/x86-64) >= Darwin9 (OS X 10.5) ought to be defaulting to DWARF already, will check that sometime. cheers, Iain Iain Sandoe CodeSourcery / Mentor Embedded

Re: Deprecate DBX/stabs?

2017-07-21 Thread Iain Sandoe
> On 21 Jul 2017, at 20:54, Jim Wilson wrote: > > On Fri, Jul 21, 2017 at 12:44 PM, Iain Sandoe wrote: >> It ought to be already, in fact anything (powerpc*/x86/x86-64) >= Darwin9 >> (OS X 10.5) ought to be defaulting to DWARF already, will check that >> somet

Re: [testsuite, i386] Require -static support in gcc.dg/pie-static-[12].c (PR testsuite/81793)

2017-08-28 Thread Iain Sandoe
RTFILE_SPEC) > accept -static and try to link libcrt0.o it the latter doesn't exist. > > However, I've just found that the bundled clang on Darwin 11 does the > same (and fails in the same way: "ld: library not found for -lcrt0.o”). I think it’s because when one is

Re: [testsuite, i386] Require -static support in gcc.dg/pie-static-[12].c (PR testsuite/81793)

2017-08-29 Thread Iain Sandoe
he code is still present in clang, suggests this could still be the case (although the ‘just left in there by accident’ explanation is possible too, I will try to query someone for a definite answer). In any case, we might as well just skip such tests (or xfail them) on Darwin, that’s a correct reflection of the user-land expectation. Iain Sandoe CodeSourcery / Mentor Embedded / Siemens

Re: [PATCH]: PR target/80204 (Darwin macosx-version-min problem)

2017-09-11 Thread Iain Sandoe
he risk of bad effects is fairly low, and we can deal with them if they occur, so it’s a reasonable patch (as has been OK’d). Please CC me directly on Darwin patches; in case I miss them in other list traffic. Whilst I cannot approve them - at least I will try to review and make suggestions. Iain Sandoe CodeSourcery / Mentor Embedded / Siemens

Re: Heads-Up: early LTO debug to land, breaking Mach-O / [X]COFF

2017-05-12 Thread Iain Sandoe
Hi Richard, > On 12 May 2017, at 10:24, Richard Biener wrote: > > > This is a heads-up that I am in the process of implementing the last > of Jasons review comments on the dwarf2out parts of early LTO debug > support. I hope to post final patches early next week after thoroughly > re-testing e

Re: [PATCH] PR target/80556

2017-09-18 Thread Iain Sandoe
of Darwin. AFAICT from the published sources, i386 Darwin should be able to work with the libgcc unwinder (and all earlier Darwin *have* to) - so I’ve proposed a modified patch in the PR that makes the changes specific to m64 x86 and doesn’t make any alteration for PPC and/or Darwin < 10. HTH, Iain Iain Sandoe CodeSourcery / Mentor Embedded / Siemens

Re: [PATCH] PR target/80556

2017-09-22 Thread Iain Sandoe
> On 18 Sep 2017, at 22:08, Simon Wright wrote: > > On 18 Sep 2017, at 21:09, Iain Sandoe wrote: >> >>> If I propose this alternative patch, should it be a new post, or should I >>> continue this thread? >> >> thanks for the patch. >>

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-01 Thread Iain Sandoe
> On 1 Feb 2017, at 08:42, Richard Biener wrote: > > On Tue, 31 Jan 2017, Jeff Law wrote: > >> On 01/31/2017 02:01 AM, Richard Biener wrote: >>> >>> This amends ADJUST_FIELD_ALIGN to always get the type of the field >>> as argument but make the field itself optional. All actual target >>> mac

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-03 Thread Iain Sandoe
> On 2 Feb 2017, at 08:08, Richard Biener wrote: > > On Wed, 1 Feb 2017, Segher Boessenkool wrote: > >> On Wed, Feb 01, 2017 at 03:53:09PM -0600, Segher Boessenkool wrote: >>> On Wed, Feb 01, 2017 at 11:59:10AM +0100, Richard Biener wrote: Wasn't successful in making a cross to ppc64-linux

Re: [PATCH] objc: update documetation and add test-case of constructor/destructor attr.

2016-09-27 Thread Iain Sandoe
> On 10 Aug 2016, at 19:53, Sandra Loosemore wrote: > > On 08/10/2016 03:11 AM, Martin Liška wrote: >> Hi. >> >> Following patch clarifies usage of ctor and dtor attributes for Objective C. >> Patch survives (on x86_64-linux-gnu): >> >> make -k check-objc RUNTESTFLAGS="execute.exp" >> >> Read

Re: [PATCH] Delete GCJ

2016-10-04 Thread Iain Sandoe
> On 4 Oct 2016, at 18:23, Mike Stump wrote: > > On Oct 4, 2016, at 1:41 AM, Andrew Haley wrote: >> >> On 04/10/16 09:39, Rainer Orth wrote: >>> Hi Matthias, >>> On 05.09.2016 17:13, Andrew Haley wrote: > As discussed. I think I should ask a Global reviewer to approve this > one

Re: [PATCH] Delete GCJ

2016-10-06 Thread Iain Sandoe
> On 6 Oct 2016, at 17:42, Rainer Orth wrote: > >>> Here's what I tested. This requires a boehm-gc version 7.0 or later >>> (having the >>> header files in a gc subdirectory). Depending on your available library, it >>> only builds the GC enabled library for the default multilib library, and

Re: [PATCH] Delete GCJ

2016-10-06 Thread Iain Sandoe
> On 6 Oct 2016, at 17:56, Rainer Orth wrote: > this assumption may not hold, though: in Solaris 11+ where libgc is bundled, both 32 and 64-bit libs are present, as always. I'd also claim that for multilib testing in general, it's bad to test different multilibs with differ

Re: [PATCH] Delete GCJ

2016-10-07 Thread Iain Sandoe
> On 7 Oct 2016, at 00:58, Matthias Klose wrote: > > On 06.10.2016 20:00, Mike Stump wrote: >> On Oct 6, 2016, at 9:56 AM, Rainer Orth >> wrote: >>> I wouldn't hard-fail, but completely disable objc-gc with an appropriate >>> warning. The Objective-C maintainers may have other preferences, th

Re: [PATCH] Delete GCJ

2016-10-10 Thread Iain Sandoe
> On 10 Oct 2016, at 05:03, Matthias Klose wrote: > > On 07.10.2016 10:30, Iain Sandoe wrote: >> >>> On 7 Oct 2016, at 00:58, Matthias Klose wrote: >>> >>> On 06.10.2016 20:00, Mike Stump wrote: >>>> On Oct 6, 2016, at 9:56 AM, Rai

Re: [PATCH] rs6000: Fix separate shrink-wrapping for TARGET_MULTIPLE

2016-10-17 Thread Iain Sandoe
Hi Segher, > On 17 Oct 2016, at 09:13, Segher Boessenkool > wrote: > > We cannot use {SAVE,REST}_MULTIPLE and separate shrink-wrapping together, > not without checking when actually emitting the prologue/epilogue that the > registers to save/restore are actually still one contiguous block up to

[Patch, committed] Fix bootstrap on freeBSD and hppa64

2016-11-28 Thread Iain Sandoe
Hi, I used a non-portable shell idiom in the second patch for pr71767. This caused configuration issues resulting in bootstrap fails for FreeBSD and hppa64-*-*. Fix tested by Andreas and John (and re-checked on Darwin and Linux by me). Applied as 242912. Iain gcc/ 2016-11-28 Iain Sandoe

Re: [Patch, committed] Fix bootstrap on freeBSD and hppa64

2016-11-28 Thread Iain Sandoe
> On 28 Nov 2016, at 10:34, Iain Sandoe wrote: > > Hi, > > I used a non-portable shell idiom in the second patch for pr71767. This > caused configuration issues resulting in bootstrap fails for FreeBSD and > hppa64-*-*. > > Fix tested by Andreas and John (and re-

[Darwin, PPC] Fix PR71496 by marking pic base loads as non-copyable.

2016-12-09 Thread Iain Sandoe
pic base loads (and reloads for non-local-gotos) are not validly copied (since the pic base label would be duplicated). Thus, this patch marks them accordingly. OK for trunk? OK for GCC-6 branch? thanks, Iain gcc/ 2016-12-09 Iain Sandoe PR rtl-optimization/71496 * config

[Darwin,PPC] Remove use of LR in restore_world.

2016-12-11 Thread Iain Sandoe
-12-11 Iain Sandoe * config/rs6000/altivec.md (*restore_world): Remove LR use. * config/rs6000/predicates.md (restore_world_operation): Adjust op count, remove one USE. --- gcc/config/rs6000/altivec.md| 1 - gcc/config/rs6000/predicates.md | 3 +-- 2 files changed, 1

[PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

2015-09-07 Thread Iain Sandoe
PR other/63758 * environ.h: New file. libiberty/ Roland McGrath Iain Sandoe PR other/63758 * pex-unix.c: Obtain the environment interface from settings in environ.h rather than in-line code. Update copyright date. * setenv.c

Re: [PATCH g++ driver] Push -static-libstdc++ back onto the command line to allow spec substitutions to use it.

2015-09-07 Thread Iain Sandoe
On 14 Jul 2015, at 18:45, Iain Sandoe wrote: > > On 14 Jul 2015, at 18:24, Jason Merrill wrote: > >> On 06/18/2015 04:12 AM, Iain Sandoe wrote: >>> The patch below pushes -static-libstdc++ onto the output command line (for >>> targets without -Bstatic/dyn

[PATCH, Darwin] Some driver TLC (improve support for the '-arch' flag).

2015-09-07 Thread Iain Sandoe
patch produces warnings if the User attempts to add multiple (different) instances of -arch. OK for trunk? Iain gcc/ Iain Sandoe * config/darwin-driver.c (darwin_driver_init): Handle '-arch' for PPC, detect conflicts between -arch and multilib settings.

Re: [PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

2015-09-08 Thread Iain Sandoe
On 8 Sep 2015, at 15:00, Ian Lance Taylor wrote: > On Mon, Sep 7, 2015 at 8:23 AM, Iain Sandoe wrote: >> >> include/ >> >>Roland McGrath >> >>PR other/63758 >>* environ.h: New file. >> >> libibe

[Darwin, Driver/specs] A bit more TLC, factor version-min code, lose some dead specs.

2015-09-12 Thread Iain Sandoe
* config/rs6000/darwin.h: Likewise. * config/darwin.opt (mmacosx-version-min=): Use the configured default, rather than an arbitrary constant. From 04cfd2ea513fdaa48826891dbc87615f97270950 Mon Sep 17 00:00:00 2001 From: Iain Sandoe Date: Mon, 7 Sep 2015 09:59:45 +0100 Subject: [

[Darwin, driver] Make our sysroot handling the same as clang's.

2015-09-12 Thread Iain Sandoe
(LINK_SYSROOT_SPEC): Revise to remove the default for target sysroot. (STANDARD_STARTFILE_PREFIX_1): New. (STANDARD_STARTFILE_PREFIX_2): New. From 3d20de66ec2e7da5f371175253f01d0dd74dc8c0 Mon Sep 17 00:00:00 2001 From: Iain Sandoe Date: Fri, 11 Sep 2015 23:39:35 +0100 Subject:

Re: [Darwin, driver] Make our sysroot handling the same as clang's.

2015-09-13 Thread Iain Sandoe
Hi Mike, On 13 Sep 2015, at 21:32, Mike Stump wrote: > On Sep 12, 2015, at 8:02 AM, Iain Sandoe wrote: >> OK for trunk? chose this comment carefully : " for something that's essentially a constant for the versions of ld that work with current GCC. " > So, does thi

Re: [PATCH] Fix PR driver/78206 by silently ignoring EPERM as well as ENOENT

2016-11-06 Thread Iain Sandoe
> On 6 Nov 2016, at 06:04, Jack Howarth wrote: > > On Sun, Nov 6, 2016 at 8:36 AM, Jack Howarth wrote: >> The use of an Apple sandbox with denied file access permissions into >> /usr/local >> exposed that cc1 fails on errors of... >> >> cc1: error: /usr/local/include: Operation not permitted

Re: [PATCH] Fix PR driver/78206 by silently ignoring EPERM as well as ENOENT

2016-11-06 Thread Iain Sandoe
> On 6 Nov 2016, at 06:57, Jack Howarth wrote: > > On Sun, Nov 6, 2016 at 9:45 AM, Iain Sandoe wrote: >> >>> On 6 Nov 2016, at 06:04, Jack Howarth wrote: >>> >>> On Sun, Nov 6, 2016 at 8:36 AM, Jack Howarth >>> wrote: >>>>

[Darwin, configury] No longer expect to find cross-target headers on the host.

2016-11-06 Thread Iain Sandoe
in the current GCC tree. OK for trunk? OK for open branches? Iain …. Iain Sandoe gcc/ * configure.ac (CROSS directory tests): Remove assumption that Darwin hosts contain suitable target sysroots in “/“. * configure: Regenerate. --- gcc/configure.ac | 21 ---

[PATCH fix PR71767 0/4] Background

2016-11-06 Thread Iain Sandoe
Hi Folks, Including Jeff on the cc since we were discussing this on Friday (and it’s not 100% clear who’s reviewing configury patches at present). Including Uros, because there’s one minor change to i386/i386.c PR71767 is " Endless stream of warnings when using GCC with -Wa,-q and Clang Integra

[PATCH fix PR71767 1/4 : ld64 atoms] Make PIC indirections and constant labels linker-visible.

2016-11-06 Thread Iain Sandoe
there are also some cases in Objective-C meta-data that need similar treatment, but those need to be caught in the objc runtime lowering. OK for trunk? OK for open branches? Iain gcc/ 2016-11-06 Iain Sandoe PR target/71767 * config/darwin.c (imachopic_indirection_name): Make d

[PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

2016-11-06 Thread Iain Sandoe
or -rdynamic is converted to be detected at config time, or by the ld64 version if that is explicitly given (as an example of usage). OK for trunk? OK for open branches? Iain gcc/ 2016-11-06 Iain Sandoe PR target/71767 * configure.ac (with-ld64): New arg-with. gcc_ld

[PATCH fix PR71767 3/4 : Darwin sections] Fix PR71767 - adjust the sections used in response to ld64 version.

2016-11-06 Thread Iain Sandoe
tions when a new enough linker is available. There’s a small change to i386.c to make it possible to switch thunk output between coalesced and “regular’ sections in response to the relevant linker info. OK for trunk? OK for open branches? Iain gcc/ 2016-11-06 Iain Sandoe PR ta

[PATCH fix PR71767 4/4 : testsuite] Fix testsuite fallout from section and linker sym visibility changes.

2016-11-06 Thread Iain Sandoe
Hi folks, As per $SUBJECT. OK for trunk (after the relevant patches are applied)? OK for open branches (likewise)? Iain gcc/testsuite/ …. Dominique d'Humieres Iain Sandoe PR target/71767 * g++.dg/abi/key2.C: Adjust for changed Darwin sections and linker-vi

[PATCH, Darwin] Fix PR57438 by avoiding empty function bodies and trailing labels.

2016-11-06 Thread Iain Sandoe
n branches? Iain gcc/ 2016-11-06 Iain Sandoe PR target/57438 * config/i386/i386.c (ix86_code_end): Note that we emitted code where the function might otherwise appear empty for picbase thunks. (ix86_output_function_epilogue): If we find a zero-sized function a

[PATCH, Darwin] fix for PR67710 : Update 'as' specs and inputs to handle newer assembler versions.

2016-11-06 Thread Iain Sandoe
10.4, for example). To avoid conflicts where the "as" is assuming some minimum, I've set the testversion to 10.5 (which is supported by all the archs we have) (e) We need to ensure that libgcc and crts are generated with a sufficiently old minversion not to conflict. OK for tr

Re: [PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

2016-11-07 Thread Iain Sandoe
Date: November 7, 2016 at 9:48:53 AM PST >> To: Iain Sandoe >> Cc: GCC Patches , Jeff Law >> >> On Nov 6, 2016, at 11:39 AM, Iain Sandoe wrote: >>> This is an initial patch in a series that converts Darwin's configury to >>> detect ld64 features, ra

Re: [PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

2016-11-07 Thread Iain Sandoe
> On 7 Nov 2016, at 13:56, Mike Stump wrote: > > On Nov 7, 2016, at 9:59 AM, Iain Sandoe wrote: >> >>> On 7 Nov 2016, at 09:51, Mike Stump wrote: >>> >>> [ possible dup ] >>> >>>> Begin forwarded message: >>>>

Re: [PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

2016-11-07 Thread Iain Sandoe
> On 7 Nov 2016, at 13:53, Mike Stump wrote: > > On Nov 7, 2016, at 10:40 AM, Jeff Law wrote: >> >> On 11/07/2016 10:48 AM, Mike Stump wrote: >>> On Nov 6, 2016, at 11:39 AM, Iain Sandoe wrote: >>>> This is an initial patch in a series that conver

Re: [PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

2016-11-07 Thread Iain Sandoe
> On 7 Nov 2016, at 13:53, Mike Stump wrote: > > On Nov 7, 2016, at 10:40 AM, Jeff Law wrote: >> >> On 11/07/2016 10:48 AM, Mike Stump wrote: >>> On Nov 6, 2016, at 11:39 AM, Iain Sandoe wrote: >>>> This is an initial patch in a series that conver

Re: [PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

2016-11-08 Thread Iain Sandoe
> On 8 Nov 2016, at 08:18, Mike Stump wrote: > > On Nov 7, 2016, at 6:33 PM, Iain Sandoe wrote: >> >> a) right now, we need to know the target linker version - while it’s not >> impossible to try and conjure up some test to see if a linker we can run >> s

Re: [PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

2016-11-08 Thread Iain Sandoe
> On 8 Nov 2016, at 10:27, Mike Stump wrote: > > On Nov 8, 2016, at 8:31 AM, Iain Sandoe wrote: >> >>> On 8 Nov 2016, at 08:18, Mike Stump wrote: >>> >>> On Nov 7, 2016, at 6:33 PM, Iain Sandoe wrote: >>>> >>>> a) rig

Re: [PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

2016-11-08 Thread Iain Sandoe
> On 8 Nov 2016, at 13:39, Mike Stump wrote: > > On Nov 8, 2016, at 1:05 PM, Iain Sandoe wrote: >> >> Simple for the simple case is already part of my patch, but capability for >> the expert and non-simple case is also present, > > I'm trying to ask a

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-11 Thread Iain Sandoe
Hi Rainer, Thanks for the patch! > On 11 Nov 2016, at 11:18, Mike Stump wrote: > > On Nov 11, 2016, at 2:15 AM, Rainer Orth > wrote: >> The patch passes fixincludes make check (this time for real ;-) and >> restores macOS 10.12 bootstrap. > > No objections from me. On x86_64-darwin14, there

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-11 Thread Iain Sandoe
> On 11 Nov 2016, at 16:50, Rainer Orth wrote: > > Hi Iain, > >>> On 11 Nov 2016, at 11:18, Mike Stump wrote: >>> >>> On Nov 11, 2016, at 2:15 AM, Rainer Orth >>> wrote: The patch passes fixincludes make check (this time for real ;-) and restores macOS 10.12 bootstrap. >>> >>> No

Re: [PATCH] fix PR sanitizer/78267

2016-11-14 Thread Iain Sandoe
> On 14 Nov 2016, at 16:57, Jack Howarth wrote: > > The attached patch fixes PR sanitizer/78267 by conditionalizing the > include of on the compiler defining __BLOCKS__ as a > supported extension. Passes bootstrap on x86_64-apple-darwin15. Okay > for gcc trunk? > Rainer has that PR assigned a

Re: [PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

2016-11-18 Thread Iain Sandoe
> On 17 Nov 2016, at 21:19, Jeff Law wrote: > > On 11/08/2016 05:49 PM, Iain Sandoe wrote: >> >>> On 8 Nov 2016, at 13:39, Mike Stump wrote: >>> >>> On Nov 8, 2016, at 1:05 PM, Iain Sandoe >>> wrote: >>>> >>>> Simp

Re: [PATCH, Darwin] Fix PR57438 by avoiding empty function bodies and trailing labels.

2016-11-18 Thread Iain Sandoe
Hi Segher, Thanks for the review, > On 6 Nov 2016, at 22:09, Segher Boessenkool > wrote: > > On Sun, Nov 06, 2016 at 12:13:16PM -0800, Iain Sandoe wrote: >> 2016-11-06 Iain Sandoe >> >> PR target/57438 >> * config/i386/i386.c (ix86_code_e

Re: [PATCH, Darwin] Fix PR57438 by avoiding empty function bodies and trailing labels.

2016-11-18 Thread Iain Sandoe
Hi Mike, > On 18 Nov 2016, at 17:16, Mike Stump wrote: > > On Nov 18, 2016, at 4:33 AM, Iain Sandoe wrote: >> >> As discussed on IRC, I was under the impression that it is desired to move >> away from #ifdef towards if() and I have been adding those where l

Re: [PATCH] Delete GCJ

2016-11-21 Thread Iain Sandoe
> On 20 Nov 2016, at 20:42, Matthias Klose wrote: > > On 10.10.2016 09:58, Iain Sandoe wrote: >> >> The point here was to simplify the dependent configury so that it only needs >> to test something that the configuring user specifies (i.e. if they specify >>

Re: [PATCH 4/4] Add -Wmisleading-indentation to -Wall

2015-12-11 Thread Iain Sandoe
> On 11 Dec 2015, at 11:25, Dominique d'Humières wrote: > > This breaks bootstrap on darwin: > > ../../work/gcc/config/darwin.c: In function 'bool > darwin_use_anchors_for_symbol_p(const_rtx)': > ../../work/gcc/config/darwin.c:3016:9: error: statement is indented as if it > were guarded by...

Re: [build] Only support -gstabs on Mac OS X if assember supports it (PR target/67973)

2015-12-14 Thread Iain Sandoe
Hi Rainer, Thanks for looking at this! > On 14 Dec 2015, at 10:40, Rainer Orth wrote: > > As described in PR PR target/67973, newer assemblers on Mac OS X, which > are based on LLVM instead of gas, don't support .stab* directives any > longer. The following patch detects this situation and tr

Re: [build] Only support -gstabs on Mac OS X if assember supports it (PR target/67973)

2015-12-14 Thread Iain Sandoe
Hi Rainer, > On 14 Dec 2015, at 11:13, Rainer Orth wrote: > >>> However, I'm not really comfortable with this solution. Initially, I >>> forgot to wrap the -Q option to as in %{gstabs*:...}, which lead to a >>> bootstrap failure: the gas- and LLVM-based assemblers differ in a >>> number of othe

Re: [build] Only support -gstabs on Mac OS X if assember supports it (PR target/67973)

2015-12-14 Thread Iain Sandoe
> On 14 Dec 2015, at 11:21, Rainer Orth wrote: > > Hi Iain, > >>> On 14 Dec 2015, at 11:13, Rainer Orth wrote: >>> > However, I'm not really comfortable with this solution. Initially, I > forgot to wrap the -Q option to as in %{gstabs*:...}, which lead to a > bootstrap failure: t

Re: [patch, build] Restore bootstrap in building libcc1 on darwin

2014-12-04 Thread Iain Sandoe
Hi Rainer, On 4 Dec 2014, at 13:32, Rainer Orth wrote: > FX writes: > >> 10-days ping >> This restores bootstrap on a secondary target, target maintainer is OK with >> it. I think I need build maintainers approval, so please review. > > While in my testing, 64-bit Mac OS X 10.10.1 (x86_64-appl

Re: [patch, build] Restore bootstrap in building libcc1 on darwin

2014-12-04 Thread Iain Sandoe
On 4 Dec 2014, at 15:24, FX wrote: >> Can you try adding it as >> >> T_CFLAGS += -mdynamic-no-pic >> >> in gcc/config/t-tarwin instead? > -mdynamic-no-pic should be used to build *host* executable stuff for m32 darwin. It is not suitable for building shared libraries (hence the problem with

Re: [patch, build] Restore bootstrap in building libcc1 on darwin

2014-12-06 Thread Iain Sandoe
Hi Jeff, On 5 Dec 2014, at 22:40, Jeff Law wrote: > On 12/05/14 15:34, Dominique Dhumieres wrote: >>> As I've tried to explain, that is IMHO wrong though. >>> If what you are after is the -B stuff too, then perhaps: >>> ... >> >> Sorry but it does not work: > BTW, thanks for working with Jakub o

[Patch, libada] Fix PR64349 - make darwin use the correct interface to access _environ.

2014-12-22 Thread Iain Sandoe
for Darwin. From c336acb970b21589368948bc1bdc502546b568fc Mon Sep 17 00:00:00 2001 From: Iain Sandoe Date: Mon, 22 Dec 2014 10:47:40 + Subject: [PATCH] Arrange for libada to use the approved interface to obtain _environ on Darwin --- gcc/ada/env.c | 9 +++-- 1 file changed, 7 i

[Patch objcpp] Update gtfiles and add a testcase for c++ headers.

2014-12-22 Thread Iain Sandoe
omatic (it's an easy omission to make). OK for trunk? Iain gcc/objcp: * config-lang.in (gtfiles): Update list. gcc/testsuite: * obj-c++.dg/standard-headers.mm New File. From fda7470f52b0bd9ff66dd808f88429d9ab3fc9ea Mon Sep 17 00:00:00 2001 From: Iain Sandoe Date: Mon, 2

[PATCH c++/objc++] Make Objective-c++ recognise lambdas.

2014-12-22 Thread Iain Sandoe
(cp_parser_objc_message_reciever): Don't assume that if a message reciever expression fails it is a hard error. gcc/testsuite: * obj-c++.dg/lambda-0.mm New file. * obj-c++.dg/lambda-1.mm New file. From e8038ba3cb16095e53d09e23ff15f4682cb5bd0c Mon Sep 17 00:00:00 2

Re: [Patch, libada] Fix PR64349 - make darwin use the correct interface to access _environ.

2014-12-22 Thread Iain Sandoe
hi Arnaud, On 22 Dec 2014, at 13:53, Arnaud Charlet wrote: > The change isn't quite right for iOS (aka arm-darwin), but the general idea > is the right one. hmm.. I wasn't aware of a [> 4.2.1] arm-mach-o backend .. if that's a general issue, then I'll consider it for future patches. > Tristan

Re: [Ada] Fix bootstrapping on darwin9/10 (PR ada/64349).

2015-01-08 Thread Iain Sandoe
Hi Tristan, On 7 Jan 2015, at 10:15, Arnaud Charlet wrote: > Use _NSGetEnviron to get environment. > > Tested on x86_64-pc-linux-gnu, committed on trunk > > 2015-01-07 Tristan Gingold > > PR ada/64349 > * env.c (__gnat_environ): Adjust for darwin9/darwin10. > > So my original

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2015-01-08 Thread Iain Sandoe
e stage4 or > will it have to wait for the next major gcc release? > Jack > > On Thu, Nov 13, 2014 at 3:34 PM, Iain Sandoe wrote: >> Hello Richard, Joseph, >> >> Thanks for your reviews, >> >> On 13 Nov 2014, at 07:40, Richard Hen

Re: [Ada] Fix bootstrapping on darwin9/10 (PR ada/64349).

2015-01-08 Thread Iain Sandoe
On 8 Jan 2015, at 13:52, Tristan Gingold wrote: > >> On 08 Jan 2015, at 13:49, Iain Sandoe wrote: >> >> Hi Tristan, >> >> On 7 Jan 2015, at 10:15, Arnaud Charlet wrote: >> >>> Use _NSGetEnviron to get environment. >>> >>>

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

2014-09-15 Thread Iain Sandoe
Hi Mike, On 15 Sep 2014, at 08:33, Mike Stump wrote: > On Sep 14, 2014, at 5:43 PM, Segher Boessenkool > wrote: >> On Sun, Sep 14, 2014 at 02:38:45PM -0700, Mike Stump wrote: >>> + SIBLING_CALL_P (tmp) = 1; >>> + SIBLING_CALL_P (tmp) = 1; >> >> The second time is to make sure? :-) >

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

2014-09-15 Thread Iain Sandoe
Hi Jeff, On 15 Sep 2014, at 16:42, Jeff Law wrote: > On 09/15/14 05:25, FX wrote: >>> Perhaps it would be safer simply to revert that hunk of the original patch >>> unless/until (1) and (2) above are addressed? >> >> Given that the original patch addresses “only” a missed-optimization (and >>

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

2014-09-18 Thread Iain Sandoe
Hello Kai, all, I am not concerned solely about Darwin here, certainly we can make a patch to "fix" the problem there. My concern is for the general state of this code: On 18 Sep 2014, at 22:26, Kai Tietz wrote: > it isn't true that I didn't replied to Iant. ( iains ;) ) > I did this on IRC

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

2014-09-19 Thread Iain Sandoe
Hello Jeff, all, On 19 Sep 2014, at 05:14, Jeff Law wrote: > On 09/18/14 16:20, Iain Sandoe wrote: >> >> 1. There has been a change made "to make the upper path like the lower path" >> (as you said on IRC). >> - apparently (from our conversation)

Re: [PATCH] Fix build on darwin (was Re: [PATCH] gcc.c: Split up the driver's "main" into smaller functions)

2014-10-03 Thread Iain Sandoe
Hi David, On 3 Oct 2014, at 20:15, David Malcolm wrote: > On Fri, 2014-10-03 at 11:02 -0400, David Malcolm wrote: >> The "main" function for the driver in gcc.c has grown from ~200 lines >> in its original form (way back in r262) to ~1000 lines today, with a >> dozen locals (if we include the par

Re: [patch] Add -static-libquadmath option

2014-10-05 Thread Iain Sandoe
Hi FX, On 4 Oct 2014, at 14:51, FX wrote: > We have a -static-libgfortran option, but on targets where we support > quad-prec math through libquadmath, we didn’t have an equivalent > -static-libquadmath so far. This patch adds it, in what I think is a rather > straightforward manner. > > The

[Patch testsuite/objc/objc++] some objc/objcxx testsuite TLC re. PRs 55654,55656,55657

2013-07-14 Thread Iain Sandoe
hallenge. --- gcc/testsuite/ 2013-07-14 Iain Sandoe PR target/55654 PR target/55656 PR target/55657 * obj-c++.dg/cxx-ivars-3.mm: Use NSObject instead of Object. * obj-c++.dg/strings/const-cfstring-5.mm: Likewise. * obj-c++.dg/torture/strings/const-s

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-17 Thread Iain Sandoe
. >>> >>> FYI, this bootstrapped and regtested with no regressions. >>> David, is this ok for mainline? >> >> Okay. > > Committed as revision 200988. Thanks Jakub and David! This series broke bootstrap on powerpc-apple-darwin9. fixed as below, co

[Patch x86/darwin] fix PR51784 'PIC register not correctly preserved...'

2013-07-17 Thread Iain Sandoe
Hi, The PR is logged against Darwin, and (as Jakub points out in the PR thread) indeed Darwin is missing a nonlocal_goto_receiver to restore the PIC reg in code that uses it (most of the patch). However, there is a second issue, and (if I've understood things correctly) this affects GOT target

Re: [Patch x86/darwin] fix PR51784 'PIC register not correctly preserved...'

2013-07-18 Thread Iain Sandoe
Hi Uros, (working on a re-vamp with an expander for the nonlocal goto MD). On 18 Jul 2013, at 08:26, Uros Bizjak wrote: > Under assumpiton that foo and bar doesn't share the same GOT, you will > see that g42 after the label is accessed with "clobbered" %ebx. My understanding is that foo and ba

Re: [Patch x86/darwin] fix PR51784 'PIC register not correctly preserved...'

2013-07-18 Thread Iain Sandoe
Hi Uros, On 18 Jul 2013, at 07:31, Uros Bizjak wrote: > This should be implemented as an expander. You also won't need > UNSPEC_NLGR that way. Now I reload the state from this PR, I recall why this did not work. in the case: foo () { do stuff that doesn't use the pic reg call nested functi

Re: [Patch x86/darwin] fix PR51784 'PIC register not correctly preserved...'

2013-07-19 Thread Iain Sandoe
Hi Uros, thanks for your reviews, On 18 Jul 2013, at 12:39, Uros Bizjak wrote: > On Thu, Jul 18, 2013 at 12:12 PM, Iain Sandoe wrote: >> >> So, I think we have to use the define_insn_and_split, or am I still missing >> something? > > Just a wild guess, do you als

Re: [Patch x86/darwin] fix PR51784 'PIC register not correctly preserved...'

2013-07-21 Thread Iain Sandoe
Hi Uros, On 21 Jul 2013, at 08:34, Uros Bizjak wrote: > Sure, I can test that - do you want me to apply it assuming it reg-tests OK on darwin & linux? (also I can amend the back ports - since I didn't have time to get to them yesterday) thanks Iain

Re: [Patch x86/darwin] fix PR51784 'PIC register not correctly preserved...'

2013-07-22 Thread Iain Sandoe
Hi Uros, On 21 Jul 2013, at 09:15, Uros Bizjak wrote: > On Sun, Jul 21, 2013 at 9:42 AM, Iain Sandoe wrote: > >>> >> >> Sure, I can test that - do you want me to apply it assuming it reg-tests OK >> on darwin & linux? >> (also I can amend the back

Re: [PATCH/Merge Request] Vtable Verification feature.

2013-08-07 Thread Iain Sandoe
hi Caroline, A (very) quick look suggests that only *) results in a return of UNSUPPORTED from libvtv/configure.tgt Do you know if anyone is working on a Darwin port for this lib? thanks, Iain On 7 Aug 2013, at 17:57, Caroline Tice wrote: > libvtv was supposed to be automatically disabled fo

Re: [PATCH/Merge Request] Vtable Verification feature.

2013-08-08 Thread Iain Sandoe
Hi Caroline, On 8 Aug 2013, at 11:27, Rainer Orth wrote: > > As an aside, I had a very quick look at libvtv to determine what's > required for a port to a non-Linux platform. Likewise.. > It would be good if the > requirements (currently, ELF, dl_iterate_phdr, __fortify_fail, certainly > sever

Re: [C++ Patch / RFC] PR 46206

2013-08-09 Thread Iain Sandoe
On 9 Aug 2013, at 12:12, Paolo Carlini wrote: > On 08/09/2013 12:52 PM, domi...@lps.ens.fr wrote: >> On x86_64-apple-darwin10, g++.dg/lookup/typedef2.C fails with >> >> FAIL: g++.dg/lookup/typedef2.C -std=c++11 (test for excess errors) >> Excess errors: >> /opt/gcc/work/gcc/testsuite/g++.dg/look

Re: [C++ Patch / RFC] PR 46206

2013-08-10 Thread Iain Sandoe
Hi Paolo, On 9 Aug 2013, at 16:47, Paolo Carlini wrote: > On 08/09/2013 05:22 PM, David Edelsohn wrote: >> Exactly. What is the common factor on AIX, Darwin and Solaris that is >> different from Linux? A difference in system types? How can we help? > Thanks David, all, for your kind offers. > >

Re: Ping: testsuite patches ({1,2,6,10,12}/14)

2013-08-14 Thread Iain Sandoe
On 14 Aug 2013, at 17:15, Janis Johnson wrote: >> >> http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00895.html > > I'd prefer to have someone else review this patch, which replaces > -gdwarf-2 with -gdwarf. It is quite likely to break on (at least) Darwin9..10 and likely later - I'll give it a s

Re: Ping: testsuite patches ({1,2,6,10,12}/14)

2013-08-14 Thread Iain Sandoe
On 14 Aug 2013, at 17:19, Iain Sandoe wrote: > On 14 Aug 2013, at 17:15, Janis Johnson wrote: >>> >>> http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00895.html >> >> I'd prefer to have someone else review this patch, which replaces >> -gdwarf-2 with

[Patch, libgcov, committed] fix PR 58127

2013-08-18 Thread Iain Sandoe
Hi, This was approved by Honza in the PR thread. applied as 201829 cheers Iain libgcc: PR gcov-profile/58127 * libgcov.c (__gcov_indirect_call_callee): Don't make this a __thread var for emulated TLS. (__gcov_indirect_call_counters): Likewise. Index: libgcc/libgc

[Patch, backport 4.7] fix pr48109 on the branch.

2013-08-18 Thread Iain Sandoe
Hi The PR was fixed on trunk by ... http://gcc.gnu.org/ml/gcc-patches/2012-06/msg01185.html .. before 4.8 forked and is thus fixed everywhere except 4.7. This is a wrong code bug under LTO and was reported against 4.6, so I'd like to back port it to 4.7. [FWIW, the only change needed is add_a

[Patch Darwin/Objc] Fix PR 48094.

2013-08-18 Thread Iain Sandoe
Hi, The PR is a(nother) bad interaction between [Darwin/NeXT] ObjC meta-data and LTO. (for the NeXT runtime) the compiler emits a small block of meta-data "ImageInfo" that conveys to the run-time whether the User had enabled fix-and-continue or objc-gc. Since these data are anonymous (the r

Re: [PATCH][buildrobot] PR59496: Fix unused variable warning

2014-01-20 Thread Iain Sandoe
angeLog (revision 206801) +++ gcc/ChangeLog (working copy) @@ -1,3 +1,10 @@ +2014-01-20 Jan-Benedict Glaw + Iain Sandoe + + PR bootstrap/59496 + * config/rs6000/darwin.h (ADJUST_FIELD_ALIGN): Fix unused variable + warning. Amend comment to reflect curren

Re: [4.8, PATCH 0/26] Backport Power8 and LE support

2014-03-24 Thread Iain Sandoe
Hi Bill, On 21 Mar 2014, at 02:05, Bill Schmidt wrote: > For convenience of those who have kindly agreed to test the patch > series, here is the entire series as a single compressed patch. Note > that this does not include patch 15/26, which we've agreed to submit > separately. To assess this o

Re: [PATCH] Fix PR libitm/55693

2013-02-06 Thread Iain Sandoe
On 6 Feb 2013, at 17:20, Jack Howarth wrote: > On Wed, Feb 06, 2013 at 05:37:12PM +0100, Patrick Marlier wrote: >> Hi Jack, >> >> Thanks for having a look at this. >> >> However I don't understand why you need this: >> >> Index: gcc/config/i386/darwin.h >> =

Re: [PATCH] Disable libsanitizer before darwin10

2013-02-11 Thread Iain Sandoe
On 11 Feb 2013, at 15:55, Jack Howarth wrote: > Iain Sandoe discovered that on intel darwin9, the asan testsuite suffers > hundreds of > failures due to the absence of dispatch calls (Grand Central Dispatch) prior > to darwin10. > The attached patch disables building libsanit

<    8   9   10   11   12   13   14   15   16   17   >