Re: [PATCH, vtv update] Change fixed size array to a vector; fix diagnostic messages.

2013-08-28 Thread Diego Novillo
There are two patches attached in your original submission. I assume they're both identical? On Wed, Aug 28, 2013 at 12:59 PM, Caroline Tice wrote: > PING! > > Could somebody please, pretty please review this patch? It's not very > big or complex, and it's been out there for three weeks now

Re: [PATCH, vtv update] Change fixed size array to a vector; fix diagnostic messages.

2013-08-28 Thread Diego Novillo
On 2013-08-28 12:59 , Caroline Tice wrote: static void -output_set_info (tree record_type, tree *vtbl_ptr_array, int array_size) +output_set_info (tree record_type, vec *vtbl_ptr_array) Since this function does not modify vtbl_ptr_array, you could pass it by value. @@ -1023,23 +1010,23 @

Re: [PATCH, vtv update] Change fixed size array to a vector; fix diagnostic messages.

2013-08-28 Thread Diego Novillo
On Wed, Aug 28, 2013 at 1:39 PM, Caroline Tice wrote: > num_vtable_args was an int that we manually incremented/decremented, > so it might have been negative. I am > assuming that a vec.length() can never be negative. So before > the else-clause was explicitly checking that the value was 0 or 1

Re: [PATCH 0/6] Convert gimple to a C++ class hierarchy

2013-08-30 Thread Diego Novillo
On Fri, Aug 30, 2013 at 11:21 AM, Michael Matz wrote: > > Hi, > > On Fri, 30 Aug 2013, Gabriel Dos Reis wrote: > > > On Fri, Aug 30, 2013 at 9:02 AM, Jakub Jelinek wrote: > > > > >> I thought the principle that was acquired was that gengtype shouldn't > > >> be improved to support more than what

Re: [PATCH 0/6] Convert gimple to a C++ class hierarchy

2013-08-30 Thread Diego Novillo
On Fri, Aug 30, 2013 at 11:37 AM, Jakub Jelinek wrote: > Teaching the gengtype parser about > {struct,class} name : public {struct,class} someothername { ... } > as opposed to current > {struct,class} name { ... } > shouldn't be that hard. And, if the complaint is that we'd need to write > whole

Re: [PATCH 0/6] Convert gimple to a C++ class hierarchy

2013-08-31 Thread Diego Novillo
On Sat, Aug 31, 2013 at 5:57 AM, Richard Biener wrote: > What do you do during stage1? Have a collector that never collects? Yes. That was the pebble in the shoe. The cc1plus built for the purposes of gengtype does not need to look at a lot of code, so turning off collection may not be a big

Re: [PATCH 6/6] Add manual GTY hooks

2013-09-05 Thread Diego Novillo
On Wed, Sep 4, 2013 at 11:40 AM, David Malcolm wrote: > On Sat, 2013-08-31 at 19:27 +0200, Richard Biener wrote: >> David Malcolm wrote: >> >On Fri, 2013-08-30 at 10:09 +0200, Richard Biener wrote: >> >> On Thu, Aug 29, 2013 at 9:44 PM, Steven Bosscher >> > wrote: >> >> > On Thu, Aug 29, 2013 at

Re: [PATCH, libvtv] Fix most of the testsuite.

2013-09-06 Thread Diego Novillo
On Thu, Sep 5, 2013 at 4:52 PM, Caroline Tice wrote: > Ping? Could somebody please review this for me? Mike already approved this upthread.

Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...

2013-09-06 Thread Diego Novillo
On 2013-08-28 17:15 , Caroline Tice wrote: # Least ordering for dependencies mean linking w/o libstdc++ for as # long as the development of libvtv does not absolutely require it. Index: gcc/doc/install.texi === --- gcc/doc/install

Re: RFC - Next refactoring steps

2013-09-06 Thread Diego Novillo
On Fri, Sep 6, 2013 at 4:14 AM, Mike Stump wrote: > On Sep 5, 2013, at 11:54 PM, Richard Biener > wrote: >> Most of the GCC headerfiles do not include all their required headers but >> rely on .c files doing that (in the appropriate order). I somehow like >> that though I cannot explain why ;)

Factor gimple structures out of gimple.h

2013-09-06 Thread Diego Novillo
rationale at the thread: http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00300.html Tested on x86_64. 2013-09-06 Diego Novillo * Makefile.in (GIMPLE_CORE_H): New. (GIMPLE_H): Depend on GIMPLE_CORE_H. (TREE_SSA_ALIAS_H): New. Replace references to tree-ssa-alias.h with

Re: RFC - Refactor tree.h

2013-09-13 Thread Diego Novillo
On Fri, Sep 13, 2013 at 11:07 AM, Jakub Jelinek wrote: > E.g. today I've noticed you've lost OMP_CLAUSE_LINEAR_NO_COPYIN > comment that has been added to tree.h recently, but you haven't > actually moved it into tree-core.h. Sorry about that. I remember an update conflict, but I thought I had i

Re: RFC - Refactor tree.h

2013-09-16 Thread Diego Novillo
On Fri, Sep 13, 2013 at 11:25 AM, Diego Novillo wrote: > On Fri, Sep 13, 2013 at 11:07 AM, Jakub Jelinek wrote: > >> E.g. today I've noticed you've lost OMP_CLAUSE_LINEAR_NO_COPYIN >> comment that has been added to tree.h recently, but you haven't >> actual

Re: gimple build interface

2013-09-20 Thread Diego Novillo
On Thu, Sep 19, 2013 at 9:20 AM, Andrew MacLeod wrote: > I see the benefit in the streamlined asan.c code, but I detest that > ssa_mode flag. And as long as it supports SSA, I don't think it should be > in gimple.c. Yeah, at the time that I introduced it, I had a hard time with the normal/ssa

Re: gimple build interface

2013-09-20 Thread Diego Novillo
On Fri, Sep 20, 2013 at 4:08 AM, Richard Biener wrote: > On Thu, Sep 19, 2013 at 6:56 PM, Andrew MacLeod wrote: >> On 09/19/2013 09:24 AM, Andrew MacLeod wrote: >>> >>> >>> I think this is of most use to ssa passes that need to construct code >>> snippets, so I propose we make this ssa specific a

Re: Ping^2: small patch to accept = inside GCC plugin arguments

2013-09-20 Thread Diego Novillo
On Mon, Sep 16, 2013 at 4:23 AM, Basile Starynkevitch wrote: > Hello All, > > I'm pinging again my small patch to accept = inside plugin arguments > http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00382.html OK. Diego.

Re: Ping patch to enable *.cc files in gengtype

2013-09-20 Thread Diego Novillo
On 2013-09-16 04:19 , Basile Starynkevitch wrote: Hello all, I'm pinging the patch (of september 2nd) on http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00036.html gcc/ChangeLog entry 2013-09-16 Basile Starynkevitch * gengtype.c (file_rules): Added rule for *.cc files. (

Re: [google, patch] Google-local version of fix for PR58312, libssp cross-compiling

2013-09-23 Thread Diego Novillo
On Fri, Sep 20, 2013 at 5:08 PM, Brooks Moses wrote: > Thus, this Google-local patch addresses our immediate need in a simple > way. Ok to commit to google/main and merge to google/gcc-4_8? OK. This should go in google/integration, actually. google/main can get it later when it merges from g/

Remove enum ssa_mode

2013-09-27 Thread Diego Novillo
The gimple builder no longer support normal form. The ssa_mode enum is not needed now. Committed to trunk. * gimple.h (enum ssa_mode): Remove. --- gcc/gimple.h | 9 - 1 file changed, 9 deletions(-) diff --git a/gcc/gimple.h b/gcc/gimple.h index 3047ab4..a031c8d 100644 --- a/gcc/

Re: Ping^6: contribute Synopsys Designware ARC port

2013-10-01 Thread Diego Novillo
On Sat, Sep 28, 2013 at 9:54 AM, Joern Rennecke wrote: > The main part of the port (everything but the testsuite) is still waiting > for review: > http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00323.html > http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00324.html > http://gcc.gnu.org/ml/gcc-patches/2

Re: Ping^6: contribute Synopsys Designware ARC port

2013-10-01 Thread Diego Novillo
On Tue, Oct 1, 2013 at 10:10 AM, Joern Rennecke wrote: > Yes. Claudiu Zissulescu at Synopsys would in principle be available as > co-maintainer, but I suppose it is customary to apply for write-after- > approval status first. I'm not sure. A question for the SC. >> SC folks, could you appoint

Re: Ping^6: contribute Synopsys Designware ARC port

2013-10-01 Thread Diego Novillo
On Sat, Sep 28, 2013 at 9:54 AM, Joern Rennecke wrote: > The main part of the port (everything but the testsuite) is still waiting > for review: > http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00323.html > http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00324.html > http://gcc.gnu.org/ml/gcc-patches/2

Re: GTY on simple struct (Was: Re: Ping^6: contribute Synopsys Designware ARC port)

2013-10-01 Thread Diego Novillo
On Tue, Oct 1, 2013 at 5:50 PM, Joern Rennecke wrote: > Quoting Diego Novillo : > >> No need to mark struct arc_frame_info with GTY. It contains no pointers. > > > That's not quite how it works. machine_function needs GTY. It uses > arc_frame_info, hence arc_fr

Re: Merge C++ conversion into trunk (4/6 - hash table rewrite)

2012-09-28 Thread Diego Novillo
On Fri, Sep 28, 2012 at 12:40 PM, Lawrence Crowl wrote: > On 9/28/12, Michael Matz wrote: >> >> I would even prefer 'e' over value_type. It's scoped, the context always >> will be clear, no need to be verbose in that name. I find the long names >> inelegant, as most of the standard libs convent

Re: [PATCH] limited C++ parsing support for gengtype

2012-10-02 Thread Diego Novillo
Aaron, I'm currently fixing other issues with gengtype and I needed this patch on top of them. I will be rolling both patches into a single one and commit them today/tomorrow. If you were working on further fixes to this, please give me a chance to commit this one first. Thanks. Diego.

Re: Use conditional casting with symtab_node

2012-10-04 Thread Diego Novillo
On Thu, Oct 4, 2012 at 2:14 PM, Lawrence Crowl wrote: > So, Jan Hubicka requested and approved the current spelling. > What now? I don't think we should hold this up. The names Jan requested seem reasonable enough. We seem to be running in circles here. Diego.

Re: Use conditional casting with symtab_node

2012-10-05 Thread Diego Novillo
On Fri, Oct 5, 2012 at 7:05 AM, Richard Guenther wrote: > Sorry, that wasn't intended. I question these numbers because > unless you bootstrap say 100 times the noise in bootstrap speed > is way too high to make such claims. Of course critical information > is missing: I agree with Nathan. Yo

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Diego Novillo
On Fri, Oct 5, 2012 at 6:08 PM, Lawrence Crowl wrote: >> For many people the time to compile (almost) empty file is very >> important, we are already bad about that right now, initializing >> too much stuff dynamically is going to make it worse. > > So far, we are looking at dynamic initializatio

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Diego Novillo
On Wed, Oct 3, 2012 at 6:46 PM, Lawrence Crowl wrote: > On 10/2/12, Richard Guenther wrote: >> You are changing a hashtable used by fold checking, did you test >> with fold checking enabled? > > One small thinko fixed. Patch passes tests. > >> The cfg.c, dse.c and hash-table.h parts are ok for

Re: [google] Emit relative addresses to function patch sections instead of absolute addresses. (issue6572065)

2012-10-05 Thread Diego Novillo
Harshit, why didn't you propose this patch for trunk? Why should we make it a google-local patch? Diego. On Fri, Sep 28, 2012 at 5:24 AM, Harshit Chopra wrote: > commit fc3a55ccec9bc770c79f8a221f5abd397befc8f6 > Author: Harshit Chopra > Date: Thu Sep 20 17:49:59 2012 -0700 > > Instead o

Re: [google] Emit relative addresses to function patch sections instead of absolute addresses. (issue6572065)

2012-10-05 Thread Diego Novillo
Harshit, why didn't you propose this patch for trunk? Why should we make it a google-local patch? Diego. On Fri, Sep 28, 2012 at 5:24 AM, Harshit Chopra wrote: > commit fc3a55ccec9bc770c79f8a221f5abd397befc8f6 > Author: Harshit Chopra > Date: Thu Sep 20 17:49:59 2012 -0700 > > Instead o

Re: [google] Emit relative addresses to function patch sections instead of absolute addresses. (issue6572065)

2012-10-05 Thread Diego Novillo
On Fri, Oct 5, 2012 at 6:53 PM, Diego Novillo wrote: > Harshit, why didn't you propose this patch for trunk? Why should we > make it a google-local patch? In the meantime, let's put it in the google branches. Please make sure that you ping the upstream patch. It will need m

[RFA] Support common C++ declarations inside GTY'd structures

2012-10-06 Thread Diego Novillo
cture, the code would not compile, and (b) all the other alternatives required making the parser much more convoluted and I'm trying hard not to make gengtype parser too smart. Tested on x86_64. OK for trunk? 2012-10-05 Aaron Gray Diego Novillo * gengtype-lex.l: Suppor

Re: handle isl and cloog in contrib/download_prerequisites

2012-10-06 Thread Diego Novillo
On 2012-10-06 13:30 , Manuel López-Ibáñez wrote: +download_prerequisite() { +WHAT=$1 +VERSION=$2 +PACK=$3 +case $PACK in +tar.bz2) TARX="j";; +tar.gz) TARX="z";; +esac GNU tar has not needed 'j' or 'z' for a while. Not sure whether other tars have the sam

Re: [PATCH] Fixup MAINTAINERS for surename change

2012-10-10 Thread Diego Novillo
On 2012-10-10 09:33 , Ian Lance Taylor wrote: with at once. Perhaps "Rick" would be a good choice. Last name "Astley"? Include links to videos, please.

[asan] New transitional branch to port ASAN to trunk

2012-10-10 Thread Diego Novillo
I have created a temporary branch to host the port of ASAN to trunk. Wei has done the initial port of the original code from Kostya. It compiles but we still do not have the runtimes (Wei is working on that). I have not touched nor reviewed the code in detail. Right now I'm interested in puttin

Re: [asan] New transitional branch to port ASAN to trunk

2012-10-10 Thread Diego Novillo
On Wed, Oct 10, 2012 at 4:20 PM, Diego Novillo wrote: > I have created a temporary branch to host the port of ASAN to > trunk. Wei has done the initial port of the original code from > Kostya. It compiles but we still do not have the runtimes (Wei > is working on that). The bran

Re: [asan] New transitional branch to port ASAN to trunk

2012-10-10 Thread Diego Novillo
On 2012-10-10 16:21 , Diego Novillo wrote: On Wed, Oct 10, 2012 at 4:20 PM, Diego Novillo wrote: I have created a temporary branch to host the port of ASAN to trunk. Wei has done the initial port of the original code from Kostya. It compiles but we still do not have the runtimes (Wei is

Re: [asan] New transitional branch to port ASAN to trunk

2012-10-10 Thread Diego Novillo
On 2012-10-10 16:48 , Steven Bosscher wrote: On Wed, Oct 10, 2012 at 10:20 PM, Diego Novillo wrote: * tree-asan.c: New file. * tree-asan.h: New file. Nit: do we still need the "tree-" prefix? IMHO not. Good point. I'll rename them to asan.[ch]. Diego.

Re: [asan] New transitional branch to port ASAN to trunk

2012-10-10 Thread Diego Novillo
On 2012-10-10 16:52 , Andrew Pinski wrote: On Wed, Oct 10, 2012 at 1:48 PM, Steven Bosscher wrote: On Wed, Oct 10, 2012 at 10:20 PM, Diego Novillo wrote: * tree-asan.c: New file. * tree-asan.h: New file. Nit: do we still need the "tree-" prefix? IMHO not. Rich

Re: Use conditional casting with symtab_node

2012-10-10 Thread Diego Novillo
On Tue, Oct 9, 2012 at 8:03 PM, Lawrence Crowl wrote: > I would like some clarity. Can I commit this patch? I'm thinking, yes. I will be making the gengtype changes in time for stage 1, so further renames can continue after those patches are in. Jan, Richard? Any strong objections? Diego.

[asan] Rename tree-asan.[ch] to asan.[ch]

2012-10-11 Thread Diego Novillo
As discussed earlier, this patch renames tree-asan.[ch] to asan.[ch]. Tested on x86_64. Committed to branch. Diego. * asan.c: Rename from tree-asan.c. Update all users. * asan.h: Rename from tree-asan.h Update all users.

Re: [asan] Target hook for shadow memory offset

2012-10-11 Thread Diego Novillo
On 2012-10-11 10:32 , Jakub Jelinek wrote: 2012-10-11 Jakub Jelinek * toplev.c (process_options): Warn and turn off -fasan if not supported by target. * asan.c: Include target.h. (asan_scale, asan_offset_log_32, asan_offset_log_64, asan_offset_log): Re

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-11 Thread Diego Novillo
On 2012-10-11 12:38 , Jakub Jelinek wrote: - gimple_seq seq, stmts; - tree shadow_type = size_in_bytes == 16 ? - short_integer_type_node : char_type_node; - tree shadow_ptr_type = build_pointer_type (shadow_type); - tree uintptr_type = lang_hooks.types.type_for_mode (ptr_mode, -

Add usage documentation for hash_table

2012-10-12 Thread Diego Novillo
Add usage documentation for hash_table. Andrew, does this help? Lawrence, I think I've gotten the details right, but please confirm. Tested by re-building stage 1. * hash-table.h: Add usage documentation. Tidy formatting. diff --git a/gcc/hash-table.h b/gcc/hash-table.h index

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-12 Thread Diego Novillo
On 2012-10-11 19:19 , Wei Mi wrote:> Hi, > > Here is the initial test results of gcc asan patch, and it shows us > some missing features in gcc but existing in llvm. > [1]. gcc regression test for gcc-asan passes. > [2]. llvm regression tests for gcc-asan: 18 failures in 123 for tests > written in

Re: [RFA] Support common C++ declarations inside GTY'd structures

2012-10-12 Thread Diego Novillo
On 2012-10-11 13:55 , Laurynas Biveinis wrote: static void -consume_until_semi (bool immediate) +consume_until_eos (void) { - if (immediate && token () != ';') -require (';'); for (;;) switch (token ()) { case ';': advance (); return; - d

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-12 Thread Diego Novillo
On 2012-10-12 11:01 , Rainer Orth wrote: Diego Novillo writes: 3- To run ASAN's testsuite, I propose a simple wrapper script that executes it using the just-built gcc. I don't think it's worth the pain to convert the testsuite into DejaGNU. If the testsuite is not converte

Re: [asan] Small cleanups

2012-10-12 Thread Diego Novillo
On 2012-10-12 12:19 , Jakub Jelinek wrote: 2012-10-12 Jakub Jelinek * asan.c (build_check_stmt): Rename join_bb variable to else_bb. (gate_asan_O0): New function. (pass_asan_O0): New variable. * passes.c (init_optimization_passes): Add pass_asan_O0. *

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-12 Thread Diego Novillo
On 2012-10-12 12:40 , Jakub Jelinek wrote: On Fri, Oct 12, 2012 at 11:51:22AM -0400, Diego Novillo wrote: On 2012-10-12 11:01 , Rainer Orth wrote: Diego Novillo writes: 3- To run ASAN's testsuite, I propose a simple wrapper script that executes it using the just-built gcc. I don&#x

Re: PR fortran/51727: make module files reproducible, question on C++ in gcc

2012-10-13 Thread Diego Novillo
On 2012-10-13 09:26 , Tobias Schlüter wrote: Hi, first a question also to non-gfortraners: if I want to use std::map, where do I "#include "? In system.h? No. Ada includes system.h in pure C code. Why not include it exactly where you need it? Diego.

Re: PR fortran/51727: make module files reproducible, question on C++ in gcc

2012-10-13 Thread Diego Novillo
On 2012-10-13 14:04 , Tobias Schlüter wrote: On 2012-10-13 20:00, Diego Novillo wrote: On 2012-10-13 09:26 , Tobias Schlüter wrote: first a question also to non-gfortraners: if I want to use std::map, where do I "#include "? In system.h? No. Ada includes system.h in pure C code

Re: Add usage documentation for hash_table

2012-10-13 Thread Diego Novillo
On 2012-10-13 14:40 , Lawrence Crowl wrote: On 10/12/12, Diego Novillo wrote: Add usage documentation for hash_table. Andrew, does this help? Lawrence, I think I've gotten the details right, but please confirm. The patch merges the descriptor class with the element class, which we d

Re: Use conditional casting with symtab_node

2012-10-14 Thread Diego Novillo
On Fri, Oct 12, 2012 at 4:22 AM, Richard Biener wrote: > I also think that instead of > >>> if (cgraph_node *q = p->cast_to ()) > > we want > > if ((q = cast_to (p)) > > I see absolutely no good reason to make cast_to a member, given > that the language has static_cast, const_cast and stuff

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-15 Thread Diego Novillo
On Mon, Oct 15, 2012 at 11:55 AM, Ian Lance Taylor wrote: > In my opinion, supporting the full range of GCC testsuite annotations > means imposing a lot of mechanism that the Go testsuite does not > require. It would complicate the Go testsuite for no benefit. > Anybody who can understand the GC

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-16 Thread Diego Novillo
On 2012-10-16 07:05 , Rainer Orth wrote: Diego Novillo writes: On Mon, Oct 15, 2012 at 11:55 AM, Ian Lance Taylor wrote: In my opinion, supporting the full range of GCC testsuite annotations means imposing a lot of mechanism that the Go testsuite does not require. It would complicate the

[RFC] VEC interface overhaul

2012-10-16 Thread Diego Novillo
05, 2006, 2007, 2008, 2010, 2011, 2012 Free Software Foundation, Inc. Contributed by Nathan Sidwell Re-implemented in C++ by Diego Novillo This file is part of GCC. GCC is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as publ

Re: [PATCH][RFC] Re-organize how we stream trees in LTO

2012-10-16 Thread Diego Novillo
On 2012-10-16 10:43 , Richard Biener wrote: This patch shows work-in-progress (read: implementation uglyness hopefully to vanish ...) regarding to moving LTO type merging work from WPA to compile stage. You mean to LTRANS, the stage after WPA, right? The patch re-organizes lto_output_tree (t

Re: [PATCH][google] Add warning flags for clang compatibility

2012-10-16 Thread Diego Novillo
On Tue, Oct 16, 2012 at 3:19 PM, Delesley Hutchins wrote: > This patch adds the clang thread safety warning flags as recognized > warning flags that do nothing, for command-line compatibility with > clang. Enclosed patch is for branches/google/gcc-4_6, I have > identical patches for google/gcc-4_

Re: [asan] Emit GIMPLE directly, small cleanups

2012-10-16 Thread Diego Novillo
On 2012-10-16 18:50 , Ian Lance Taylor wrote: That is fine with me as long as we acknowledge that the upstream sources don't care about GCC and will think it is absurd that they should modify their code to carry untested and unmaintained GCC-specific annotations. It would be one thing if the GC

Re: [RFC] VEC interface overhaul

2012-10-17 Thread Diego Novillo
On 2012-10-17 06:14 , Richard Biener wrote: Can't we implement vec_e as vec by means of a partial specialization? Ah, yes, that's certainly possible and prevents renaming the types in the future. I have not yet implemented the "fast" vectors from my proposal. Those would be useful for free

Re: [asan] Protection of globals

2012-10-17 Thread Diego Novillo
On 2012-10-17 07:11 , Jakub Jelinek wrote: 2012-10-17 Jakub Jelinek * varasm.c: Include asan.h. (assemble_noswitch_variable): Grow size by asan_red_zone_size if decl is asan protected. (place_block_symbol): Likewise. (assemble_variable): If decl is asa

Re: [asan] Protection of stack vars (take 3)

2012-10-17 Thread Diego Novillo
On 2012-10-17 05:35 , Jakub Jelinek wrote: 2012-10-17 Jakub Jelinek * Makefile.in (asan.o): Depend on $(EXPR_H) $(OPTABS_H). (cfgexpand.o): Depend on asan.h. * asan.c: Include expr.h and optabs.h. (asan_shadow_set): New variable. (asan_shadow_cst, asan

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-19 Thread Diego Novillo
On 2012-10-12 18:19 , Sriraman Tallam wrote: When the front-end sees more than one decl for "foo", it calls a target hook to determine if they are versions. To prevent duplicate definition errors with other versions of "foo", "decls_match" function in cp/decl.c is made to return false when 2

Re: Plan to merge LRA.

2012-10-19 Thread Diego Novillo
On 2012-10-19 10:31 , Vladimir Makarov wrote: So my plan is to merge trunk into LRA branch first and, if it looks ok, commit LRA to the trunk on Sunday to be ready solve problems (if there are any) starting Monday morning EST. LRA merge will affect only x86/x86-64 target. If you suspect any

Re: Plan to merge LRA.

2012-10-19 Thread Diego Novillo
On 2012-10-19 11:51 , Vladimir Makarov wrote: I counted 4 vectors (with about 25 lines referencing them). One vector (point_freq_vec) is analogous to IRA. Perfect. That shouldn't be hard at all then. Thanks. Diego.

Re: [asan] migrate runtime from llvm

2012-10-19 Thread Diego Novillo
On 2012-10-19 13:16 , Xinliang David Li wrote: Other than that, if there are no other comments, the change is good to check into the branch. Remaining bugs can always be found and fixed later. Agreed. David, could you commit the patch after Wei has addressed your feedback? I have just commi

Re: [asan] migrate runtime from llvm

2012-10-19 Thread Diego Novillo
On Fri, Oct 19, 2012 at 3:52 PM, Xinliang David Li wrote: > The library builds fine with the following diff. The file acinclude.m4 > is cloned from libmudflap. This is OK with the corresponding ChangeLog entry (in ChangeLog.asan). Diego.

Re: [asan] migrate runtime from llvm

2012-10-25 Thread Diego Novillo
On Thu, Oct 25, 2012 at 12:48 PM, Xinliang David Li wrote: > On Thu, Oct 25, 2012 at 9:39 AM, Jakub Jelinek wrote: >> >> librt is a very bad name, that clashes with glibc librt, would only create >> confusion. > > Ok, then we should pick something that is not confusing but reflect > the fact the

Re: [asan] migrate runtime from llvm

2012-10-25 Thread Diego Novillo
On Thu, Oct 25, 2012 at 1:24 PM, Xinliang David Li wrote: > I don't know why you think so (It seems that the points mentioned in > http://www.akkadia.org/drepper/no_static_linking.html mainly apply to > release binaries, not sanitized ones), but for now let's drop the > static link request. Yeah

Re: Change hash_table for separate comparator, documentation, cleanups...

2012-10-25 Thread Diego Novillo
On Thu, Oct 25, 2012 at 5:03 PM, Lawrence Crowl wrote: > Change hash_table to support a comparator type different from the > value type stored in the hash table. The 'find' functions now may > take a different type from the value type. This requires introducing > a second typedef into the Descri

Re: [asan] a small patch to fix bogus error about global buffer overflow

2012-10-25 Thread Diego Novillo
On Thu, Oct 25, 2012 at 5:32 PM, Wei Mi wrote: > Hi, > > A small patch to remove the bogus error reports exposed in the > spec2000 testing. In varasm.c, asan_protected should be equivalent > with asan_protect_global (decl) all the time, or else compiler will > not insert redzones for some globals

Re: [asan] New transitional branch to port ASAN to trunk

2012-10-26 Thread Diego Novillo
On Fri, Oct 26, 2012 at 4:40 AM, Kostya Serebryany wrote: > One thing I overlooked before. > In the gcc patch we are using -fasan flag name, while clang uses > -f[no-]address-sanitizer > (it used to be -fasan in early patches, but was renamed before submitting to > trunk). > Do we want to be flag-

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-26 Thread Diego Novillo
On Fri, Oct 19, 2012 at 10:33 PM, Sriraman Tallam wrote: Yes, the support is only for C++ for now. "target" attribute is not new and if the user tries to use this with 'C' then a duplicate defintion error would occur just like now. I have plans to implement this for C too. Would it be hard t

Re: [patch] Unify bitmap interface.

2012-10-29 Thread Diego Novillo
On Thu, Oct 25, 2012 at 6:39 PM, Lawrence Crowl wrote: > The sbitmap non-bool returning bitwise operations have been merged with > the bool versions. Sometimes this merge involved modifying the non-bool > version to compute the bool value, and sometimes modifying bool version to > add additional

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
Arnaud, After updating my tree to rev 192942 this morning, I'm getting a bootstrap failure with ada enabled: raised CONSTRAINT_ERROR : a-comlin.adb:65 explicit raise make[6]: *** [rts/s-oscons.ads] Error 1 make[6]: Leaving directory `bld-gcc/gcc/ada' make[5]: *** [gnatlib-shared-default] Error 2

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 10:36 AM, Arnaud Charlet wrote: >> After updating my tree to rev 192942 this morning, I'm getting a >> bootstrap failure with ada enabled: > > Looks like make did not rebuild (or too late?) xoscons. > > I'd suggest doing a rm -rf gcc/ada/bldtools from your obj directory and

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 10:39 AM, Arnaud Charlet wrote: >> Well, this was a build from scratch. Maybe there is a parallel make >> bug in the new ada changes? Some undeclared dependency? > > There is not in the recent changes. Maybe there's a latent bug, although I > have never experienced it. >

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 10:44 AM, Arnaud Charlet wrote: >> >> Well, this was a build from scratch. Maybe there is a parallel make >> >> bug in the new ada changes? Some undeclared dependency? >> > >> > There is not in the recent changes. Maybe there's a latent bug, although I >> > have never exp

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 10:48 AM, Diego Novillo wrote: > On Mon, Oct 29, 2012 at 10:44 AM, Arnaud Charlet wrote: >>> >> Well, this was a build from scratch. Maybe there is a parallel make >>> >> bug in the new ada changes? Some undeclared dependency? >&

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 10:51 AM, Arnaud Charlet wrote: >> Yup, it does: > > OK then can you check the timestamp of ./gcc/ada/bldtools/oscons/xoscons > vs e.g. ./gcc/ada/bldtools/oscons/xoscons/xoscons.adb and > $(srcdir)/gcc/ada/xoscons.adb? I have no directory called gcc/ada/bldtools/oscons/xos

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 12:29 PM, Arnaud Charlet wrote: > Committed on trunk now. Sorry for the breakage, my build was incremental > and missed this missing part. Great. Thanks for the quick fix! Diego.

Re: [patch] Unify bitmap interface.

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 2:46 PM, Lawrence Crowl wrote: > Okay, but I point out that there is an awful lot of #if 0 code > out there. I would rather have done such removal in a followup > patch. Sure. But the point is not to add more. We should mechanically strip all the #if 0 code from the tr

Re: [patch] Unify bitmap interface.

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 2:54 PM, Diego Novillo wrote: > Just to make sure. Testing on ppc should be fast, for example. And useless. Your patch does not touch ppc. Diego.

Re: [patch] Unify bitmap interface.

2012-10-30 Thread Diego Novillo
On Tue, Oct 30, 2012 at 2:17 AM, Bin.Cheng wrote: > On Tue, Oct 30, 2012 at 8:23 AM, Lawrence Crowl wrote: >> On 10/29/12, Diego Novillo wrote: >>> On Oct 29, 2012 Diego Novillo wrote: >>> > Just to make sure. Testing on ppc should be fast, for example. >>

Re: [patch] Unify bitmap interface.

2012-10-30 Thread Diego Novillo
On Mon, Oct 29, 2012 at 4:25 PM, Steven Bosscher wrote: > On Mon, Oct 29, 2012 at 7:54 PM, Diego Novillo wrote: > >> Sure. But the point is not to add more. We should mechanically strip >> all the #if 0 code from the tree, btw. No point keeping all that >> garbage arou

Re: [patch] Apply conditional down cast to cgraph.h et.al.

2012-10-30 Thread Diego Novillo
On 2012-10-29 15:01 , Lawrence Crowl wrote: On 10/27/12, Marc Glisse wrote: On Fri, 26 Oct 2012, Lawrence Crowl wrote: 2012-10-26 Lawrence Crowl missing '>' Fixed. * is-a.h: New. (is_a (U*)): New. Test for is-a relationship. (as_a (U*)): New. Treat as a deri

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-10-30 Thread Diego Novillo
On Mon, Oct 29, 2012 at 1:56 PM, Jakub Jelinek wrote: > Status > == > > I'd like to close the stage 1 phase of GCC 4.8 development > on Monday, November 5th. If you have still patches for new features you'd > like to see in GCC 4.8, please post them for review soon. Patches > posted before t

Re: [patch] Apply conditional down cast to cgraph.h et.al.

2012-10-30 Thread Diego Novillo
On Tue, Oct 30, 2012 at 4:53 PM, Lawrence Crowl wrote: > On 10/30/12, Diego Novillo wrote: >> >> So, to use these three functions, the user must define this single >> 'is_a_helper' routine? Nothing else? > > You need to distinguish which kind user. Someo

Re: [Ada] Fix Makefile dependencies of C files

2012-10-31 Thread Diego Novillo
On Tue, Oct 30, 2012 at 6:50 PM, Eric Botcazou wrote: > This will hopefully fix the build failure reported by Diego. Apart from > adding missing dependencies, this also removes redundant command lines. > > Tested on x86_64-suse-linux, applied on the mainline and 4.7 branch. > > > 2012-10-30 Eric

Re: [patch] The remainder of tree-flow.h refactored.

2013-10-09 Thread Diego Novillo
On Wed, Oct 9, 2013 at 11:37 AM, Andrew MacLeod wrote: > bootstraps on x86_64-unknown-linux-gnu, regressions test are still running. > OK? Sure.

Re: [PATCH][i386]Fix PR 57756

2013-10-17 Thread Diego Novillo
On Wed, Oct 16, 2013 at 6:06 PM, David Edelsohn wrote: > How is Google going to change its patch commit policies to ensure that > this does not happen again? There is nothing to change. Google follows http://gcc.gnu.org/contribute.html, like everyone else. Sri just fixed the oversight and if th

Re-factor inclusion of tree.h

2013-10-21 Thread Diego Novillo
ovmem. (ix86_expand_setmem): Call ix86_expand_set_or_movmem. +2013-10-21 Diego Novillo + + * asan.c: Include tree.h + * bb-reorder.c: Likewise. + * cfgcleanup.c: Likewise. + * cfgloopmanip.c: Likewise. + * data-streamer-in.c: Likewise. + * data-str

Re: Re-factor inclusion of tree.h

2013-10-21 Thread Diego Novillo
On Mon, Oct 21, 2013 at 12:57 PM, Jeff Law wrote: > On 10/21/13 10:52, Diego Novillo wrote: >> >> I plan to commit this by tomorrow, unless there are objections. > > I can't think of a good reason to even bother waiting :-) Heh, OK, thanks. After analyzing all th

Re: [PATCH][buildrobot] tilepro/tilegx: fallout after tree.h refactoring (was: Re-factor inclusion of tree.h)

2013-10-22 Thread Diego Novillo
On Tue, Oct 22, 2013 at 4:22 AM, Jan-Benedict Glaw wrote: > On Mon, 2013-10-21 15:36:49 -0400, Diego Novillo wrote: >> Can anyone think of some way that we can use to automatically block >> inclusions of tree.h from header files? Code review is the only way >> that comes t

Re: [patch] Flatten tree-ssa-loops.h

2013-10-23 Thread Diego Novillo
On Wed, Oct 23, 2013 at 10:27 AM, Andrew MacLeod wrote: > Similar to tree-ssa.h, tree-ssa-loops.h became an aggregator for 3 of the > tree-ssa-loop* header files. This remedies that situation. > > The average .c file required only 1 of the 3 includes from tree-ssa-loop.h. > > Bootstraps on x86_6

Re: [PATCH] rewrite stack vectors

2013-10-25 Thread Diego Novillo
On 2013-10-10 14:07 , tsaund...@mozilla.com wrote: This makes the implementation of stack vectors simpler and easier to use. This works by making

Re: [PATCH] Support multiline GTY markers in Doxygen filter; add unittests

2013-11-01 Thread Diego Novillo
On Thu, Oct 31, 2013 at 4:06 PM, David Malcolm wrote: > It's possible to run GCC's sources through Doxygen by setting > INPUT_FILTER = contrib/filter_gcc_for_doxygen > within contrib/gcc.doxy and invoking doxygen on the latter file. > > The script filters out various preprocessor

Re: [PATCH] use stack vectors more

2013-11-01 Thread Diego Novillo
On Thu, Oct 31, 2013 at 7:48 PM, wrote: > From: Trevor Saunders > > Hi, > > This patch is pretty dull, it just replaces a bunch of things of the form > vec x; > x.create (N); // N is a constant > blah blah > x.release (); > by > stack_vec x; > blah blah > > Of course its even nicer than that in

Re: [PATCH] use stack vectors more

2013-11-01 Thread Diego Novillo
On Fri, Nov 1, 2013 at 3:33 PM, Trevor Saunders wrote: >> The patch is OK, but it did not completely apply in my tree. Mind >> sending an updated version (or point me at a git repo I can pull it >> from). > > interesting, I just pulled and rebased it onto r204296 without any manual > merging. Pat

  1   2   3   4   5   6   7   8   9   10   >