[PATCH,DWARF,v2] AIX dwarf2out label fix

2017-05-18 Thread David Edelsohn
This version adds a macro DWARF_INITIAL_LENGTH_SIZE_STR based on DWARF_OFFSET_SIZE to define the string expression to append to the label to correct the offset. Because AIX Assembler inserts the section length, the section label generated by GCC points to the wrong location and must be adjusted wh

Re: [PATCH,DWARF,v2] AIX dwarf2out label fix PING

2017-06-01 Thread David Edelsohn
Ping https://gcc.gnu.org/ml/gcc-patches/2017-05/msg01440.html Thanks, David

Re: [PATCH,DWARF,v2] AIX dwarf2out label fix

2017-06-01 Thread David Edelsohn
On Thu, Jun 1, 2017 at 3:03 PM, Jason Merrill wrote: > On 05/18/2017 06:00 AM, David Edelsohn wrote: >> >> This version adds a macro DWARF_INITIAL_LENGTH_SIZE_STR based on >> DWARF_OFFSET_SIZE to define the string expression to append to the >> label to correct th

Re: [PATCH] PR 78534 Change character length from int to size_t

2017-01-03 Thread David Edelsohn
This patch broke bootstrap. I now am seeing numerous errors when building libgomp. Please fix or revert immediately. Thanks, David omp_lib.f90:184:40: logical (4) :: omp_test_lock 1 Error: Symbol 'omp_test_lock' at (1) has already been host

Re: [PATCH], PR target/78900, Fix PowerPC __float128 signbit

2017-01-03 Thread David Edelsohn
On Fri, Dec 30, 2016 at 3:54 PM, Michael Meissner wrote: > The signbit-3.c test explicitly tests for the value coming from memory, a > vector register, or a GPR. Unfortunately, the code did not handle splitting > up > the registers when the value was in a GPR. > > These patches add teh GPR suppo

Re: [PATCH], PR tqrget/78953, Fix power9 insn does not meet its constraints

2017-01-03 Thread David Edelsohn
On Tue, Jan 3, 2017 at 4:43 PM, Michael Meissner wrote: > In builting Spec 2006 with -mcpu=power9 with -O3, two of the benchmarks > (gamess > and calculix) did not build due to an "insn does not match its constraints" > error. > > (insn 2674 2673 2675 37 (parallel [ > (set (reg:SI 0 0

Re: [PATCH], PR 71977/70568/78823: Improve PowerPC code that uses SFmode in unions

2017-01-04 Thread David Edelsohn
On Thu, Dec 29, 2016 at 7:24 PM, Michael Meissner wrote: Mike, Thanks for the tremendous effort on this patch. A few comments. The ChangeLog contains a lot of extraneous commentary that should be in the documentation comments. And a few typos in comments. > * config/rs6000/predicates

Re: [PATCH], PR 71977/70568/78823: Improve PowerPC code that uses SFmode in unions

2017-01-04 Thread David Edelsohn
On Wed, Jan 4, 2017 at 4:00 PM, Michael Meissner wrote: > On Wed, Jan 04, 2017 at 02:17:16PM -0500, David Edelsohn wrote: >> The change to rs6000_emit_move() really should have been in a helper >> function. We have to stop adding to the complexity of the function. I >>

Re: [PATCH] PR 78534 Change character length from int to size_t

2017-01-13 Thread David Edelsohn
On Fri, Jan 13, 2017 at 12:09 PM, Janne Blomqvist wrote: > On Thu, Jan 12, 2017 at 10:46 AM, FX wrote: >>> I was finally able to get a 32-bit i686 compiler going (my attempts to >>> do this on a x86_64-pc-linux-gnu host failed, in the end I resorted to >>> running 32-bit builds/tests on a i686 co

Re: Fix ppc64le bootstrap comparison failure

2017-01-14 Thread David Edelsohn
Jeff, The ppc64le bootstrap comparison may have been fixed, but I continue to see the additional testsuite failures on AIX, all of the form: internal compiler error: in fill_vec_av_set, at sel-sched.c:3712 I rolled back the earlier version of DSE patch and the failures were resolved, so it defin

Re: Fix ppc64le bootstrap comparison failure

2017-01-14 Thread David Edelsohn
On Sat, Jan 14, 2017 at 11:46 AM, Jeff Law wrote: > On 01/14/2017 08:49 AM, David Edelsohn wrote: >> >> Jeff, >> >> The ppc64le bootstrap comparison may have been fixed, but I continue >> to see the additional testsuite failures on AIX, all of the form:

Re: [C++ Patch] PR 71737

2017-01-16 Thread David Edelsohn
This patch caused a libstdc++ regression on AIX libstdc++-v3/include/tr1/shared_ptr.h:556: internal compiler error: tree check: expected class 'type', have 'exceptional' (error_mark) in build_variant_type_copy, at tree.c:6737

Re: [PATCH] -mstack-protector-guard and friends (PR78875)

2017-01-17 Thread David Edelsohn
On Tue, Jan 17, 2017 at 12:43 PM, Segher Boessenkool wrote: > Currently, on PowerPC, code compiled with -fstack-protector will load > the canary from -0x7010(13) (for -m64) or from -0x7008(2) (for -m32) > if GCC was compiled against GNU libc 2.4 or newer or some other libc > that supports -fstack-

Re: [PATCH] rs6000: Fix the new SSP guard configuration code (PR79140)

2017-01-19 Thread David Edelsohn
On Thu, Jan 19, 2017 at 6:00 PM, Segher Boessenkool wrote: > I foolishly tested this with r241087 reverted. After that revision > default_stack_protect_guard is no longer called if the compiler defaults > to using the TLS guard, which of course is the wrong thing to do if > there is some other wa

Re: Implement -Wduplicated-branches (PR c/64279) (v3)

2017-01-20 Thread David Edelsohn
This patch introduced a new testsuite failure: FAIL: g++.dg/warn/Wduplicated-branches1.C -std=gnu++98 (test for excess errors) Excess errors: /nasfarm/edelsohn/src/src/gcc/testsuite/g++.dg/warn/Wduplicated-branches1.C:9:3: warning: this condition has identical branches [-Wduplicated-branches] /n

Re: [PATCH] PR libstdc++/79195 fix make_array type deduction

2017-01-23 Thread David Edelsohn
FAIL: experimental/array/make_array.cc (test for excess errors) Excess errors: /nasfarm/edelsohn/src/src/libstdc++v3/testsuite/experimental/array/make_array.cc:38: error: 'ref' is not a member of 'std'

Re: [PATCH] Enable -fsanitize=thread and =leak support on ppc64{,le}

2017-01-23 Thread David Edelsohn
On Mon, Jan 23, 2017 at 7:20 PM, Jakub Jelinek wrote: > Hi! > > On Mon, Jan 23, 2017 at 03:32:46PM +0100, Jakub Jelinek wrote: >> I think it should be enabled if it works, even this late. >> I bet we need something like the following patch on top of >> the PR79168 patch. >> >> I'll test both patch

Re: Fix ICE with -Wduplicated-branches (PR c/79199)

2017-01-26 Thread David Edelsohn
I'm receiving the following error message for the new testcase: FAIL: c-c++-common/Wduplicated-branches-13.c -std=gnu++98 (test for excess errors) Excess errors: /nasfarm/edelsohn/src/src/gcc/testsuite/c-c++-common/Wduplicated-branches-13.c:11:7: warning: this decimal constant is unsigned only in

Re: [PATCH] For broken exception handling in GDB on AIX platform

2017-03-26 Thread David Edelsohn
Nitish works for IBM and I can stand in as the contributor. The patch would be very helpful to work around an AIX exception handling problem. Because the patch is a generic option and not target-specific, it needs a build machinery maintainer or Global Reviewer to approve. Thanks, David

Re: [PATCH] Real fix for AIX exception handling

2017-03-27 Thread David Edelsohn
> As far as I have discovered, the real problem with AIX exception handling is > that the exception landing pads are symbols that must not (but still are) > exported from shared libraries - even libstdc++. > > I'm wondering if attached libtool(!)-patch would fix even that GDB problem > once applied

Re: [PATCH] Real fix for AIX exception handling

2017-03-29 Thread David Edelsohn
On Wed, Mar 29, 2017 at 3:50 PM, Jeff Law wrote: > On 03/27/2017 09:41 AM, David Edelsohn wrote: >>> >>> As far as I have discovered, the real problem with AIX exception handling >>> is >>> that the exception landing pads are symbols that must not (

Re: [PATCH] Real fix for AIX exception handling

2017-03-29 Thread David Edelsohn
On Wed, Mar 29, 2017 at 4:48 PM, Jeff Law wrote: > On 03/29/2017 02:21 PM, David Edelsohn wrote: >> >> >> The problem is GCC EH tables and static linking. libstdc++ and the >> main application are ending up with two separate copies of the tables >> to registe

Re: [PATCH] Real fix for AIX exception handling

2017-03-29 Thread David Edelsohn
On Wed, Mar 29, 2017 at 5:20 PM, Jeff Law wrote: > On 03/29/2017 02:56 PM, David Edelsohn wrote: >> >> On Wed, Mar 29, 2017 at 4:48 PM, Jeff Law wrote: >>> >>> On 03/29/2017 02:21 PM, David Edelsohn wrote: >>>> >>>> >>>> >

Re: [PATCH] Real fix for AIX exception handling

2017-03-30 Thread David Edelsohn
On Thu, Mar 30, 2017 at 4:11 AM, Michael Haubenwallner wrote: > On 03/29/2017 10:21 PM, David Edelsohn wrote: >> On Wed, Mar 29, 2017 at 3:50 PM, Jeff Law wrote: >>> On 03/27/2017 09:41 AM, David Edelsohn wrote: >>>>> >>>>> As far as I have

Re: Who broke options.h?

2017-04-25 Thread David Edelsohn
On Tue, Apr 25, 2017 at 11:03 AM, David Malcolm wrote: > On Tue, 2017-04-25 at 06:59 -0700, Steve Kargl wrote: >> Someone (other than Richard who seems to have fixed his >> bootstrap issue) in the last 3 days has broken bootstrap >> on FreeBSD. The generated file gcc/options.h contains >> code of

Re: Enable Go for AIX

2017-04-26 Thread David Edelsohn
Hi, Tony Why is enabling Go the *first* patch? It seems that the support should be added before one allows it to be configured. Also, what are you trying to accomplish with the changes to "rs6000" in the target triplets. I think that you are trying to distinguish between different versions of A

Re: [PATCH] Enhance PHI processing in VN

2017-09-14 Thread David Edelsohn
* tree-ssa-sccvn.c (visit_phi): Merge undefined values similar to VN_TOP. This seems to have regressed FAIL: gcc.dg/tree-prof/time-profiler-2.c scan-ipa-dump-times profile "Read tp_first_run: 0" 2 FAIL: gcc.dg/tree-prof/time-profiler-2.c scan-ipa-dump-times profile "Read tp_first_run: 2" 1 FAIL:

Re: [PATCH] Enhance PHI processing in VN

2017-09-15 Thread David Edelsohn
On Fri, Sep 15, 2017 at 2:53 AM, Richard Biener wrote: > On Thu, 14 Sep 2017, David Edelsohn wrote: > >> * tree-ssa-sccvn.c (visit_phi): Merge undefined values similar >> to VN_TOP. >> >> This seems to have regressed >> >> FAIL: gcc.dg/tree-prof/tim

Re: [Patch, Fortran] PR 82143: add a -fdefault-real-16 flag

2017-09-25 Thread David Edelsohn
promotion_3.f90 and promotion_4.f90 are failing on at least PowerPC and AArch64. Are these new tests limited to x86 or some long double assumptions? f951: Fatal Error: REAL(KIND=16) is not available for '-fdefault-real-16' option compilation terminated. f951: Fatal Error: REAL(KIND=10) is not av

Re: [Patch, Fortran] PR 82143: add a -fdefault-real-16 flag

2017-09-26 Thread David Edelsohn
On Tue, Sep 26, 2017 at 4:44 AM, Janus Weil wrote: > 2017-09-25 23:23 GMT+02:00 Steve Kargl : >> On Mon, Sep 25, 2017 at 11:14:42PM +0200, Janus Weil wrote: >>> 2017-09-25 17:07 GMT+02:00 David Edelsohn : >>> > promotion_3.f90 and promotion_4.f90 are failing on at l

Re: [PATCH] Enhance PHI processing in VN

2017-09-27 Thread David Edelsohn
On Wed, Sep 27, 2017 at 6:58 PM, Richard Sandiford wrote: > David Edelsohn writes: >> On Fri, Sep 15, 2017 at 2:53 AM, Richard Biener wrote: >>> On Thu, 14 Sep 2017, David Edelsohn wrote: >>> >>>> * tree-ssa-sccvn.c (visit_phi): Merge undefined values

Re: [PATCH,AIX] Manage Go Closure in libffi for AIX

2017-10-03 Thread David Edelsohn
I committed the import of AIX Go support from libffi repository into the GCC copy of libffi. Thanks, David

Re: [PATCH,AIX] Fix issue with PRI*64 on AIX.

2017-10-10 Thread David Edelsohn
On Tue, Oct 10, 2017 at 5:09 AM, REIX, Tony wrote: > Description: > * This patch enables to build on AIX. > > Tests: > * AIX: Build: SUCCESS >- build made by means of gmake within GCC 8 trunk. > > ChangeLog: > * go-system.h : Enable to build on AIX. > (fix issue with PRIx64 and PRIu64)

Re: [PATCH,AIX] Fix issue with PRI*64 on AIX.

2017-10-10 Thread David Edelsohn
On Tue, Oct 10, 2017 at 10:31 AM, REIX, Tony wrote: > Hi David, > > Since the file ./gcc/go/go-system.h in GCC source code starts by: > > // go-system.h -- Go frontend inclusion of gcc header files -*- C++ -*- > // Copyright (C) 2009-2017 Free Software Foundation, Inc. > > // This file is part o

Re: [RFC] overflow safe scaling of 64bit values

2017-10-10 Thread David Edelsohn
> Any ideas for better version? If not I will go ahead with this variant and > increase profile probability base. Why not use GCC wide int? - David

[PATCH,AIX] rs6000 output_aligned_decl_common fix

2017-10-11 Thread David Edelsohn
GCC toplev.c uses ASM_OUTPUT_ALIGNED_DECL_COMMON with a NULL decl to emit the LTO marker, so the rs6000 implementation needs to test for that situation. config/darwin.c tests similarly. With this patch, gcc -flto produces correct output on AIX. Bootstrapped on powerpc-ibm-aix7.2.0.0 Thanks, Dav

Re: [PATCH, rs6000] Fix PR79268

2017-01-29 Thread David Edelsohn
On Sun, Jan 29, 2017 at 6:17 PM, Segher Boessenkool wrote: >> --- gcc/testsuite/gcc.target/powerpc/pr79268.c(revision 0) >> +++ gcc/testsuite/gcc.target/powerpc/pr79268.c(working copy) >> @@ -0,0 +1,18 @@ >> +/* { dg-do compile { target { powerpc64le-*-* } } } */ > > Is that corre

Re: [PATCH] Fix gcc-5-branch build with libc++

2017-01-31 Thread David Edelsohn
> As discussed with the FreeBSD gcc ports maintainer, building the > gcc-5-branch with libc++ requires standard C++ headers to be included > *before* gcc/system.h, otherwise the redefinition of abort() to > fancy_abort() will cause trouble. > > In trunk r235362, most gcc C++ sources were updated to

Re: [PATCH] rs6000: Mark powerpc*-*-*spe* as obsolete

2017-02-14 Thread David Edelsohn
On Tue, Feb 14, 2017 at 10:22 AM, Segher Boessenkool wrote: > As discussed in . > > Is this okay for trunk? > > > Segher > > > 2017-02-14 Segher Boessenkool > > * config.gcc (Obsolete configurations): Add powerpc*-*-*spe* . Okay. Thank

Re: [PATCH] portability fix for gcc.dg/strncmp-2.c testcase

2017-02-14 Thread David Edelsohn
On Tue, Feb 14, 2017 at 2:24 PM, Aaron Sawdey wrote: > On Tue, 2017-02-14 at 13:09 -0600, Segher Boessenkool wrote: >> On Tue, Feb 14, 2017 at 11:56:50AM -0600, Aaron Sawdey wrote: >> > This testcase I added failed to compile on AIX or older linux due >> > to >> > the use of aligned_alloc(). Now f

Re: [PATCH] PR libstdc++/79789 fix non-reserved names in headers

2017-03-03 Thread David Edelsohn
This patch caused a new regression on AIX. - David FAIL: 17_intro/names.cc (test for excess errors) Excess errors: /tmp/GCC/gcc/include-fixed/sys/types.h:600: error: expected unqualified-id before '[' token /tmp/GCC/gcc/include-fixed/sys/types.h:600: error: expected ')' before '[' token /tmp/GCC/

Re: [PATCH] PR libstdc++/79789 fix non-reserved names in headers

2017-03-10 Thread David Edelsohn
On Fri, Mar 10, 2017 at 10:20 AM, Jonathan Wakely wrote: > On 09/03/17 19:46 +, Jonathan Wakely wrote: >> >> On 03/03/17 10:47 -0500, David Edelsohn wrote: >>> >>> This patch caused a new regression on AIX. >> >> >> I'm unable to bootstr

Re: [PATCH, rs6000] Add support for xxpermr and vpermr instructions

2016-03-09 Thread David Edelsohn
On Tue, Mar 8, 2016 at 11:24 AM, Kelvin Nilsen wrote: > > This patch adds support for two new Power9 instructions, xxpermr and vpermr, > providing more efficient vector permutation operations on little-endian > configurations. These new instructions are described in the Power ISA 3.0 > document.

Re: [PATCH, rs6000] Fix PR target/70168

2016-03-10 Thread David Edelsohn
On Thu, Mar 10, 2016 at 6:10 PM, Ulrich Weigand wrote: > Hello, > > this patch fixes PR target/70168, a wrong code generation problem > caused by rs6000_expand_atomic_compare_and_swap not properly handling > the case where changing retval clobbers newval due to a register overlap. > > Tested with

Re: [PATCH], Fix PR 70131, disable (double)(int) optimization for power8

2016-03-11 Thread David Edelsohn
On Fri, Mar 11, 2016 at 5:41 PM, Michael Meissner wrote: > As I was auditing rs6000.md for power9 changes, I noticed that changes I had > made in 2010 for power7 weren't as effective with power8. > > The FCTIWZ/FCTIWUZ instructions convert the scalar floating point value to a > 32-bit signed/unsig

Re: [PATCH] rs6000: Handle "d" output in the bd*z patterns (PR70098)

2016-03-12 Thread David Edelsohn
On Sat, Mar 12, 2016 at 8:55 AM, Segher Boessenkool wrote: > In the rs6000 port, FLOAT_REGS can contain DImode values when compiling > for 64-bit targets. Some instructions (like "fcfid" in the testcase, > convert from integer to DP float) only work on floating point registers. > So, we do want t

Re: [PATCH] rs6000: Handle "d" output in the bd*z patterns (PR70098)

2016-03-13 Thread David Edelsohn
On Sun, Mar 13, 2016 at 2:52 PM, Segher Boessenkool wrote: > On Sat, Mar 12, 2016 at 09:59:12AM -0500, David Edelsohn wrote: >> > 2016-03-12 Segher Boessenkool >> > >> > PR target/70098 >> > * config/rs6000/rs6000.m

Re: [PATCH, testsuite] Fix ifcvt-4.c for PowerPC

2016-03-14 Thread David Edelsohn
On Mon, Mar 14, 2016 at 7:35 PM, Jeff Law wrote: > On 03/14/2016 02:23 PM, Pat Haugen wrote: >> >> As stated in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68232, this >> test needs -misel on powerpc to pass. Verified the following fixes the >> test on both powerpc64/powerpc64le. Ok for trunk? >>

Re: [PATCH, testsuite] Fix ifcvt-4.c for PowerPC

2016-03-15 Thread David Edelsohn
On Mon, Mar 14, 2016 at 4:23 PM, Pat Haugen wrote: > As stated in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68232, this test > needs -misel on powerpc to pass. Verified the following fixes the test on > both powerpc64/powerpc64le. Ok for trunk? > > -Pat > > testsuite/ChangeLog: > 2016-03-14 Pa

Re: [PATCH, rs6000] Add support for xxpermr and vpermr instructions

2016-03-19 Thread David Edelsohn
On Thu, Mar 17, 2016 at 2:58 PM, Kelvin Nilsen wrote: > > This patch adds support for two new Power9 instructions, xxpermr and vpermr, > providing more efficient vector permutation operations on > little-endian configurations. These new instructions are described in > the Power ISA 3.0 document.

Re: [PATCH] Fix rs6000 vector builtin macro handling if it is followed by a fn-like macro without arguments (PR target/70296)

2016-03-19 Thread David Edelsohn
On Fri, Mar 18, 2016 at 5:34 PM, Jakub Jelinek wrote: > Hi! > > The following testcase is diagnosed as errorneous, because the preprocessor > mishandles > > #define c(x) x > vector c; > > and > > #define int(x) x > vector int n; > > The thing is if a function-like macro is not followed by (, then

Re: [PATCH 1/4] [RS6000] Simplify setting of fixed_regs[RS6000_PIC_OFFSET_TABLE_REGNUM]

2016-03-21 Thread David Edelsohn
On Mon, Mar 21, 2016 at 9:06 AM, Alan Modra wrote: > This makes the conditions look the same as other places that deal with > RS6000_PIC_OFFSET_TABLE_REGNUM, eg. first_reg_to_save. No functional > changes. > > * config/rs6000/rs6000.c (rs6000_conditional_register_usage): > Remove

Re: [PATCH 2/4] [RS6000] PR69645, -ffixed-reg ignored

2016-03-21 Thread David Edelsohn
On Mon, Mar 21, 2016 at 9:06 AM, Alan Modra wrote: > Treat -ffixed-reg as we do for global asm regs. The only slightly > complicated part of this patch is that the rs6000 backend itself sets > fixed_regs[RS6000_PIC_OFFSET_TABLE_REGNUM] in some cases, which means > we can't simply test fixed_regs[

Re: [PATCH 3/4] [RS6000] Split SAVRES_STRATEGY

2016-03-21 Thread David Edelsohn
On Mon, Mar 21, 2016 at 9:07 AM, Alan Modra wrote: > No functional change here. A single bit becomes two bits, which > always have the same value at the moment. In preparation for the > next patch. > > * config/rs6000/rs6000.c (SAVRES_MULTIPLE): Replace with.. > (SAVE_STRATEGY, R

Re: [PATCH 4/4] [RS6000] Allow saving of fixed regs.

2016-03-21 Thread David Edelsohn
On Mon, Mar 21, 2016 at 9:08 AM, Alan Modra wrote: > As I noted a long time ago in the comment on fixed_reg_p, the real > problem with saving fixed/global regs is that exception frame > unwinding might restore them. So don't emit eh_frame info for any > such reg, and the unwinder won't restore th

Re: [PATCH] PR libgcc/70363, fix __float128 problem with non ISA-3.0 assembler

2016-03-22 Thread David Edelsohn
On Tue, Mar 22, 2016 at 4:33 PM, Michael Meissner wrote: > This patch fixes PR libgcc/70363, which is a configuration issue if you build > GCC 6.x with an assembler that does not support the ISA 3.0 instructions. I > missed one emulation function that needed to be a different name if the IFUNC >

Re: rs6000 stack_tie mishap again

2016-03-23 Thread David Edelsohn
First, SPE has not been maintained and little participation from Freescale. I would rather deprecate all SPE support. SPE ABI is broken by design. I find the approach very heavy-handed. If you want to enable the target hook for SPE *only*, that's fine with me. The description and references to

Re: [RS6000, PATCH] PR70052, ICE compiling _Decimal128 test case

2016-03-24 Thread David Edelsohn
On Thu, Mar 24, 2016 at 7:01 AM, Alan Modra wrote: > This fixes the PR70052 ICE by modifying easy_fp_constant to correctly > return false for decimal floating point zero. 0.0D is not an all-zero > bit pattern, at least, not the canonical form. > > I've also taken on Mike's suggestion of using a m

Re: [RS6000, PATCH] PR70052, ICE compiling _Decimal128 test case

2016-03-29 Thread David Edelsohn
On Tue, Mar 29, 2016 at 6:14 AM, Alan Modra wrote: > On Fri, Mar 25, 2016 at 07:36:34PM +1030, Alan Modra wrote: >> +2016-03-25 Alan Modra >> + >> + PR target/70052 >> + * config/rs6000/constraints.md (j): Simplify. >> + * config/rs6000/predicates.md (easy_fp_constant): Exclude >> +

Re: [PATCH] Disable guality tests for powerpc*-linux*

2016-03-29 Thread David Edelsohn
On Mon, Mar 28, 2016 at 8:38 PM, Bill Schmidt wrote: > Hi, > > For a long time we've had hundreds of failing guality tests. These > failures don't seem to have any correlation with gdb functionality for > POWER, which is working fine. At this point the value of these tests to > us seems question

Re: [PATCH, rs6000] Add support for int versions of vec_adde

2016-04-05 Thread David Edelsohn
On Tue, Apr 5, 2016 at 3:36 PM, Bill Seurer wrote: > This patch adds support for the signed and unsigned int versions of the > vec_adde altivec builtins from the Power Architecture 64-Bit ELF V2 ABI > OpenPOWER ABI for Linux Supplement (16 July 2015 Version 1.1). There are > many of the builtins

Re: [PATCH] PR70117, ppc long double isinf

2016-04-07 Thread David Edelsohn
On Thu, Apr 7, 2016 at 10:17 AM, Alan Modra wrote: > On Thu, Apr 07, 2016 at 11:32:58AM +0200, Richard Biener wrote: >> That's good to know. I think the patch is OK but please seek approval from >> a ppc maintainer as well > > There's only one of those. David? Thread starts here > https://gcc.

Re: [PATCH], Re-fix PR 70381 (disable -mfloat128 by default) and add workaround for PR 70589

2016-04-11 Thread David Edelsohn
On Thu, Apr 7, 2016 at 7:44 PM, Michael Meissner wrote: > After applying the fix for PR 70381 to not enable -mfloat128 by default, I > discovered the IEEE 128-bit floating point emulation routines in libgcc are no > longer being built. > > The reason for this is the configuration test involved com

Re: [PATCH], PR target/70640, Fix thinkos in PowerPC IEEE 128-bit floating point emulation

2016-04-12 Thread David Edelsohn
On Tue, Apr 12, 2016 at 3:11 PM, Michael Meissner wrote: > After I moved the patches for the 70381 to my internal branch for GCC 7.0 > submissions, I noticed test float128-1.c was failing. I tracked it down to the > fact that the pre-gcc7 branch defaults to using LRA on by default instead of > rel

Re: [PATCH, rs6000] Add support for int versions of vec_adde

2016-04-13 Thread David Edelsohn
On Wed, Apr 13, 2016 at 10:47 AM, Bill Seurer wrote: > Here is an updated patch: > > > This patch adds support for the signed and unsigned int versions of the > vec_adde altivec builtins from the Power Architecture 64-Bit ELF V2 ABI > OpenPOWER ABI for Linux Supplement (16 July 2015 Version 1.1).

Re: [PATCH] Fix PR target/70669 (allow __float128 to use direct move)

2016-04-14 Thread David Edelsohn
On Thu, Apr 14, 2016 at 6:43 PM, Michael Meissner wrote: > When adding the basic __float128 support, I forgot to enable direct move > support for moving __float128 between VSX registers and GPR registers. > > This patch enables using direct move for __float128 variables on Power8 > systems. I boo

Re: [PATCH 2/2] (header usage fix) include c++ headers in system.h

2016-04-22 Thread David Edelsohn
On Fri, Apr 22, 2016 at 6:02 AM, Szabolcs Nagy wrote: > Some gcc source files include standard headers after > "system.h" but those headers may declare and use poisoned > symbols, they also cannot be included before "system.h" > because they might depend on macro definitions from there, > so they

Re: [PATCH] More trivial bits from early LTO debug merge

2016-09-20 Thread David Edelsohn
dbxout.c has two definitions of the structure: dbx and xcoff. The patch forgot to update the xcoff one (lucky AIX :-). * dbxout.c (xcoff_debug_hooks): Add filename parameter to early_finish hook. Thanks, David Index: dbxout.c ===

Re: [PATCH] Fix PR ipa/77653

2016-09-22 Thread David Edelsohn
@@ -,13 +2221,11 @@ sem_variable::merge (sem_item *alias_item) } /* We can not merge if address comparsion metters. */ - if (original_address_matters && alias_address_matters - && flag_merge_constants < 2) + if (alias_address_matters && flag_merge_constants < 2) { i

Re: [PATCHv3][ARM] -mpure-code option for ARM

2016-09-22 Thread David Edelsohn
This patch broke bootstrap. In file included from /nasfarm/edelsohn/src/src/gcc/target-def.h:106:0, from /nasfarm/edelsohn/src/src/gcc/config/rs6000/rs6000.c:77:./target-hooks-def.h:92:38: error: 'hook_uint_uintp_false' was not declared in this scope #define TARGET_ASM_ELF_FLAGS_

Re: [PATCH] builtin expansion of memcmp for powerpc

2016-09-24 Thread David Edelsohn
This patch broke bootstrap on AIX. The ChangeLog entry was not committed to the gcc/ChangeLog file. TARGET_LITTLE_ENDIAN only is defined for PPC64 Linux. This patch should be using !BYTES_BIG_ENDIAN. Thanks, David

Re: [PATCH 5/5] rs6000: Separate shrink-wrapping

2016-09-26 Thread David Edelsohn
On Fri, Sep 23, 2016 at 4:21 AM, Segher Boessenkool wrote: > This implements the hooks for separate shrink-wrapping for rs6000. > It handles GPRs and LR. The GPRs get a component number corresponding > to their register number; LR gets component number 0. > > > 2016-09-23 Segher Boessenkool >

[PATCH] Omit AIX mapping class from VAR_DECL

2016-09-27 Thread David Edelsohn
AIX Assembler uses storage mapping classes to map symbols and CSECTs to XCOFF file sections. References to symbols with a section to be determined in the future are suppose to use [UA] storage mapping class for "unclassified". rs6000.c:rs6000_output_symbol() adds the [DS] decoration for function s

Re: C++ PATCH for c++/68703 (dependent vector length)

2016-09-28 Thread David Edelsohn
Hi, Jason This patch added testcases g++.dg/ext/vector32.C and vector32a.C, but there is no gcc/testsuite/ChangeLog entry. The testcases are failing on AIX with a strange ICE: src/gcc/testsuite/g++.dg/ext/vector32.C: In function 'int main()': src/gcc/testsuite/g++.dg/ext/vector32.C:18:1: interna

Re: [PATCH 1/2][RS6000] .gnu.attribute Tag_GNU_Power_ABI_FP

2016-09-29 Thread David Edelsohn
Alan, This patch broke bootstrap on AIX. sysv4.opt is not included on AIX. References to sysv4.opt-specific flags have to be protected in rs6000.c. In file included from /gsa/yktgsa-p4/06/gnu/aix/7.1/power/include/c++/4.8.4/cstddef:42:0, from /gsa/yktgsa/home/e/d/edelsohn/instal

Re: [PATCH] rs6000: Fix shrink-wrap-separate for AIX

2016-10-15 Thread David Edelsohn
On Fri, Oct 14, 2016 at 11:00 PM, Segher Boessenkool wrote: > All out-of-line register save routines need LR, so we cannot wrap the > LR component if there are out-of-line saves. This didn't show up for > testing on Linux because none of the tests there use out-of-line FPR > saves without also us

Re: [PATCH] rs6000: Fix shrink-wrap-separate for AIX

2016-10-16 Thread David Edelsohn
On Sat, Oct 15, 2016 at 2:16 PM, Segher Boessenkool wrote: > On Sat, Oct 15, 2016 at 07:55:47AM -0400, David Edelsohn wrote: >> Maybe rs6000 always should prefer inline save-restore when SWS is >> enabled, except for optimize_size? > > Yes, that would be a good

[PATCH] AIX symbol encoding

2016-10-17 Thread David Edelsohn
This patch shifts earlier the point during compilation where the rs6000 backend adds decoration to symbols: to encode_section_info. AIX uses the XCOFF file format, which extends COFF in a few ways, including some increased granularity of sections through a mechanism called Storage Mapping Class --

Re: [PATCH v2,rs6000] Add built-in function support for Power9 string operations

2016-10-18 Thread David Edelsohn
This patch broke bootstrap on AIX. In altivec_init_builtins(), the loop to initialize predicates is encountering mode1 == SImode. Thanks, David

[PATCH] rs6000.c visitibility fix and formatting

2016-10-20 Thread David Edelsohn
I noticed that rs6000.c rs6000_assemble_visibility has two of the visibility keywords swapped. This only is used for ELF with dot symbols, which are deprecated, so any problems were not apparent, but it should be fixed. The function defines the keywords as: static const char * const visibi

[PATCH] AIX visibility

2016-11-01 Thread David Edelsohn
This patch enables visibility support for AIX. AIX of course chose different syntax, so the default machinery isn't usable. AIX appends the visibility to the .globl and .comm pseudo-ops. Within the rs6000 port, this patch only affects AIX / XCOFF. Also, because visibility support implicitly ena

[PATCH v2] AIX visibility

2016-11-02 Thread David Edelsohn
This revised patch makes two changes: 1) Fix typo in configure.ac 2) Add AIX visibility support for ASM_WEAKEN_DECL, which does touch the same code as Linux. The AIX "weak" support fixes a large number of C++ visibility testcases. Bootstrapped on powerpc-ibm-aix7.2.0.0. * configure.ac (.hidden)

[PATCH] AIX xcoff declare object name

2016-11-03 Thread David Edelsohn
During Richi's debugging of the section type conflict, he found a problem with rs6000_xcoff_declare_object_name trying to access a decl that did not exist. Fixed thusly. * config/rs6000/rs6000.c (rs6000_xcoff_declare_object_name): Use symtab_node::get_create. Index: rs6000.c

Re: [PATCH] PR77359: Properly align local variables in functions calling alloca.

2016-11-03 Thread David Edelsohn
[Please cc me and Segher on PowerPC / AIX patches.] I bootstrapped successfully with the patch and ran the testsuite. Without patch: https://gcc.gnu.org/ml/gcc-testresults/2016-11/msg00186.html With patch: https://gcc.gnu.org/ml/gcc-testresults/2016-11/msg00233.html Not exactly the same revisio

Re: [PATCHv3, testsuite] Enable some existing __float128 tests for powerpc

2016-07-01 Thread David Edelsohn
On Fri, Jul 1, 2016 at 3:39 PM, Bill Schmidt wrote: > Hi, > > This changes my previous patch to use a separate base_quadfloat_support > effective target that can be used in conjunction with either the float128 > or __float128 effective targets, and modifies the tests accordingly. > I dropped addin

Re: [PATCH, rs6000] Fix PR target/71733, ICE with -mcpu=power9 -mno-vsx

2016-07-06 Thread David Edelsohn
On Tue, Jul 5, 2016 at 10:26 PM, Peter Bergner wrote: > The following patch fixes a bug where we do not disable POWER9 vector dform > addressing when we compile for POWER9 but without VSX support. This > manifested > itself with us trying to use dform addressing with altivec loads/stores > which

Re: Improve insert/emplace robustness to self insertion

2016-07-09 Thread David Edelsohn
This patch has caused some new libstdc++ testsuite failures on AIX. FAIL: 23_containers/list/debug/insert4_neg.cc (test for excess errors) Excess errors: /tmp/20160708/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/debug/formatter.h:387:7: error: __gnu_debug::_Error_formatter& __gnu_debug::_Error_f

Re: Improve insert/emplace robustness to self insertion

2016-07-09 Thread David Edelsohn
On Sat, Jul 9, 2016 at 7:59 PM, Jonathan Wakely wrote: > On 09/07/16 13:47 -0400, David Edelsohn wrote: >> >> This patch has caused some new libstdc++ testsuite failures on AIX. > > > Which patch? > > My last patch only added a new test, that can't have c

Re: [PATCH] rs6000: Make the ctr* patterns allow ints in vector regs (PR71763)

2016-07-11 Thread David Edelsohn
Should we backport this? At least Alan's UNSPEC_DOLOOP part? - David On Mon, Jul 11, 2016 at 6:30 AM, Alan Modra wrote: > On Fri, Jul 08, 2016 at 04:17:36AM -0500, Segher Boessenkool wrote: >> Maybe just UNSPEC_BDZ? UNSPEC_DOLOOP? > > Committed revision 238207, using UNSPEC_DOLOOP. > > -- > A

New libstdc++ testsuite failures on AIX

2016-07-11 Thread David Edelsohn
Jason, I believe that one of the patches in your recent C++ series introduced some new libstdc++ testsuite failures on AIX. With r238197 the problem exists and with r238169 (after the libstdc++ changes but before your C++ patches) the failures are not present. Note that this was tested with Rich

Re: [PATCH] Avoid invoking ranlib on libbackend.a

2016-07-17 Thread David Edelsohn
> Patrick Palka writes: > Hmm, this is only a problem due to command line length limits right? > Fortunately the change makes the longest command line only about 10% > longer than the previous longest command line. With the change to > avoid building libbackend.a altogether, the longest comma

Re: [PATCH] Avoid invoking ranlib on libbackend.a

2016-07-17 Thread David Edelsohn
On Sun, Jul 17, 2016 at 10:43 AM, Patrick Palka wrote: > On Sun, Jul 17, 2016 at 9:15 AM, David Edelsohn wrote: >>>>>>> Patrick Palka writes: >> >>> Hmm, this is only a problem due to command line length limits right? >>> Fortunately the cha

Re: [PATCH] disable ifunc on *-musl by default

2016-07-20 Thread David Edelsohn
> Musl libc does not support gnu ifunc, so disable it by default. > (not disabled on s390-* since that has no musl support yet.) Musl libc now supports PPC64. Support for s390 is in progress. - David

Re: [PATCH] disable ifunc on *-musl by default

2016-07-20 Thread David Edelsohn
On Wed, Jul 20, 2016 at 7:09 AM, Szabolcs Nagy wrote: > On 20/07/16 14:45, David Edelsohn wrote: >>> Musl libc does not support gnu ifunc, so disable it by default. >>> (not disabled on s390-* since that has no musl support yet.) >> >> Musl libc now supports PPC64

Re: [PATCH] rs6000: Fix logic for when to emit .machine (PR71216)

2016-07-22 Thread David Edelsohn
On Fri, Jul 22, 2016 at 4:36 AM, Segher Boessenkool wrote: > The current logic determining whether to use .machine in the generated > asm code puts it there if the compiler is not configured with a default > target cpu, _or_ no -mcpu= was given on the command line. It should > be "and" instead. >

Re: [PATCH] rs6000: Testcases for rl*i*

2016-11-25 Thread David Edelsohn
On Fri, Nov 25, 2016 at 8:51 PM, Segher Boessenkool wrote: > These testcases test that we generate the expected code for all of the > rl*i* instructions, that is, rotate-and-mask and rotate-and-mask-insert > for immediate rotation counts. All the testcases do rotate, shift left, > as well as shif

Re: [PATCH] correct handling of non-constant width and precision (pr 78521)

2016-11-28 Thread David Edelsohn
Martin, I am seeing a number of new failures with the testcases on AIX. FAIL: gcc.dg/tree-ssa/builtin-sprintf-warn-1.c (test for excess errors) Excess errors: /nasfarm/edelsohn/src/src/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-1.c:1485:3: warning: specified destination size 2147483647 i

[PATCH] Fix PR68838

2016-11-29 Thread David Edelsohn
Separate from ulimit, 32 bit AIX processes have the concept of memory segments. By default, AIX devotes one 256MB segment to the data section of an executable. Some libstdc++ testcases allocate more than that amount of memory. Instead of individually fixing tests, this patch always adds the AIX

[PATCH,libstdc++] xfail operator new on AIX

2016-11-30 Thread David Edelsohn
AIX shared libraries do not allow overriding and interposition of symbols by default, which is used to override operators, such as operator new (and operator delete) in C++. Four libstdc++ testcases rely on this behavior and fail on AIX. Jonathan and I have decided to XFAIL the testcases to reduc

Re: [v3 PATCH] Implement LWG 2534, Constrain rvalue stream operators.

2016-11-30 Thread David Edelsohn
I believe that this broke g++.old-deja/g++.law/ctors10.C invalid initialization of reference of type 'Klasse::Err&' from expression of type 'std::basic_ostream::__ostream_type {aka std::basic_ostream} - David

<    5   6   7   8   9   10   11   12   13   14   >