[PATCH] Fix PR71984 testcase

2016-08-04 Thread Richard Biener
Committed. Richard. 2016-08-04 Richard Biener PR middle-end/71984 * gcc.dg/torture/pr71984.c: Guard correctness check for little-endian. Index: gcc/testsuite/gcc.dg/torture/pr71984.c === --- gcc/testsuit

Re: Fix fir PR71696 in Libiberty Demangler (6)

2016-08-04 Thread Marcel Böhme
Hi Jeff, > Can you take care of the minor issues above, retest & repost? Sure. I removed the whitespace nits, used XDUPVEC instead of XNEWVEC+memcpy, and adjusted the growing heuristics of the new array proctypevec. The revised patch is attached below. Bootstrapped and regression tested on x86

Re: fix fallout of pr22051-2.c on arm

2016-08-04 Thread Richard Biener
On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote: > Hi, > The attached patch fixes pr22051-2.c which regressed due to > r238754. Matthew, could you please confirm if this patch fixes the > test-case for you ? > > Bootstrapped and tested on x86_64-unknown-linux-gnu. > Cross tested on arm*-*-*. > OK f

Re: [PR70920] transform (intptr_t) x eq/ne CST to x eq/ne (typeof x) cst

2016-08-04 Thread Richard Biener
On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote: > On 3 August 2016 at 17:27, Matthew Wahab wrote: > > On 29/07/16 15:32, Prathamesh Kulkarni wrote: > >> > >> On 29 July 2016 at 12:42, Richard Biener wrote: > >>> > >>> On Fri, 29 Jul 2016, Prathamesh Kulkarni wrote: > >>> > On 28 July 2016 at

Re: [PR70920] transform (intptr_t) x eq/ne CST to x eq/ne (typeof x) cst

2016-08-04 Thread Prathamesh Kulkarni
On 4 August 2016 at 12:39, Richard Biener wrote: > On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote: > >> On 3 August 2016 at 17:27, Matthew Wahab wrote: >> > On 29/07/16 15:32, Prathamesh Kulkarni wrote: >> >> >> >> On 29 July 2016 at 12:42, Richard Biener wrote: >> >>> >> >>> On Fri, 29 Jul 2016,

Re: [LTO] Add wide_int streaming support

2016-08-04 Thread Richard Biener
On Thu, Aug 4, 2016 at 6:12 AM, kugan wrote: > Hi, > > During IPA-VRP implementation, I realized that we don't support streaming > wide_int in LTO. Attached patch does this. Tested with IPA-VRP. Is this OK > for trunk if bootstrap and regression testing is fine. Hmm, those functions belong to dat

Re: [PATCH 6/9] sel-sched: Don't mess with register restores

2016-08-04 Thread Andrey Belevantsev
Hello, On 01.08.2016 4:42, Segher Boessenkool wrote: > If selective scheduling copies register restores it confuses dwarf2cfi. > > 2016-06-07 Segher Boessenkool > > * sel-sched-ir.c (init_global_and_expr_for_insn): Don't copy > instructions with a REG_CFA_RESTORE note. OK from se

Re: [RFC] ipa bitwise constant propagation

2016-08-04 Thread Richard Biener
On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote: > Hi, > This is a prototype patch for propagating known/unknown bits > inter-procedurally. > for integral types which propagates info obtained from get_nonzero_bits (). > > Patch required making following changes: > a) To make info from get_nonzero_

Re: [PR70920] transform (intptr_t) x eq/ne CST to x eq/ne (typeof x) cst

2016-08-04 Thread Richard Biener
On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote: > On 4 August 2016 at 12:39, Richard Biener wrote: > > On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote: > > > >> On 3 August 2016 at 17:27, Matthew Wahab > >> wrote: > >> > On 29/07/16 15:32, Prathamesh Kulkarni wrote: > >> >> > >> >> On 29 July 2016

Re: [LTO] Add wide_int streaming support

2016-08-04 Thread kugan
Hi Richard, Thanks for the review. On 04/08/16 17:26, Richard Biener wrote: On Thu, Aug 4, 2016 at 6:12 AM, kugan wrote: Hi, During IPA-VRP implementation, I realized that we don't support streaming wide_int in LTO. Attached patch does this. Tested with IPA-VRP. Is this OK for trunk if boots

Re: [PATCH] Teach VRP to truncate the case ranges of a switch

2016-08-04 Thread Richard Biener
On Thu, Aug 4, 2016 at 4:30 AM, Patrick Palka wrote: > On Wed, 3 Aug 2016, David Malcolm wrote: > >> On Wed, 2016-08-03 at 15:47 +0200, Richard Biener wrote: >> > On Wed, Aug 3, 2016 at 6:00 AM, Patrick Palka >> > wrote: >> > > VRP currently has functionality to eliminate case labels that lie >>

Re: libgo patch committed: Update to 1.7rc3

2016-08-04 Thread Uros Bizjak
On Thu, Aug 4, 2016 at 12:53 AM, Ian Lance Taylor wrote: > On Thu, Jul 28, 2016 at 4:24 AM, Uros Bizjak wrote: >> >> A new testsuite failure is introduced: >> >> FAIL: text/template >> >> on both, x86_64-linux-gnu and alpha-linux-gnu. >> >> The testcase corrupts stack with a too deep recursion. >

Re: [LTO] Add wide_int streaming support

2016-08-04 Thread Richard Biener
On Thu, Aug 4, 2016 at 10:09 AM, kugan wrote: > Hi Richard, > > Thanks for the review. > > On 04/08/16 17:26, Richard Biener wrote: >> >> On Thu, Aug 4, 2016 at 6:12 AM, kugan >> wrote: >>> >>> Hi, >>> >>> During IPA-VRP implementation, I realized that we don't support streaming >>> wide_int in L

Re: [PATCH][RFC] PR middle-end/22141 GIMPLE store widening pass

2016-08-04 Thread Richard Biener
On Wed, Aug 3, 2016 at 5:15 PM, Kyrill Tkachov wrote: > Hi Richard, > > On 18/07/16 13:22, Richard Biener wrote: >> >> On Fri, Jul 15, 2016 at 5:13 PM, Kyrill Tkachov >> wrote: > > > > > >> + /* Record the original statements so that we can keep track of >> +statements emitted in th

Re: [PATCH 15/17][ARM] Add tests for ARMv8.2-A FP16 support.

2016-08-04 Thread Ramana Radhakrishnan
On Mon, Jul 4, 2016 at 3:17 PM, Matthew Wahab wrote: > On 17/05/16 15:48, Matthew Wahab wrote: >> Support for using the half-precision floating point operations added by >> the ARMv8.2-A FP16 extension is based on the macros and intrinsics added >> to the ACLE for the extension. >> >> This patch a

Re: [PATCH 16/17][ARM] Add tests for VFP FP16 ACLE instrinsics.

2016-08-04 Thread Ramana Radhakrishnan
On Mon, Jul 4, 2016 at 3:18 PM, Matthew Wahab wrote: > On 18/05/16 11:58, Matthew Wahab wrote: >> On 18/05/16 02:06, Joseph Myers wrote: >>> On Tue, 17 May 2016, Matthew Wahab wrote: >>> In some tests, there are unavoidable differences in precision when calculating the actual and the exp

Re: fix fallout of pr22051-2.c on arm

2016-08-04 Thread Matthew Wahab
On 03/08/16 23:08, Prathamesh Kulkarni wrote: Hi, The attached patch fixes pr22051-2.c which regressed due to r238754. Matthew, could you please confirm if this patch fixes the test-case for you ? Confirmed. (Tested with arm-none-linux-gnueabihf.) Thanks Matthew

Re: [PATCH GCC]Simplify interface for simplify_using_initial_conditions

2016-08-04 Thread Bin.Cheng
On Wed, Aug 3, 2016 at 11:17 PM, Jeff Law wrote: > On 08/03/2016 10:35 AM, Bin Cheng wrote: >> >> Hi, >> When I introduced parameter STOP for expand_simple_operations, I also >> added it for simplify_using_initial_conditions. The STOP argument is also >> passed to simplify_using_initial_condition

Re: [RFC] ipa bitwise constant propagation

2016-08-04 Thread Prathamesh Kulkarni
On 4 August 2016 at 13:31, Richard Biener wrote: > On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote: > >> Hi, >> This is a prototype patch for propagating known/unknown bits >> inter-procedurally. >> for integral types which propagates info obtained from get_nonzero_bits (). >> >> Patch required mak

Re: [PATCH 17/17][ARM] Add tests for NEON FP16 ACLE intrinsics.

2016-08-04 Thread Ramana Radhakrishnan
On Mon, Jul 4, 2016 at 3:22 PM, Matthew Wahab wrote: > On 17/05/16 15:52, Matthew Wahab wrote: >> Support for using the half-precision floating point operations added by >> the >> ARMv8.2-A FP16 extension is based on the macros and intrinsics added to >> the >> ACLE for the extension. >> >> This p

Re: [RFC] ipa bitwise constant propagation

2016-08-04 Thread kugan
On 04/08/16 18:57, Prathamesh Kulkarni wrote: On 4 August 2016 at 13:31, Richard Biener wrote: On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote: Hi, This is a prototype patch for propagating known/unknown bits inter-procedurally. for integral types which propagates info obtained from get_nonze

Re: [LTO] Add wide_int streaming support

2016-08-04 Thread Jan Hubicka
> Hi Richard, > > Thanks for the review. > > On 04/08/16 17:26, Richard Biener wrote: > >On Thu, Aug 4, 2016 at 6:12 AM, kugan > >wrote: > >>Hi, > >> > >>During IPA-VRP implementation, I realized that we don't support streaming > >>wide_int in LTO. Attached patch does this. Tested with IPA-VRP.

Re: [AArch64] Handle HFAs of float16 types properly

2016-08-04 Thread James Greenhalgh
On Tue, Jul 26, 2016 at 02:55:02PM +0100, James Greenhalgh wrote: > > Hi, > > It looks like we've not been handling structures of 16-bit floating-point > data correctly for AArch64. For some reason we end up passing them > packed in to integer registers. That is to say, on trunk and GCC 6, for: >

[PATCH 1/2] Fix GNU coding style in gcov.c

2016-08-04 Thread Martin Liška
On 08/03/2016 04:22 PM, Nathan Sidwell wrote: > Martin, >> As I've going through all PRs related to gcov-profile, I've noticed this PR. >> Current implementation of cycle detection in gcov is very poor, leading to >> extreme run time >> for cases like mentioned in the PR (which does not contain a

Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)

2016-08-04 Thread Martin Liška
On 08/03/2016 04:22 PM, Nathan Sidwell wrote: > Martin, >> As I've going through all PRs related to gcov-profile, I've noticed this PR. >> Current implementation of cycle detection in gcov is very poor, leading to >> extreme run time >> for cases like mentioned in the PR (which does not contain a

Re: [RFC] ipa bitwise constant propagation

2016-08-04 Thread Richard Biener
On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote: > On 4 August 2016 at 13:31, Richard Biener wrote: > > On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote: > > > >> Hi, > >> This is a prototype patch for propagating known/unknown bits > >> inter-procedurally. > >> for integral types which propagates in

[PATCH][AArch64] Add legitimize_address_displacement hook

2016-08-04 Thread Wilco Dijkstra
This patch adds legitimize_address_displacement hook so that stack accesses with large offsets are split into a more efficient sequence. Byte and halfword accesses use a 4KB range, wider accesses use a 16KB range to maximise the available addressing range and increase opportunities to share the ba

[PATCH][AArch64] Improve stack adjustment

2016-08-04 Thread Wilco Dijkstra
Improve stack adjustment by reusing a temporary move immediate from the epilog if the register is still valid in the epilog. This generates smaller code for leaf functions: mov x16, 4 sub sp, sp, x16 ldr w0, [sp, w0, sxtw 2] add sp, sp, x16

[PATCH] Simplify std::__invoke_impl definitions

2016-08-04 Thread Jonathan Wakely
Some minor tidying before I add support for is_callable and is_nothrow_callable. * include/std/functional (_Unwrap): Rename to __inv_unwrap. (__invfwd): Adjust. (__invoke_impl): Remove unused template parameters. * testsuite/20_util/function_objects/invoke/59768.cc

[PATCH][AArch64] Simplify eh_return implementation

2016-08-04 Thread Wilco Dijkstra
This patch simplifies the handling of the EH return value. We force the use of the frame pointer so the return location is always at FP + 8. This means we can emit a simple volatile access in EH_RETURN_HANDLER_RTX without needing md patterns, splitters and frame offset calculations. The new im

protected alloca class for malloc fallback

2016-08-04 Thread Aldy Hernandez
Howdy! As part of my -Walloca-larger-than=life work, I've been running said pass over gcc, binutils, and gdb, and trying to fix things along the way. Particularly irritating and error prone is having to free malloc'd pointers on every function exit point. We end up with a lot of: foo(size_

Re: [PATCH 1/2] Fix GNU coding style in gcov.c

2016-08-04 Thread Nathan Sidwell
On 08/04/16 06:39, Martin Liška wrote: On 08/03/2016 04:22 PM, Nathan Sidwell wrote: Martin, As I've going through all PRs related to gcov-profile, I've noticed this PR. Current implementation of cycle detection in gcov is very poor, leading to extreme run time for cases like mentioned in the

Re: libgo patch committed: Update to 1.7rc3

2016-08-04 Thread Rainer Orth
Hi Uros, >> I have committed a patch to update libgo to the 1.7rc3 release >> candidate. This is very close to the upcoming 1.7 release. As usual >> with libgo updates, the patch is too large to include in this e-mail >> message. I've appended the changes to the gccgo-specific directories. > >

Re: [PATCH] Teach VRP to truncate the case ranges of a switch

2016-08-04 Thread Patrick Palka
On Thu, 4 Aug 2016, Richard Biener wrote: > On Thu, Aug 4, 2016 at 4:30 AM, Patrick Palka wrote: > > On Wed, 3 Aug 2016, David Malcolm wrote: > > > >> On Wed, 2016-08-03 at 15:47 +0200, Richard Biener wrote: > >> > On Wed, Aug 3, 2016 at 6:00 AM, Patrick Palka > >> > wrote: > >> > > VRP currentl

Re: libgo patch committed: Update to 1.7rc3

2016-08-04 Thread Rainer Orth
Hi Uros, > BTW: I can see this failure on other targets, too, e.g. powerpc64le > [1] and aarch64 [2]. > > [1] https://gcc.gnu.org/ml/gcc-testresults/2016-08/msg00321.html > [2] https://gcc.gnu.org/ml/gcc-testresults/2016-08/msg00318.html right, both Solaris/x86 and Solaris/SPARC are affected, too

[PATCH] Create x.gcov file for binary w/o x.gcda file (PR, gcov-profile/65831)

2016-08-04 Thread Martin Liška
Hi. Following patch is grabbed from the PR, where I just applied the patch and wrote a test-case which removes x.gcda file before running gcov tool. Ready to be installed? Martin >From 0e8a129302eaf8b5950b7b1a6de560b9c2ee4354 Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 4 Aug 2016 14:04:36 +

Re: [PATCH] Define feature-test macro for std::enable_shared_from_this

2016-08-04 Thread Jonathan Wakely
On 03/08/16 20:11 +0100, Jonathan Wakely wrote: Another feature we already support, so just define the macro. * include/bits/shared_ptr_base.h (__cpp_lib_enable_shared_from_this): Define feature-test macro. * testsuite/20_util/enable_shared_from_this/members/reinit.cc: Te

Re: Implement -Wimplicit-fallthrough (take 2): the rest

2016-08-04 Thread Michael Matz
Hi, On Wed, 27 Jul 2016, Marek Polacek wrote: > And this is the rest. Either I just adjusted a falls through comment, > or I added __builtin_fallthrough (). These were the cases where I was > fairly sure that the fall through is intentional. I saw one case where I think the warning is a bit

[PATCH] Fix latent bugs

2016-08-04 Thread Richard Biener
The following fixes two latent bugs I ran into when fixing PR72772. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2016-08-04 Richard Biener * tree-cfgcleanup.c (tree_forwarder_block_p): Use bb_loop_header_p. * cfghooks.c (force_nonfallthru): If we e

Re: [PATCH GCC]Simplify interface for simplify_using_initial_conditions

2016-08-04 Thread Richard Biener
On Thu, Aug 4, 2016 at 10:40 AM, Bin.Cheng wrote: > On Wed, Aug 3, 2016 at 11:17 PM, Jeff Law wrote: >> On 08/03/2016 10:35 AM, Bin Cheng wrote: >>> >>> Hi, >>> When I introduced parameter STOP for expand_simple_operations, I also >>> added it for simplify_using_initial_conditions. The STOP argu

Re: [LTO] Add wide_int streaming support

2016-08-04 Thread Richard Biener
On Thu, Aug 4, 2016 at 11:32 AM, Jan Hubicka wrote: >> Hi Richard, >> >> Thanks for the review. >> >> On 04/08/16 17:26, Richard Biener wrote: >> >On Thu, Aug 4, 2016 at 6:12 AM, kugan >> >wrote: >> >>Hi, >> >> >> >>During IPA-VRP implementation, I realized that we don't support streaming >> >>w

Re: [PATCH] Create x.gcov file for binary w/o x.gcda file (PR, gcov-profile/65831)

2016-08-04 Thread Nathan Sidwell
On 08/04/16 08:27, Martin Liška wrote: Hi. Following patch is grabbed from the PR, where I just applied the patch and wrote a test-case which removes x.gcda file before running gcov tool. Ready to be installed? 2016-08-04 Martin Liska * g++.dg/gcov/gcov-16.C: New test. * l

Re: protected alloca class for malloc fallback

2016-08-04 Thread Richard Biener
On Thu, Aug 4, 2016 at 1:30 PM, Aldy Hernandez wrote: > Howdy! > > As part of my -Walloca-larger-than=life work, I've been running said pass > over gcc, binutils, and gdb, and trying to fix things along the way. > > Particularly irritating and error prone is having to free malloc'd pointers > on e

Re: [RFC] ipa bitwise constant propagation

2016-08-04 Thread Jan Hubicka
> I didn't look at the propagation part but eventually the IPA-CP > lattice gets quite big. Also the alignment lattice is very > similar to the bits lattice so why not merge those two? But This was always the original idea to replace alignment propagation by bitwise ccp. I suppose we only have

Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)

2016-08-04 Thread Nathan Sidwell
On 08/04/16 06:41, Martin Liška wrote: On 08/03/2016 04:22 PM, Nathan Sidwell wrote: Martin, As I've going through all PRs related to gcov-profile, I've noticed this PR. Current implementation of cycle detection in gcov is very poor, leading to extreme run time for cases like mentioned in the

split test cases pr71078-1.c and pr71078-2.c

2016-08-04 Thread Prathamesh Kulkarni
Hi, The attached patch splits each test-case into three, one for float, double and long-double. I verified that the long double tests are unsupported now for arm target. OK to commit ? Thanks, Prathamesh 2016-08-04 Prathamesh Kulkarni testsuite/ * gcc.dg/tree-ssa/pr71078-1.c: Remove do

Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)

2016-08-04 Thread Jan Hubicka
> On 08/04/16 06:41, Martin Liška wrote: > >On 08/03/2016 04:22 PM, Nathan Sidwell wrote: > >>Martin, > >>>As I've going through all PRs related to gcov-profile, I've noticed this > >>>PR. > >>>Current implementation of cycle detection in gcov is very poor, leading to > >>>extreme run time > >>>f

[PATCH] Update C++17 library implementation status table

2016-08-04 Thread Jonathan Wakely
This adds all the features from the latest draft of SD-6, and reformats the table to be closer to the tables at https://gcc.gnu.org/projects/cxx-status.html (including adding the feature-test macros). * doc/xml/manual/status_cxx2017.xml: Update C++17 status table. * doc/html/manua

Re: split test cases pr71078-1.c and pr71078-2.c

2016-08-04 Thread Richard Biener
On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote: > Hi, > The attached patch splits each test-case into three, one for float, > double and long-double. > I verified that the long double tests are unsupported now for arm target. > OK to commit ? Ok. Richard. > Thanks, > Prathamesh > -- Richard B

Re: Go patch committed: add escape analysis debugging

2016-08-04 Thread Rainer Orth
Hi Ian, > This patch by Chris Manghane adds debugging to the escape analysis > code. This debugging is designed to generate the same sort of output > as the gc Go compiler, for easier comparison of results. Escape > analysis is still not enabled by default. Bootstrapped and ran Go > testsuite o

Re: [PATCH] Teach VRP to truncate the case ranges of a switch

2016-08-04 Thread Richard Biener
On Thu, Aug 4, 2016 at 2:14 PM, Patrick Palka wrote: > On Thu, 4 Aug 2016, Richard Biener wrote: > >> On Thu, Aug 4, 2016 at 4:30 AM, Patrick Palka wrote: >> > On Wed, 3 Aug 2016, David Malcolm wrote: >> > >> >> On Wed, 2016-08-03 at 15:47 +0200, Richard Biener wrote: >> >> > On Wed, Aug 3, 2016

Re: C++ OpenACC routine directive testing: templated, and "auto", trailing return type syntax

2016-08-04 Thread Thomas Schwinge
Hi! On Tue, 12 Jul 2016 15:55:37 +0200, Jakub Jelinek wrote: > On Tue, Jul 12, 2016 at 03:50:14PM +0200, Thomas Schwinge wrote: > > Templated, and "auto", trailing return type syntax with the C++ OpenACC > > routine directive all works, but doesn't have test coverage. OK for > > trunk? > >

Re: [Fortran, Patch, pr70524, v1] [5/6/7 Regression] ICE when using -frepack-arrays -Warray-temporaries

2016-08-04 Thread Dominique d'Humières
The patch works as advertised. It would be nice to have it reviewed and committed. TIA Dominique

Re: Tighten syntax checking for OpenACC routine construct in C

2016-08-04 Thread Thomas Schwinge
Hi! On Tue, 24 May 2016 16:02:39 +0200, I wrote: > Committed without changes in r236639: > > commit c9d624bd2672463771546e73bf3d6446d64e43c0 > Author: tschwinge > Date: Tue May 24 14:00:39 2016 + > > Tighten syntax checking for OpenACC routine construct in C Backported to gomp-4_0-br

Re: C/C++: Simplify handling of location information for OpenACC routine directives

2016-08-04 Thread Thomas Schwinge
Hi! On Wed, 13 Jul 2016 11:25:46 +0200, I wrote: > C/C++: Simplify handling of location information for OpenACC routine > directives Without changes, committed to trunk in r239127: commit 5f429ee2993ea1795d88c5589251c500e6e9062a Author: tschwinge Date: Thu Aug 4 13:35:19 2016 +

Re: Rework C/C++ OpenACC routine parsing

2016-08-04 Thread Thomas Schwinge
Hi! On Fri, 22 Jul 2016 16:22:18 +0200, Jakub Jelinek wrote: > On Wed, Jul 13, 2016 at 04:10:31PM +0200, Thomas Schwinge wrote: > > @@ -14029,29 +14032,32 @@ c_parser_oacc_kernels_parallel (location_t loc, > > c_parser *parser, > > static void > > c_parser_oacc_routine (c_parser *parser, enum

Re: Test cases to check OpenACC offloaded function's attributes and classification

2016-08-04 Thread Thomas Schwinge
Hi! Ping. On Wed, 27 Jul 2016 10:59:02 +0200, I wrote: > Hi! > > OK for trunk? > > commit 8200af082db5438be18bc60f721fcf21641c0d86 > Author: Thomas Schwinge > Date: Tue Jul 26 17:18:21 2016 +0200 > > Test cases to check OpenACC offloaded function's attributes and > classification >

Re: Use "oacc kernels" attribute for OpenACC kernels

2016-08-04 Thread Thomas Schwinge
Hi! Ping. On Wed, 27 Jul 2016 12:06:59 +0200, I wrote: > On Mon, 25 Jan 2016 16:09:14 +0100, Jakub Jelinek wrote: > > On Mon, Jan 25, 2016 at 10:06:50AM -0500, Nathan Sidwell wrote: > > > On 01/04/16 10:39, Nathan Sidwell wrote: > > > >There's currently no robust predicate to determine whether a

Re: [PTX] fix worker propagation ICE

2016-08-04 Thread Thomas Schwinge
Hi! On Wed, 3 Aug 2016 13:30:10 -0400, Nathan Sidwell wrote: > --- libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c (nonexistent) > +++ libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c (working copy) > @@ -0,0 +1,28 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O0" } */ Of

Re: [PATCH 1/3] (v2) On-demand locations within string-literals

2016-08-04 Thread David Malcolm
On Wed, 2016-08-03 at 09:59 -0600, Jeff Law wrote: > On 07/29/2016 03:42 PM, Joseph Myers wrote: > > On Tue, 26 Jul 2016, David Malcolm wrote: > > > > > This patch implements precise tracking of source locations for > > > the > > > individual chars within string literals, so that we can e.g. > > >

[PATCH][PR64971]Convert function pointer to Pmode when emit call

2016-08-04 Thread Renlin Li
Hi all, In the case of PR64971 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64971), the compiler ICE when compiling gcc.c-torture/compile/pr37433.c with ilp32 abi. As we know, in aarch64 ilp32, the ptr_mode is SImode while Pmode is still DImode. It means all address should be DImode, and the

Re: [PATCH 1/4] Cherry-pick fprofile-generate-atomic from google/gcc-4_9 branch

2016-08-04 Thread Nathan Sidwell
On 08/01/16 09:29, Martin Liška wrote: I also added a small hunk that describes problematic of app having not-joined (or detached) threads, can you please take a look at documentation change, maybe it would need some transformation? sorry for the tady response,thanks for the ping. In genera

[GCC Steering Committee attention] [PING] [PING] [PING] libgomp: In OpenACC testing, cycle though $offload_targets, and by default only build for the offload target that we're actually going to test

2016-08-04 Thread Thomas Schwinge
Hi! Ping. It has now been more than three months (!) that I first submitted this, without receiving any meaningful review. (Apart from one initial "deprecative" comment by Jakub, which I then repeatedly detailed on, without receiving any further response.)

Re: libgo patch committed: Update to 1.7rc3

2016-08-04 Thread Ian Lance Taylor
On Thu, Aug 4, 2016 at 5:12 AM, Rainer Orth wrote: > Hi Uros, > >>> I have committed a patch to update libgo to the 1.7rc3 release >>> candidate. This is very close to the upcoming 1.7 release. As usual >>> with libgo updates, the patch is too large to include in this e-mail >>> message. I've

Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)

2016-08-04 Thread Martin Liška
On 08/04/2016 03:15 PM, Nathan Sidwell wrote: > On 08/04/16 06:41, Martin Liška wrote: >> On 08/03/2016 04:22 PM, Nathan Sidwell wrote: >>> Martin, As I've going through all PRs related to gcov-profile, I've noticed this PR. Current implementation of cycle detection in gcov is very

[PING] Use correct location information for OpenACC shape and simple clauses in C/C++

2016-08-04 Thread Thomas Schwinge
Hi! On Wed, 27 Jul 2016 17:09:38 -0400, David Malcolm wrote: > On Wed, 2016-07-27 at 17:17 +0200, Thomas Schwinge wrote: > > I found that for a lot of OpenACC (and potentially also OpenMP) > > clauses > > (in C/C++ front ends; didn't look at Fortran), we use wrong location > > information. The p

Re: [PATCH/AARCH64] Add ThunderX vector cost model

2016-08-04 Thread Richard Earnshaw (lists)
On 03/08/16 23:42, Andrew Pinski wrote: > Hi, > This patch adds to the thunderx model, the vector cost model. I > benchmarked this on SPEC CPU INT 2006 and got a small speed up. I > have a few more cost model patches that I am going upstream but they > are going to be split up. > > OK? Bootst

Re: [PATCH], Improve vector int/long initialization on PowerPC

2016-08-04 Thread Segher Boessenkool
Hi Mike, On Thu, Aug 04, 2016 at 12:33:44AM -0400, Michael Meissner wrote: > I built spec 2006 with these patches on a little endian power8 system, and at > least 18 of the benchmarks had vector initializations replaced. Most > benchmarks only used the initialization in a few places, but gamess,

Re: [RS6000] rs6000_preferred_reload_class

2016-08-04 Thread Segher Boessenkool
On Thu, Aug 04, 2016 at 02:44:34PM +0930, Alan Modra wrote: > On Wed, Aug 03, 2016 at 03:30:53PM -0400, Michael Meissner wrote: > > On Mon, Aug 01, 2016 at 09:00:43AM +0930, Alan Modra wrote: > > > Hi Mike, > > > I've been looking at a lot of reload/lra code lately in trying to fix > > > pr71680, a

Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)

2016-08-04 Thread Nathan Sidwell
On 08/04/16 10:42, Martin Liška wrote: I decided to use a new enum, hope it's better? that's fine. But you know, if you set the enum values appropriately you could use the | trick rather than the compare you've done (c++ enum type safety would require an overloaded | operator though). I do

Re: protected alloca class for malloc fallback

2016-08-04 Thread Aldy Hernandez
On 08/04/2016 08:57 AM, Richard Biener wrote: On Thu, Aug 4, 2016 at 1:30 PM, Aldy Hernandez wrote: Howdy! As part of my -Walloca-larger-than=life work, I've been running said pass over gcc, binutils, and gdb, and trying to fix things along the way. Particularly irritating and error prone is

[PATCH v2,rs6000] Add built-in function support for Power9 binary floating point operations

2016-08-04 Thread Kelvin Nilsen
This patch adds built-in support for the following fourteen new binary floating point instructions introduced with the Power9 architecture: VSX Scalar Extract Exponent Double-Precision VSX Scalar Extract Significand Double-Precision VSX Scalar Insert Exponent Double-Precision VSX Scalar Compare E

Re: [PATCH][AArch64] Add legitimize_address_displacement hook

2016-08-04 Thread Richard Earnshaw (lists)
On 04/08/16 12:00, Wilco Dijkstra wrote: > This patch adds legitimize_address_displacement hook so that stack accesses > with large offsets are split into a more efficient sequence. Byte and > halfword > accesses use a 4KB range, wider accesses use a 16KB range to maximise the > available address

Re: [PATCH 1/4] Cherry-pick fprofile-generate-atomic from google/gcc-4_9 branch

2016-08-04 Thread Martin Liška
On 08/04/2016 04:48 PM, Nathan Sidwell wrote: > diff --git a/libgcc/libgcov-profiler.c b/libgcc/libgcov-profiler.c > +static inline void > +__gcov_one_value_profiler_body_atomic (gcov_type *counters, gcov_type value) > +{ > ... > > The body looks to have data races. Some kind of cmp_store needed

Re: [PING] Use correct location information for OpenACC shape and simple clauses in C/C++

2016-08-04 Thread David Malcolm
On Thu, 2016-08-04 at 16:54 +0200, Thomas Schwinge wrote: > Hi! > > On Wed, 27 Jul 2016 17:09:38 -0400, David Malcolm < > dmalc...@redhat.com> wrote: > > On Wed, 2016-07-27 at 17:17 +0200, Thomas Schwinge wrote: > > > I found that for a lot of OpenACC (and potentially also OpenMP) > > > clauses >

C++ PATCH for c++/72796 (wrong resolution of scoped call)

2016-08-04 Thread Jason Merrill
On this testcase, finish_class_member_access_expr unpacked the SCOPE_REF, changing the name variable, and then used that variable to return a dependent COMPONENT_REF. We are already holding onto the original value of name, we should use that instead. Tested x86_64-pc-linux-gnu, applying to trunk.

C++ PATCH to rename TYPE_ANONYMOUS_P to TYPE_UNNAMED_P

2016-08-04 Thread Jason Merrill
Martin pointed out that the macro name TYPE_ANONYMOUS_P is confusing because it doesn't identify anonymous structs/unions; the C++ standard consistently refers to classes with no name as "unnamed", not "anonymous", so let's use that term internally as well. Tested x86_64-pc-linux-gnu, applying to

Re: [PATCH][AArch64] Improve stack adjustment

2016-08-04 Thread Richard Earnshaw (lists)
On 04/08/16 12:06, Wilco Dijkstra wrote: > Improve stack adjustment by reusing a temporary move immediate > from the epilog if the register is still valid in the epilog. This generates > smaller code for leaf functions: > > mov x16, 4 > sub sp, sp, x16 > ldr

C++ PATCH for c++/72415 (concepts ICE with fold-expression constraint)

2016-08-04 Thread Jason Merrill
Substituting into the fold-expression was producing an EXPR_PACK_EXPANSION, but it would be better to keep it as a fold-expression. tsubst_unary_left_fold et al try to do this, but weren't recognizing the case where tsubst_pack_expansion returns a TREE_VEC containing a single pack expansion. In t

Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)

2016-08-04 Thread Martin Liška
On 08/04/2016 05:13 PM, Nathan Sidwell wrote: > On 08/04/16 10:42, Martin Liška wrote: > >> I decided to use a new enum, hope it's better? > > that's fine. But you know, if you set the enum values appropriately you > could use the | trick rather than the compare you've done (c++ enum type > sa

Re: [PR55641] drop spurious const_type from reference_type variables

2016-08-04 Thread Jason Merrill
OK. On Mon, Aug 1, 2016 at 11:12 PM, Alexandre Oliva wrote: > Although C++ reference types, denoted by DW_TAG_reference_type in > DWARFv2+ debug info, are unchangeable, we output names of reference type > with DW_TAG_const_type, because internally we mark such variables as > TREE_READONLY. That'

Re: Go patch committed: add escape analysis debugging

2016-08-04 Thread Ian Lance Taylor
On Thu, Aug 4, 2016 at 6:47 AM, Rainer Orth wrote: > >> This patch by Chris Manghane adds debugging to the escape analysis >> code. This debugging is designed to generate the same sort of output >> as the gc Go compiler, for easier comparison of results. Escape >> analysis is still not enabled

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-08-04 Thread Jeff Law
On 07/27/2016 03:01 AM, Aldy Hernandez wrote: Just in case this got lost in noise, since I know there was a lot of back and forth between Martin Sebor and I. This is the last iteration. Tested on x86-64 Linux. OK for trunk? curr gcc/ * Makefile.in (OBJS): Add gimple-ssa-warn-walloc

Re: [PATCH 1/4] Cherry-pick fprofile-generate-atomic from google/gcc-4_9 branch

2016-08-04 Thread Nathan Sidwell
On 08/04/16 11:34, Martin Liška wrote: On 08/04/2016 04:48 PM, Nathan Sidwell wrote: diff --git a/libgcc/libgcov-profiler.c b/libgcc/libgcov-profiler.c +static inline void +__gcov_one_value_profiler_body_atomic (gcov_type *counters, gcov_type value) +{ ... The body looks to have data races. So

Re: Implement -Wimplicit-fallthrough (take 2): the rest

2016-08-04 Thread Jeff Law
On 08/04/2016 06:36 AM, Michael Matz wrote: Hi, On Wed, 27 Jul 2016, Marek Polacek wrote: And this is the rest. Either I just adjusted a falls through comment, or I added __builtin_fallthrough (). These were the cases where I was fairly sure that the fall through is intentional. I saw one

Re: libgo patch committed: Update to 1.7rc3

2016-08-04 Thread Ian Lance Taylor
On Thu, Aug 4, 2016 at 1:11 AM, Uros Bizjak wrote: > On Thu, Aug 4, 2016 at 12:53 AM, Ian Lance Taylor wrote: >> On Thu, Jul 28, 2016 at 4:24 AM, Uros Bizjak wrote: >>> >>> A new testsuite failure is introduced: >>> >>> FAIL: text/template >>> >>> on both, x86_64-linux-gnu and alpha-linux-gnu. >

Re: [PATCH] Fix wrong code on aarch64 due to paradoxical subreg

2016-08-04 Thread James Greenhalgh
On Wed, Aug 03, 2016 at 04:08:30PM -0600, Jeff Law wrote: > On 08/03/2016 11:41 AM, Bernd Edlinger wrote: > >On 08/03/16 17:38, Jeff Law wrote: > >>cse.c changes look good, but I'd really like to see a testcase for each > >>issue in the dejagnu framework. Extra points if you tried to build a > >>u

Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)

2016-08-04 Thread Nathan Sidwell
On 08/04/16 12:10, Martin Liška wrote: On 08/04/2016 05:13 PM, Nathan Sidwell wrote: On 08/04/16 10:42, Martin Liška wrote: I decided to use a new enum, hope it's better? that's fine. But you know, if you set the enum values appropriately you could use the | trick rather than the compare y

Re: Fix fir PR71696 in Libiberty Demangler (6)

2016-08-04 Thread Jeff Law
On 08/04/2016 01:07 AM, Marcel Böhme wrote: Hi Jeff, Can you take care of the minor issues above, retest & repost? Sure. I removed the whitespace nits, used XDUPVEC instead of XNEWVEC+memcpy, and adjusted the growing heuristics of the new array proctypevec. The revised patch is attached bel

[PATCH] do not throw in std::make_exception_ptr

2016-08-04 Thread Gleb Natapov
Instead of throwing an exception allocate its memory and initialize it explicitly. Makes std::make_exception_ptr more efficient since no stack unwinding is needed. In this version I hopefully addressed all Jonathan comments. * libsupc++/exception (std::exception): Move... * libsupc++/exception.h:

[C++ Patch] PR 72800

2016-08-04 Thread Paolo Carlini
Hi, when back in 2014 I sent the patch for c++/61088 I noticed some cases where we wanted to return early error_mark_node from add_capture to avoid ICEs during error recovery when COMPLETE_TYPE_P is used on an error_mark_node. The new testcase noticed one additional case, where the error_mark

Re: Use correct location information for OpenACC shape and simple clauses in C/C++

2016-08-04 Thread Jeff Law
On 07/27/2016 09:17 AM, Thomas Schwinge wrote: Hi! I found that for a lot of OpenACC (and potentially also OpenMP) clauses (in C/C++ front ends; didn't look at Fortran), we use wrong location information. The problem is that c_parser_oacc_all_clauses/c_parser_omp_all_clauses calls cp_parser_omp

Re: [PATCH 1/4] Cherry-pick fprofile-generate-atomic from google/gcc-4_9 branch

2016-08-04 Thread Nathan Sidwell
On 08/04/16 12:43, Nathan Sidwell wrote: How about: gcov_t expected; atomic_load (&counter[0], val, ...); gcov_t delta = val == value ? 1 : -1; atomic_add (&counter[1], delta); <-- or atomic_add_fetch if (delta < 0) { /* can we set counter[0]? */ atomic_load (&counter[1], &expected, ...);

Re: [PATCH, rs6000] Switch the rs6000 port over to LRA

2016-08-04 Thread Peter Bergner
On 8/3/16 6:03 PM, David Edelsohn wrote: Please open a Bugzilla for the rs6000 backend about the vsx-timode performance regression. The vsx-timode regression needs to be fixed for GCC 7. Ok, I opened https://gcc.gnu.org/PR72804 and will start debugging the problem. Peter

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-08-04 Thread Ian Lance Taylor
On Thu, Jul 28, 2016 at 8:57 AM, Marek Polacek wrote: > On Wed, Jul 27, 2016 at 10:05:25AM -0700, Mike Stump wrote: >> On Jul 27, 2016, at 9:52 AM, Marek Polacek wrote: >> > >> > This is what the new warning pointed out. I think all these are bugs. >> > >> > --- gcc/libgo/runtime/heapdump.c >> >

Re: [PATCH 1/3] (v2) On-demand locations within string-literals

2016-08-04 Thread Jeff Law
On 08/04/2016 08:27 AM, David Malcolm wrote: As for test coverage, v2 and v3 of the kit add over a thousand lines of selftest code that heavily exercise string lexing, using the line_table_case machinery to run the tests with various interesting boundary conditions with line_table (e.g. near L

Re: [PATCH 2/4] (v3) On-demand locations within string-literals

2016-08-04 Thread Jeff Law
On 08/03/2016 09:45 AM, David Malcolm wrote: Changes in v3: - Avoid including cpplib.h from input.h - Properly handle stringified macro arguments (with tests for this) - Minor whitespace fixes - Move selftest.h changes to a separate patch Changes in v2: - Tweaks to substring location selftests -

Re: [PATCH] do not throw in std::make_exception_ptr

2016-08-04 Thread Jonathan Wakely
On 04/08/16 20:01 +0300, Gleb Natapov wrote: Instead of throwing an exception allocate its memory and initialize it explicitly. Makes std::make_exception_ptr more efficient since no stack unwinding is needed. In this version I hopefully addressed all Jonathan comments. * libsupc++/exception (st

[PATCH] Define std::is_callable and std::is_nothrow_callable

2016-08-04 Thread Jonathan Wakely
Two new traits for C++17, as well as identical __is__callable and __is_nothrow_callable traits defined for C++11 mode (so I can use the latter to add an exception specification to std::__invoke). * doc/xml/manual/status_cxx2017.xml: Update status table. * include/std/functional (_

[PATCH, Fortran] New flag -finit-derived to initialize components of derived types

2016-08-04 Thread Fritz Reese
All, With many other compilers, local variables are automatically initialized to zero (or some other user-specified value) by default. GNU Fortran allows this with the options -finit-local-zero, -finit-real=, -finit-integer=, etc... However several other compilers also initialize structure variabl

  1   2   >