Re: [PATCH 7/7] Libsanitizer merge from upstream r249633.

2015-10-19 Thread Jakub Jelinek
On Fri, Oct 16, 2015 at 02:29:08PM +0300, Maxim Ostapenko wrote: > On 14/10/15 15:12, Jakub Jelinek wrote: > >On Wed, Oct 14, 2015 at 03:02:22PM +0300, Maxim Ostapenko wrote: > >>On 14/10/15 14:06, Jakub Jelinek wrote: > >>>On Wed, Oct 14, 2015 at 01:51:44PM +0300, Maxim Ostapenko wrote: > Ok,

Re: [PATCH 2/7] Libsanitizer merge from upstream r249633.

2015-10-19 Thread Jakub Jelinek
On Thu, Oct 15, 2015 at 01:34:06PM +0300, Maxim Ostapenko wrote: > Ah, right, fixing this now. Does this looks better now? Yes, it is ok now. > 2015-10-12 Maxim Ostapenko > > config/ > > * bootstrap-asan.mk: Replace ASAN_OPTIONS=detect_leaks with > LSAN_OPTIONS=detect_leaks. > >

[RFC] Add OPTGROUP_PAR

2015-10-19 Thread Tom de Vries
Hi, this patch adds OPTGROUP_PAR. It allows a user to see on stderr what loops are parallelized by pass_parallelize_loops, using -fopt-info-par: ... $ gcc -O2 -fopt-info-par test.c -ftree-parallelize-loops=32 test.c:5:3: note: parallelized inner loop ... This patch doesn't include any MSG_MIS

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-19 Thread Eric Botcazou
> Why is Ada fliddling with the modes? Is it only for packed structures? Yes, in Ada packing or representation clauses are allowed to modify the type of components, so you can have e.g. a record type with size S1 and BLKmode and fields of this type with a packed version of this record type (with

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-19 Thread Eric Botcazou
> Adding back the mode check is fine if all types with the same TYPE_CANONICAL > have the same mode. Otherwise we'd regress here. It's true for the Ada compiler, the type fiddling machinery always resets it. -- Eric Botcazou

Re: [patch 2/6] scalar-storage-order merge: C front-end

2015-10-19 Thread Eric Botcazou
> > + if (BYTES_BIG_ENDIAN != WORDS_BIG_ENDIAN) > > +error ("scalar_storage_order is not supported"); > > You might want to consider indicating why it's not supported. Not that > I expect folks to be using this on a pdp11 :-) Done, I added "because endianness is not uniform". > > - /*

[gomp4, committed] Don't parallelize loops in oacc routine

2015-10-19 Thread Tom de Vries
Hi, this patch prevents parloops from trying to parallelize loops in an oacc routine. Committed to gomp-4_0-branch. Thanks, - Tom Don't parallelize loops in oacc routine 2015-10-19 Tom de Vries * tree-parloops.c (parallelize_loops): Do not parallelize loops in offloaded functions. ---

Re: [RFC VTV] Fix VTV for targets that have section anchors.

2015-10-19 Thread Ramana Radhakrishnan
On Tue, Oct 13, 2015 at 1:53 PM, Ramana Radhakrishnan wrote: > > > > On 12/10/15 21:44, Jeff Law wrote: >> On 10/09/2015 03:17 AM, Ramana Radhakrishnan wrote: >>> This started as a Friday afternoon project ... >>> >>> It turned out enabling VTV for AArch64 and ARM was a matter of fixing >>> PR6786

Re: [PATCH] PR middle-end/68002: introduce -fkeep-static-functions

2015-10-19 Thread Richard Biener
On Sat, Oct 17, 2015 at 5:17 PM, VandeVondele Joost wrote: > In some cases (e.g. coverage testing) it is useful to emit code for static > functions even if they are never used, which currently is not possible at -O1 > and above. The following patch introduces a flag for this, which basically >

Re: [PATCH, committed] PR other/65800. Fix crash in gengtype's internal debug debug dump

2015-10-19 Thread Richard Biener
On Mon, Oct 19, 2015 at 1:46 AM, Mikhail Maltsev wrote: > Hi! > > gengtype has an option '-d' which allows to dump it's internal state. I > planned > to use it in order to create some kind of list of all data which GCC stores in > garbage-collected memory. > > Unfortunately this option was broken

Re: [RFC] Add OPTGROUP_PAR

2015-10-19 Thread Richard Biener
On Mon, Oct 19, 2015 at 9:27 AM, Tom de Vries wrote: > Hi, > > this patch adds OPTGROUP_PAR. > > It allows a user to see on stderr what loops are parallelized by > pass_parallelize_loops, using -fopt-info-par: > ... > $ gcc -O2 -fopt-info-par test.c -ftree-parallelize-loops=32 > test.c:5:3: note:

Re: [PATCH] Fix default_binds_local_p_2 for extern protected data

2015-10-19 Thread Szabolcs Nagy
On 14/10/15 10:55, Szabolcs Nagy wrote: On 30/09/15 20:23, Andreas Krebbel wrote: On 09/30/2015 06:21 PM, Szabolcs Nagy wrote: On 30/09/15 14:47, Bernd Schmidt wrote: On 09/17/2015 11:15 AM, Szabolcs Nagy wrote: ping 2. this patch is needed for working visibility ("protected") attribute for

[hsa] Fix ICE in build_outer_var_ref within GPUKERNEL

2015-10-19 Thread Martin Jambor
Hi, the following patch fixes a segfault when building an outer_ref which would be in GPUKERNEL context hwen lowering. In that case, we need to use the outer context od the GPUKERNEL container. Committed to the branch. Thanks, Martin 2015-10-19 Martin Jambor * omp-low.c (build_ou

Re: [gomp4.1] map clause parsing improvements

2015-10-19 Thread Thomas Schwinge
Hi! On Thu, 11 Jun 2015 14:14:20 +0200, Jakub Jelinek wrote: > On Tue, Jun 09, 2015 at 09:36:08PM +0300, Ilya Verbin wrote: > > On Wed, Apr 29, 2015 at 14:06:44 +0200, Jakub Jelinek wrote: > > > [...] The draft requires only alloc or to > > > (or always, variants) for enter data and only from or

Re: [gomp4.1] map clause parsing improvements

2015-10-19 Thread Jakub Jelinek
On Mon, Oct 19, 2015 at 12:20:23PM +0200, Thomas Schwinge wrote: > > @@ -77,7 +79,21 @@ enum gomp_map_kind > > /* ..., and copy from device. */ > > GOMP_MAP_FORCE_FROM = (GOMP_MAP_FLAG_FORCE | GOMP_MAP_FROM), > > /* ..., and copy to and from device. */ > > -GOMP_MAP_FO

Re: Add simple sign-stripping cases to match.pd

2015-10-19 Thread Richard Sandiford
Richard Sandiford writes: > Marc Glisse writes: >> On Thu, 15 Oct 2015, Richard Sandiford wrote: >> >>> This patch makes sure that, for every simplification that uses >>> fold_strip_sign_ops, there are associated match.pd rules for the >>> leaf sign ops, i.e. abs, negate and copysign. A follow-o

Re: Add simple sign-stripping cases to match.pd

2015-10-19 Thread Richard Sandiford
Richard Sandiford writes: > Richard Sandiford writes: >> Marc Glisse writes: >>> On Thu, 15 Oct 2015, Richard Sandiford wrote: >>> This patch makes sure that, for every simplification that uses fold_strip_sign_ops, there are associated match.pd rules for the leaf sign ops, i.e. ab

Re: [PATCH] Use GET_MODE_BITSIZE to get vector natural alignment

2015-10-19 Thread Uros Bizjak
On Fri, Oct 16, 2015 at 7:42 PM, H.J. Lu wrote: > Since GET_MODE_ALIGNMENT is defined by psABI and the biggest alignment > is 4 byte for IA MCU psABI, we should use GET_MODE_BITSIZE to get > vector natural alignment to check misaligned vector move. > > OK for trunk? > > Thanks. > > H.J. > --- >

[vec-cmp, patch 7/6] Vector comparison enabling in SLP

2015-10-19 Thread Ilya Enkovich
Hi, It appeared our testsuite doesn't have a test which would require vector comparison support in SLP even after boolean pattern disabling. This patch adds such tests and allow comparison for SLP. Is it OK? Thanks, Ilya -- gcc/ 2015-10-19 Ilya Enkovich * tree-vect-slp.c (vect_bu

Re: [PATCH] PR target/67995: __attribute__ ((target("arch=XXX"))) enables unsupported ISA

2015-10-19 Thread Uros Bizjak
On Sat, Oct 17, 2015 at 12:38 AM, H.J. Lu wrote: > When processing __attribute__ ((target("arch=XXX"))), we should clear > the ISA bits in x_ix86_isa_flags first to avoid leaking ISA from > command line. > > Tested on x86-64. OK for trunk? OK. Thanks, Uros. > Thanks. > > H.J. > --- > gcc/ > >

Re: [PATCH, rs6000] Pass --secure-plt to the linker

2015-10-19 Thread Alan Modra
On Thu, Oct 15, 2015 at 06:50:50PM +0100, Szabolcs Nagy wrote: > A powerpc toolchain built with (or without) --enable-secureplt > currently creates a binary that uses bss plt if > > (1) any of the linked PIC objects have bss plt relocs > (2) or all the linked objects are non-PIC or have no relocs,

Re: [PATCH] Use GET_MODE_BITSIZE to get vector natural alignment

2015-10-19 Thread H.J. Lu
On Mon, Oct 19, 2015 at 4:05 AM, Uros Bizjak wrote: > On Fri, Oct 16, 2015 at 7:42 PM, H.J. Lu wrote: >> Since GET_MODE_ALIGNMENT is defined by psABI and the biggest alignment >> is 4 byte for IA MCU psABI, we should use GET_MODE_BITSIZE to get >> vector natural alignment to check misaligned vect

Re: [PATCH] Use GET_MODE_BITSIZE to get vector natural alignment

2015-10-19 Thread Uros Bizjak
On Mon, Oct 19, 2015 at 1:12 PM, H.J. Lu wrote: > On Mon, Oct 19, 2015 at 4:05 AM, Uros Bizjak wrote: >> On Fri, Oct 16, 2015 at 7:42 PM, H.J. Lu wrote: >>> Since GET_MODE_ALIGNMENT is defined by psABI and the biggest alignment >>> is 4 byte for IA MCU psABI, we should use GET_MODE_BITSIZE to ge

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-19 Thread Bernd Schmidt
On 10/18/2015 08:17 AM, Mikhail Maltsev wrote: On 10/12/2015 11:57 PM, Jeff Law wrote: -#ifdef ENABLE_CHECKING +#if CHECKING_P I fail to see the point of this change. I'm guessing (and Mikhail, please correct me if I'm wrong), but I think he's trying to get away from ENABLE_CHECKING and inste

Re: Move some bit and binary optimizations in simplify and match

2015-10-19 Thread Hurugalawadi, Naveen
Hi, Please find attached the modified patch of duplicate patterns which were posted in the earlier part. Please review them and let me know if any further modifications are required. Thanks, Naveendiff --git a/gcc/fold-const.c b/gcc/fold-const.c index de45a2c..b36e2f5 100644 --- a/gcc/fold-const

Re: Move some bit and binary optimizations in simplify and match

2015-10-19 Thread Hurugalawadi, Naveen
Hi, >> That's not what Richard meant. We already have: Done. As per the comments. Please find attached the modified patch as per your comments. Please review them and let me know if any further modifications are required. Thanks, Naveendiff --git a/gcc/fold-const.c b/gcc/fold-const.c index de4

[mask-vec_cond, patch 3/2] SLP support

2015-10-19 Thread Ilya Enkovich
Hi, This patch adds missing support for cond_expr with no embedded comparison in SLP. No new test added because vec cmp SLP test becomes (due to changes in bool patterns by the first patch) a regression test for this patch. Does it look OK? Thanks, Ilya -- gcc/ 2015-10-19 Ilya Enkovich

Re: [PATCH] PR middle-end/68002: introduce -fkeep-static-functions

2015-10-19 Thread H.J. Lu
On Mon, Oct 19, 2015 at 2:18 AM, Richard Biener wrote: > On Sat, Oct 17, 2015 at 5:17 PM, VandeVondele Joost > wrote: >> In some cases (e.g. coverage testing) it is useful to emit code for static >> functions even if they are never used, which currently is not possible at >> -O1 and above. The

Re: Add a pass to back-propagate use information

2015-10-19 Thread Richard Biener
On Thu, Oct 15, 2015 at 3:17 PM, Richard Sandiford wrote: > This patch adds a pass that collects information that is common to all > uses of an SSA name X and back-propagates that information up the statements > that generate X. The general idea is to use the information to simplify > instruction

Re: Move some bit and binary optimizations in simplify and match

2015-10-19 Thread Marc Glisse
+/* Fold X + (X / CST) * -CST to X % CST. */ This one is still wrong. It is extremely similar to X-(X/CST)*CST, and the current version of that one in match.pd is broken, we should fix that one first. +/* Fold (A & ~B) - (A & B) into (A ^ B) - B. */ +(simplify + (minus (bit_and:s @0 (bit_no

Re: [PATCH] Use GET_MODE_BITSIZE to get vector natural alignment

2015-10-19 Thread H.J. Lu
On Mon, Oct 19, 2015 at 4:12 AM, Uros Bizjak wrote: > On Mon, Oct 19, 2015 at 1:12 PM, H.J. Lu wrote: >> On Mon, Oct 19, 2015 at 4:05 AM, Uros Bizjak wrote: >>> On Fri, Oct 16, 2015 at 7:42 PM, H.J. Lu wrote: Since GET_MODE_ALIGNMENT is defined by psABI and the biggest alignment is 4

Re: Remove fold_strip_sign_ops

2015-10-19 Thread Richard Biener
On Thu, Oct 15, 2015 at 3:28 PM, Richard Sandiford wrote: > This patch deletes fold_strip_sign_ops in favour of the tree-ssa-backprop.c > pass. > > Tested on x86_64-linux-gnu, aarch64-linux-gnu and arm-linux-gnueabi. > OK to install? Ok once the pass goes in. Thanks, Richard. > Thanks, > Richar

Re: [PATCH V3][GCC] Algorithmic optimization in match and simplify

2015-10-19 Thread Richard Biener
On Thu, Oct 15, 2015 at 3:50 PM, Christophe Lyon wrote: > On 9 October 2015 at 18:11, James Greenhalgh wrote: >> On Thu, Oct 08, 2015 at 01:29:34PM +0100, Richard Biener wrote: >>> > Thanks again for the comments Richard! >>> > >>> > A new algorithmic optimisation: >>> > >>> > ((X inner_op C0) ou

Re: [PATCH] tree-scalar-evolution.c: Handle LSHIFT by constant

2015-10-19 Thread Richard Biener
On Fri, Oct 16, 2015 at 5:25 PM, Alan Lawrence wrote: > This lets the vectorizer handle some simple strides expressed using left-shift > rather than mul, e.g. a[i << 1] (whereas previously only a[i * 2] would have > been handled). > > This patch does *not* handle the general case of shifts - neith

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-19 Thread Bernd Schmidt
diff --git a/gcc/cfgcleanup.c b/gcc/cfgcleanup.c - -#ifdef ENABLE_CHECKING - verify_flow_info (); -#endif + checking_verify_flow_info (); This looks misindented. -#ifdef ENABLE_CHECKING cgraph_edge *e; gcc_checking_assert ( !(e = caller->get_edg

Re: Add simple sign-stripping cases to match.pd

2015-10-19 Thread Richard Biener
On Mon, Oct 19, 2015 at 12:48 PM, Richard Sandiford wrote: > Richard Sandiford writes: >> Richard Sandiford writes: >>> Marc Glisse writes: On Thu, 15 Oct 2015, Richard Sandiford wrote: > This patch makes sure that, for every simplification that uses > fold_strip_sign_ops, the

[mask conversion, patch 1/2] Add pattern for mask conversions

2015-10-19 Thread Ilya Enkovich
Hi, This patch adds a vectorization pattern which detects cases where mask conversion is needed and adds it. It is done for all statements which may consume mask. Some additional changes were made to support MASK_LOAD with pattern and allow scalar mode for vectype of pattern stmt. It is appl

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-19 Thread Richard Biener
On Sun, Oct 18, 2015 at 7:14 PM, Jan Hubicka wrote: >> >> Adding back the mode check is fine if all types with the same TYPE_CANONICAL >> have the same mode. Otherwise we'd regress here. I thought we do for >> >> Struct x { int i; }; >> Typedef y x __attribute__((packed)); >> >> And then doing

[mask conversion, patch 2/2, i386] Add pack/unpack patterns for scalar masks

2015-10-19 Thread Ilya Enkovich
Hi, This patch adds patterns to be used for vector masks pack/unpack for AVX512. Bootstrapped and tested on x86_64-unknown-linux-gnu. Does it look OK? Thanks, Ilya -- gcc/ 2015-10-19 Ilya Enkovich * config/i386/sse.md (HALFMASKMODE): New attribute. (DOUBLEMASKMODE): New a

Re: [c++-delayed-folding] First stab at convert_to_integer

2015-10-19 Thread Marek Polacek
On Fri, Oct 16, 2015 at 02:07:51PM -1000, Jason Merrill wrote: > On 10/16/2015 07:35 AM, Marek Polacek wrote: > >>This code path seems to be for pushing a conversion down into a binary > >>expression. We shouldn't do this at all when we aren't folding. > > > >I tend to agree, but this case is tric

Re: Move some bit and binary optimizations in simplify and match

2015-10-19 Thread Richard Biener
On Mon, Oct 19, 2015 at 1:14 PM, Hurugalawadi, Naveen wrote: > Hi, > >>> That's not what Richard meant. We already have: > > Done. As per the comments. > > Please find attached the modified patch as per your comments. > > Please review them and let me know if any further modifications are required

Re: Add a pass to back-propagate use information

2015-10-19 Thread Richard Sandiford
Richard Biener writes: > On Thu, Oct 15, 2015 at 3:17 PM, Richard Sandiford > wrote: >> This patch adds a pass that collects information that is common to all >> uses of an SSA name X and back-propagates that information up the statements >> that generate X. The general idea is to use the inform

Re: [PATCH, rs6000] Pass --secure-plt to the linker

2015-10-19 Thread Szabolcs Nagy
On 19/10/15 12:12, Alan Modra wrote: On Thu, Oct 15, 2015 at 06:50:50PM +0100, Szabolcs Nagy wrote: A powerpc toolchain built with (or without) --enable-secureplt currently creates a binary that uses bss plt if (1) any of the linked PIC objects have bss plt relocs (2) or all the linked objects

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-19 Thread Mikhail Maltsev
On 10/19/2015 02:13 PM, Bernd Schmidt wrote: > But for normal C conditions the patches end up using flag_checking, so > the CHECKING_P macro buys us nothing over ENABLE_CHECKING. Presumably 'if (CHECKING_P)' can be used for performance-critical parts (in this case the condition will be DCE-d) and a

[PATCH] Move cproj simplification to match.pd

2015-10-19 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-10-19 Richard Biener * gimple-fold.c (gimple_phi_nonnegative_warnv_p): New function. (gimple_stmt_nonnegative_warnv_p): Use it. * match.pd (CPROJ): New operator list. (cproj (complex .

[PATCH][AArch64][1/2] Add fmul-by-power-of-2+fcvt optimisation

2015-10-19 Thread Kyrill Tkachov
Hi all, The fcvtzs and fcvtzu instructions have a form where they convert to a fixed-point form with a specified number of fractional bits. In practice this has the effect of multiplying the floating point argument by 2^ and then converting the result to integer. We can exploit that behaviour d

[PATCH][simplify-rtx][2/2] Use constants from pool when simplifying binops

2015-10-19 Thread Kyrill Tkachov
Hi all, This second patch teaches simplify_binary_operation to return the dereferenced constants from the constant pool in the binary expression if other simplifications failed. This, combined with the 1/2 patch for aarch64 (https://gcc.gnu.org/ml/gcc-patches/2015-10/msg01744.html) allow for:

[PATCH v10][aarch64] Implemented reciprocal square root (rsqrt) estimation in -ffast-math

2015-10-19 Thread Benedikt Huber
This tenth revision of the patch: * Removes unnecessary enum. Ok for check in. Benedikt Huber (1): 2015-10-19 Benedikt Huber Philipp Tomsich gcc/ChangeLog | 20 gcc/config/aarch64/aarch64-builtins.c | 115 +

[PATCH] 2015-10-19 Benedikt Huber Philipp Tomsich

2015-10-19 Thread Benedikt Huber
* config/aarch64/aarch64-builtins.c: Builtins for rsqrt and rsqrtf. * config/aarch64/aarch64-protos.h: Declare. * config/aarch64/aarch64-simd.md: Matching expressions for frsqrte and frsqrts. * config/aarch64/aarch64-tuning-flags.def: Added recip_sqrt.

Re: [PATCH v10][aarch64] Implemented reciprocal square root (rsqrt) estimation in -ffast-math

2015-10-19 Thread Bernd Schmidt
On 01/04/1970 01:02 AM, Benedikt Huber wrote: This tenth revision of the patch: * Removes unnecessary enum. Please fix your clock. Bernd

Re: [PATCH][simplify-rtx][2/2] Use constants from pool when simplifying binops

2015-10-19 Thread Segher Boessenkool
Hi Kyrill, On Mon, Oct 19, 2015 at 02:57:54PM +0100, Kyrill Tkachov wrote: > because combine now successfully tries to match: > (set (reg/i:SI 0 x0) > (fix:SI (mult:SF (reg:SF 32 v0 [ a ]) > (const_double:SF 3.2e+1 [0x0.8p+6] > > whereas before it would not try the to use the

Re: [PATCH][simplify-rtx][2/2] Use constants from pool when simplifying binops

2015-10-19 Thread Bernd Schmidt
On 10/19/2015 03:57 PM, Kyrill Tkachov wrote: This second patch teaches simplify_binary_operation to return the dereferenced constants from the constant pool in the binary expression if other simplifications failed. This, combined with the 1/2 patch for aarch64 (https://gcc.gnu.org/ml/gcc-patche

Re: Add a pass to back-propagate use information

2015-10-19 Thread Richard Biener
On Mon, Oct 19, 2015 at 2:38 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Thu, Oct 15, 2015 at 3:17 PM, Richard Sandiford >> wrote: >>> This patch adds a pass that collects information that is common to all >>> uses of an SSA name X and back-propagates that information up the stat

Re: [PATCH][simplify-rtx][2/2] Use constants from pool when simplifying binops

2015-10-19 Thread Kyrill Tkachov
On 19/10/15 15:31, Segher Boessenkool wrote: Hi Kyrill, Hi Segher, On Mon, Oct 19, 2015 at 02:57:54PM +0100, Kyrill Tkachov wrote: because combine now successfully tries to match: (set (reg/i:SI 0 x0) (fix:SI (mult:SF (reg:SF 32 v0 [ a ]) (const_double:SF 3.2e+1 [0x0.8p+6

Re: [PATCH][simplify-rtx][2/2] Use constants from pool when simplifying binops

2015-10-19 Thread Kyrill Tkachov
Hi Bernd, On 19/10/15 15:31, Bernd Schmidt wrote: On 10/19/2015 03:57 PM, Kyrill Tkachov wrote: This second patch teaches simplify_binary_operation to return the dereferenced constants from the constant pool in the binary expression if other simplifications failed. This, combined with the 1/2

Move cabs simplifications to match.pd

2015-10-19 Thread Richard Sandiford
The fold code also expanded cabs(x+yi) to fsqrt(x*x+y*y) when optimising for speed. tree-ssa-math-opts.c has this transformation too, but unlike the fold code, it first checks whether the target implements the sqrt optab. The patch simply removes the fold code and keeps the tree-ssa-math-opts.c l

Re: Benchmarks of v2 (was Re: [PATCH 0/5] RFC: Overhaul of diagnostics (v2))

2015-10-19 Thread Michael Matz
Hi, On Fri, 16 Oct 2015, David Malcolm wrote: > This fixes much of the bloat seen for influence.i when sending ranges > through for every token. Yeah, I think that's on the right track. > This was with 8 bits allocated for packed ranges (which is probably > excessive, but it makes debugging e

Re: Add a pass to back-propagate use information

2015-10-19 Thread Richard Sandiford
Richard Biener writes: diff --git a/gcc/fold-const.c b/gcc/fold-const.c index de45a2c..7f00e72 100644 --- a/gcc/fold-const.c +++ b/gcc/fold-const.c @@ -319,7 +318,7 @@ fold_overflow_warning (const char* gmsgid, enum >>> warn_strict_overflow_code wc) /* Return true if

Re: [gomp4.1] map clause parsing improvements

2015-10-19 Thread Thomas Schwinge
Hi! On Mon, 19 Oct 2015 12:34:08 +0200, Jakub Jelinek wrote: > On Mon, Oct 19, 2015 at 12:20:23PM +0200, Thomas Schwinge wrote: > > > +/* Decrement usage count and deallocate if zero. */ > > > +GOMP_MAP_RELEASE = (GOMP_MAP_FLAG_ALWAYS > > > +

Re: Fix prototype for print_insn in rtl.h

2015-10-19 Thread Jeff Law
On 10/15/2015 10:28 AM, Andrew MacLeod wrote: On 10/13/2015 11:32 AM, Jeff Law wrote: On 10/13/2015 02:21 AM, Nikolai Bozhenov wrote: 2015-10-13 Nikolai Bozhenov * gcc/rtl.h (print_insn): fix prototype Installed on the trunk after bootstrap & regression test. jeff Sorry, a little lat

Re: Split out some tests from builtins-20.c

2015-10-19 Thread Jeff Law
On 10/15/2015 07:18 AM, Richard Sandiford wrote: Stripping unnecessary sign ops at the gimple level means that we're no longer able to optimise: if (cos(y<10 ? -fabs(x) : tan(x<20 ? -x : -fabs(y))) != cos(y<10 ? x : tan(x<20 ? x : y))) link_error (); because we're currently not a

[c++-delayed-folding] Introduce convert_to_pointer_nofold

2015-10-19 Thread Marek Polacek
This patch introduces convert_to_pointer_nofold; a variant that only folds CONSTANT_CLASS_P expressions. In the C++ FE, convert_to_pointer was only used in cp_convert_to_pointer which is only used in cp_convert. Instead of introducing many _nofold variants, I just made cp_convert_to_pointer use t

[c++-delayed-folding] Use convert_to_integer_nofold

2015-10-19 Thread Marek Polacek
As discussed in the other thread. This is a patch I intend to commit to the branch when I can actually commit stuff. diff --git gcc/cp/semantics.c gcc/cp/semantics.c index 9a8caa7..d15d6f9 100644 --- gcc/cp/semantics.c +++ gcc/cp/semantics.c @@ -5577,7 +5577,8 @@ finish_omp_clauses (tree clauses)

[gomp4.5] Add checking that OpenMP loop iterators aren't referenced in the bounds/step expressions

2015-10-19 Thread Jakub Jelinek
Hi! In 4.0 and earlier, there has just been a restriction that the lb, b and incr expressions in the syntax (low/high bounds and step) can't change their values during the loop, but in OpenMP 4.5 we have even stronger restriction, the iterators may not be referenced in there at all, so even if you

Re: config header file reduction patch checked in.

2015-10-19 Thread Andrew MacLeod
On 10/18/2015 05:31 AM, Iain Sandoe wrote: Hi Andrew, On 16 Oct 2015, at 20:49, Andrew MacLeod wrote: On 10/12/2015 04:04 AM, Jeff Law wrote: On 10/08/2015 07:37 AM, Andrew MacLeod wrote: On 10/07/2015 06:02 PM, Jeff Law wrote: I'm slightly concerned about the darwin, windows and solaris bi

[gomp4] Merge gomp-4_1-branch r224607 (2015-06-18) into gomp-4_0-branch

2015-10-19 Thread Thomas Schwinge
Hi! I have recently merged trunk r228776 (2015-10-13) into gomp-4_0-branch, which is the trunk revision before Jakub's big "Merge from gomp-4_1-branch to trunk", . Instead of attempting to merge that one

Re: [mask-vec_cond, patch 3/2] SLP support

2015-10-19 Thread Jeff Law
On 10/19/2015 05:21 AM, Ilya Enkovich wrote: Hi, This patch adds missing support for cond_expr with no embedded comparison in SLP. No new test added because vec cmp SLP test becomes (due to changes in bool patterns by the first patch) a regression test for this patch. Does it look OK? Than

[PATCH] Don't allow FSM threader to create irreducible loops unless it eliminates a multi-way branch

2015-10-19 Thread Jeff Law
If I hack up GCC's old jump threader to avoid threading across backedges and instead let the FSM threader handle that case, then we end up with cases where the FSM threader creates irreducible loops with marginal benefit. This can be seen in ssa-dom-thread-2{d,e,f}.c. We've long avoided such

OpenACC async clause regressions (was: [gomp4.1] Add new versions of GOMP_target{,_data,_update} and GOMP_target_enter_exit_data)

2015-10-19 Thread Thomas Schwinge
Hi! Chung-Lin, would you please have a look at the following (on gomp-4_0-branch)? Also, anyone else got any ideas off-hand? On Tue, 23 Jun 2015 13:51:39 +0200, Jakub Jelinek wrote: > On Tue, Jun 23, 2015 at 02:40:43PM +0300, Ilya Verbin wrote: > > On Sat, Jun 20, 2015 at 00:35:14 +0300, Ilya V

Re: Fix prototype for print_insn in rtl.h

2015-10-19 Thread Jeff Law
On 10/19/2015 09:14 AM, Jeff Law wrote: On 10/15/2015 10:28 AM, Andrew MacLeod wrote: On 10/13/2015 11:32 AM, Jeff Law wrote: On 10/13/2015 02:21 AM, Nikolai Bozhenov wrote: 2015-10-13 Nikolai Bozhenov * gcc/rtl.h (print_insn): fix prototype Installed on the trunk after bootstrap & reg

Re: [patch] fix gotools cross build

2015-10-19 Thread Ian Lance Taylor
On Wed, May 6, 2015 at 5:34 AM, Matthias Klose wrote: > > Yes, it's documented that there is still some work to do for cross builds, > however a cross build for gotools currently fails. > > The toplevel make always passes the GOC variable in the environment, > overwriting > anything configured in

Re: OpenACC async clause regressions (was: [gomp4.1] Add new versions of GOMP_target{,_data,_update} and GOMP_target_enter_exit_data)

2015-10-19 Thread Ilya Verbin
On Mon, Oct 19, 2015 at 18:24:35 +0200, Thomas Schwinge wrote: > Chung-Lin, would you please have a look at the following (on > gomp-4_0-branch)? Also, anyone else got any ideas off-hand? > > PASS: libgomp.oacc-c/../libgomp.oacc-c-c++-common/data-2.c > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SH

Forwarding -foffload=[...] from the driver (compile-time) to libgomp (run-time)

2015-10-19 Thread Thomas Schwinge
Hi! Ping... On Wed, 30 Sep 2015 17:54:07 +0200, I wrote: > On Tue, 29 Sep 2015 10:18:14 +0200, Jakub Jelinek wrote: > > On Mon, Sep 28, 2015 at 11:39:10AM +0200, Thomas Schwinge wrote: > > > On Fri, 11 Sep 2015 17:43:49 +0200, Jakub Jelinek > > > wrote: > > > > So, do I understand well that yo

Re: [PATCH 1/3] [ARM] PR63870 Add qualifiers for NEON builtins

2015-10-19 Thread Alan Lawrence
On 14/10/15 23:02, Charles Baylis wrote: On 12 October 2015 at 11:58, Alan Lawrence wrote: > Given we are making changes here to how this all works on bigendian, have you tested armeb at all? I tested on big endian, and it passes, except Well, I asked because it seemed good to make sur

Re: [vec-cmp, patch 7/6] Vector comparison enabling in SLP

2015-10-19 Thread Jeff Law
On 10/19/2015 05:06 AM, Ilya Enkovich wrote: Hi, It appeared our testsuite doesn't have a test which would require vector comparison support in SLP even after boolean pattern disabling. This patch adds such tests and allow comparison for SLP. Is it OK? Thanks, Ilya -- gcc/ 2015-10-19 Ilya

Re: [PR fortran/63858] Fix mix of OpenACC and OpenMP sentinels in continuations

2015-10-19 Thread Thomas Schwinge
Hi! Ping... On Fri, 9 Oct 2015 12:15:24 +0200, I wrote: > On Mon, 27 Jul 2015 16:14:17 +0200, I wrote: > > On Tue, 30 Jun 2015 03:39:42 +0300, Ilmir Usmanov wrote: > > > 08.06.2015, 17:59, "Cesar Philippidis" : > > > > On 06/07/2015 02:05 PM, Ilmir Usmanov wrote: > > > >> 08.06.2015, 00:01, "Il

[HSA] Class refactoring

2015-10-19 Thread Martin Liška
Hello. Following tarball is made of patches that rename class member variables to respect C++ coding style, where all member variables should begin with 'm_'. Martin hsa-class-refactoring.tar.bz2 Description: application/bzip

Re: Move cabs simplifications to match.pd

2015-10-19 Thread Richard Biener
On October 19, 2015 4:42:23 PM GMT+02:00, Richard Sandiford wrote: >The fold code also expanded cabs(x+yi) to fsqrt(x*x+y*y) when >optimising >for speed. tree-ssa-math-opts.c has this transformation too, but >unlike >the fold code, it first checks whether the target implements the sqrt >optab.

[gomp4] auto partitioning

2015-10-19 Thread Nathan Sidwell
I've committed this patch to gomp4 branch. It implements handling of the 'auto' clause on a loop. such loops can be implicitly partitioned, if they are (explicitly or implicitly) 'independent'. This patch walks the loop structure after explicit partitioning has been handled, and attempts to a

Re: [PATCH] mn10300: Use the STC bb-reorder algorithm at -Os

2015-10-19 Thread Jeff Law
On 10/16/2015 06:53 AM, Segher Boessenkool wrote: For mn10300, STC still gives better results for optimise-for-size than "simple" does. So use STC at -Os as well. Is this okay for trunk? Segher 2015-10-16 Segher Boessenkool * common/config/mn10300/mn10300-common.c (mn103

Re: [Patch] Add OPT_Wattributes to ignored attributes on template args

2015-10-19 Thread Ryan Mansfield
Ping: https://gcc.gnu.org/ml/gcc-patches/2015-09/msg02256.html Regards, Ryan Mansfield On 15-09-29 04:21 PM, Ryan Mansfield wrote: Hi, In canonicalize_type_argument attributes are being discarded with a warning. Should it be added to OPT_Wattributes? 2015-09-29 Ryan Mansfield *

Re: [PATCH] Fix default_binds_local_p_2 for extern protected data

2015-10-19 Thread Richard Henderson
On 07/22/2015 07:01 AM, Szabolcs Nagy wrote: 2015-07-22 Szabolcs Nagy PR target/66912 * varasm.c (default_binds_local_p_2): Turn on extern_protected_data. gcc/testsuite/ChangeLog: 2015-07-22 Szabolcs Nagy PR target/66912 * gcc.target/aarch64/pr66912.c: New.

Re: [PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

2015-10-19 Thread Mike Stump
On Oct 18, 2015, at 3:42 AM, Iain Sandoe wrote: This seems likely to break cross-compilers to Darwin that do not have the system libraries available. I guess I don't care about that if you don't. >>> >>> I do care about it, but I'm not visualising the case... >>> >>> AFAICS, when

Re: [PATCH, sh][v3] musl support for sh

2015-10-19 Thread Szabolcs Nagy
On 17/10/15 02:14, Oleg Endo wrote: On Fri, 2015-10-16 at 17:06 +0100, Szabolcs Nagy wrote: Revision of https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01636.html The musl dynamic linker name is /lib/ld-musl-sh{-nofpu}{-fdpic}.so.1 New in this revision: Add -fdpic to the name, will be useful wi

Re: [PATCH, rs6000] Pass --secure-plt to the linker

2015-10-19 Thread Szabolcs Nagy
On 19/10/15 14:04, Szabolcs Nagy wrote: On 19/10/15 12:12, Alan Modra wrote: On Thu, Oct 15, 2015 at 06:50:50PM +0100, Szabolcs Nagy wrote: A powerpc toolchain built with (or without) --enable-secureplt currently creates a binary that uses bss plt if (1) any of the linked PIC objects have bss

[PATCH] fortran/68019 -- Remove an assert() that prevents error message

2015-10-19 Thread Steve Kargl
The attached patch removes an assert() that prevents gfortran from issuing an error message. Built and tested on x86_64-*-freebsd. Althoug probably an "obviously correct" patch, OK to commit? 2015-10-19 Steven G. Kargl PR fortran/68019 * decl.c (add_init_expr_to_sym): Remove a

Re: [PATCH] Fix partial template specialization syntax in wide-int.h

2015-10-19 Thread H.J. Lu
On Mon, Jul 20, 2015 at 12:15 AM, Mikhail Maltsev wrote: > On 07/17/2015 07:46 PM, Mike Stump wrote: >> On Jul 17, 2015, at 2:28 AM, Mikhail Maltsev wrote: >>> The following code (reduced from wide-int.h) is rejected by Intel C++ >>> Compiler (EDG-based): >> >> So, could you test this with the to

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-19 Thread Jan Hubicka
Hi, this is patch that reverts the TYPE_MODE mismatch related changes and adds test to type checker that TYPE_MODE always match with TYPE_CANONICAL. I have bootstrapped/regtested x86_64-linux, but unfrtunately the regtesting had some unrelated noise (spawn failures). I am re-testing. I am on a trip

Re: [PATCH] Fix partial template specialization syntax in wide-int.h

2015-10-19 Thread H.J. Lu
On Mon, Oct 19, 2015 at 12:39 PM, H.J. Lu wrote: > On Mon, Jul 20, 2015 at 12:15 AM, Mikhail Maltsev wrote: >> On 07/17/2015 07:46 PM, Mike Stump wrote: >>> On Jul 17, 2015, at 2:28 AM, Mikhail Maltsev wrote: The following code (reduced from wide-int.h) is rejected by Intel C++ Compile

Re: [gomp4.1] depend nowait support for target {update,{enter,exit} data}

2015-10-19 Thread Ilya Verbin
On Thu, Oct 15, 2015 at 16:01:56 +0200, Jakub Jelinek wrote: > >void *fn_addr = gomp_get_target_fn_addr (devicep, fn); > > > > + if (flags & GOMP_TARGET_FLAG_NOWAIT) > > +{ > > + gomp_create_target_task (devicep, fn_addr, mapnum, hostaddrs, sizes, > > + kind

PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86

2015-10-19 Thread H.J. Lu
-- Forwarded message -- From: H.J. Lu Date: Wed, Sep 9, 2015 at 3:02 PM Subject: [PATCH] PR target/67215: -fno-plt needs improvements for x86 To: gcc-patches@gcc.gnu.org prepare_call_address in calls.c is the wrong place to handle -fno-plt. We shoudn't force function address into

Re: [c++-delayed-folding] First stab at convert_to_integer

2015-10-19 Thread Jason Merrill
On 10/19/2015 02:31 AM, Marek Polacek wrote: On Fri, Oct 16, 2015 at 02:07:51PM -1000, Jason Merrill wrote: On 10/16/2015 07:35 AM, Marek Polacek wrote: This code path seems to be for pushing a conversion down into a binary expression. We shouldn't do this at all when we aren't folding. I te

Re: [PATCH] fortran/68019 -- Remove an assert() that prevents error message

2015-10-19 Thread Paul Richard Thomas
Hi Steve, Yes, this is OK for trunk. I suggest that it is so obvious that it should go into 5 branch as well. Cheers Paul On 19 October 2015 at 21:13, Steve Kargl wrote: > The attached patch removes an assert() that prevents gfortran from > issuing an error message. Built and tested on x86_64

PING: [PATCH] X86: Optimize access to globals in PIE with copy reloc

2015-10-19 Thread H.J. Lu
PING. -- Forwarded message -- From: H.J. Lu Date: Wed, Jul 1, 2015 at 5:11 AM Subject: [PATCH] X86: Optimize access to globals in PIE with copy reloc To: gcc-patches@gcc.gnu.org Normally, with PIE, GCC accesses globals that are extern to the module using GOT. This is two instr

Re: New power of 2 hash policy

2015-10-19 Thread François Dumont
Is this one ok ? François On 28/09/2015 21:16, François Dumont wrote: > On 25/09/2015 15:28, Jonathan Wakely wrote: >> @@ -501,6 +503,129 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION >>> mutable std::size_t_M_next_resize; >>> }; >>> >>> + /// Range hashing function considering that second args

Re: [c++-delayed-folding] First stab at convert_to_integer

2015-10-19 Thread Marek Polacek
On Mon, Oct 19, 2015 at 09:59:03AM -1000, Jason Merrill wrote: > >Done. But I can't seem to commit the patch to the c++-delayed-folding > >branch; is that somehow restricted? I'm getting: > > > >svn: E170001: Commit failed (details follow): > >svn: E170001: Authorization failed > >svn: E170001: Y

[PATCH] Refactoring sese.h and graphite-poly.h

2015-10-19 Thread Aditya Kumar
Rename scop->region to scop->scop_info Removed conversion constructors for sese_l and dr_info. Removed macros. No functional changed intended. Passes regtest and bootstrap. gcc/ChangeLog: 2015-19-10 Aditya Kumar * graphite-poly.h (struct dr_info): Removed conversion constructor.

Re: [PATCH] Move cproj simplification to match.pd

2015-10-19 Thread Christophe Lyon
On 19 October 2015 at 15:54, Richard Biener wrote: > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > Hi Richard, This patch caused arm and aarch64 builds of newlib to cause ICEs: In file included from /tmp/884316_1.tmpdir/aci-gcc-fsf/sources/newlib/newlib/libc/include/stdlib.h:

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-19 Thread Jan Hubicka
Richard, I missed your reply earlier today. > > Therefore I would say that TYPE_CANONICAL determine mode modulo the fact > > that > > incoplete variant of a complete type will have VOIDmode instead of complete > > type's mode (during non-LTO). That is why I allow mode changes for casts > > from

Re: [patch] header file re-ordering.

2015-10-19 Thread Jeff Law
On 10/14/2015 08:05 AM, Andrew MacLeod wrote: On 10/12/2015 04:04 AM, Jeff Law wrote: Oh, you must be looking at the original combined patch? Possibly :-) fold-const.h is indirectly included by cp-tree.h, which gets it from including c-common.h. some of the output from show-headers on objc

  1   2   >