> > + if (BYTES_BIG_ENDIAN != WORDS_BIG_ENDIAN)
> > + error ("scalar_storage_order is not supported");
>
> You might want to consider indicating why it's not supported. Not that
> I expect folks to be using this on a pdp11 :-)
Done, I added "because endianness is not uniform".
> > - /* For &x[y], return x+y */
> > - if (TREE_CODE (arg) == ARRAY_REF)
> > - {
> > - tree op0 = TREE_OPERAND (arg, 0);
> > - if (!c_mark_addressable (op0))
> > - return error_mark_node;
> > - }
>
> Do we still get a proper diagnostic for &x[y] where x isn't something we
> can mark addressable?
Yes, c_mark_addressable is invoked on 'arg' later and the function looks into
the prefix of an ARRAY_REF
> No real objections, assuming that &x[y] diagnostics is still handled
> correctly somewhere.
OK, thanks.
--
Eric Botcazou
