Re: [PATCH] -fsanitize-recover=list

2014-12-19 Thread Jakub Jelinek
On Thu, Dec 18, 2014 at 05:34:12PM -0800, Alexey Samsonov wrote: > Reviving this thread. > > What do you think of the following idea: > 1) we keep "-fsanitize-recover" and "-fno-sanitize-recover" as > deprecated synonyms > for "-f(no-)?sanitize=" > 2) we introduce -fsanitize-recover= and > -fno-sa

[PATCHv2][PING] New check and updates in check_GNU_style script

2014-12-19 Thread Yury Gribov
Hi all, Attached patch adds new check (all blocks of 8 spaces are replaced with tabs) to contrib/check_GNU_style.sh. It also changes the script to allow reading patches from stdin and strengthens the "Dot, space, space, new sentence." check. Is this ok to commit? -Y >From c099086a7325d5feca286

[PATCH, 2/2][ARM]: New CPU support for Marvell Whitney

2014-12-19 Thread Xingxing Pan
Hi, This patch expands the arm types neon_logic, neon_from_gp and neon_to_gp. This change mainly suits to marvell-whitney cores, and will not affect other arm core's pipeline description. neon_logic is expanded to neon_logic_reg and neon_logic_imm, corresponding respectively to the predicates s_

Re: Speedup and cleanup hash-table.h

2014-12-19 Thread Richard Biener
On December 19, 2014 12:48:22 AM CET, Jan Hubicka wrote: >Hi, >this patch started as experiment moving hash_table_mod1 inline because >it shows >high in streaming profiles and it represents a branch-less code that is >good >to schedule to surrounding instructions. >While looking at hash-tab.h I ho

Re: [PATCH, 2/2][ARM]: New CPU support for Marvell Whitney

2014-12-19 Thread James Greenhalgh
On Fri, Dec 19, 2014 at 08:19:17AM +, Xingxing Pan wrote: > Hi, > > This patch expands the arm types neon_logic, neon_from_gp and > neon_to_gp. This change mainly suits to marvell-whitney cores, and > will not affect other arm core's pipeline description. > > neon_logic is expanded to neon_lo

RES: Aproved patches

2014-12-19 Thread Ricardo Sardano Guanciale
Jakub, first thanks for answering, one question: Only tested and approved patches are commited? Ricardo -Mensagem original- De: Jakub Jelinek [mailto:ja...@redhat.com] Enviada em: quinta-feira, 18 de dezembro de 2014 15:35 Para: Ricardo Sardano Guanciale Cc: gcc-patches@gcc.gnu.org Assun

Re: RES: Aproved patches

2014-12-19 Thread Jakub Jelinek
On Fri, Dec 19, 2014 at 07:36:12AM -0200, Ricardo Sardano Guanciale wrote: > Jakub, first thanks for answering, one question: Only tested and approved > patches are commited? Sure. Jakub

Re: [PATCH][ARM] Fix reservation pattern in cortex-a9-neon.md

2014-12-19 Thread James Greenhalgh
On Fri, Dec 19, 2014 at 02:46:51AM +, Xingxing Pan wrote: > Hi, > > This patch fix the reservation pattern of cortex_a9_neon_vmov in > cortex-a9-neon.md. > > Is it OK for trunk? This patch is obvious, and fixes my typo. I couldn't see your name or email address in the MAINTAINERS file, so

Re: [PATCH][ARM] Fix reservation pattern in cortex-a9-neon.md

2014-12-19 Thread Xingxing Pan
Brilliant! Xingxing On 19/12/2014 17:44, James Greenhalgh wrote: On Fri, Dec 19, 2014 at 02:46:51AM +, Xingxing Pan wrote: Hi, This patch fix the reservation pattern of cortex_a9_neon_vmov in cortex-a9-neon.md. Is it OK for trunk? This patch is obvious, and fixes my typo. I couldn't s

[PATCH] Fix for PR64081 in RTL loop unroller

2014-12-19 Thread Zamyatin, Igor
Hi! This is an attempt to extend RTL unroller to allow cases like mentioned in the PR - namely when loop has duplicated exit blocks and back edges. Bootstrapped and regtested on x86_64, also checking wide range of benchmarks - spec2K, spec2006, EEMBC Is it ok for trunk in case if no testing is

Re: [PATCH][ARM][doc] Remove mention of Advanced RISC Machines

2014-12-19 Thread Kyrill Tkachov
On 18/12/14 17:37, James Greenhalgh wrote: On Thu, Dec 18, 2014 at 05:18:18PM +, Kyrill Tkachov wrote: Ping. https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00947.html This patch almost certainly falls under the obvious rule: "will the person who objects to my work the most be able to

Re: [PATCH] PR 62173, re-shuffle insns for RTL loop invariant hoisting

2014-12-19 Thread Jiong Wang
2014-12-19 3:51 GMT+00:00 Bin.Cheng : > On Fri, Dec 19, 2014 at 6:09 AM, Segher Boessenkool > wrote: >> On Thu, Dec 18, 2014 at 05:00:01PM +, Jiong Wang wrote: >>> On 17/12/14 15:54, Richard Biener wrote: >>> >ick. I realize we don't have SSA form on RTL but doesn't DF provide >>> >at least s

Re: [PATCH, 2/2][ARM]: New CPU support for Marvell Whitney

2014-12-19 Thread Xingxing Pan
On 19/12/2014 17:35, James Greenhalgh wrote: On Fri, Dec 19, 2014 at 08:19:17AM +, Xingxing Pan wrote: Hi, This patch expands the arm types neon_logic, neon_from_gp and neon_to_gp. This change mainly suits to marvell-whitney cores, and will not affect other arm core's pipeline description.

Re: [RFC, PATCH, fortran] PR fortran/60255 Deferred character length

2014-12-19 Thread Dominique d'Humières
Hi Andre, I have posted my results with your patch (and those for pr63851) at https://gcc.gnu.org/ml/gcc-testresults/2014-12/msg02408.html. I don’t see any problem with unlimited_polymorphic_2.f90. However the character lengths are now wrong (they are 0) with your old patch for pr60289 at https

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2014-12-19 Thread Kyrill Tkachov
Hi Xingxing, On 18/12/14 10:13, Xingxing Pan wrote: + +(define_attr "tune_marvell_whitney" "yes,no" + (const (if_then_else (eq_attr "tune" "marvell_whitney") + (const_string "yes") + (const_string "no" Why do you need this? The canonical way we

Re: Pragma parsing

2014-12-19 Thread Jakub Jelinek
On Thu, Dec 18, 2014 at 07:00:09PM +0100, Thomas Schwinge wrote: > > The point is that we now have lots of clauses, and making it clear what from > > those clauses are Cilk+, what are OpenACC, what are OpenMP will help with > > code readability. So here is what I'd like to see with PRAGMA_O*_CLAUS

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2014-12-19 Thread Kyrill Tkachov
Hi Xingxin, It seems that your mail client mangled this patch, at least the following hunk doesn't apply, even when I try to get it from the web archives. Could you please resend it as an attachment perhaps? Thanks, Kyrill On 18/12/14 10:13, Xingxing Pan wrote: diff --git a/gcc/config/arm/a

Re: [PATCH] IPA ICF: refactoring + fix for PR ipa/63569

2014-12-19 Thread Richard Biener
On Thu, Dec 18, 2014 at 2:39 PM, Martin Liška wrote: > On 12/17/2014 04:23 PM, Richard Biener wrote: >> >> On Wed, Dec 17, 2014 at 12:17 PM, Martin Liška wrote: >>> >>> On 12/11/2014 01:37 PM, Richard Biener wrote: On Wed, Dec 10, 2014 at 1:18 PM, Martin Liška wrote: > > >

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2014-12-19 Thread Xingxing Pan
On 19/12/2014 18:38, Kyrill Tkachov wrote: Hi Xingxin, It seems that your mail client mangled this patch, at least the following hunk doesn't apply, even when I try to get it from the web archives. Could you please resend it as an attachment perhaps? Thanks, Kyrill On 18/12/14 10:13, Xingxing

Re: [PATCH, 2/2][ARM]: New CPU support for Marvell Whitney

2014-12-19 Thread Xingxing Pan
On 19/12/2014 18:29, Xingxing Pan wrote: On 19/12/2014 17:35, James Greenhalgh wrote: On Fri, Dec 19, 2014 at 08:19:17AM +, Xingxing Pan wrote: Hi, This patch expands the arm types neon_logic, neon_from_gp and neon_to_gp. This change mainly suits to marvell-whitney cores, and will not affe

Re: [PATCH] IPA ICF: refactoring + fix for PR ipa/63569

2014-12-19 Thread Richard Biener
On Thu, Dec 18, 2014 at 6:38 PM, Martin Liška wrote: > On 12/17/2014 04:23 PM, Richard Biener wrote: >> >> On Wed, Dec 17, 2014 at 12:17 PM, Martin Liška wrote: >>> >>> On 12/11/2014 01:37 PM, Richard Biener wrote: On Wed, Dec 10, 2014 at 1:18 PM, Martin Liška wrote: > > >

Re: [debug-early] reuse variable DIEs and fix their context

2014-12-19 Thread Richard Biener
On Thu, Dec 18, 2014 at 8:23 PM, Aldy Hernandez wrote: > Hi Jason. > > It's embarrassing that I just got to this now. I hope you don't repay the > favor and take as long responding to me :(. > > On 09/12/14 08:15, Jason Merrill wrote: >> >> On 09/11/2014 08:51 PM, Aldy Hernandez wrote: > > >>>

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Richard Biener
On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: > This patch flattens tree.h and tree-core.h. This work is part of the GCC > Re-Architecture effort being led by Andrew MacLeod. > > I removed the includes in tree.h and tree-core.h except for the include of > tree-core.h in tree.h. > > I mo

Re: [PATCH] PR 62173, re-shuffle insns for RTL loop invariant hoisting

2014-12-19 Thread Richard Biener
On Fri, Dec 19, 2014 at 11:28 AM, Jiong Wang wrote: > 2014-12-19 3:51 GMT+00:00 Bin.Cheng : >> On Fri, Dec 19, 2014 at 6:09 AM, Segher Boessenkool >> wrote: >>> On Thu, Dec 18, 2014 at 05:00:01PM +, Jiong Wang wrote: On 17/12/14 15:54, Richard Biener wrote: >ick. I realize we don't

Re: [PATCH 2/3] Extended if-conversion

2014-12-19 Thread Richard Biener
On Thu, Dec 18, 2014 at 2:45 PM, Yuri Rumyantsev wrote: > Richard, > > I am sending you full patch (~1000 lines) but if you need only patch.1 > and patch.2 will let me know and i'll send you reduced patch. > > Below are few comments regarding your remarks for patch.3. > > 1. I deleted sub-phase if

Re: [PATCH] PR 62173, re-shuffle insns for RTL loop invariant hoisting

2014-12-19 Thread Eric Botcazou
> still can anyone confirm that it is safe to re-use REG_DEAD info there > without calling df_note_add_problem and df_analysis first? or I am > using those info passed down from the previous pass which calculated > these info and maybe broken? It is generally _not_ safe to consume REG_UNUSED and R

Re: [PATCH] __has_{,cpp_}attribute fixes (PR preprocessor/63831)

2014-12-19 Thread Ed Smith-Rowland
On 12/17/2014 05:43 PM, Jakub Jelinek wrote: On Wed, Dec 17, 2014 at 04:14:00PM -0500, Jason Merrill wrote: On 12/05/2014 03:28 PM, Jakub Jelinek wrote: 3) there is no __has_attribute__ middle-end secondary macro, when it is a built-in macro, it works fine in #ifdef too I'm not sure what th

Re: Pragma parsing

2014-12-19 Thread Thomas Schwinge
Hi Jakub! On Fri, 19 Dec 2014 11:36:39 +0100, Jakub Jelinek wrote: > On Thu, Dec 18, 2014 at 07:00:09PM +0100, Thomas Schwinge wrote: > > > The point is that we now have lots of clauses, and making it clear what > > > from > > > those clauses are Cilk+, what are OpenACC, what are OpenMP will hel

[Patch, Fortran, OOP] PR 64209: runtime segfault with CLASS(*), INTENT(OUT) dummy argument

2014-12-19 Thread Janus Weil
Hi all, the attached patch fixes a wrong-code issue with unlimited poylmorphic INTENT(OUT) arguments. We default-initialize all polymorphic INTENT(OUT) arguments via the _def_init component of the vtable. The problem is that the intrinsic types don't have a default initialization. Therefore their

Re: Pragma parsing

2014-12-19 Thread Jakub Jelinek
On Fri, Dec 19, 2014 at 01:20:52PM +0100, Thomas Schwinge wrote: > Hi Jakub! > > On Fri, 19 Dec 2014 11:36:39 +0100, Jakub Jelinek wrote: > > On Thu, Dec 18, 2014 at 07:00:09PM +0100, Thomas Schwinge wrote: > > > > The point is that we now have lots of clauses, and making it clear what > > > > f

[build] libatomic, libgfortran: Use automake-1.11.1 to sync with the rest

2014-12-19 Thread Michael Haubenwallner
On the way to prepare some (aix) libtool patch for toplevel libtool.m4 I've discovered that different versions of automake were used to generate files across various libs: most libs: automake-1.11.1 libatomic r211747: automake-1.11.6 libgfortran r204654: automake-1.11.3 r21

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 06:20 AM, Richard Biener wrote: On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: This patch flattens tree.h and tree-core.h. This work is part of the GCC Re-Architecture effort being led by Andrew MacLeod. I removed the includes in tree.h and tree-core.h except for the i

Re: [Patch, Fortran, OOP] PR 64209: runtime segfault with CLASS(*), INTENT(OUT) dummy argument

2014-12-19 Thread Tobias Burnus
Janus Weil wrote: > the attached patch fixes a wrong-code issue with unlimited poylmorphic > INTENT(OUT) arguments. > > We default-initialize all polymorphic INTENT(OUT) arguments via the > _def_init component of the vtable. The problem is that the intrinsic > types don't have a default initializat

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 08:44 AM, Andrew MacLeod wrote: On 12/19/2014 06:20 AM, Richard Biener wrote: On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: This patch flattens tree.h and tree-core.h. This work is part of the GCC Re-Architecture effort being led by Andrew MacLeod. I removed the inc

Re: [PATCH] PR 62173, re-shuffle insns for RTL loop invariant hoisting

2014-12-19 Thread Segher Boessenkool
On Fri, Dec 19, 2014 at 11:51:06AM +0800, Bin.Cheng wrote: > >> yes, we want to restrict the transformation on single-use pseudo only, > >> and it's better the transformation could re-use existed info and helper > >> function to avoid increase compile time. but I haven't found anything I > >> can r

Re: [PATCH] PR 62173, re-shuffle insns for RTL loop invariant hoisting

2014-12-19 Thread Kenneth Zadeck
On 12/19/2014 06:26 AM, Richard Biener wrote: On Fri, Dec 19, 2014 at 11:28 AM, Jiong Wang wrote: 2014-12-19 3:51 GMT+00:00 Bin.Cheng : On Fri, Dec 19, 2014 at 6:09 AM, Segher Boessenkool wrote: On Thu, Dec 18, 2014 at 05:00:01PM +, Jiong Wang wrote: On 17/12/14 15:54, Richard Biener wr

[ping] [PATCH] combine: Do not allow identical insns for I0,I1 and/or I2 (PR64268)

2014-12-19 Thread Segher Boessenkool
Hi, Sorry for the quick ping, but this fixes bootstrap on AIX, powerpc-darwin, and 32-bit PowerPC Linux. Could a gentle soul please spare a minute to review, before the holidays? Thanks in advance! Segher p.s. The regtests of course succeeded. On Tue, Dec 16, 2014 at 03:28:16PM -0800, Segh

Re: [patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

2014-12-19 Thread Kai Tietz
2014-12-19 0:14 GMT+01:00 Jason Merrill : > On 12/18/2014 01:16 PM, Kai Tietz wrote: >> >> Well, in general I would have assumed to be able to get alias decl of >> tmpl. Wasn't able to find a simple way to get it. So, by looking into >> source I found that most cases handling args > tmpl-args by us

Go patch committed: More temporaries for interface conversion

2014-12-19 Thread Ian Lance Taylor
Compiling more Go code revealed a couple more cases that need a temporary for interface conversion. The first is passing an interface value to panic. The second is when a temporary itself has a type that forces conversion, which can happen in a return statement. This patch adds them. Bootstrapp

Re: [patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

2014-12-19 Thread Jason Merrill
OK, thanks. Jason

Re: [patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

2014-12-19 Thread H.J. Lu
On Fri, Dec 19, 2014 at 8:00 AM, Kai Tietz wrote: > 2014-12-19 0:14 GMT+01:00 Jason Merrill : >> On 12/18/2014 01:16 PM, Kai Tietz wrote: >>> >>> Well, in general I would have assumed to be able to get alias decl of >>> tmpl. Wasn't able to find a simple way to get it. So, by looking into >>> sour

Re: [patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

2014-12-19 Thread Kai Tietz
2014-12-19 17:46 GMT+01:00 H.J. Lu : > > Did you forget to check in the testcase? No, see rev 218956. > -- > H.J.

Re: [PATCH, rs6000] PR59708, Fix operand ordering for 128-bit andc/orc

2014-12-19 Thread Segher Boessenkool
Hi, On Thu, Dec 18, 2014 at 02:48:46PM -0600, Pat Haugen wrote: > ;; 128-bit ANDC/ORC > +;; In the case where rs6000_split_logical is called, the NOT'd operand > +;; must be opnd1 in order for the split insns to be recognized. So fix rs6000_split_logical? > (define_insn_and_split "*boolc3_

SD-6 Feature test for

2014-12-19 Thread Ed Smith-Rowland
Since we have C++14 sized deallocation we should enable the SD-6 feature test macro. For this feature test I'm not using language version but testing flag_sized_deallocation in case C++14 turns the feature off or C++11 turns the feature on (as my reading and testing indicate that it can). Bu

Re: SD-6 Feature test for

2014-12-19 Thread Jason Merrill
OK, thanks. Jason

Re: [patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

2014-12-19 Thread Paolo Carlini
Hi, On 12/19/2014 05:48 PM, Kai Tietz wrote: 2014-12-19 17:46 GMT+01:00 H.J. Lu : Did you forget to check in the testcase? No, see rev 218956. But you want to move it to the cpp0x directory, and likely name it alias-decl-45.C or something similar. In the template directory is also compiled i

Re: [ping] [PATCH] combine: Do not allow identical insns for I0,I1 and/or I2 (PR64268)

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 16:13, Segher Boessenkool wrote: > Hi, > > Sorry for the quick ping, but this fixes bootstrap on AIX, powerpc-darwin, > and 32-bit PowerPC Linux. Could a gentle soul please spare a minute to > review, before the holidays? Thanks in advance! I cannot approve it, but the patch is

Re: [Patch, Fortran, OOP] PR 64209: runtime segfault with CLASS(*), INTENT(OUT) dummy argument

2014-12-19 Thread Janus Weil
2014-12-19 14:48 GMT+01:00 Tobias Burnus : > As you write yourself, the issue can only occur for CLASS(*). Hence, > please apply this only for UNLIMITED_POLY() to avoid unneccessary code side > increase and performance decrease. Good point, thanks for reviewing. An updated patch is attached. Will

Re: C++ PATCH for c++/64105 (ICE on generic lambda with -std=c++11)

2014-12-19 Thread Paolo Carlini
Hi, On 12/19/2014 12:52 AM, Jason Merrill wrote: + X::f([](auto... xs){}); // { dg-error "" "" { target { ! cxx14 } } } I think you want to change the ! cxx14 bits, apparently don't work. Thanks, Paolo.

Re: Including a file from include/ in gcc/*.h (was: [gomp4] Use include/gomp-constants.h more actively)

2014-12-19 Thread Thomas Schwinge
Hi Jakub! On Thu, 18 Dec 2014 19:33:07 +0100, Jakub Jelinek wrote: > On Thu, Dec 18, 2014 at 07:25:03PM +0100, Thomas Schwinge wrote: > > On Wed, 17 Dec 2014 23:26:53 +0100, I wrote: > > > Committed to gomp-4_0-branch in r218840: > > > > > > commit febcd8dfdb10fa80edff0880973d1915ca2fef74 > > >

Re: [PATCH AArch64 0/3] Optimizations for 64x1 vectors, also fixes/enables XOR

2014-12-19 Thread Alan Lawrence
I've now committed all three of these patches, as r/218958 r/218960 and r/218961, after investigating the effect of the first two on a range of benchmarks (Spec2000, Geekbench, Spec2k6) and finding almost no effect on codegen and no significant performance difference on Cortex-A53 or Cortex-A57.

Re: [patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

2014-12-19 Thread Kai Tietz
2014-12-19 18:22 GMT+01:00 Paolo Carlini : > Hi, > > > On 12/19/2014 05:48 PM, Kai Tietz wrote: >> >> 2014-12-19 17:46 GMT+01:00 H.J. Lu : >>> >>> Did you forget to check in the testcase? >> >> No, see rev 218956. > > But you want to move it to the cpp0x directory, and likely name it > alias-decl-4

Re: [ping] [PATCH] combine: Do not allow identical insns for I0,I1 and/or I2 (PR64268)

2014-12-19 Thread Richard Biener
On December 19, 2014 6:23:05 PM CET, Paolo Bonzini wrote: > > >On 19/12/2014 16:13, Segher Boessenkool wrote: >> Hi, >> >> Sorry for the quick ping, but this fixes bootstrap on AIX, >powerpc-darwin, >> and 32-bit PowerPC Linux. Could a gentle soul please spare a minute >to >> review, before the

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Richard Biener
On December 19, 2014 2:44:00 PM CET, Andrew MacLeod wrote: >On 12/19/2014 06:20 AM, Richard Biener wrote: >> On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison >> wrote: >>> This patch flattens tree.h and tree-core.h. This work is part of the >GCC >>> Re-Architecture effort being led by Andrew Ma

Re: [patch] New std::string implementation

2014-12-19 Thread Jonathan Wakely
The powerpc64 ICE is fixed, so I'm committing the std::string ABI transition patch. This replaces our venerable Copy-on-Write std::string with a C++11-conforming* Small-String Optimized std::__cxx11::string. (* It's not quite 100% conforming, as it's missing some allocator features. Of course.

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 01:12 PM, Richard Biener wrote: On December 19, 2014 2:44:00 PM CET, Andrew MacLeod wrote: On 12/19/2014 06:20 AM, Richard Biener wrote: On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: This patch flattens tree.h and tree-core.h. This work is part of the GCC Re-Archi

Merge from trunk to gccgo branch

2014-12-19 Thread Ian Lance Taylor
I merged trunk revision 218953 to the gccgo branch. Ian

Re: Speedup and cleanup hash-table.h

2014-12-19 Thread Jan Hubicka
> On December 19, 2014 12:48:22 AM CET, Jan Hubicka wrote: > >Hi, > >this patch started as experiment moving hash_table_mod1 inline because > >it shows > >high in streaming profiles and it represents a branch-less code that is > >good > >to schedule to surrounding instructions. > >While looking at

Re: [debug-early] reuse variable DIEs and fix their context

2014-12-19 Thread Jan Hubicka
> > Yeah, I've told you that this is a major blocker I couldn't resolve the last > time I tried to move things. > > IMHO this Java method aliases needs to be made cgraph-aware somehow, > thus we need to build the aliases as proper aliases during candidate > collection but somehow mark them reclai

Re: [debug-early] reuse variable DIEs and fix their context

2014-12-19 Thread Jan Hubicka
> > > > Yeah, I've told you that this is a major blocker I couldn't resolve the last > > time I tried to move things. > > > > IMHO this Java method aliases needs to be made cgraph-aware somehow, > > thus we need to build the aliases as proper aliases during candidate > > collection but somehow ma

Re: [debug-early] reuse variable DIEs and fix their context

2014-12-19 Thread Aldy Hernandez
On 12/19/14 10:58, Jan Hubicka wrote: Yeah, I've told you that this is a major blocker I couldn't resolve the last time I tried to move things. IMHO this Java method aliases needs to be made cgraph-aware somehow, thus we need to build the aliases as proper aliases during candidate collection bu

Re: [debug-early] reuse variable DIEs and fix their context

2014-12-19 Thread Aldy Hernandez
On 12/19/14 10:53, Jan Hubicka wrote: Yeah, I've told you that this is a major blocker I couldn't resolve the last time I tried to move things. IMHO this Java method aliases needs to be made cgraph-aware somehow, thus we need to build the aliases as proper aliases during candidate collection bu

Re: [debug-early] reuse variable DIEs and fix their context

2014-12-19 Thread Jason Merrill
It looks like java aliases are still using assemble_alias directly; switching to using same_body aliases like thunks and such should handle the issue. Jason

Re: [Patch, Fortran, OOP] PR 64209: runtime segfault with CLASS(*), INTENT(OUT) dummy argument

2014-12-19 Thread Janus Weil
Committed as r218968. Cheers, Janus 2014-12-19 18:24 GMT+01:00 Janus Weil : > 2014-12-19 14:48 GMT+01:00 Tobias Burnus : >> As you write yourself, the issue can only occur for CLASS(*). Hence, >> please apply this only for UNLIMITED_POLY() to avoid unneccessary code side >> increase and perform

[PATCH, committed] Handle NULL in gcc_jit_context_set_str_option

2014-12-19 Thread David Malcolm
r218617 broke test-error-pr63969-missing-driver.c. The commit added an xstrdup of new string option values on a gcc_jit_context, but string option values are allowed to be NULL. Handle the NULL case. Committed to trunk as r218969. gcc/jit/ChangeLog: * jit-recording.c (gcc::jit::recordin

Re: Including a file from include/ in gcc/*.h (was: [gomp4] Use include/gomp-constants.h more actively)

2014-12-19 Thread Jakub Jelinek
On Fri, Dec 19, 2014 at 06:54:04PM +0100, Thomas Schwinge wrote: > Like this (not yet applied)? I think it is fine, though the ChangeLog entry is not. Though in the late of hopefully soonish merge and creation of full ChangeLog entry it is not a big deal. Jakub

Re: [debug-early] reuse variable DIEs and fix their context

2014-12-19 Thread Jan Hubicka
> It looks like java aliases are still using assemble_alias directly; assemble_alias dispatch to code adding alias pair to callgarph, so that should be safe. My understanding is that Aldys concern is that creating the aliases early leads to undefined symbol because we produce aliases that never g

Re: [PATCH, rs6000] PR59708, Fix operand ordering for 128-bit andc/orc

2014-12-19 Thread Segher Boessenkool
On Fri, Dec 19, 2014 at 10:54:22AM -0600, Segher Boessenkool wrote: > On Thu, Dec 18, 2014 at 02:48:46PM -0600, Pat Haugen wrote: > > ;; 128-bit ANDC/ORC > > +;; In the case where rs6000_split_logical is called, the NOT'd operand > > +;; must be opnd1 in order for the split insns to be recogni

[PATCH, committed] Fix issue with string options and nested gcc_jit_contexts

2014-12-19 Thread David Malcolm
The change to dynamically-allocated string options in r218617 introduced an issue with nested contexts, which were simply taking a copy of the string pointer, rather than owning their own buffer. Visible as various read-after-free errors when running test-nested-contexts.c under valgrind, where a

RE: [PATCHv2,MIPS 1/2] MIPS64r6 support

2014-12-19 Thread Matthew Fortune
> Okay with those changes. Committed as r218973 Thanks, Matthew

RE: [PATCHv2,MIPS 2/2] Add new triplets for vendor 'img'

2014-12-19 Thread Matthew Fortune
> > gcc/ > > > > * config.gcc: Support mips*-img-linux* and mips*-img-elf*. > > * config/mips/mti-linux.h: Support mips32r6 as being the default > > arch. > > * config/mips/t-img-elf: New. > > * config/mips/t-img-linux: New. > > > > This patch is OK to commit. Committed as r218975

[PATCH, committed] Fix casting non-"int" to bool.

2014-12-19 Thread David Malcolm
Attempts to use gcc_jit_context_new_cast on an rvalue with non-"int" numeric type, with "bool" as the desired type would lead to an ICE when the context was compiled. Fix it. Brings jit.sum from: # of expected passes 4888 to: # of expected passes 5008 Committed to trunk as

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Michael Collison
The reason I included tree-core.h in all the .c files was the requirement in tree.h (now flattened to the .c files) for fold-const.h. In tree.h there are inline functions such as fold_build_pointer_plus_hwi_loc which reference functions in fold-const.h. The moment you include fold-const.h you r

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Prathamesh Kulkarni
On 20 December 2014 at 02:16, Michael Collison wrote: > The reason I included tree-core.h in all the .c files was the requirement in > tree.h (now flattened to the .c files) for fold-const.h. In tree.h there are > inline functions such as fold_build_pointer_plus_hwi_loc which reference > functions

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 03:46 PM, Michael Collison wrote: The reason I included tree-core.h in all the .c files was the requirement in tree.h (now flattened to the .c files) for fold-const.h. In tree.h there are inline functions such as fold_build_pointer_plus_hwi_loc which reference functions in fold-c

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Michael Collison
Andrew, Yes it appears those are the three offenders. I like the approach of moving them to fold-const.c and exporting from fold-const.h. I will try that approach. On 12/19/2014 02:10 PM, Andrew MacLeod wrote: On 12/19/2014 03:46 PM, Michael Collison wrote: The reason I included tree-core.h

Re: [PATCH, rs6000] PR59708, Fix operand ordering for 128-bit andc/orc

2014-12-19 Thread Pat Haugen
On 12/19/2014 01:50 PM, Segher Boessenkool wrote: On Fri, Dec 19, 2014 at 10:54:22AM -0600, Segher Boessenkool wrote: >On Thu, Dec 18, 2014 at 02:48:46PM -0600, Pat Haugen wrote: > > ;; 128-bit ANDC/ORC > >+;; In the case where rs6000_split_logical is called, the NOT'd operand > >+;; must

Go patch committed: More temporaries for interface conversion

2014-12-19 Thread Ian Lance Taylor
More test cases, more cases where the Go frontend needs to create a temporary in the case of interface conversion. This is for map index expressions and map composite literals. Also only flatten call expressions once; they tend to appear in the tree multiple times. Bootstrapped and ran Go testsui

Re: [PATCH 2/4] Add Visium support to libgcc

2014-12-19 Thread Eric Botcazou
Revision version, the divmod and the parity routines have been reimplemented based on libgcc2.c and all the new files are now under GPL+exception. libgcc/ChangeLog 2014-12-19 Eric Botcazou * config.host: Add Visium support. * config/visium: New directory. -- Eric

Re: [PATCH][rtlanal.c][BE][1/2] Fix vector load/stores to not use ld1/st1

2014-12-19 Thread Eric Botcazou
> Please be more specific though. If you don't think the patch is correct, > what do you think the requirement should be and how should it be integrated > into the existing checks? Good question, but I have asked it first. :-) So what are the new subregs that we want to accept here? Can someone

[Patch, Fortran, F08] PR 54756: Should reject CLASS, intent(out) in PURE procedures

2014-12-19 Thread Janus Weil
Hi all, after committing my recent patch for PR 64209, I realized that the accompanying test case is actually invalid in one aspect and that there is already a PR (and patch) for that problem: PR 54756. It's about F08 forbidding polymorphic INTENT(OUT) arguments in pure procedures. The reason for

Merge from trunk to gccgo branch

2014-12-19 Thread Ian Lance Taylor
I've done yet another merge from trunk, revision 218979, to gccgo branch. Ian

Re: [PATCH] Treat a sibling call as though it does a wild read

2014-12-19 Thread John David Anglin
On 16-Dec-14, at 8:17 PM, John David Anglin wrote: On 8-Dec-14, at 5:36 PM, Jeff Law wrote: On 12/08/14 15:15, John David Anglin wrote: On 12/8/2014 3:01 PM, Jeff Law wrote: The above is wrong for sibcalls. Sibcall arguments are relative to the incoming argument pointer. Is this always the

Re: [patch] New std::string implementation

2014-12-19 Thread François Dumont
Hello Great news. However we need the following to make debug/profile modes happy. Shouldn't we use _GLIBCXX_ABI_TAG_CXX11 to tag the __cxx11 namespace ? 2014-12-20 François Dumont * include/bits/c++config: inline __cxx11 namespace within namespace __cxx1998. Ok to com

Re: [patch] New std::string implementation

2014-12-19 Thread Jonathan Wakely
This fixes some duplicate symbols which break Darwin bootstrap. Tested x86_64-linux and powerpc64-linux, committed to trunk. commit fa3a5af2feee0f9873ba1a9bdb84148dd122506c Author: Jonathan Wakely Date: Fri Dec 19 23:44:01 2014 + Fix duplicate symbol errors in Darwin bootstrap.

Re: [PATCH v5] warning about const multidimensional array as function parameter

2014-12-19 Thread Joseph Myers
On Mon, 8 Dec 2014, Martin Uecker wrote: > Another version of this patch. I fixed the formatting problems and > the spurios use of OPT_Wdiscarded_array_qualifiers. I also added > '-pedantic -Wdiscarded-array-qualifiers' to the dg-options in > 'testsuite/gcc.dg/qual-component-1.c' and changed the

Re: [patch] New std::string implementation

2014-12-19 Thread Jonathan Wakely
On 20/12/14 00:52 +0100, François Dumont wrote: Hello Great news. However we need the following to make debug/profile modes happy. Ah, thanks for checking it. Shouldn't we use _GLIBCXX_ABI_TAG_CXX11 to tag the __cxx11 namespace ? No, that is defined to __attribute__((abi_tag("cxx

Re: [PATCH, rs6000] PR59708, Fix operand ordering for 128-bit andc/orc

2014-12-19 Thread David Edelsohn
The canonical form has the NOT first. If the second operand needs the NOT, the operands need to be reversed when the new insn is created, in rs6000_split_logical, not in the pattern. Thanks, David On Fri, Dec 19, 2014 at 4:27 PM, Pat Haugen wrote: > On 12/19/2014 01:50 PM, Segher Boessenkool w

Re: [RFC PATCH 1/9] LRA: Take account implicit usage of pseudo reg in mem arg

2014-12-19 Thread Kaz Kojima
>> It would be nice to have a small test case for this problem with >> compiler options to reproduce it. > > Thanks for the detailed explanation. The original issue has found > with the older sh-lra branch which was based on trunk at this September. > Now I've found that the original test case in

[GOOGLE] Make LIPO aux function removal consistent

2014-12-19 Thread Teresa Johnson
Passes regression tests, ok for google 4_9? Thanks, Teresa 2014-12-19 Teresa Johnson Google ref b/18800499 * cgraph.c (cgraph_can_remove_if_no_direct_calls_and_refs_p): Make consistent with mark_functions_for_output for LIPO aux functions. Index: cgraph.c

Re: [debug-early] reuse variable DIEs and fix their context

2014-12-19 Thread Aldy Hernandez
On 12/19/14 11:03, Jason Merrill wrote: First of all, my bad Richard. I vaguely remember you mentioning something about Java, but it was early enough in the project that I had no idea what you were talking about. Thanks for your patience. It looks like java aliases are still using assemble