Re: [PATCH, i386, Pointer Bounds Checker 33/x] MPX ABI

2014-09-22 Thread Jeff Law
On 09/21/14 06:34, Uros Bizjak wrote: On Fri, Sep 19, 2014 at 9:55 AM, Ilya Enkovich wrote: Here is an updated version of this patch. @@ -25000,10 +25082,32 @@ ix86_expand_call (rtx retval, rtx fnaddr, rtx callarg1, } call = gen_rtx_CALL (VOIDmode, fnaddr, callarg1); + if (retv

Re: Speedup int_bit_from_pos

2014-09-22 Thread Jan Hubicka
> Not quite: > > offset_int woffset > = (wi::to_offset (xoffset) >+ wi::lrshift (wi::to_offset (DECL_FIELD_BIT_OFFSET (field)), > LOG2_BITS_PER_UNIT)); > > offset_int is the type that can hold all bit positions, byte positions, byte > sizes and

Re: [GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

2014-09-22 Thread Xinliang David Li
On Mon, Sep 22, 2014 at 8:04 AM, Teresa Johnson wrote: > On Mon, Sep 22, 2014 at 1:36 AM, Nathan Sidwell wrote: >> On 09/21/14 18:58, Xinliang David Li wrote: >> the intent is that that points to the gcov_info object of the object file containing the live version of the function. I cou

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

2014-09-22 Thread Mike Stump
On Sep 20, 2014, at 10:52 AM, Kai Tietz wrote: > I missed that op points still on the memory here. So corrected patch > is inlined below. So, I’m wondering if the x86 maintainers want me to review and approve a patch, or if they want to. I was assuming they wanted to.

Re: Speedup int_bit_from_pos

2014-09-22 Thread Mike Stump
On Sep 22, 2014, at 11:22 AM, Jan Hubicka wrote: >> Not quite: >> >> offset_int woffset >>= (wi::to_offset (xoffset) >> + wi::lrshift (wi::to_offset (DECL_FIELD_BIT_OFFSET (field)), >> LOG2_BITS_PER_UNIT)); >> >> offset_int is the type that can hol

Re: [PATCH IRA] update_equiv_regs fails to set EQUIV reg-note for pseudo with more than one definition

2014-09-22 Thread Jeff Law
On 09/22/14 08:40, Felix Yang wrote: Hi, I find that update_equiv_regs in ira.c sets the wrong EQUIV reg-note for pseudo with more than one definiton in certain situation. Here is a simplified RTL snippet after this function finishs handling: (insn 77 37 78 2 (set (reg:SI 171)

[Patch AArch64] Fix extended register width

2014-09-22 Thread Carrot Wei
Hi The extended register width in add/adds/sub/subs/cmp instructions is not always the same as target register, it depends on both target register width and extension type. But in current implementation the extended register width is always the same as target register. We have noticed it can gener

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

2014-09-22 Thread Uros Bizjak
On Mon, Sep 22, 2014 at 8:24 PM, Mike Stump wrote: > On Sep 20, 2014, at 10:52 AM, Kai Tietz wrote: >> I missed that op points still on the memory here. So corrected patch >> is inlined below. > > So, I’m wondering if the x86 maintainers want me to review and approve a > patch, or if they want

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

2014-09-22 Thread Mike Stump
On Sep 22, 2014, at 11:43 AM, Uros Bizjak wrote: > As far as I'm concerned, this is Darwin specific patch, so it needs > an approval from Darwin maintainer. The patch just happens to live in > i386 directory ;) Ok, thanks.

Re: [C++ Patch/RFC] PR 62219

2014-09-22 Thread Jason Merrill
OK for trunk and 4.9; I'd hold off on 4.8 unless someone asks for it there. Jason

Re: [PATCH, i386, Pointer Bounds Checker 32/x] Pointer Bounds Checker hooks for i386 target

2014-09-22 Thread Uros Bizjak
On Mon, Sep 22, 2014 at 5:30 PM, Ilya Enkovich wrote: > On 19 Sep 18:21, Uros Bizjak wrote: >> On Fri, Sep 19, 2014 at 2:53 PM, Ilya Enkovich >> wrote: >> >> >> > This patch adds i386 target hooks for Pointer Bounds Checker. >> >> > New version with fixes and better documentation for ix86_load_b

Re: Speedup int_bit_from_pos

2014-09-22 Thread Jan Hubicka
> On Sep 22, 2014, at 11:22 AM, Jan Hubicka wrote: > >> Not quite: > >> > >> offset_int woffset > >>= (wi::to_offset (xoffset) > >> + wi::lrshift (wi::to_offset (DECL_FIELD_BIT_OFFSET (field)), > >> LOG2_BITS_PER_UNIT)); > >> > >> offset_int is the

Re: [PATCH, i386, Pointer Bounds Checker 32/x] Pointer Bounds Checker hooks for i386 target

2014-09-22 Thread Jeff Law
On 09/19/14 10:21, Uros Bizjak wrote: +static tree +ix86_make_bounds_constant (HOST_WIDE_INT lb, HOST_WIDE_INT ub) +{ + tree low = lb ? build_minus_one_cst (pointer_sized_int_node) +: build_zero_cst (pointer_sized_int_node); + tree high = ub ? build_zero_cst (pointer_sized_int_node) +:

C++ PATCH for c++/63320 (lambda in static member function)

2014-09-22 Thread Jason Merrill
The fix for 60463 didn't handle properly the case where we don't find a 'this' at all. Tested x86_64-pc-linux-gnu, applying to trunk. commit 7ef1880eec81f1c3914f6e018e709224a64fefc1 Author: Jason Merrill Date: Mon Sep 22 13:21:16 2014 -0400 PR c++/63320 PR c++/60463 PR c++/607

Re: Speedup int_bit_from_pos

2014-09-22 Thread Jan Hubicka
Hi, it now seems to work, finaly :) Bootstrapped/regtested x86_64-linux, OK? * tree.c (int_bit_position): Move to... * tree.h (int_bit_position): ... here; implement using direct wide_int calculation instead of folding. Index: tree.c

C++ PATCH to tweak invalid non-static data member diagnostic

2014-09-22 Thread Jason Merrill
Adjusting this diagnostic to conform to our convention of having only one error message plus notes. Tested x86_64-pc-linux-gnu, applying to trunk. commit 99ef5c20fe8566fbfbe14e085f765d2c3f05b252 Author: Jason Merrill Date: Mon Sep 22 13:43:18 2014 -0400 * semantics.c (finish_non_static_

Re: libsanitizer merge from upstream r218156

2014-09-22 Thread Konstantin Serebryany
- one wrong e-mail On Mon, Sep 22, 2014 at 11:44 AM, Konstantin Serebryany wrote: > re-sending with the patch compressed: > > === gcc/testsuite/ChangeLog > 2014-09-22 Kostya Serebryany > > Update to match the changed asan API. > * asan.c (asan_global_struct): Update

RE: FW: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C

2014-09-22 Thread Tannenbaum, Barry M
That's exactly correct. There are two ways to implement a work-stealing scheduler. We refer to them as: - Child Stealing - This is what TBB implements. The spawned call is bundled up with all the parameters and pushed onto a queue. The worker will continue executing the code after the spawne

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

2014-09-22 Thread Dominique d'Humières
Le 22 sept. 2014 à 20:50, Dominique d'Humières a écrit : > > So, I’m wondering if the x86 maintainers want me to review and approve a > > patch, > > or if they want to. I was assuming they wanted to. > > Mike, > > From the information available, I think the only acceptable patch is > the one

[jit] Add notes on internals to documentation

2014-09-22 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ChangeLog.jit: * docs/index.rst: Add internals/index.rst. * docs/internals/index.rst: New. * notes.txt: Update to reflect renaming of toplev_main to toplev::main. --- gcc/jit/ChangeLog.jit| 7 gcc/jit/docs

Re: Updated no_reorder patchkit

2014-09-22 Thread Jan Hubicka
> This version addresses earlier comments and has an updated testsuite > (still no LTO tests however). The assembler statements also > no stay in order with ordered statements. > > It doesn't disable sorting of paritions with ordered symbols. I think > that's an existing bug and is best addressed

Re: [PATCH 5/9] rs6000: Clean up bool3

2014-09-22 Thread Richard Henderson
On 09/20/2014 11:23 AM, Segher Boessenkool wrote: > +(define_code_attr iorxor [(ior "ior") (xor "xor")]) > +(define_code_attr IORXOR [(ior "IOR") (xor "XOR")]) You don't need these. They are and respectively. r~

Re: [PATCH 5/9] rs6000: Clean up bool3

2014-09-22 Thread Segher Boessenkool
On Mon, Sep 22, 2014 at 01:13:38PM -0700, Richard Henderson wrote: > On 09/20/2014 11:23 AM, Segher Boessenkool wrote: > > +(define_code_attr iorxor [(ior "ior") (xor "xor")]) > > +(define_code_attr IORXOR [(ior "IOR") (xor "XOR")]) > > You don't need these. They are and respectively. Ah nice,

Re: [PATCH 1/2] Add an no_reorder attribute for LTO

2014-09-22 Thread Jan Hubicka
> gcc/c-family/: > > 2014-09-15 Andi Kleen > > * c-common.c (handle_no_reorder_attribute): New function. > (c_common_attribute_table): Add no_reorder attribute. > > gcc/: > > 2014-09-14 Andi Kleen > > * cgraph.h (symtab_node): Add no_reorder attribute. > (symbol_t

Re: [PATCH 2/2] Add test cases for noreorder

2014-09-22 Thread Jan Hubicka
> From: Andi Kleen > > Add some simple test cases for noreorder behaving like > -fno-toplevel-reorder and -fno-toplevel-reorder still working. > Unfortunately there's no easy way to check for output order in DG, > so we just check for existence. OK, thanks! Honza > > gcc/testsuite/: > > 2014-0

libgo patch committed: Mark runtime_goexit as noinline

2014-09-22 Thread Ian Lance Taylor
This patch from Peter Collingbourne marks runtime_goexit as noinline. If we don't do that, it may be inlined into the kickoff function. That function refers to the TLS variable g, as does runtime_goexit. But by the time kickoff calls runtime_goexit, it may be running in a different thread. If th

[PATCH, rs6000] Cleanup movsf/movsd/movdf/movdd constraints; Cleanup TImode boolean

2014-09-22 Thread Michael Meissner
I was working to support enhancing addressing modes in the the compiler that is indended to better support load fusion in power8, and to finally allow DFmode/SFmode scalar values in the traditional altivec registers. I noticed that the floating point moves were still using constraints that could t

Re: [patch] libstdc++/29988 Rb_Tree reuse allocated nodes

2014-09-22 Thread François Dumont
On 11/06/2014 14:02, Jonathan Wakely wrote: @@ -514,11 +651,11 @@ { return this->_M_impl._M_header._M_right; } _Link_type - _M_begin() _GLIBCXX_NOEXCEPT + _M_begin() const _GLIBCXX_NOEXCEPT { return static_cast<_Link_type>(this->_M_impl._M_header._M_parent); } What

Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-09-22 Thread Jeff Law
On 09/03/14 07:51, Segher Boessenkool wrote: This came up when investigating PR62151. In that PR combine messes up a four-insn combination. It should really have done the combination of the first three insns in that. The second of those instructions sets a register; the third clobbers the same

Remove LIBGCC2_LONG_DOUBLE_TYPE_SIZE target macro

2014-09-22 Thread Joseph S. Myers
This patch removes the target macro LIBGCC2_LONG_DOUBLE_TYPE_SIZE. After recent changes, this macro was used in two ways in libgcc: to determine the mode of long double in dfp-bit.h, and to determine whether a particular mode has excess precision for use in complex multiplication. The former is c

Re: [PATCH] Fix whitespace in comments.

2014-09-22 Thread Jeff Law
On 09/20/14 08:48, Tobias Burnus wrote: Hi Joost and Thomas, On 20.09.2014 12:02, Thomas Koenig wrote: A somewhat trivial patch to cleanup whitespace issues in comments: sed "s/\. \*\//\. \*\//g" Tested with a recompile only. Ok for trunk ? OK. (Obvious, really). I want to point a downside

Re: Remove LIBGCC2_LONG_DOUBLE_TYPE_SIZE target macro

2014-09-22 Thread Jeff Law
On 09/22/14 17:12, Joseph S. Myers wrote: This patch removes the target macro LIBGCC2_LONG_DOUBLE_TYPE_SIZE. After recent changes, this macro was used in two ways in libgcc: to determine the mode of long double in dfp-bit.h, and to determine whether a particular mode has excess precision for use

Re: Move dwarf2 frame tables to read-only section for AIX

2014-09-22 Thread Andrew Dixie
Hi, On Tue, Sep 23, 2014 at 2:47 AM, Joseph S. Myers wrote: > If you rename a target macro, the old target macro name needs to be > poisoned in system.h. Fixed in patch below. > This ChangeLog entry seems very incomplete. It doesn't mention the > changes for other architectures, or to defaults.

RFA: another patch to fix PR61360

2014-09-22 Thread Vladimir Makarov
The previous patch to solve PR61360 fixed the problem in IRA (it was easier for me to do as I know the code well) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 Although imo it was an ok fix, Richard expressed concerns with the patch and the practice to have different enable attribute

Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-09-22 Thread Bin.Cheng
On Fri, Sep 12, 2014 at 4:01 AM, Jeff Law wrote: > On 09/11/14 13:01, Segher Boessenkool wrote: >> >> Ping? > > Not forgotten. Still waiting to hear back from Bin on my recommendation > that we drop the bogus note on the floor and avoid combining pseudos with > multiple sets like that. Sorry tha

Re: [PATCH IRA] update_equiv_regs fails to set EQUIV reg-note for pseudo with more than one definition

2014-09-22 Thread Yangfei (Felix)
> On 09/22/14 08:40, Felix Yang wrote: > > Hi, > > > > I find that update_equiv_regs in ira.c sets the wrong EQUIV > > reg-note for pseudo with more than one definiton in certain situation. > > Here is a simplified RTL snippet after this function finishs handling: > > > > (insn 77 37 78

Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-22 Thread Alessandro Fanfarillo
Thanks a lot. I'm moving and I didn't have time to make a test case. Regards 2014-09-20 8:14 GMT-06:00 Tobias Burnus : > Hi Alessandro et al., > > I have now committed (Rev. 215421) the attached patch, which includes a test > case for it. > > Thanks for the report and the patch Alessandro! > > Tob

Re: [gccgo/4.9] debug/elf: support arm64 relocations

2014-09-22 Thread Ian Lance Taylor
On Mon, Sep 22, 2014 at 2:26 PM, Michael Hudson-Doyle wrote: > > I'm attaching the patch that will be in Go 1.4 that enables debug/elf to > parse aarch64 relocations, necessary for cgo. It will end up in gccgo > mainline soon enough but 4.9 is going to be the default compiler on > arm64 for a whi

Re: RFA: another patch to fix PR61360

2014-09-22 Thread Uros Bizjak
On Tue, Sep 23, 2014 at 3:26 AM, Vladimir Makarov wrote: > The previous patch to solve PR61360 fixed the problem in IRA (it was > easier for me to do as I know the code well) > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 > > Although imo it was an ok fix, Richard expressed concerns wi

Re: [Ping] Port of VTV for Cygwin and MinGW

2014-09-22 Thread Caroline Tice
Ok, your patch looks OK to me, but I can only approve the libvtv file changes. The changes in the other files also seem ok to me, but someone else will have to approve the modifications in them: gcc/config/i386/cygwin.h gcc/config/i386/mingw-w64.h gcc/config/i386/mingw32.h gcc/cp/vtable-class-hie

Re: [PATCH, i386, Pointer Bounds Checker 33/x] MPX ABI

2014-09-22 Thread Ilya Enkovich
2014-09-22 22:22 GMT+04:00 Jeff Law : > On 09/21/14 06:34, Uros Bizjak wrote: >> >> On Fri, Sep 19, 2014 at 9:55 AM, Ilya Enkovich >> wrote: >> >>> Here is an updated version of this patch. >>> @@ -25000,10 +25082,32 @@ ix86_expand_call (rtx retval, rtx fnaddr, rtx >>> callarg1, >>> } >>> >>

[Ping] [PATCH, 1/10] two hooks for conditional compare (ccmp)

2014-09-22 Thread Zhenqiang Chen
Ping? Patch is attached for easy to apply. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Monday, June 23, 2014 2:57 PM > To: gcc-patches@gcc.gnu.org > Subject: [PATCH, 1/10] two

[Discard] [PATCH, 3/10] skip swapping operands used in ccmp

2014-09-22 Thread Zhenqiang Chen
The patch is discarded since I can not reproduce the issue with the latest trunk. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Thursday, June 26, 2014 3:21 PM > To: Richard

[Ping] [PATCH, 2/10] prepare ccmp

2014-09-22 Thread Zhenqiang Chen
Ping? Patch is attached for easy to apply. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Tuesday, July 01, 2014 1:08 PM > To: Richard Earnshaw > Cc: gcc-patches@gcc.gnu.org > Sub

[Ping] [PATCH, 5/10] aarch64: add ccmp operand predicate

2014-09-22 Thread Zhenqiang Chen
Ping? Patch is attached for easy to apply. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Monday, June 23, 2014 3:00 PM > To: gcc-patches@gcc.gnu.org > Subject: [PATCH, 5/10] aarc

[Ping] [PATCH, 4/10] expand ccmp

2014-09-22 Thread Zhenqiang Chen
Ping? Patch is rebased and regenerated since "[PATCH, 3/10] skip swapping operands used in ccmp" is discarded. Please find the updated patch in attachment. Bootstrap and no make check regression on X86-64. Thanks! -Zhenqiang ChangeLog: 2014-09-23 Zhenqiang Chen * ccmp.c: New file.

[Ping] [PATCH, 6/10] aarch64: add ccmp CC mode

2014-09-22 Thread Zhenqiang Chen
Ping? Patch is attached for easy to apply. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Monday, June 23, 2014 3:00 PM > To: gcc-patches@gcc.gnu.org > Subject: [PATCH, 6/10] aarc

[Ping] [PATCH, 7/10] aarch64: add function to output ccmp insn

2014-09-22 Thread Zhenqiang Chen
Ping? Patch is attached for easy to apply. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Monday, June 23, 2014 3:00 PM > To: gcc-patches@gcc.gnu.org > Subject: [PATCH, 7/10] aarc

[Ping] [PATCH, 8/10] aarch64: ccmp insn patterns

2014-09-22 Thread Zhenqiang Chen
Ping? Patch is attached for easy to apply. Move the cstorecc4 pattern from "[PATCH, 10/10] aarch64: Handle ccmp in ifcvt to make it work with cmov" to this patch, since cmov optimization does not depend on that patch. Thanks! -Zhenqiang ChangeLog: 2014-09-23 Zhenqiang Chen * config/

[Ping] [PATCH, 9/10] aarch64: generate conditional compare instructions

2014-09-22 Thread Zhenqiang Chen
Ping? Patch is attached for easy to apply. Bootstrap on AARCH64 qemu. Test cases: test_frame_*.c need update after the patch. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Monda

[Ping] [PATCH, 10/10] aarch64: Handle ccmp in ifcvt to make it work with cmov

2014-09-22 Thread Zhenqiang Chen
Ping? Patch is rebased and attached. Thanks! -Zhenqiang ChangeLog 2014-09-23 Zhenqiang Chen Andrew Pinski * ccmp.c (used_in_cond_stmt_p): Hande ? expr. * expr.c (expand_cond_expr_using_cmove): Handle CCmode. * ifcvt.c: #include "ccmp.h". (struct

Re: [PATCH, i386, Pointer Bounds Checker 32/x] Pointer Bounds Checker hooks for i386 target

2014-09-22 Thread Ilya Enkovich
2014-09-22 22:51 GMT+04:00 Uros Bizjak : > On Mon, Sep 22, 2014 at 5:30 PM, Ilya Enkovich wrote: >> On 19 Sep 18:21, Uros Bizjak wrote: >>> On Fri, Sep 19, 2014 at 2:53 PM, Ilya Enkovich >>> wrote: >>> >>> >> > This patch adds i386 target hooks for Pointer Bounds Checker. >>> >>> > New version w

<    1   2