Re: Fix firefox FDO build

2014-08-19 Thread Richard Biener
On Mon, Aug 18, 2014 at 5:15 PM, Jan Hubicka wrote: > Hi, > Firefox FDO build fails with undefined reference to __builtin_unreachable. > THis is caused by a bug > in gimple-fold that introduces the refernece in the cases it hits impossible > devirtualization. > We use __builtin_unreachable in t

Re: [GSoC][match-and-simplify] add more constant folding tests

2014-08-19 Thread Richard Biener
On Mon, Aug 18, 2014 at 8:00 PM, Prathamesh Kulkarni wrote: > On Mon, Aug 18, 2014 at 11:06 PM, David Malcolm wrote: >> On Mon, 2014-08-18 at 01:11 +0530, Prathamesh Kulkarni wrote: >>> We now have at-least one test-case for each of constant folding >>> patterns >>> in match-constant-folding.pd >

Re: [PATCH v2] Add strict aliasing warning when inlining function.

2014-08-19 Thread Richard Biener
On Tue, Aug 19, 2014 at 7:20 AM, lin zuojian wrote: > Hi, > Here patch v2. Move the function as Andrew instructed. > > * tree-inline.c (setup_one_parameter): Add strict aliasing check. > * c-family/c-common.c (strict_aliasing_warning): Move to alias.c. > * c-family/c-common.h (stri

Re: [PATH] Intel offload library

2014-08-19 Thread Kirill Yukhin
Hello, On 12 Aug 10:58, Andrey Turetskiy wrote: > All remarks from > https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02166.html are fixed. > Updated version of liboffloadmic you can find in GIT branch > kyukhin/gomp4-offload: > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/kyukhin/gomp4-

Re: [PATCH v2] Add strict aliasing warning when inlining function.

2014-08-19 Thread lin zuojian
Hi Richard, > Generally I don't think we want to expand the use of the IMHO broken > strict_aliasing_warning code. If you have read my test code, you must understand it is the programmer who responsible for this undefined behavior, instead of the compiler. Like PR 60546 concluded.

Re: [C/C++ PATCH] Implement -Wbool-compare (PR c++/62153)

2014-08-19 Thread Manuel López-Ibáñez
On 19 August 2014 06:58, Marek Polacek wrote: > On Mon, Aug 18, 2014 at 10:57:58PM +0200, Manuel López-Ibáñez wrote: >> On 18 August 2014 22:04, Marek Polacek wrote: >> > +void >> > +maybe_warn_bool_compare (location_t loc, enum tree_code code, tree op0, >> > +tree op1) >>

Re: [PATCH v2] Add strict aliasing warning when inlining function.

2014-08-19 Thread lin zuojian
Here is the warning after my patch: 1.cpp: In function 'int foo(int, int, int)': 1.cpp:29:70: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] return hash2(static_cast(change1), len / 2);

Re: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

2014-08-19 Thread Janne Blomqvist
On Mon, Aug 18, 2014 at 6:48 PM, VandeVondele Joost wrote: > ping ? > > https://gcc.gnu.org/ml/fortran/2014-05/msg00162.html Ok, again. If Dominique comes up with some reason why the patch should be modified, it can be done then. AFAICT your patch is better than the status quo. -- Janne Blomq

RE: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

2014-08-19 Thread VandeVondele Joost
Thanks, can somebody with svn write access commit ?

Re: Does anyone use Ada on Alpha?

2014-08-19 Thread Alan Lawrence
Unfortunately the Alpha box I used last time is no longer available and so I've not been able to try the linker fix. I've not had any responses from anyone saying they use Ada on Alpha (let alone on VMS - where the original bug was reported - and Ada/VMS support has now been retired). If none of

Re: Does anyone use Ada on Alpha?

2014-08-19 Thread Arnaud Charlet
> Unfortunately the Alpha box I used last time is no longer available > and so I've not been able to try the linker fix. I've not had any > responses from anyone saying they use Ada on Alpha (let alone on VMS > - where the original bug was reported - and Ada/VMS support has now > been retired). If

[PATCH] Fix thinko in handle_alias_pairs (PR c/61271)

2014-08-19 Thread Marek Polacek
handle_alias_pairs contains the following thinko. I believe it should be "not a virtual function". Bootstrapped/regtested on x86_64-linux, ok for trunk? 2014-08-19 Marek Polacek PR c/61271 * cgraphunit.c (handle_alias_pairs): Fix condition. diff --git gcc/cgraphunit.c gcc/cgr

Re: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

2014-08-19 Thread Janne Blomqvist
On Tue, Aug 19, 2014 at 1:07 PM, VandeVondele Joost wrote: > Thanks, can somebody with svn write access commit ? Please get yourself write-after-approval access per instructions at https://gcc.gnu.org/svnwrite.html . You can use me as your sponsor. Thanks. -- Janne Blomqvist

Re: [gomp4] Add tables generation

2014-08-19 Thread Ilya Verbin
On 18 Aug 18:24, Bernd Schmidt wrote: > I think I'd be happier if the function was called init_offload_table > and also collected functions, rather than leaving that to > expand_omp_target. I think the patch would be ok with that change. For the functions it's not so easy to identify which of them

[PATCH AArch64 1/2] Improve codegen of vector compares inc. tst instruction

2014-08-19 Thread Alan Lawrence
Vector comparisons are sometimes generated with needless 'not' instructions, and 'cmtst' is generally not output at all. This patch makes gen_aarch64_vcond_internal more intelligent with regard to swapping the operands to both the comparison and the conditional move, such that not is avoided whe

[PING PATCH] demangler, only access valid fields for DEMANGLE_COMPONENT_FIXED_TYPE.

2014-08-19 Thread Gary Benson
Hi all, I just retested this patch. The crash it fixes is still there, and the patch still fixes it. Is this ok to commit? Cheers, Gary Andrew Burgess wrote: > In two places when a struct demangle_component is of type > DEMANGLE_COMPONENT_FIXED_TYPE we fall back to accessing the default > s_bi

Re: [wwwdocs] Re: gcc.gnu.org/simtest-howto.html (was: Question for ARM person re asm_fprintf)(

2014-08-19 Thread Hans-Peter Nilsson
On Mon, 18 Aug 2014, Oleg Endo wrote: > On Mon, 2014-08-18 at 16:57 -0400, Hans-Peter Nilsson wrote: > > On Mon, 18 Aug 2014, Oleg Endo wrote: > > > On Sun, 2014-08-17 at 16:56 -0400, Hans-Peter Nilsson wrote: > > > > On Fri, 15 Aug 2014, Oleg Endo wrote: > > > > > > How about the attached .html as

Re: [PATCH] Add guality [p]type test.

2014-08-19 Thread Mark Wielaard
On Mon, 2014-07-07 at 11:57 +0200, Richard Biener wrote: > Btw, why doesn't it succeed with LTO? I suspect it's because > we drop the unused variables - try adding __attribute__((used)) to > them. You are right, this makes the whole new test PASS also with LTO: 2014-08-19 Mark Wielaard *

[PATCH] Fix devirt to NULL

2014-08-19 Thread Richard Biener
This fixes Honzas previous commit to not build &integer_zero_node (what?). Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-08-19 Richard Biener * gimple-fold.c (fold_gimple_assign): Properly build a null-pointer constant when devirtualizing addres

Re: [PATCH] Fix thinko in handle_alias_pairs (PR c/61271)

2014-08-19 Thread Richard Biener
On Tue, Aug 19, 2014 at 12:25 PM, Marek Polacek wrote: > handle_alias_pairs contains the following thinko. > I believe it should be "not a virtual function". > > Bootstrapped/regtested on x86_64-linux, ok for trunk? Ok. Is only trunk affected? Thanks, Richard. > 2014-08-19 Marek Polacek > >

Re: [PATCH] Add guality [p]type test.

2014-08-19 Thread Richard Biener
On Tue, Aug 19, 2014 at 1:05 PM, Mark Wielaard wrote: > On Mon, 2014-07-07 at 11:57 +0200, Richard Biener wrote: >> Btw, why doesn't it succeed with LTO? I suspect it's because >> we drop the unused variables - try adding __attribute__((used)) to >> them. > > You are right, this makes the whole n

Re: [PATCH] Fix thinko in handle_alias_pairs (PR c/61271)

2014-08-19 Thread Marek Polacek
On Tue, Aug 19, 2014 at 01:22:20PM +0200, Richard Biener wrote: > On Tue, Aug 19, 2014 at 12:25 PM, Marek Polacek wrote: > > handle_alias_pairs contains the following thinko. > > I believe it should be "not a virtual function". > > > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > Ok.

Re: [PATCH] Fix thinko in handle_alias_pairs (PR c/61271)

2014-08-19 Thread Richard Biener
On Tue, Aug 19, 2014 at 1:31 PM, Marek Polacek wrote: > On Tue, Aug 19, 2014 at 01:22:20PM +0200, Richard Biener wrote: >> On Tue, Aug 19, 2014 at 12:25 PM, Marek Polacek wrote: >> > handle_alias_pairs contains the following thinko. >> > I believe it should be "not a virtual function". >> > >> >

Re: [PATCH] Fix for PR/62089 (enable missing Asan checks)

2014-08-19 Thread Dominique Dhumieres
> Makes sense, I've attached new patch (retested as usual). Well, you probably did not test with -m32: Running target unix/-m32 FAIL: c-c++-common/asan/pr62089.c -O0 output pattern test, is = FAIL: c-c++-common/asan/pr62089.c -

Re: [PATCH, Fortran] PR61234: -Wuse-no-only

2014-08-19 Thread Dominique Dhumieres
> So the negative version is -Wno-use-no-only? That sounds weird. What about -Wuse-without-only? I can also confirm that the test succeeds without the ' ! { dg-bogus "has no ONLY qualifier" }'. Dominique

RE: [PATCH, Fortran] PR61234: -Wuse-no-only

2014-08-19 Thread VandeVondele Joost
>> So the negative version is -Wno-use-no-only? That sounds weird. > What about -Wuse-without-only? Would be fine with me. Approved with this change ?

Re: [PATCH] Fix thinko in handle_alias_pairs (PR c/61271)

2014-08-19 Thread Marek Polacek
On Tue, Aug 19, 2014 at 01:35:20PM +0200, Richard Biener wrote: > On Tue, Aug 19, 2014 at 1:31 PM, Marek Polacek wrote: > > On Tue, Aug 19, 2014 at 01:22:20PM +0200, Richard Biener wrote: > >> On Tue, Aug 19, 2014 at 12:25 PM, Marek Polacek wrote: > >> > handle_alias_pairs contains the following

Re: [gomp4] Add tables generation

2014-08-19 Thread Bernd Schmidt
On 08/19/2014 12:41 PM, Ilya Verbin wrote: On 18 Aug 18:24, Bernd Schmidt wrote: I think I'd be happier if the function was called init_offload_table and also collected functions, rather than leaving that to expand_omp_target. I think the patch would be ok with that change. For the functions i

Re: [PATCH] Add guality [p]type test.

2014-08-19 Thread Mark Wielaard
On Tue, 2014-08-19 at 13:22 +0200, Richard Biener wrote: > On Tue, Aug 19, 2014 at 1:05 PM, Mark Wielaard wrote: > > On Mon, 2014-07-07 at 11:57 +0200, Richard Biener wrote: > >> Btw, why doesn't it succeed with LTO? I suspect it's because > >> we drop the unused variables - try adding __attribut

Re: [PATCH] Add guality [p]type test.

2014-08-19 Thread Richard Biener
On Tue, Aug 19, 2014 at 2:10 PM, Mark Wielaard wrote: > On Tue, 2014-08-19 at 13:22 +0200, Richard Biener wrote: >> On Tue, Aug 19, 2014 at 1:05 PM, Mark Wielaard wrote: >> > On Mon, 2014-07-07 at 11:57 +0200, Richard Biener wrote: >> >> Btw, why doesn't it succeed with LTO? I suspect it's becau

[PATCH][match-and-simplify] Fix GENERIC outermost expression type

2014-08-19 Thread Richard Biener
We shouldn't use the type of the operand but the type requested. This otherwise triggers asserts for (eq @0 @1) which requires boolean type, not whatever type @0 has. Applied. Richard. 2014-08-19 Richard Biener * genmatch.c (dt_simplify::gen_generic): Properly use the specif

[C++ Patch] Add default arguments to cp_parser_assignment_expression and cp_parser_constant_expression

2014-08-19 Thread Paolo Carlini
Hi, two more functions. Tested x86_64-linux. Thanks, Paolo. /// 2014-08-19 Paolo Carlini * parser.c (cp_parser_assignment_expression, cp_parser_constant_expression): Add default arguments. (cp_parser_primary_expression, cp_parser_postfix_o

Re: [gomp4] Add tables generation

2014-08-19 Thread Ilya Verbin
On 19 Aug 13:55, Bernd Schmidt wrote: > On 08/19/2014 12:41 PM, Ilya Verbin wrote: > >For the functions it's not so easy to identify which of them to add into the > >table, e.g.: > > #pragma omp target > > #pragma omp parallel > > x++; > >Here 2 functions with "omp declare target" attr

Re: [PATCH] Fix for PR/62089 (enable missing Asan checks)

2014-08-19 Thread Yury Gribov
On 08/19/2014 03:37 PM, Dominique Dhumieres wrote: Makes sense, I've attached new patch (retested as usual). Well, you probably did not test with -m32: Right, I only did plain "make check" until now. Thanks for reporting, I'll check this tomorrow. -Y

[PATCH][match-and-simplify] Allow zero-operand operators as predicates

2014-08-19 Thread Richard Biener
This makes us accept (plus @0 INTEGER_CST) and parse it as (plus @0 (INTEGER_CST)), that is, handle operator names in predicate position as expression with zero operands. This makes those leafs better integrate with the decision tree and also removes the need to define all those INTEGER_CST_P p

[PATCH][match-and-simplify] Split out common code for c_expr codegen

2014-08-19 Thread Richard Biener
Applied. Richard. 2014-08-19 Richard Biener * genmatch.c (c_expr::output_code): New method. (c_expr::gen_transform): Call it. (outline_c_exprs): Likewise. Index: gcc/genmatch.c === --- gcc/genmatch.c

Re: [PATCH][AArch64][tests]Skip graphite tests that don't fit -mcmodel=tiny

2014-08-19 Thread Kyrill Tkachov
On 11/08/14 18:34, Mike Stump wrote: On Aug 11, 2014, at 2:06 AM, Richard Earnshaw wrote: Not quite, read the subject line again. Doh. I did miss that entirely. The solutions I gave were for other cases than the case at hand. I'm not sure what the correct change to the testsuite is here.

RE: [PATCH, Fortran] PR61234: -Wuse-no-only

2014-08-19 Thread Tobias Burnus
VandeVondele Joost wrote: > >> So the negative version is -Wno-use-no-only? That sounds weird. > > What about -Wuse-without-only? > > Would be fine with me. Approved with this change ? That would be the patch: https://gcc.gnu.org/ml/fortran/2014-06/msg00114.html > +Warn if a use statement has no

Re: [gomp4] Add tables generation

2014-08-19 Thread Ilya Verbin
On 19 Aug 13:55, Bernd Schmidt wrote: > In any case, I think let's get this checked in for now and iterate later. Committed revision 214148. -- Ilya

Re: [PATCH][AArch64] Use CC_Z and CC_NZ with csinc and similar instructions

2014-08-19 Thread Kyrill Tkachov
On 18/08/14 19:52, Richard Henderson wrote: On 08/18/2014 05:24 AM, Kyrill Tkachov wrote: -(define_insn "*csinc2_insn" +(define_insn "*csinc2__insn" [(set (match_operand:GPI 0 "register_operand" "=r") (plus:GPI (match_operator:GPI 2 "aarch64_comparison_operator" -

Re: DSE calls to builtins (memset, etc)

2014-08-19 Thread Richard Biener
On Sat, Aug 16, 2014 at 11:21 PM, Marc Glisse wrote: > Hello, > > here is a patch extending DSE to handle calls to memset, memcpy and memmove. > A number of alias functions didn't have a version taking an ao_ref*, so I > added those. Instead of naming things _1, _2, etc I took advantage of C++ > a

Re: [PATCH] Fix devirt to NULL

2014-08-19 Thread Jan Hubicka
> > This fixes Honzas previous commit to not build &integer_zero_node (what?). Oops, thanks! Honza > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > Richard. > > 2014-08-19 Richard Biener > > * gimple-fold.c (fold_gimple_assign): Properly build a > null-poi

[PATCH AArch64 2/2] Remove vector compare/tst __builtins

2014-08-19 Thread Alan Lawrence
The vector compare intrinsics (vc[gl][et]z, vceqz, vtst) were written using __builtin functions as (IIUC) at the time gcc vector extensions did not support comparison ops across both C and C++ frontends. These have since been updated. Following the first patch, we now get equal/better code gene

[PATCH][match-and-simplify] Use a switch (code) for the GIMPLE code gen

2014-08-19 Thread Richard Biener
on the outermost level. Committed. Richard. 2014-08-19 Richard Biener * genmatch.c (decision_tree::gen_gimple): Use a switch statement for the outermost level. * gimple-match.h (code_helper::get_rep): New method. Index: gcc/genmatch.c ===

Fwd: [PATCH] Add patch for debugging compiler ICEs.

2014-08-19 Thread Maxim Ostapenko
Ping. -Maxim Original Message Subject:[PATCH] Add patch for debugging compiler ICEs. Date: Mon, 04 Aug 2014 21:03:22 +0400 From: Maxim Ostapenko To: GCC Patches CC: Jeff Law , Jakub Jelinek , tsaund...@mozilla.com, Yury Gribov , Slava Garbuzov Hi, A ye

Re: [PATCH] Fix comment typo in ira.c

2014-08-19 Thread Vladimir Makarov
On 08/18/2014 10:51 AM, Kito Cheng wrote: > Hi Vladimir: > > Here is a tiny typo in comment, allono -> allocno. > > ChangLog > 2014-08-18 Kito Cheng > > * ira.c: Fix typo in comment. Thanks, Kito. Of course, the patch is ok. You can commit it if it is not committed yet.

Re: [C/C++ PATCH] Implement -Wbool-compare (PR c++/62153)

2014-08-19 Thread Marek Polacek
On Tue, Aug 19, 2014 at 11:08:39AM +0200, Manuel López-Ibáñez wrote: > > Not sure about that: it matters whether the CST is a LHS or a RHS > > - because we want to say if the comparison is always true or false. > > I tried to introduce some bool flag, but that didn't really help > > readability IMH

[PATCH] Quash Wbool-compare warning in optabs.c

2014-08-19 Thread Marek Polacek
On some archs, C[TL]Z_DEFINED_VALUE_AT_ZERO macros return only true/false, so -Wbool-compare would warn. But on e.g. mips or aarch64 they might yield 2. This patch casts the value to int to quash that warning. Dropping the "== 2" would be prettier, but I don't want to break other archs. The poin

Re: DSE calls to builtins (memset, etc)

2014-08-19 Thread Marc Glisse
On Tue, 19 Aug 2014, Richard Biener wrote: /* Return true whether REF may refer to global memory. */ bool -ref_may_alias_global_p (tree ref) +ref_may_alias_global_p (ao_ref *ref) { - tree base = get_base_address (ref); + tree base = ao_ref_base (ref); if (DECL_P (base)) return is_

Re: [PATCH] C frontend: cast-expressions sometimes retain type qualifiers

2014-08-19 Thread Patrick Palka
On Mon, Aug 18, 2014 at 2:07 PM, Joseph S. Myers wrote: > On Sat, 16 Aug 2014, Patrick Palka wrote: > >> 2014-08-17 Patrick Palka ppa...@gcc.gnu.org >> >> * c-typeck.c (build_c_cast): Do a conversion even when the >> TYPE_MAIN_VARIANTs are the same. >> >> 2014-08-17 Patrick Palka p

Re: [PATCH] Remove CALLER_SAVE_PROFITABLE since nobody use it now

2014-08-19 Thread Kito Cheng
Hi Richard: >Hmm, I'm not sure about this. It might not be used at present, but on: >AArch64, with more call-clobbered registers than call-saved registers, I >would expect this ought to be a win. The fact that it isn't on today >may say more about the way it works than the concept that it's the w

Re: [PATCH] fix FTBFS with --target=i686-pc-cygwin

2014-08-19 Thread Kai Tietz
Applied for you at rev. 214153. Kai 2014-08-12 20:37 GMT+02:00 Kai Tietz : > 2014-08-12 20:34 GMT+02:00 Yaakov Selkowitz : >> There is a syntax error in r213009 causing a FTBFS in trunk with >> --target=i686-pc-cygwin. Patch attached, with which trunk now builds for >> said target. >> >> -- >> Y

Re: [PATCH] Quash Wbool-compare warning in optabs.c

2014-08-19 Thread Richard Henderson
On 08/19/2014 07:12 AM, Marek Polacek wrote: > On some archs, C[TL]Z_DEFINED_VALUE_AT_ZERO macros return only > true/false, so -Wbool-compare would warn. Then we should fix them to return 0/1 instead. r~

[PATCH][match-and-simplify] Avoid excessive bracesin code-gen

2014-08-19 Thread Richard Biener
Committed. Richard. 2014-08-19 Richard Biener * genmatch.c (dt_operand::gen_gimple): Remove excessive braces. (dt_operand::gen_generic): Likewise. Index: gcc/genmatch.c === --- gcc/genmatch.c (revis

Re: [Patch] Enable libatomic for cygwin targets

2014-08-19 Thread Kai Tietz
Applied for you at revision 214154. Kai

Re: [PATCH 011/236] Replace PREV_INSN et al macros with functions

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:20 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > Yet more scaffolding: convert the NEXT_INSN/PREV_INSN macros > > and their SET_* variants into functions. > > > > Convert the rvalue-style functions into returning > > rtx_insn * rather than plain rtx.

Re: [PATCH] Fix cygwin-stdint.h

2014-08-19 Thread Kai Tietz
Applied for you at revision 214156. Kai

[PATCH][0/7][ARM] Convert VFP mnemonics to UAL

2014-08-19 Thread Kyrill Tkachov
Hi all, This patch series converts the arm backend to output unified assembly syntax for the VFP instructions. This makes it more readable since most UAL mnemonics also include various type suffixes such as .f32 and .f64 that quickly allow to identify the data types being operated on. Each p

Re: [PATCH] cygwin: fix --tsaware, add --large-address-aware

2014-08-19 Thread Kai Tietz
Applied for you at revision 214158. Kai

[PATCH][ARM][3/7] Convert FP mnemonics to UAL | mul+add patterns

2014-08-19 Thread Kyrill Tkachov
Hi all, This patch switches over the FP mul+add, mul+neg+add etc patterns. Mixing some of the mnemonics up is a danger but the ARM ARM has a handy section that maps each mnemonic to its UAL equivalent. Ok for trunk? Thanks, Kyrill 2014-08-19 Kyrylo Tkachov * config/arm/vfp.md (*muls

[PATCH][ARM][4/7] Convert FP mnemonics to UAL | vcvt patterns

2014-08-19 Thread Kyrill Tkachov
Hi all, These are the fp<->fp and int<->fp convert patterns. IMHO these are much more readable than the pre-UAL ones because they use two suffixes to indicate which data types are being converted to and from. Ok for trunk? Thanks, Kyrill 2014-08-19 Kyrylo Tkachov * config/arm/vfp.md

[PATCH][ARM][5/7] Convert FP mnemonics to UAL | sqrt and FP compare patterns

2014-08-19 Thread Kyrill Tkachov
Hi all, The sqrt and floating point compare patterns. For the case when we compare with floating-point 0 the ARM ARM uses the syntax 'vcmp {s,d}, #0.0' but current gas has a bug and doesn't accept that form, only 'vcmp {s,d}, #0' There is a gas patch in review on the binutils mailing list but

[PATCH][ARM][6/7] Convert FP mnemonics to UAL | movcc_vfp (fmstat)

2014-08-19 Thread Kyrill Tkachov
Hi all, The ARM ARM explicitly says that fmstat is translated into 'vmrs APSR_nzcvm, FPSCR' in UAL syntax so this patch does that. Ok for trunk? Thanks, Kyrill 2014-08-19 Kyrylo Tkachov * config/arm/vfp.md (*movcc_vfp): Use UAL syntax.commit f33bf477f1e30e1125250838843343facb2a7716 A

[PATCH][ARM][7/7] Convert FP mnemonics to UAL | f{ld,st}m -> v{ld,st}m

2014-08-19 Thread Kyrill Tkachov
Hi all, This patch updates some FP load/store multiple patterns and in the vfp_output_vstmd case when the instruction is used as a push to sp it now emits a vpush mnemonic instead of vstmdb. Ok for trunk? Thanks, Kyrill 2014-08-19 Kyrylo Tkachov * config/arm/arm.md (vfp_pop_multiple

Re: [PATCH] Move caret printing to diagnostics_finalizer

2014-08-19 Thread Dodji Seketeli
Manuel López-Ibáñez writes: > This patch is in preparation for further patches moving the Fortran FE > to use the common diagnostics machinery. > > Fortran has its own way of printing the caret information, so we need > a way to override the default in the diagnostics machinery. A simple > way is

[COMMITTED] Add myself to MAINTAINERS (Write After Approval)

2014-08-19 Thread VandeVondele Joost
Committed revision 214159. 2014-08-19 Joost VandeVondele * MAINTAINERS (Write After Approval): Add myself. Index: MAINTAINERS === --- MAINTAINERS (revision 214158) +++ MAINTAINERS (working copy) @@ -561,6 +561,7 @@ Markus

[PATCH][ARM][2/7] Convert FP mnemonics to UAL | add/sub/div/abs patterns

2014-08-19 Thread Kyrill Tkachov
Hi all, Nothing too controversial here, convert the concerned patterns to UAL. The size of the data types in the operation is expressed in the .f32 or .f64 suffix. Ok for trunk? Thanks, Kyrill 2014-08-19 Kyrylo Tkachov * config/arm/vfp.md (*abssf2_vfp): Use UAL assembly syntax. (

Re: [PATCH 012/236] Convert DF_REF_INSN to a function for now

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:20 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > DF_REF_INSN looks up the "insn" field of the referenced df_insn_info. > > This will eventually be an rtx_insn *, but for now is just an rtx. > > > > As further scaffolding: for now, convert DF_REF_INSN

[PATCH][ARM][1/7] Convert FP mnemonics to UAL | mov patterns

2014-08-19 Thread Kyrill Tkachov
Hi all, In this patch the move patterns are updated. For the fconst case where the constant is encoded in a decimal representation before going into the immediate field of the assembly instruction UAL syntax allows for the real operand to be output directly and leaves the assembler to do the enco

Re: [PATCH][AArch64] Use CC_Z and CC_NZ with csinc and similar instructions

2014-08-19 Thread Richard Henderson
On 08/19/2014 06:29 AM, Kyrill Tkachov wrote: > +(define_special_predicate "cc_register_zero" > + (and (match_code "reg") > + (and (match_test "REGNO (op) == CC_REGNUM") > + (ior (match_test "mode == GET_MODE (op)") > + (ior (match_test "mode == VOIDmode > +

Re: [PATCH] cygwin: __cxa_atexit support

2014-08-19 Thread Kai Tietz
Patch is ok. Applied this patch at revision 214162 together with your followup-patch at revision 214161. Thanks, Kai

Re: [PATCH] cygwin: accept -pthread

2014-08-19 Thread Kai Tietz
Patch is ok. Applied this patch at revision 214161 together with your followup-patch at revision 214162. Thanks, Kai

Re: [PATCH] _cxa_thread_atexit fixes for Cygwin/MinGW-w64

2014-08-19 Thread Kai Tietz
Applied at revision 214163. Thanks, Kai

Re: [PATCH 013/236] DEP_PRO/DEP_CON scaffolding

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:21 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > For now, convert DEP_PRO and DEP_CON into functions. We will eventually > > change them back to macros once the relevant fields are of type > > rtx_insn *. > > > > gcc/ > > * sched-int.h (DEP_PRO):

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-19 Thread Chen Gang
Excuse me, I did not finish in time. At present, I shall be mainly focus on testsuite. Before I finish it, I can do nothing (I should do nothing) for this patch. Originally: - I get a PC (not buy), it is low quality which cause reboot after run several hours with full cpu used, I wasted much

Re: [PATCH 014/236] VINSN_INSN_RTX scaffolding

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:21 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > For now, convert into VINSN_INSN_RTX a pair of functions. We will > > eventually change them back to a macro once the relevant field is of type > > rtx_insn *. > > > > gcc/ > > * sel-sched-ir.h (VI

[committed] Fix typo in diagnostics

2014-08-19 Thread Marek Polacek
I noticed a typo in a diagnostic message. No test needs adjusting. Bootstrapped/regtested on x86_64-linux, applying to trunk. 2014-08-19 Marek Polacek * lex.c (_cpp_lex_direct): Fix a typo. diff --git gcc/lex.c gcc/lex.c index 0713f65..827cfb0 100644 --- gcc/lex.c +++ gcc/lex.c @@ -

Re: [PATCH][AArch64] Use CC_Z and CC_NZ with csinc and similar instructions

2014-08-19 Thread Kyrill Tkachov
On 19/08/14 16:25, Richard Henderson wrote: On 08/19/2014 06:29 AM, Kyrill Tkachov wrote: +(define_special_predicate "cc_register_zero" + (and (match_code "reg") + (and (match_test "REGNO (op) == CC_REGNUM") + (ior (match_test "mode == GET_MODE (op)") +(ior (mat

[COMMITTED] Remove myself from MAINTAINERS

2014-08-19 Thread Christopher Faylor
Committed as revision 214157. 2014-08-19 Christopher Faylor * MAINTAINERS: Remove myself Index: MAINTAINERS === --- MAINTAINERS (revision 214153) +++ MAINTAINERS (working copy) @@ -136,7 +136,6 @@ VMS

Re: [PATCH] Quash Wbool-compare warning in optabs.c

2014-08-19 Thread Richard Henderson
On 08/19/2014 08:54 AM, Marek Polacek wrote: > Works as well. So is the following ok once the regtest finishes? > > Bootstrapped on x86_64-linux. > > 2014-08-19 Marek Polacek > > * config/alpha/alpha.h (CLZ_DEFINED_VALUE_AT_ZERO, > CTZ_DEFINED_VALUE_AT_ZERO): Return 0/1 rather th

Re: [PATCH 015/236] BB_NOTE_LIST scaffolding

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:22 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > gcc/ > > * sel-sched-ir.h (BB_NOTE_LIST): struct sel_region_bb_info_def's > > "note_list" field will eventually be an rtx_insn *. To help with > > transition, for now, convert from an acces

Re: [PATCH][AArch64] Use CC_Z and CC_NZ with csinc and similar instructions

2014-08-19 Thread Richard Henderson
> (define_special_predicate "cc_register_zero" > (match_code "reg") > { > return (REGNO (op) == CC_REGNUM > && (GET_MODE (op) == CCmode > || GET_MODE (op) == CC_Zmode > || GET_MODE (op) == CC_NZmode)); > }) ... and now that I read the backend more closely,

Re: [PATCH] Quash Wbool-compare warning in optabs.c

2014-08-19 Thread Marek Polacek
On Tue, Aug 19, 2014 at 07:52:33AM -0700, Richard Henderson wrote: > On 08/19/2014 07:12 AM, Marek Polacek wrote: > > On some archs, C[TL]Z_DEFINED_VALUE_AT_ZERO macros return only > > true/false, so -Wbool-compare would warn. > > Then we should fix them to return 0/1 instead. Works as well. So

Re: PATCH: PR other/62168: error in configure: line 21572: test: =: unary operator expected

2014-08-19 Thread H.J. Lu
On Mon, Aug 18, 2014 at 08:51:35AM -0700, H.J. Lu wrote: > When --enable-gold=no is used to configure gcc, we will see > > configure: line 21572: test: =: unary operator expected > > I checked in this patch to set install_gold_as_default to no for > --enable-gold=no. Tested on Linux/x86-64. > >

Re: [PATCH, i386]: Fix PR62011, False data dependency in popcnt instruction

2014-08-19 Thread H.J. Lu
On Mon, Aug 18, 2014 at 12:29 PM, Uros Bizjak wrote: > On Mon, Aug 18, 2014 at 9:16 PM, H.J. Lu wrote: > >>> Attached patch fixes the problem with false data dependency on output >>> register for popcnt, lzcnt and tzcnt insns on sandybridge and haswell >>> targets. >>> >>> The new insn pattern sh

Re: [PATCH][AArch64][tests]Skip graphite tests that don't fit -mcmodel=tiny

2014-08-19 Thread Mike Stump
On Aug 19, 2014, at 6:12 AM, Kyrill Tkachov wrote: > So how about this? Ok. Thanks.

Re: [PATCH 016/236] BND_TO scaffolding

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:22 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > gcc/ > > * sel-sched-ir.h (BND_TO): insn_t will eventually be an > > rtx_insn *. To help with transition, for now, convert from an > > access macro into a pair of functions: BND_TO, returni

Re: [PATCH][AArch64] Use CC_Z and CC_NZ with csinc and similar instructions

2014-08-19 Thread Kyrill Tkachov
On 19/08/14 17:09, Richard Henderson wrote: (define_special_predicate "cc_register_zero" (match_code "reg") { return (REGNO (op) == CC_REGNUM && (GET_MODE (op) == CCmode || GET_MODE (op) == CC_Zmode || GET_MODE (op) == CC_NZmode)); }) ... and now t

Re: [C/C++ PATCH] Implement -Wbool-compare (PR c++/62153)

2014-08-19 Thread Marek Polacek
On Mon, Aug 18, 2014 at 10:23:49PM +0200, Marek Polacek wrote: > On Mon, Aug 18, 2014 at 04:10:49PM -0400, Jason Merrill wrote: > > On 08/18/2014 04:04 PM, Marek Polacek wrote: > > >Unfortunately, this warning cannot be enabled by -Wall yet, because > > >of a few blunders we have in the codebase.

Re: [PATCH] PowerPC: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV

2014-08-19 Thread Adhemerval Zanella
Ping. On 06-08-2014 17:21, Adhemerval Zanella wrote: > On 01-08-2014 12:31, Joseph S. Myers wrote: >> On Thu, 31 Jul 2014, David Edelsohn wrote: >> >>> Thanks for implementing the FENV support. The patch generally looks >>> good to me. >>> >>> My one concern is a detail in the implementation of

Re: [PATCH 017/236] Add subclasses for the various kinds of instruction

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 21:07 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > gcc/ > > * coretypes.h (class rtx_real_insn): Add forward declaration. > > (class rtx_debug_insn): Likewise. > > (class rtx_nonjump_insn): Likewise. > > (class rtx_jump_insn): Likewise.

[PATCH AArch64] Add a builtin for rbit(q?)_p8; add intrinsics and tests.

2014-08-19 Thread Alan Lawrence
This patch adds the missing vrbit_p8 and vrbitq_p8 intrinsics to arm_neon.h, and implements all the vrbit(q?)_[psu]8 intrinsics using a new builtin, rather than the previous temporary asm. Also adds a testcase checking (a) execution results and (b) that we output rbit vXX.8b,vYY.8b or correspond

[PATCH] Fix bootstrap on ppc64

2014-08-19 Thread Marek Polacek
My recent patch broke bootstrap on ppc64, because, by default, char on ppc defaults to be an unsigned char. But the code relied on char being signed by default. Furthermore, the compat warning about // comments shouldn't be issued in C++ mode at all. Sorry about that. Bootstrapped on ppc64-linux,

Re: C++ PATCH to set DECL_COMDAT on undefined inlines/templates

2014-08-19 Thread Jason Merrill
Another needed tweak, applying to trunk. commit aac24a75af315fb6aa6099a159c6bce339706bc1 Author: Jason Merrill Date: Mon Aug 18 21:34:12 2014 -0400 PR lto/53808 PR c++/61659 * decl.c (maybe_commonize_var): Don't use DECL_COMDAT to trigger comdat_linkage. diff --git a/gcc/c

[c++-concepts] normalization checks

2014-08-19 Thread Andrew Sutton
This patch adds checks for user-defined logical operators during constraint normalization and ensures that all atomics can be converted to bool. 2014-08-14 Andrew Sutton Implement normalization checks. * gcc/cp/constraint.cc (normalize_expr): Delegate cast and atomic no

Re: [PATCH 018/236] Strengthen return types of various {next|prev}_*insn from rtx to rtx_insn *

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:59 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > These should all eventually require an rtx_insn * as an argument, > > but we'll save that for a later patch. > > > > gcc/ > > * rtl.h (previous_insn): Strengthen return type from rtx to > > rtx_

Re: [C/C++ PATCH] Implement -Wbool-compare (PR c++/62153)

2014-08-19 Thread Jason Merrill
On 08/19/2014 12:52 PM, Marek Polacek wrote: + tree cst = TREE_CODE (op0) == INTEGER_CST +? op0 : TREE_CODE (op1) == INTEGER_CST ? op1 : NULL_TREE; This indentation won't survive Emacs auto-indent; please add parentheses. + int sign = TREE_CODE (op0) == INTEGER_CST +

Re: [PATCH] Add guality [p]type test.

2014-08-19 Thread Mark Wielaard
On Tue, 2014-08-19 at 14:16 +0200, Richard Biener wrote: > On Tue, Aug 19, 2014 at 2:10 PM, Mark Wielaard wrote: > > gcc/testsuite/ChangeLog > > 2014-08-19 Mark Wielaard > > > > * gcc.dg/guality/restrict.c: Add `used' attribute to all variables. > > (cpy): Change type of last argument t

[PATCH/PR c/59304] #pragma diagnostic pop after warning fails for options unspecified in the command-line and disabled by default

2014-08-19 Thread Manuel López-Ibáñez
The idea is that when we see a change of classification, and the option was originally unspecified, we record the command-line status. This way, when doing pop later, we already check if the option was reclassified so we get the command-line status. This also works with -Wall, since all dependent o

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:19 AM, David Malcolm wrote: > @@ -2772,11 +2772,11 @@ mn10300_adjust_sched_cost (rtx insn, rtx link, rtx > dep, int cost) >if (!TARGET_AM33) > return 1; > > - if (GET_CODE (insn) == PARALLEL) > -insn = XVECEXP (insn, 0, 0); > + if (GET_CODE (PATTERN (insn)) == PAR

  1   2   >