On Mon, Aug 18, 2014 at 8:00 PM, Prathamesh Kulkarni <bilbotheelffri...@gmail.com> wrote: > On Mon, Aug 18, 2014 at 11:06 PM, David Malcolm <dmalc...@redhat.com> wrote: >> On Mon, 2014-08-18 at 01:11 +0530, Prathamesh Kulkarni wrote: >>> We now have at-least one test-case for each of constant folding >>> patterns >>> in match-constant-folding.pd >>> >>> [gcc/testsuite/gcc.dg/tree-ssa] >>> * match-constant-folding.c: Add test-cases. >>> >>> [...snip...] >> >> A minor nit for one of the comments, for modulo division: >> >>> Index: match-constant-folding.c >>> =================================================================== >>> --- match-constant-folding.c (revision 214020) >>> +++ match-constant-folding.c (working copy) >> [...] >> >>> +/* x % x -> 1 */ >> ^ >> 0, rather than 1, surely? > Thanks, fixed in this patch. > > * testsuite/match-constant-folding.c: Fix typo.
Applied. Richard. > Regards, > Prathamesh >> >> >>
