Re: [Patch] Fix undefined behaviors in regex

2013-10-16 Thread Tim Shen
On Wed, Oct 16, 2013 at 6:33 PM, Paolo Carlini wrote: > By the way, please feel free to prepare a reduced testcase for the > -fsanitize people (Marek, Jakub?) Here it is. And we should get undefined behaviors before this commit(r203732). -- Tim Shen split.cc Description: Binary data

Re: [Patch] Fix undefined behaviors in regex

2013-10-16 Thread Paolo Carlini
On 10/17/2013 12:39 AM, Tim Shen wrote: On Wed, Oct 16, 2013 at 6:33 PM, Paolo Carlini wrote: By the way, please feel free to prepare a reduced testcase for the -fsanitize people (Marek, Jakub?) Here it is. And we should get undefined behaviors before this commit(r203732). To be honest, I was

[rl78] add rtx paranoia

2013-10-16 Thread DJ Delorie
Building newlib uncovered a few invalid assumptions... Committed. * config/rl78/rl78.c (rl78_alloc_address_registers_macax): Verify op is a REG before checking REGNO. (rl78_alloc_physical_registers): Verify pattern is a SET before checking SET_SRC. Index: config/

Re: [Patch] Fix undefined behaviors in regex

2013-10-16 Thread Tim Shen
On Wed, Oct 16, 2013 at 6:42 PM, Paolo Carlini wrote: > On 10/17/2013 12:39 AM, Tim Shen wrote: >> >> On Wed, Oct 16, 2013 at 6:33 PM, Paolo Carlini >> wrote: >>> >>> By the way, please feel free to prepare a reduced testcase for the >>> -fsanitize people (Marek, Jakub?) >> >> Here it is. >> >> A

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread Michael Meissner
On Wed, Oct 16, 2013 at 02:34:56PM -0700, Sriraman Tallam wrote: > On Tue, Oct 15, 2013 at 10:54 PM, Alan Modra wrote: > > On Tue, Oct 15, 2013 at 02:45:23PM -0700, Sriraman Tallam wrote: > >> I committed this patch after making the above change. > > > > /src/gcc-virgin/gcc/config/rs6000/rs6000.c:

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread Sriraman Tallam
On Wed, Oct 16, 2013 at 4:13 PM, Michael Meissner wrote: > On Wed, Oct 16, 2013 at 02:34:56PM -0700, Sriraman Tallam wrote: >> On Tue, Oct 15, 2013 at 10:54 PM, Alan Modra wrote: >> > On Tue, Oct 15, 2013 at 02:45:23PM -0700, Sriraman Tallam wrote: >> >> I committed this patch after making the ab

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-10-16 Thread Wei Mi
> Go ahead and consider that pre-approved. Just send it to the list with a > note that I approved it in this thread. > > Jeff Thanks! The new patch addressed Jeff's comments. Is it ok for x86 maintainer? Thanks, Wei Mi. 2013-10-16 Wei Mi * gcc/config/i386/i386.c (memory_address_len

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread Michael Meissner
On Wed, Oct 16, 2013 at 04:23:56PM -0700, Sriraman Tallam wrote: > On Wed, Oct 16, 2013 at 4:13 PM, Michael Meissner > wrote: > > On Wed, Oct 16, 2013 at 02:34:56PM -0700, Sriraman Tallam wrote: > >> On Tue, Oct 15, 2013 at 10:54 PM, Alan Modra wrote: > >> > On Tue, Oct 15, 2013 at 02:45:23PM -07

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

2013-10-16 Thread DJ Delorie
> As it looks like, the -fstrict-volatile-bitfields are already totally broken, I tested your example on rl78-elf, with and without -fstrict-volatile-bitfields, and it generates correct code with it and incorrect code without it. Same for m32c-elf. Same for h8300-elf. Seems to be working OK for

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread David Edelsohn
On Wed, Oct 16, 2013 at 7:23 PM, Sriraman Tallam wrote: > I was unable to build a native powerpc compiler. I checked for > build_target_node and build_optimization_node throughout and changed > rs6000 because it had references. I did not realize > function_specific_save and function_specific_rest

Re: patch to canonize unsigned tree-csts

2013-10-16 Thread Kenneth Zadeck
On 10/15/2013 02:30 PM, Richard Sandiford wrote: Richard Sandiford writes: if (small_prec) ; else if (precision == xprecision) while (len >= 0 && val[len - 1] == -1) len--; Err, len > 0 obviously. you were only close.patch tested on ppc and commit

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread Sriraman Tallam
On Wed, Oct 16, 2013 at 6:06 PM, David Edelsohn wrote: > On Wed, Oct 16, 2013 at 7:23 PM, Sriraman Tallam wrote: > >> I was unable to build a native powerpc compiler. I checked for >> build_target_node and build_optimization_node throughout and changed >> rs6000 because it had references. I did n

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-16 Thread Andrew Pinski
On Wed, Oct 16, 2013 at 2:12 AM, Zhenqiang Chen wrote: > Hi, > > The patch enhances ifcombine pass to recover some non short circuit > branches. Basically, it will do the following transformation: > > Case 1: > if (cond1) > if (cond2) > ==> > if (cond1 && cond2) > > Case 2: > if (cond1)

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

2013-10-16 Thread Sandra Loosemore
On 10/16/2013 05:46 PM, DJ Delorie wrote: As it looks like, the -fstrict-volatile-bitfields are already totally broken, I tested your example on rl78-elf, with and without -fstrict-volatile-bitfields, and it generates correct code with it and incorrect code without it. Same for m32c-elf. Sa

Re: [PATCH][i386]Fix PR 57756

2013-10-16 Thread Xinliang David Li
On Wed, Oct 16, 2013 at 6:06 PM, David Edelsohn wrote: > On Wed, Oct 16, 2013 at 7:23 PM, Sriraman Tallam wrote: > >> I was unable to build a native powerpc compiler. I checked for >> build_target_node and build_optimization_node throughout and changed >> rs6000 because it had references. I did n

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

2013-10-16 Thread DJ Delorie
> I'm curious; do all the test cases included in > http://gcc.gnu.org/ml/gcc-patches/2013-09/msg02058.html > work for you on those targets as well (without applying the rest of the > patch)? Not all of them can work, because they describe something that can't be done in hardware. For example, t

Re: FW: MAX_PATH problems with mingw gcc

2013-10-16 Thread Joey Ye
Thanks for contribution. See review comments at following. On Wed, Oct 16, 2013 at 6:45 PM, Vladimir Simonov wrote: > Hi, > > Resending filename-normalize patch to correct list gcc-patches@gcc.gnu.org. > All context, please, see below. > > +extern void filename_normalize (char *f); > +#define FI

Re: FW: MAX_PATH problems with mingw gcc

2013-10-16 Thread Joey Ye
On Wed, Oct 16, 2013 at 6:45 PM, Vladimir Simonov wrote: > There are many pro and contras, i.e. it adds additional, probably unnecessary > work on Linux > time but makes filenames shorter, it affects libiberty which is shared > between gcc/binutils/gdb, > but it may be useful in other packages,

RE: [PATCH]Fix computation of offset in ivopt

2013-10-16 Thread bin.cheng
Hi, As noted in previous messages, GCC forces offset to unsigned in middle end. It also gets offset value and stores it in HOST_WIDE_INT then uses it in various computation. In this scenario, It should use int_cst_value to do additional sign extension against the type of tree node, otherwise we mi

Re: [RFC] By default if-convert only basic blocks that will be vectorized

2013-10-16 Thread Sergey Ostanevich
Jakub, Richard, I believe this patch is a good opportunity to improve the vectorization capabilities. I have the following question related to it: whether we plan to treat the #pragma omp simd as a directive to vectorize the underlying loop, hence dropping any assessment regarding profitablity?

Re: [RFC] By default if-convert only basic blocks that will be vectorized

2013-10-16 Thread pinskia
> On Oct 15, 2013, at 5:32 AM, Jakub Jelinek wrote: > > Hi! > > Especially on i?86/x86_64 if-conversion pass seems to be often > a pessimization, but the vectorization relies on it and without it we can't > vectorize a lot of the loops. I think on many other targets it actually helps. I know

<    1   2