[Patch] Regex back-reference support

2013-08-10 Thread Tim Shen
Nothing surprising here. Bootstrap passed and tested under x86_64 and i386 Linux. -- Tim Shen backref.patch Description: Binary data

Re: [Patch] Regex back-reference support

2013-08-10 Thread Tim Shen
On Sat, Aug 10, 2013 at 4:37 PM, Tim Shen wrote: > Nothing surprising here. > > Bootstrap passed and tested under x86_64 and i386 Linux. Changelog. -- Tim Shen changelog Description: Binary data

Re: [Patch] Regex back-reference support

2013-08-10 Thread Paolo Carlini
On 08/10/2013 10:37 AM, Tim Shen wrote: +regex_match(s, *(&s+1)-1, m, re); I don't like these *(&s+1)-1. Paolo.

Re: [Patch] Regex back-reference support

2013-08-10 Thread Tim Shen
On Sat, Aug 10, 2013 at 4:58 PM, Paolo Carlini wrote: > On 08/10/2013 10:37 AM, Tim Shen wrote: >> >> +regex_match(s, *(&s+1)-1, m, re); > > I don't like these *(&s+1)-1. As you wish :) -- Tim Shen changelog Description: Binary data backref.patch Description: Binary data

Re: Speculative call support in the callgraph

2013-08-10 Thread Jan Hubicka
> On Sat, Aug 10, 2013 at 02:25:21AM +0200, Andi Kleen wrote: > > On Sat, Aug 10, 2013 at 01:15:11AM +0200, Jan Hubicka wrote: > > > > Jan Hubicka writes: > > > > > > > > > Hi, > > > > > this patch adds support for speculative calls into callgraph. The > > > > > idea is that > > > > > any IPA o

Re: Speculative call support in the callgraph

2013-08-10 Thread Jan Hubicka
Hi, also I just became aware that this patch hits the following bug of gold http://sourceware.org/bugzilla/show_bug.cgi?id=14342 It makes gcc.dg/tree-prof/crossmodule-indircall-1.c fail with the bogus diagnostic on TLS and non-TLS use of the same symbol. I attached the details into the PR. GNU-LD

Re: [Patch] Regex back-reference support

2013-08-10 Thread Paolo Carlini
Hi, Tim Shen ha scritto: >On Sat, Aug 10, 2013 at 4:58 PM, Paolo Carlini > wrote: >> On 08/10/2013 10:37 AM, Tim Shen wrote: >>> >>> +regex_match(s, *(&s+1)-1, m, re); >> >> I don't like these *(&s+1)-1. > >As you wish :) See wasn't that difficult, after all ;) Seriously, a modern c++ prog

Re: Speculative call support in the callgraph

2013-08-10 Thread Jan Hubicka
> This is really strange. The speculative edges should not be created here at > all. > So perhaps some uninitialized memory access crept in :( > It would help if you try to track how the ->speculative bit appears for you > in the loop in cgraph_rebuild_references. I will try to reproduce your set

Re: RFC - Refactor tree.h

2013-08-10 Thread Richard Biener
Mike Stump wrote: >On Aug 9, 2013, at 3:36 PM, Diego Novillo wrote: >> This patch is still WIP. It builds stage1, but I'm getting ICEs >> during stage 2. >> >> The patch splits tree.h into three files: >> >> - tree-core.h: All data structures, enums and typedefs from >> tree.h >> >> - tree-a

Re: [Patch] Regex back-reference support

2013-08-10 Thread Tim Shen
On Sat, Aug 10, 2013 at 5:41 PM, Paolo Carlini wrote: > More important: we are adding support for a non trivial feature and not a > single comment in the new code refers to it. This is not ok, please add at > least 2 or 3. Here it is. Two pieces of code concerning implementation logic is commen

Re: [C++ Patch / RFC] PR 46206

2013-08-10 Thread Iain Sandoe
Hi Paolo, On 9 Aug 2013, at 16:47, Paolo Carlini wrote: > On 08/09/2013 05:22 PM, David Edelsohn wrote: >> Exactly. What is the common factor on AIX, Darwin and Solaris that is >> different from Linux? A difference in system types? How can we help? > Thanks David, all, for your kind offers. > >

Re: Speculative call support in the callgraph

2013-08-10 Thread Jan Hubicka
> Hi, > also I just became aware that this patch hits the following bug of gold > http://sourceware.org/bugzilla/show_bug.cgi?id=14342 > It makes gcc.dg/tree-prof/crossmodule-indircall-1.c fail with the bogus > diagnostic on TLS and non-TLS use of the same symbol. I attached the > details into the

Re: Speculative call support in the callgraph

2013-08-10 Thread Andi Kleen
I can confirm that trunk bootstraps again. Thanks. Now if someone could please fix http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58090 too (bootstrap comparison failure with --enable-gather-detailed-mem-stats) -Andi -- a...@linux.intel.com -- Speaking for myself only.

Re: [Patch] Regex back-reference support

2013-08-10 Thread Paolo Carlini
Hi, On 08/10/2013 12:50 PM, Tim Shen wrote: On Sat, Aug 10, 2013 at 5:41 PM, Paolo Carlini wrote: More important: we are adding support for a non trivial feature and not a single comment in the new code refers to it. This is not ok, please add at least 2 or 3. Here it is. Two pieces of code

Re: [Patch] Regex back-reference support

2013-08-10 Thread Paolo Carlini
On 08/10/2013 06:04 PM, Paolo Carlini wrote: Also, in the new comment, you refer to a "stack", but in the same patch you removed a std::stack and added a std::vector as data member, something seems inconsistent. I had having a closer look to this: if one looks at the code now, without knowing t

Re: RFC - Refactor tree.h

2013-08-10 Thread Mike Stump
On Aug 10, 2013, at 3:03 AM, Richard Biener wrote: > Mike Stump wrote: >> On Aug 9, 2013, at 3:36 PM, Diego Novillo wrote: >>> This patch is still WIP. It builds stage1, but I'm getting ICEs >>> during stage 2. >>> >>> The patch splits tree.h into three files: >>> >>> - tree-core.h: All data

[PATCH] Add -fno-instrument-function v2

2013-08-10 Thread Andi Kleen
From: Andi Kleen [I posted this originally quite some time ago. This version fixes all review problems, particularly it works for C++ too and the test case really works.] This adds a new C/C++ option to force __attribute__((no_instrument_function)) on every function compiled. This is useful tog

Re: [PATCH 2/2] Fix HLE example in manual

2013-08-10 Thread Andi Kleen
On Thu, Jun 20, 2013 at 11:05:15AM -0700, Richard Henderson wrote: > On 06/20/2013 06:20 AM, Andi Kleen wrote: > > gcc/: > > 2013-06-13 Andi Kleen > > > > * doc/extend.texi: Dont use __atomic_clear in HLE > > example. Fix typo. > > Ok. I would like to to backport this to 4.8. Ok too?

Re: [PATCH] Handle target specific memory models in C frontend

2013-08-10 Thread Andi Kleen
On Fri, Nov 09, 2012 at 07:08:07AM -0800, Richard Henderson wrote: > On 2012-11-09 07:03, Andi Kleen wrote: > > PR55139 > > * c-common.c (get_atomic_generic_size): Mask with > > MEMMODEL_MASK > > Ok. I would like to backport this patch to 4.8. Ok? -Andi -- a...@linux.intel.com

[PATCH] Update MAINTAINERS file

2013-08-10 Thread Caroline Tice
I would like to make the following changes to the MAINTAINERS file. May I commit this? -- Caroline Tice cmt...@google.com 2013-08-10 Caroline Tice * MAINTAINERS: Add myself as libvtv maintainer. Correct my email address in the Write After Approval section. maintainers.patch Description: Bi

Re: Speculative call support in the callgraph

2013-08-10 Thread Jan Hubicka
> > Hi, > > also I just became aware that this patch hits the following bug of gold > > http://sourceware.org/bugzilla/show_bug.cgi?id=14342 > > It makes gcc.dg/tree-prof/crossmodule-indircall-1.c fail with the bogus > > diagnostic on TLS and non-TLS use of the same symbol. I attached the > > deta

Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv

2013-08-10 Thread Caroline Tice
OK, I have removed the attempt to use $HOME for the logs; they will now either go into the directory specified by the environment variable VTV_LOGS_DIR, or they will go into the current directory. I also added code to use secure_getenv, rather than getenv, if it is available. Is this patch ok to

Re: [Patch] Regex back-reference support

2013-08-10 Thread Tim Shen
On Sun, Aug 11, 2013 at 2:12 AM, Paolo Carlini wrote: > On 08/10/2013 06:04 PM, Paolo Carlini wrote: >> >> Also, in the new comment, you refer to a "stack", but in the same patch >> you removed a std::stack and added a std::vector as data member, something >> seems inconsistent. > > I had having a

[PATCH] x86-64 gcc generate wrong assembly instruction movabs for intel syntax

2013-08-10 Thread Perez Read
When compiles below testcase with gcc -masm=intel -O2 --cut here-- int test(){ long *ptr = (long*)0x8000; *ptr = -1; return 0; } --cut here-- movabs is incorrectly translated into "mov [rax], -1", and causes compile error "Error: ambiguous operand size for `mov' ". It sh