Hi,
On 08/10/2013 12:50 PM, Tim Shen wrote:
On Sat, Aug 10, 2013 at 5:41 PM, Paolo Carlini <paolo.carl...@oracle.com> wrote:
More important: we are adding support for a non trivial feature and not a
single comment in the new code refers to it. This is not ok, please add at
least 2 or 3.
Here it is. Two pieces of code concerning implementation logic is
commented. Add another testcase.
I'll test it again before final commit.
Thanks. Please also move out of line, to the *.tcc, _M_insert_backref,
it's too big to be inline.
Also, in the new comment, you refer to a "stack", but in the same patch
you removed a std::stack and added a std::vector as data member,
something seems inconsistent.
Thanks,
Paolo.
