Re: [i386] scalar ops that preserve the high part of a vector

2012-12-03 Thread Uros Bizjak
On Sun, Dec 2, 2012 at 1:30 PM, Marc Glisse wrote: >>> here is a patch. If it is accepted, I'll extend it to other vm patterns >>> (mul, div, min, max are likely candidates, but I need to check the doc). >>> It >>> passed bootstrap+testsuite on x86_64-linux. >>> >>> >>> 2012-12-01 Marc Glisse

Re: [Patch, Fortran] PR55475 - fix invalid reads with show_locus

2012-12-03 Thread Tobias Burnus
I have now committed that patch as obvious, Rev. 194076. http://gcc.gnu.org/ml/fortran/2012-11/msg00084.html Tobias Tobias Burnus wrote: As found with -fsanitize=address by HJ, but it also shows up with valgrind. The fix for the PR is the change in scanner.c; I think the patch is rather obvio

[PATCH] Fix PR52872

2012-12-03 Thread Rainer Emrich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This fixes the tests for "exported symbols" and "-rdynamic" on systems with exe extensions. Kai, feel free to commit, if ok. Cheers Rainer Patch against trunk: Index: gcc/configure.ac ===

Re: [PATCH] asan_test.cc from llvm

2012-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2012 at 11:06:48AM +0400, Konstantin Serebryany wrote: > This patch copies the asan tests almost, but not quite, verbatim from > upstream. > Since the patch is not in attachment (and gmail messes up with inlined > patches) I can't see the exact changes. Sending patches inline rath

Re: [PATCH] asan_test.cc from llvm

2012-12-03 Thread Konstantin Serebryany
On Mon, Dec 3, 2012 at 1:18 PM, Jakub Jelinek wrote: > On Mon, Dec 03, 2012 at 11:06:48AM +0400, Konstantin Serebryany wrote: >> This patch copies the asan tests almost, but not quite, verbatim from >> upstream. >> Since the patch is not in attachment (and gmail messes up with inlined >> patches)

[patch] Small tweak to -Wuninitialized

2012-12-03 Thread Eric Botcazou
Hi, if you compile the attached testcase on x86 with -O2 -Wuninitialized, you get: strip.adb: In function 'Strip': strip.adb:4:4: warning: 'Last' may be used uninitialized in this function [- Wuninitialized] strip.adb:26:44: warning: 'First' may be used uninitialized in this function [-Wmaybe-un

Re: [PATCH] Fix PR35634

2012-12-03 Thread Richard Biener
On Sat, 1 Dec 2012, David Edelsohn wrote: > Richard, > > The testcases assume default signed char and fail on systems with > different semantics. I believe that both testcases need to declare c > as signed char to consistently test the desired behavior, right? Fixed as follows. Richard. 2012-

Re: [PATCH] asan unit tests from llvm lit-test

2012-12-03 Thread Jakub Jelinek
Hi! Mike, CCing you especially on the proposed lib/gcc-dg.exp dg-env-var changes and I have one question about cleanup of files (file delete vs. remote_file target (or is that host or build) delete). But of course if you could eyeball the rest and comment, I'd be even happier. On Fri, Nov 30, 201

Re: [patch] Rework RTL CFG graph dumping to dump DOT format

2012-12-03 Thread Richard Biener
On Sat, Dec 1, 2012 at 6:40 PM, Steven Bosscher wrote: > On Sat, Dec 1, 2012 at 2:23 PM, Steven Bosscher wrote: >> On Mon, Nov 26, 2012 at 4:46 PM, Richard Biener wrote: >>> Btw, I of course have my own CFG dumper (producing graphviz input) >>> in my local tree - attached for reference (I'm simply

Re: [PATCH] asan_test.cc from llvm

2012-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2012 at 01:51:50PM +0400, Konstantin Serebryany wrote: > > I'm attaching the diff for asan_test.cc from llvm anyway. > > > >> I see #ifdef ASAN_AVOID_EXPENSIVE_TESTS, which I don't really like > >> because I'd rather fix the test than disable it. > > > > The test isn't disabled, jus

Re: [patch] Small tweak to -Wuninitialized

2012-12-03 Thread Richard Biener
On Mon, Dec 3, 2012 at 10:51 AM, Eric Botcazou wrote: > Hi, > > if you compile the attached testcase on x86 with -O2 -Wuninitialized, you get: > > strip.adb: In function 'Strip': > strip.adb:4:4: warning: 'Last' may be used uninitialized in this function [- > Wuninitialized] > strip.adb:26:44: war

Re: [PATCH] asan_test.cc from llvm

2012-12-03 Thread Konstantin Serebryany
On Mon, Dec 3, 2012 at 3:05 PM, Jakub Jelinek wrote: > On Mon, Dec 03, 2012 at 01:51:50PM +0400, Konstantin Serebryany wrote: >> > I'm attaching the diff for asan_test.cc from llvm anyway. >> > >> >> I see #ifdef ASAN_AVOID_EXPENSIVE_TESTS, which I don't really like >> >> because I'd rather fix th

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-12-03 Thread Jakub Jelinek
Hi! On Thu, Nov 29, 2012 at 12:20:39PM -0800, H.J. Lu wrote: > On Thu, Nov 29, 2012 at 11:06 AM, Jakub Jelinek wrote: > > On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote: > >> On 11/29/2012 06:36 PM, Tobias Burnus wrote: > >> >H.J. Lu wrote: > >> >>This patch adds --with-build-confi

Re: Reduce complette unrolling & peeling limits

2012-12-03 Thread Eric Botcazou
> here is updated patch. It should get the bounds safe enough to not have > effect on codegen of complette unrolling. > > There is IMO no way to cut the walk of loop body w/o affecting codegen in > unrolling for size mode. The condition on unroling to happen is > > unrolled_size * 2 / 3 < orig

Re: [IA-64] Fix dynamic allocation in leaf functions

2012-12-03 Thread Eric Botcazou
> 2012-11-19 Eric Botcazou > > * config/ia64/ia64.c (ia64_compute_frame_size): Allocate the scratch > area if the function allocates dynamic stack space. > (ia64_initial_elimination_offset): Adjust offsets to above change. Ping: http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01

[PATCH] Fix PR55570

2012-12-03 Thread Marek Polacek
We segfaulted on attached testcase, because we were accessing ->typed.type field via TREE_TYPE, but IDENTIFIER_NODEs don't contain ->typed element at all. Fixed by switching the expressions in a condition, so we always first check that we're operating on INTEGER_CST. Regtested/bootstrapped on x86

Re: [PATCH] Fix PR55570

2012-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2012 at 01:36:28PM +0100, Marek Polacek wrote: > We segfaulted on attached testcase, because we were accessing > ->typed.type field via TREE_TYPE, but IDENTIFIER_NODEs don't contain > ->typed element at all. Fixed by switching the expressions in > a condition, so we always first c

Re: [PATCH] PR c++/53609 - Wrong argument deduction for pack expansion in argument pack

2012-12-03 Thread Dodji Seketeli
Jason Merrill writes: > It seems like your new code is a generalization of the old code for > handling substitution of a pack for itself (arg_from_parm_pack and > such) and the code for handling other packs with a single pack > expansion argument, and should replace those rather than adding on.

Re: [cxx-conversion] graphite-related hash tables

2012-12-03 Thread Diego Novillo
On Sun, Dec 2, 2012 at 4:58 AM, Tobias Grosser wrote: > Assuming the test suite passes and this is just a no-behavior change > intended commit, I am fine with this. No idea, who needs to sign off > branch commits, though. The branch is under the usual maintainer rules (it's a regular development

Re: [asan] Another ICE fix

2012-12-03 Thread Dodji Seketeli
Jakub Jelinek writes: > Fixed thusly, ok for trunk? > > 2012-11-27 Jakub Jelinek > > * asan.c (instrument_assignment): Instrument lhs only > for gimple_store_p and rhs1 only for gimple_assign_load_p. This is OK, thanks. And sorry for the delay. -- Dodji

Re: [C++ Patch] PR 54170

2012-12-03 Thread Jason Merrill
OK, thanks. Jason

RE: [PATCH] [AArch64] Add vcond, vcondu support.

2012-12-03 Thread James Greenhalgh
> -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Marcus Shawcroft > Sent: 15 October 2012 12:37 > To: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] [AArch64] Add vcond, vcondu support. > > On 09/10/12 12:08, James Greenhalgh

Re: [asan] Fix some asan ICEs

2012-12-03 Thread Dodji Seketeli
> Ok for trunk? > > 2012-11-27 Jakub Jelinek > > * asan.c (instrument_mem_region_access): Don't instrument > if base doesn't have pointer type or len integral type. > Add cast if len doesn't have size_t compatible type. > (instrument_builtin_call): Don't instrument BUILT

[contrib] Fix buglet in validate_failures.py

2012-12-03 Thread Diego Novillo
An earlier patch had made the command line options a global variable _OPTIONS, but it had not renamed all the uses of the old options argument. * testsuite-management/validate_failures.py: Fix stale use of 'options'. Doug, if you're using validate_failures.py in some other branch,

[committed] Fix up reassoc_4.f testcase (PR testsuite/55452)

2012-12-03 Thread Jakub Jelinek
Hi! Honza changed recently max-completely-peeled-insns param default from 400 to 100, which broke the testcase assumptions. Fixed by forcing the old default, everywhere, committed to trunk as obvious. 2012-12-03 Jakub Jelinek PR testsuite/55452 * gfortran.dg/reassoc_4.f: Use

Re: [i386] scalar ops that preserve the high part of a vector

2012-12-03 Thread Marc Glisse
On Mon, 3 Dec 2012, Uros Bizjak wrote: On Sun, Dec 2, 2012 at 1:30 PM, Marc Glisse wrote: here is a patch. If it is accepted, I'll extend it to other vm patterns (mul, div, min, max are likely candidates, but I need to check the doc). It passed bootstrap+testsuite on x86_64-linux. 2012-12-0

Re: [PATCH] Allocate extra 16 bytes for -fsanitize=address

2012-12-03 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> 2012-11-23 Jakub Jelinek Jakub> PR bootstrap/55380 Jakub> * files.c (read_file_guts): Allocate extra 16 bytes instead of Jakub> 1 byte at the end of buf. Pass size + 16 instead of size Jakub> to _cpp_convert_input. Jakub> * charset.c (_cpp_co

[Patch, Fortran] Auxiliary functions/fixes for FINAL

2012-12-03 Thread Tobias Burnus
Dear all, this patch adds some auxiliary functions for FINAL - and it fixes some issues which mainly occur with FINAL. Build and regtested on x86-64-gnu-linux. OK for the trunk? Tobias 2012-12-03 Tobias Burnus Janus Weil PR fortran/37336 * class.c (gfc_is_finalizable): New functi

Re: [PATCH] libgcc refactor aarch64 sfp-machine.h

2012-12-03 Thread Marcus Shawcroft
PING /Marcus On 15 Nov 2012, at 15:58, Marcus Shawcroft wrote: > This patch reorganizes the AArch64 sfp-machine.h file, splitting out > FP_HANDLE_EXCEPTIONS into a new file sfp-exceptions.c following the same > idiom used in ia64 and i386. > > OK ? > > Cheers > /Marcus > > 2012-11-15 Mar

Re: [PATCH 2/2] Update soft-fp from GLIBC

2012-12-03 Thread Marcus Shawcroft
PING On 14 Nov 2012, at 15:31, Marcus Shawcroft wrote: > This patch provides a definition of FP_TRAPPING_EXCEPTION for aarch64. > > /Marcus > > 2012-11-14 Marcus Shawcroft > > * config/aarch64/sfp-machine.h (FP_EX_ALL): Define. > (FP_EX_SHIFT): Define. > (FP_TRAPPING_E

[PATCh][Revisedx2] Fix PR55521 by switching libsanitizer from mach_overrideto mac interpose functions on darwin

2012-12-03 Thread Jack Howarth
The attached patch eliminates PR 55521/sanitizer by switching libasan on darwin from using mach_override to mac function interposition via the importation of the asan/dynamic/asan_interceptors_dynamic.cc file from llvm.org's compiler-rt svn. The changes involve defining USING_MAC_INTERPOSE in

Re: [PATCH] libgcc refactor aarch64 sfp-machine.h

2012-12-03 Thread Richard Earnshaw
On 03/12/12 16:00, Marcus Shawcroft wrote: PING I would have thought that both this and the other patch (the update from GLibC) comes under the remit of the port maintainer, rather than the libgcc maintainer. So I would work on the assumption that if Ian doesn't say anything in the next

[libquadmath, patch, committed] Fix exponent reading

2012-12-03 Thread Tobias Burnus
Somehow that got lot when updating the file. I think, we really need a proper test suite - the current quad_{1,2,3}.f90 are a first step, but rather incomplete. Committed as Rev. 194100 after build+regtesting. Tobias Index: libquadmath/ChangeLog

Re: [Patch AArch64] Add support for vectorizable standard math patterns.

2012-12-03 Thread Marcus Shawcroft
On 27/11/12 20:47, Mike Stump wrote: On Nov 27, 2012, at 8:51 AM, James Greenhalgh wrote: In particular, we add support for vectorizing across: ceil (), ceilf (), lceil (), We add testcases ensuring that each of the expected functions are vectorized. As the i386 and rs6000 backends both ost

[patch] Hookize CFG DOT graph dumping

2012-12-03 Thread Steven Bosscher
Hello, This is the last patch in this series for now, unless I can convince everyone that some files should be renamed after all these changes :-) The attached patch makes graph.c independent of the IR contained in the CFG it dumps. For this, I made the node label dumping routine a cfghook. I als

Re: [PATCH] Convert asan to use sanitizer.def builtins, initialize them if the FE didn't

2012-12-03 Thread Dodji Seketeli
Jakub Jelinek writes: > Ok for trunk (the patch is on top of the tsan patch)? > > 2012-11-22 Jakub Jelinek > > * sanitizer.def: Add Address Sanitizer builtins. > Rename BUILT_IN_TSAN_READ_* to BUILT_IN_TSAN_READ* and > BUILT_IN_TSAN_WRITE_* to BUILT_IN_TSAN_WRITE*. > *

[PATCH, libatomic] detect and build for ARM architecture armv8-a

2012-12-03 Thread Marcus Shawcroft
libatomic does not build for --arch=armv8-a because there is no architecture version detection. This patch allows libatomic to build for armv8-a, but does not exploit any of the new features of v8. /Marcus 2012-12-03 Marcus Shawcroft * config/arm/arm-config.h (__ARM_ARCH_8A__): New.

[PATCH] AArch64 fix ICE due to missing TYPE_STUB_DECL on va_list.

2012-12-03 Thread Marcus Shawcroft
This patch fixes an ICE due to a missing TYPE_STUB_DECL on the builtin va_list tree node. /Marcus gcc/ 2012-11-27 Marcus Shawcroft * config/aarch64/aarch64.c (aarch64_build_builtin_va_list): Set TYPE_STUB_DECL. testsuite/ 2012-11-27 Marcus Shawcroft * gcc.target

Re: [PATCH, PR 54394] Compute loops when generating inline summaries

2012-12-03 Thread H.J. Lu
On Fri, Aug 31, 2012 at 7:41 AM, Martin Jambor wrote: > Hi, > > On Fri, Aug 31, 2012 at 12:06:33PM +0200, Jan Hubicka wrote: >> > >> > This is not required to make hints working, it is necessary because of >> > the following line a in estimate_function_body_sizes: >> > >> > es->loop_dept

Re: [i386] scalar ops that preserve the high part of a vector

2012-12-03 Thread Uros Bizjak
On Mon, Dec 3, 2012 at 4:34 PM, Marc Glisse wrote: >> However, looking a bit more into the usage cases for these patterns, >> they are only used through intrinsics with _m128 operands. While your >> proposed patch makes these patterns more general (they can use 64bit >> aligned memory), this is n

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-12-03 Thread H.J. Lu
On Mon, Dec 3, 2012 at 3:52 AM, Jakub Jelinek wrote: > Hi! > > On Thu, Nov 29, 2012 at 12:20:39PM -0800, H.J. Lu wrote: >> On Thu, Nov 29, 2012 at 11:06 AM, Jakub Jelinek wrote: >> > On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote: >> >> On 11/29/2012 06:36 PM, Tobias Burnus wrote:

Re: Sparc ASAN

2012-12-03 Thread David Miller
From: Konstantin Serebryany Date: Tue, 27 Nov 2012 18:12:00 +0400 > On Wed, Nov 21, 2012 at 9:05 PM, Konstantin Serebryany > wrote: >> On Wed, Nov 21, 2012 at 8:40 PM, David Miller wrote: >>> From: Konstantin Serebryany >>> Date: Wed, 21 Nov 2012 19:39:52 +0400 >>> There are various other

Re: [PATCH, PR 54394] Compute loops when generating inline summaries

2012-12-03 Thread H.J. Lu
On Mon, Dec 3, 2012 at 9:50 AM, H.J. Lu wrote: > On Fri, Aug 31, 2012 at 7:41 AM, Martin Jambor wrote: >> Hi, >> >> On Fri, Aug 31, 2012 at 12:06:33PM +0200, Jan Hubicka wrote: >>> > >>> > This is not required to make hints working, it is necessary because of >>> > the following line a in estimat

Re: Sparc ASAN

2012-12-03 Thread Konstantin Serebryany
On Mon, Dec 3, 2012 at 10:02 PM, David Miller wrote: > From: Konstantin Serebryany > Date: Tue, 27 Nov 2012 18:12:00 +0400 > >> On Wed, Nov 21, 2012 at 9:05 PM, Konstantin Serebryany >> wrote: >>> On Wed, Nov 21, 2012 at 8:40 PM, David Miller wrote: From: Konstantin Serebryany Date:

Re: Fix twolf -funroll-loops -O3 miscompilation (a semi-latent web.c bug)

2012-12-03 Thread Eric Botcazou
> >> 2. gcse.c: gcse_emit_move_after added notes, but none of them was very > >> useful as far as I could tell, and almost all of them turned > >> self-referencing after CPROP. So I propose we just never add notes in > >> this case. > > > > gcse_emit_move_after also preserves existing notes. Are

Re: Sparc ASAN

2012-12-03 Thread David Miller
From: Konstantin Serebryany Date: Mon, 3 Dec 2012 22:18:56 +0400 > On Mon, Dec 3, 2012 at 10:02 PM, David Miller wrote: >> The only changes to libsantizier is to put __sparc__ checks where >> __powerpc__ checks exist in the unwind code. > > Like this? > > ==

Re: Sparc ASAN

2012-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2012 at 10:18:56PM +0400, Konstantin Serebryany wrote: > The LLVM implementation always used 32-byte alignment for stack redzones. > I never actually did any performance checking on x86 (32-byte aligned > vs 8-byte aligned), > although I suspect 32-byte aligned redzones should be ~2

Re: [PATCH] asan unit tests from llvm lit-test

2012-12-03 Thread Wei Mi
Hi, Jakub, thank you for your so detailed comments! I will fix them according to your comments. About the lto options, llvm test does't include it too so I skipped it in torture options. Is it because most cases we only use asan under O1/O2? Kostya, could you tell us is there any reason to not tes

Re: Sparc ASAN

2012-12-03 Thread Konstantin Serebryany
On Mon, Dec 3, 2012 at 10:29 PM, David Miller wrote: > From: Konstantin Serebryany > Date: Mon, 3 Dec 2012 22:18:56 +0400 > >> On Mon, Dec 3, 2012 at 10:02 PM, David Miller wrote: >>> The only changes to libsantizier is to put __sparc__ checks where >>> __powerpc__ checks exist in the unwind cod

Re: Sparc ASAN

2012-12-03 Thread Konstantin Serebryany
On Mon, Dec 3, 2012 at 10:31 PM, Jakub Jelinek wrote: > On Mon, Dec 03, 2012 at 10:18:56PM +0400, Konstantin Serebryany wrote: >> The LLVM implementation always used 32-byte alignment for stack redzones. >> I never actually did any performance checking on x86 (32-byte aligned >> vs 8-byte aligned)

Re: Sparc ASAN

2012-12-03 Thread David Miller
From: Konstantin Serebryany Date: Mon, 3 Dec 2012 22:33:12 +0400 > On Mon, Dec 3, 2012 at 10:29 PM, David Miller wrote: >> We could also add a __sparc__ block to sanitizer_stacktrace.cc:patch_pc(). >> The Sparc PC is actually 8 bytes after the caller's jump. Sparc has >> a delay slot, the place

Re: Sparc ASAN

2012-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2012 at 10:18:56PM +0400, Konstantin Serebryany wrote: > The LLVM implementation always used 32-byte alignment for stack redzones. > I never actually did any performance checking on x86 (32-byte aligned > vs 8-byte aligned), > although I suspect 32-byte aligned redzones should be ~2

Re: Sparc ASAN

2012-12-03 Thread Konstantin Serebryany
On Mon, Dec 3, 2012 at 10:37 PM, David Miller wrote: > From: Konstantin Serebryany > Date: Mon, 3 Dec 2012 22:33:12 +0400 > >> On Mon, Dec 3, 2012 at 10:29 PM, David Miller wrote: >>> We could also add a __sparc__ block to sanitizer_stacktrace.cc:patch_pc(). >>> The Sparc PC is actually 8 bytes

Re: Sparc ASAN

2012-12-03 Thread David Miller
From: Konstantin Serebryany Date: Mon, 3 Dec 2012 22:44:15 +0400 > On Mon, Dec 3, 2012 at 10:37 PM, David Miller wrote: >> From: Konstantin Serebryany >> Date: Mon, 3 Dec 2012 22:33:12 +0400 >> >>> On Mon, Dec 3, 2012 at 10:29 PM, David Miller wrote: We could also add a __sparc__ block to

Re: [PATCH] asan unit tests from llvm lit-test

2012-12-03 Thread Konstantin Serebryany
On Mon, Dec 3, 2012 at 10:32 PM, Wei Mi wrote: > Hi, > > Jakub, thank you for your so detailed comments! I will fix them > according to your comments. About the lto options, llvm test does't > include it too so I skipped it in torture options. Is it because most > cases we only use asan under O1/O

Re: [PATCH] asan unit tests from llvm lit-test

2012-12-03 Thread Mike Stump
On Dec 3, 2012, at 3:00 AM, Jakub Jelinek wrote: > Mike, CCing you especially on the proposed lib/gcc-dg.exp dg-env-var > changes and I have one question about cleanup of files (file delete > vs. remote_file target (or is that host or build) delete). > But of course if you could eyeball the rest a

Re: [cxx-conversion] various hash tables, part 1/2

2012-12-03 Thread Diego Novillo
On Sat, Dec 1, 2012 at 8:47 PM, Lawrence Crowl wrote: > +inline bool > +attribute_hasher::equal (const value_type *spec, const compare_type *str) > +{ > + return (!strncmp (spec->name, str->str, str->length) I have a slight preference for strncmp() == 0. It's easier to read (I realize that you

Re: [PATCh][Revisedx2] Fix PR55521 by switching libsanitizer from mach_overrideto mac interpose functions on darwin

2012-12-03 Thread Mike Stump
On Dec 3, 2012, at 8:02 AM, Jack Howarth wrote: > The attached patch eliminates PR 55521/sanitizer by switching libasan on > darwin > from using mach_override to mac function interposition So, I'm thinking the sanitizer people will just review and approve it, even though it says darwin and is

Re: [Patch AArch64] Add support for vectorizable standard math patterns.

2012-12-03 Thread Mike Stump
On Dec 3, 2012, at 8:43 AM, Marcus Shawcroft wrote: > Mike, Are you happy to go with the proposal from James or would like to give > folk more time to think this one over? Good to go. If people want to improve it, if they see a way, then can submit a patch anytime they want. I didn't see anyo

Re: [cxx-conversion] various hash tables, part 1/2

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo wrote: > On Sat, Dec 1, 2012 at 8:47 PM, Lawrence Crowl wrote: > >> +inline bool >> +attribute_hasher::equal (const value_type *spec, const compare_type >> *str) >> +{ >> + return (!strncmp (spec->name, str->str, str->length) > > I have a slight preference for strncmp()

Re: [cxx-conversion] various hash tables, part 1/2

2012-12-03 Thread Diego Novillo
On 2012-12-03 14:24 , Lawrence Crowl wrote: } -static int -htab_cu_eq (const void *of1, const void *of2) +inline bool +cu_hash_table_entry_hasher::equal (const value_type *entry1, + const compare_type *entry2) No static? The in-class declaration has the

Re: [PATCH] asan unit tests from llvm lit-test

2012-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2012 at 11:09:07AM -0800, Mike Stump wrote: > On Dec 3, 2012, at 3:00 AM, Jakub Jelinek wrote: > > Mike, CCing you especially on the proposed lib/gcc-dg.exp dg-env-var > > changes and I have one question about cleanup of files (file delete > > vs. remote_file target (or is that hos

Re: [PATCH] asan unit tests from llvm lit-test

2012-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2012 at 10:32:52AM -0800, Wei Mi wrote: > Jakub, thank you for your so detailed comments! I will fix them > according to your comments. About the lto options, llvm test does't > include it too so I skipped it in torture options. Is it because most > cases we only use asan under O1/O

Re: [cxx-conversion] various hash tables, part 2/2

2012-12-03 Thread Diego Novillo
On 2012-12-01 20:48 , Lawrence Crowl wrote: +inline bool +cselib_hasher::equal (const value_type *v, const compare_type *x_arg) +{ + struct elt_loc_list *l; + rtx x = CONST_CAST_RTX (x_arg); + enum machine_mode mode = GET_MODE (x); + + gcc_assert (!CONST_SCALAR_INT_P (x) && GET_CODE (x) != C

Re: [PATCH] asan unit tests from llvm lit-test

2012-12-03 Thread Mike Stump
On Dec 3, 2012, at 11:36 AM, Jakub Jelinek wrote: > The env vars are used by the target libs when running the test executable. > So, are you suggesting we name it dg-set-target-env-var instead of > dg-set-env-var, so that in the future we can also have > dg-set-{host,build}-env-var? Yes. The set

Re: [cxx-conversion] various hash tables, part 1/2

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo wrote: > On 2012-12-03 14:24 , Lawrence Crowl wrote: -static int -htab_cu_eq (const void *of1, const void *of2) +inline bool +cu_hash_table_entry_hasher::equal (const value_type *entry1, + const compare_type *entry

Re: [cxx-conversion] ggc-common hash tables

2012-12-03 Thread Diego Novillo
On 2012-12-01 20:46 , Lawrence Crowl wrote: Index: gcc/ChangeLog 2012-11-30 Lawrence Crowl * hash-table.h (class hash_table): Correct many methods with parameter types compare_type to the correct value_type. (Correct code was unlikely to notice the change.)

Re: [cxx-conversion] various hash tables, part 2/2

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo wrote: > On 2012-12-01 20:48 , Lawrence Crowl wrote: >> +inline bool >> +cselib_hasher::equal (const value_type *v, const compare_type *x_arg) >> +{ >> + struct elt_loc_list *l; >> + rtx x = CONST_CAST_RTX (x_arg); >> + enum machine_mode mode = GET_MODE (x); >> + >> +

Re: [cxx-conversion] various hash tables, part 1/2

2012-12-03 Thread Diego Novillo
On Mon, Dec 3, 2012 at 2:50 PM, Lawrence Crowl wrote: > On 12/3/12, Diego Novillo wrote: >> On 2012-12-03 14:24 , Lawrence Crowl wrote: > -static int > -htab_cu_eq (const void *of1, const void *of2) > +inline bool > +cu_hash_table_entry_hasher::equal (const value_type *entry1, >>>

Re: [cxx-conversion] tree-related hash tables

2012-12-03 Thread Diego Novillo
On 2012-12-01 20:45 , Lawrence Crowl wrote: Index: gcc/tree-hasher.h === --- gcc/tree-hasher.h (revision 0) +++ gcc/tree-hasher.h (revision 0) @@ -0,0 +1,56 @@ +/* Data and Control Flow Analysis for Trees. This is the wrong de

Re: [cxx-conversion] ggc-common hash tables

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo wrote: > On 2012-12-01 20:46 , Lawrence Crowl wrote: >> Index: gcc/ChangeLog >> >> 2012-11-30 Lawrence Crowl >> >> * hash-table.h (class hash_table): >> Correct many methods with parameter types compare_type to the correct >> value_type. (Correct code w

Re: [cxx-conversion] gimplify_ctx::temp_htab hash table

2012-12-03 Thread Diego Novillo
On 2012-12-01 20:44 , Lawrence Crowl wrote: Index: gcc/gimple-fold.c === --- gcc/gimple-fold.c (revision 193902) +++ gcc/gimple-fold.c (working copy) @@ -30,6 +30,7 @@ along with GCC; see the file COPYING3. #include "tree-ssa-

Re: [cxx-conversion] tree-related hash tables

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo wrote: > On 2012-12-01 20:45 , Lawrence Crowl wrote: >> Index: gcc/tree-hasher.h >> === >> --- gcc/tree-hasher.h(revision 0) >> +++ gcc/tree-hasher.h(revision 0) >> @@ -0,0 +1,56 @@ >> +/* Dat

Re: PATCH: pass sysroot to cc1plus

2012-12-03 Thread Etienne Le Sueur
First ping... anyone? On 28/11/12 1:21 PM, Etienne Le Sueur wrote: Hi, With a sysroot of /dev/null, passing a .i file to cc1plus causes it to attempt to open /dev/null/usr/include, which fails. This causes problems for ccache and distcc. There is an open bugzilla ticket at [1]. The patch bel

Re: [cxx-conversion] LTO-related hash tables

2012-12-03 Thread Diego Novillo
On 2012-12-01 20:40 , Lawrence Crowl wrote: Change LTO-related hash tables from htab_t to hash_table: lto-streamer.h output_block::string_hash_table lto-streamer-in.c file_name_hash_table lto-streamer.c tree_htab The struct string_slot moves from data-streamer.h to lto-streamer.h to resolve com

PATCH: pass sysroot to cc1plus

2012-12-03 Thread Etienne Le Sueur
Hi, With a sysroot of /dev/null, passing a .i file to cc1plus causes it to attempt to open /dev/null/usr/include, which fails. This causes problems for ccache and distcc. There is an open bugzilla ticket at [1]. The patch below applies on to 4.6.3, but it appears the bug is still present in 4

Re: [cxx-conversion] gimplify_ctx::temp_htab hash table

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo wrote: > On 2012-12-01 20:44 , Lawrence Crowl wrote: >> Index: gcc/gimple-fold.c >> === >> --- gcc/gimple-fold.c(revision 193902) >> +++ gcc/gimple-fold.c(working copy) >> @@ -30,6 +30,7 @@ al

Re: Fix twolf -funroll-loops -O3 miscompilation (a semi-latent web.c bug)

2012-12-03 Thread Paolo Bonzini
Il 01/12/2012 15:54, Eric Botcazou ha scritto: >> Attached is a different fix. It splits DF_REF_IN_NOTE in two: One flag >> > for each kind of note. This allows the dead note removal code to >> > distinguish the source note for the EQ_USES. I needed to remove one >> > flag to keep the df_ref_flags

Re: Fix twolf -funroll-loops -O3 miscompilation (a semi-latent web.c bug)

2012-12-03 Thread Steven Bosscher
On Mon, Dec 3, 2012 at 7:23 PM, Eric Botcazou wrote: >> >> 2. gcse.c: gcse_emit_move_after added notes, but none of them was very >> >> useful as far as I could tell, and almost all of them turned >> >> self-referencing after CPROP. So I propose we just never add notes in >> >> this case. >> > >> >

Re: [Patch, Fortran] Auxiliary functions/fixes for FINAL

2012-12-03 Thread Paul Richard Thomas
OK for trunk. I think that Janus approved the other patch that we talked about last night, did he not? Spent evening fixing unlimited polymorphic bugs - all of them associated with character targets! Cheers Paul On 3 December 2012 16:54, Tobias Burnus wrote: > Dear all, > > this patch adds so

Re: [cxx-conversion] LTO-related hash tables

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo wrote: > On 2012-12-01 20:40 , Lawrence Crowl wrote: > > Change LTO-related hash tables from htab_t to hash_table: > > > > lto-streamer.h output_block::string_hash_table > > lto-streamer-in.c file_name_hash_table > > lto-streamer.c tree_htab > > > > The struct string_slot

Re: Fix twolf -funroll-loops -O3 miscompilation (a semi-latent web.c bug)

2012-12-03 Thread Eric Botcazou
> You mean the patch at > http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02275.html right? > > I haven't tried that other patch. I'll test that one. Yes, thanks. > I suppose so. But this was all added before RTL fwprop and way before > GIMPLE optimizations. Avoiding the self-referential case is ju

Re: [Patch, Fortran] PR 55548: SYSTEM_CLOCK with integer(8) provides nanosecond resolution, but only microsecond precision (without -lrt)

2012-12-03 Thread Janus Weil
>> Unless somebody else has objections, together with a documentation >> patch and a ChangeLog entry, this is Ok for trunk. > > thanks, Janne. Here is an updated patch with docu and ChangeLog. I > will wait another day before committing, in order to allow for further > comments. Committed as r1941

Re: [Google 4.7] Backport upstream fission changes (issue6852101)

2012-12-03 Thread Cary Coutant
> 2012-11-27 Sterling Augustine > > Backport changes to fission implementation required by > trunk. See > http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02684.html and > susbsequent messages for a full description of what needed to > change for it to be acc

Re: Sparc ASAN

2012-12-03 Thread Richard Henderson
On 2012-11-21 11:28, Peter Bergner wrote: > + if (Unwind_GetBP(ctx) == p->bp) { I've mentioned multiple times that BP is unusable on most RISC. You need to be looking at SP. r~

Re: [PATCH, libatomic] detect and build for ARM architecture armv8-a

2012-12-03 Thread Richard Henderson
On 2012-12-03 10:59, Marcus Shawcroft wrote: > 2012-12-03 Marcus Shawcroft > > * config/arm/arm-config.h (__ARM_ARCH_8A__): New. Ok. r~

Re: Fix twolf -funroll-loops -O3 miscompilation (a semi-latent web.c bug)

2012-12-03 Thread Steven Bosscher
On Mon, Dec 3, 2012 at 9:19 PM, Steven Bosscher wrote: >> So the compiler doesn't bootstrap with the gcse.c patch you posted earlier in >> the thread? Still this seems too bold to me, the note datum could be a >> constant and should be preserved in this case. > > You mean the patch at > http://gcc

Re: [IA-64] Fix dynamic allocation in leaf functions

2012-12-03 Thread Richard Henderson
On 2012-11-19 16:12, Eric Botcazou wrote: > 2012-11-19 Eric Botcazou > > * config/ia64/ia64.c (ia64_compute_frame_size): Allocate the scratch > area if the function allocates dynamic stack space. > (ia64_initial_elimination_offset): Adjust offsets to above change. Ok for any

Re: [PATCH] libgcc refactor aarch64 sfp-machine.h

2012-12-03 Thread Ian Lance Taylor
Richard Earnshaw writes: > On 03/12/12 16:00, Marcus Shawcroft wrote: >> >> PING >> > > I would have thought that both this and the other patch (the update > from GLibC) comes under the remit of the port maintainer, rather than > the libgcc maintainer. > > So I would work on the assumption that i

Ping: Synopsys DesignWare ARC Port

2012-12-03 Thread Joern Rennecke
This patch set hasn't been reviewed for more than a week: libgcc: 2012-10-09 Joern Rennecke * config.host (arc-*-elf*, arc*-*-linux-uclibc*): New configurations. gcc: 2012-11-22 Joern Rennecke Brendan Kehoe * config.gcc (arc-*-elf*, arc*-*-linux-uclibc*):

Go patch committed: Don't permit go/defer calls to be parenthesized

2012-12-03 Thread Ian Lance Taylor
The Go language spec does not permit go or defer calls to be parenthesized, but gccgo was permitting it. This patch issues an error for that case. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 4427b2edf858 go/parse.cc --- a/go/parse.cc Sun De

Backported r185231 from trunk. (issue 6878045)

2012-12-03 Thread asharif
Reviewers: davidxl, xur, Message: When I backported this patch to google/gcc-4.6, I forgot to do it for main. So now I am backporting this to google/main, google/4_7 and google/4_7-mobile. This is the first of the 3 (google/main is the target). I am running crosstool_validate.py and it should m

Re: Backported r185231 from trunk. (issue 6878045)

2012-12-03 Thread asharif
On 2012/12/04 00:50:45, asharif wrote: When I backported this patch to google/gcc-4.6, I forgot to do it for main. So now I am backporting this to google/main, google/4_7 and google/4_7-mobile. This is the first of the 3 (google/main is the target). I am running crosstool_validate.py and

Re: Backported r185231 from trunk. (issue 6878045)

2012-12-03 Thread Xinliang David Li
Looks good for gcc-4_7* branches. There is no need to port any trunk changes to google/main (it will be synced to trunk at some point). David On Mon, Dec 3, 2012 at 4:50 PM, wrote: > Reviewers: davidxl, xur, > > Message: > When I backported this patch to google/gcc-4.6, I forgot to do it for >

Ping: RE: [Patch, ARM] Fix the check on arg reg number in function thumb_find_work_register

2012-12-03 Thread Terry Guo
Hi Ramana, Can you please help to review this patch? Thanks. BR, Terry > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Terry Guo > Sent: Wednesday, November 28, 2012 1:53 PM > To: gcc-patches@gcc.gnu.org > Subject: [Patch,

Re: [PATCh][Revisedx2] Fix PR55521 by switching libsanitizer from mach_overrideto mac interpose functions on darwin

2012-12-03 Thread Alexander Potapenko
Jack, Note that MAC_INTERPOSE_FUNCTIONS is always defined in interception.h to either 0 or 1. I'm going to keep "#if MAC_INTERPOSE_FUNCTIONS" (adding "&& !defined(MISSING_BLOCKS_SUPPORT) " where appropriate) in libsanitizer. On Mon, Dec 3, 2012 at 11:17 AM, Mike Stump wrote: > On Dec 3, 2012, at

Ping-2: RE: [RFC] New feature to reuse one multilib among different targets

2012-12-03 Thread Terry Guo
Hi Joseph, Can you please review this patch? If I missed something, please point out. Thanks. BR, Terry > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Terry Guo > Sent: Friday, November 23, 2012 5:12 PM > To: jos...@codes

Re: [PATCh][Revisedx2] Fix PR55521 by switching libsanitizer from mach_overrideto mac interpose functions on darwin

2012-12-03 Thread Alexander Potapenko
I've added MISSING_BLOCKS_SUPPORT to LLVM compiler-rt in r169206. The rest of your change looks good to me as well. On Mon, Dec 3, 2012 at 6:33 PM, Alexander Potapenko wrote: > Jack, > > Note that MAC_INTERPOSE_FUNCTIONS is always defined in interception.h > to either 0 or 1. > I'm going to keep

Go patch committed: Fix crash on go/defer of some builtin functions

2012-12-03 Thread Ian Lance Taylor
This patch to the Go compiler fixes a crash when using go or defer with some builtin functions, namely those that have no side-effects. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.7 branch. Ian diff -r 952fc7825cfa go/expressions.cc --- a/go/expressi

Re: Sparc ASAN

2012-12-03 Thread Konstantin Serebryany
I've committed a flag to the LLVM implementation to not realign the stack (-mllvm -asan-realign-stack=0). On Xeon W3690 I've measured no performance difference (tried C/C++ part of SPEC2006). So, on x86 it's probably the right thing to not realign the stack. --kcc On Mon, Dec 3, 2012 at 10:41 PM,

  1   2   >