On Mon, Dec 3, 2012 at 2:50 PM, Lawrence Crowl <cr...@googlers.com> wrote: > On 12/3/12, Diego Novillo <dnovi...@google.com> wrote: >> On 2012-12-03 14:24 , Lawrence Crowl wrote: >>>>> -static int >>>>> -htab_cu_eq (const void *of1, const void *of2) >>>>> +inline bool >>>>> +cu_hash_table_entry_hasher::equal (const value_type *entry1, >>>>> + const compare_type *entry2) >>>> >>>> No static? >>> >>> The in-class declaration has the static keyword. (It's still a >>> global symbol though, not local.) >> >> Ah, right. I've seen other cases where the patch removes the >> 'static' qualifier in free functions, though (in the second patch >> too). Did you need to make those functions externally available? > > In C++03, any function argument to a template needs to be externally > available. These functions are parameters to the traverse templates.
Oh, right. Ignore all my other static-related comments then. Diego.
