Re: [PATCH, GCC][AArch64] Use Enums for code models option selection

2012-06-13 Thread Marcus Shawcroft
On 13/06/12 14:38, Sofiane Naci wrote: Hi, I discovered a bug in my previous patch, so I attach a new one. The ChangeLog hasn't changed. OK to commit? Thanks Sofiane -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Sofiane Na

Re: Make timevar phases mutually exclusive. (issue6302064)

2012-06-13 Thread Diego Novillo
On 12-06-13 08:46 , Diego Novillo wrote: The LTO bits are fine. I would prefer if an FE maintainer takes a second look over the other bits. Jason, Joseph? Incidentally, could you please test it with an LTO-enabled bootstrap? $ ../src/configure --with-build-config=bootstrap-lto --enable-langu

Re: C++ PATCH for c++/42603 and c++/6709 (DR 743/950, allow decltype as base-specifier and nested-name-specifier)

2012-06-13 Thread H.J. Lu
On Wed, Jul 20, 2011 at 7:29 AM, Jason Merrill wrote: > DRs 743 and 950 allow decltype to be used as the scope in a > nested-name-specifier and as a base-specifier.  This patch implements that > functionality.  In order to deal with the ambiguity when we first encounter > "decltype" as to whether

Re: [arm] Remove obsolete FPA support (1/n): obsolete target removal

2012-06-13 Thread Richard Earnshaw
On 13/06/12 14:19, Sebastian Huber wrote: > On 06/13/2012 02:51 PM, Richard Earnshaw wrote: >> (arm*-*-rtems*): Remove. > > For RTEMS the intention was to rename arm*-*-rtemseabi* into arm*-*-rtems* > and > provide an arm*-*-rtemself* legacy target. My personal opinion is to avoid a > arm

PATCH: PR target/53647: Set proper cache values when needed

2012-06-13 Thread H.J. Lu
Hi, On i386, ix86_size_cost will be used for -Os, which has zero for simultaneous_prefetches, prefetch_block, l1_cache_size and l2_cache_size. This patch adds ix86_tune_cost and uses it for simultaneous_prefetches, prefetch_block, l1_cache_size and l2_cache_size if ones from ix86_cost are zero. O

[PATCH][1/n] VRP and anti-range handling

2012-06-13 Thread Richard Guenther
I am trying to refresh my patches for PR30318 and while doing so I am about to re-organize how to deal with them in general. Basically reduce operations to primitives and combine them where necessary instead of open-coding all possibilities. I've started some of this last year (handling NEGATE_EX

[PATCH][2/n] VRP and anti-range handling

2012-06-13 Thread Richard Guenther
This adds proper VR_ANTI_RANGE handling (for constant ranges) to all unary and binary operations by decomposing anti-ranges into VR_RANGEs and vrp_meet-ing the results. Bootstrapped and tested on x86_64-unknown-linux-gnu with some minor fallout that prompted me to improve vrp_meet. Re-bootstrap

Re: Committed: atomic support for CRIS

2012-06-13 Thread Mike Stump
On Jun 12, 2012, at 4:47 PM, Hans-Peter Nilsson wrote: >> From: Richard Henderson >> Date: Tue, 12 Jun 2012 23:04:02 +0200 > Putting a lot of trust onto users and libraries there, to choose > the right model... My take, very, very few people will actually write code that plays with models and ba

Re: [PATCH 3/3] rs6000: Rewrite sync patterns for atomic; expand early.

2012-06-13 Thread Richard Henderson
On 2012-06-12 16:16, David Edelsohn wrote: > Should Altivec and SSE be used for TImode, and AVX for OImode? I dunno about Altivec, but SSE/AVX loads are not guaranteed atomic, so, no. r~

[PATCH, i386]: Some more soft-fp cleanups

2012-06-13 Thread Uros Bizjak
Hello! A couple of #defines can be moved to shared header, no need to mask _fex with exception mask and fnstsw should be marked volatile, since it depends on hidden FP status register. 2012-06-13 Uros Bizjak * config/i386/32/sfp-machine.h (_FP_NANSIGN_S, _FP_NANSIGN_D, _FP_NAN

Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support

2012-06-13 Thread Matt Turner
On Wed, Jun 13, 2012 at 3:26 AM, nick clifton wrote: > Hi Matt, Hi Xinyu, > > >> This series was written by Marvell and sent by Xinyu Qi >> a number of times in the last year. > > > Sorry for the long delay in reviewing these patches.  Overall they were > fine, with only a few, very minor, formatt

Re: [PATCH 3/3] rs6000: Rewrite sync patterns for atomic; expand early.

2012-06-13 Thread Richard Henderson
On 2012-06-13 01:33, Richard Guenther wrote: > If you are sure it won't break anything go ahead (sooner than later please). Done. r~

Re: [PATCH 3/7] Add stdint.h wrapper for VxWorks.

2012-06-13 Thread rbmj
On 06/12/2012 04:20 PM, Joseph S. Myers wrote: On Tue, 12 Jun 2012, rbmj wrote: On 06/12/2012 11:47 AM, Joseph S. Myers wrote: On Wed, 6 Jun 2012, rbmj wrote: The stdint.h doesn't have all the typedefs needed for standards compliance, so add a hack that adds all of the needed typedefs to be

Re: Committed: atomic support for CRIS

2012-06-13 Thread Hans-Peter Nilsson
> From: Mike Stump > CC: "r...@redhat.com" , "gcc-patches@gcc.gnu.org" > > Date: Wed, 13 Jun 2012 17:06:39 +0200 > References: <201206122347.q5cnlvkz030...@ignucius.se.axis.com> > x-spam-status: No, score=-1.9 required=5 tests=[BAYES_00=-1.9, > FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=

[RFA 4.7 PATCH, ia64]: Change ior attribute to "or" in sync.md

2012-06-13 Thread Uros Bizjak
Hello! This patch fixes a trivial oversight in the name of "or" family of sync functions. 2012-06-12 Uros Bizjak * config/ia64/sync.md (fetchop_name): Change ior attribute to "or". Tested on ia64-unknown-linux-gnu. Is it still OK to squeeze this trivial one-liner to 4.7 branch? Uro

Re: PATCH: PR target/53647: Set proper cache values when needed

2012-06-13 Thread Uros Bizjak
On Wed, Jun 13, 2012 at 4:47 PM, H.J. Lu wrote: > On i386, ix86_size_cost will be used for -Os, which has zero for > simultaneous_prefetches, prefetch_block, l1_cache_size and l2_cache_size. > This patch adds ix86_tune_cost and uses it for simultaneous_prefetches, > prefetch_block, l1_cache_size

Re: [RFA 4.7 PATCH, ia64]: Change ior attribute to "or" in sync.md

2012-06-13 Thread Jakub Jelinek
On Wed, Jun 13, 2012 at 07:04:54PM +0200, Uros Bizjak wrote: > This patch fixes a trivial oversight in the name of "or" family of > sync functions. > > 2012-06-12 Uros Bizjak > > * config/ia64/sync.md (fetchop_name): Change ior attribute to "or". > > Tested on ia64-unknown-linux-gnu. I

Re: PATCH: PR target/53647: Set proper cache values when needed

2012-06-13 Thread H.J. Lu
On Wed, Jun 13, 2012 at 10:40 AM, Uros Bizjak wrote: > On Wed, Jun 13, 2012 at 4:47 PM, H.J. Lu wrote: > >> On i386, ix86_size_cost will be used for -Os, which has zero for >> simultaneous_prefetches, prefetch_block, l1_cache_size and l2_cache_size. >> This patch adds ix86_tune_cost and uses it f

Re: Make timevar phases mutually exclusive. (issue6302064)

2012-06-13 Thread Joseph S. Myers
On Wed, 13 Jun 2012, Diego Novillo wrote: > The LTO bits are fine. I would prefer if an FE maintainer takes a second look > over the other bits. Jason, Joseph? The c-decl.c changes are fine with me. -- Joseph S. Myers jos...@codesourcery.com

Re: MIPS testsuite patch for --with-synci configurations

2012-06-13 Thread Richard Sandiford
Steve Ellcey writes: > On Mon, 2012-06-11 at 18:24 -0700, David Daney wrote: > >> > This patch addes the -mno-synci flag to MIPS tests that specify an >> > architecture that does not support synci, thus getting rid of the >> > warning message and making the tests pass. Tested with the mips-linux-

Re: [PATCH 3/7] Add stdint.h wrapper for VxWorks.

2012-06-13 Thread Joseph S. Myers
On Wed, 13 Jun 2012, rbmj wrote: > Since u?int.*_t are already defined, would this work? Or should I use the > non-typedef'd versions? Also, I'm not exactly sure how to run the regression > tests with a cross compiler. I'm still new to everything, bear with me :-) You have to use the non-typed

Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores

2012-06-13 Thread Ramana Radhakrishnan
On 29 May 2012 10:07, Yi-Hsiu Hsu wrote: > Hi, > > This patch maintains Marvell PJ4 cores pipeline description. > Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. > >        * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. >        * config/arm/arm.c (ar

Re: [PATCH 1/3] Add atomic_compare_and_swap, atomic_exchange and atomic_fetch_add patterns.

2012-06-13 Thread Richard Sandiford
Looks good, thanks. Just a couple of silly comments... Maxim Kuvyrkov writes: > +/* Subroutines of the mips_process_sync_loop. > + Emit barriers as needed for the memory MODEL. */ > + > +static bool > +mips_emit_pre_atomic_barrier_p (enum memmodel model) > +{ > + switch (model) > +{ > +

Re: [PATCH 2/3] Add XLP-specific atomic instructions and tweaks.

2012-06-13 Thread Richard Sandiford
Maxim Kuvyrkov writes: > diff --git a/gcc/config/mips/sync.md b/gcc/config/mips/sync.md > index 604aefa..ac953b5 100644 > --- a/gcc/config/mips/sync.md > +++ b/gcc/config/mips/sync.md > @@ -607,10 +607,32 @@ > (match_operand:GPR 1 "memory_operand") > (match_operand:GPR 2 "arith_operand") >

Re: [PATCH 2/3] Add XLP-specific atomic instructions and tweaks.

2012-06-13 Thread Maxim Kuvyrkov
On 14/06/2012, at 6:50 AM, Richard Sandiford wrote: > Maxim Kuvyrkov writes: >> diff --git a/gcc/config/mips/sync.md b/gcc/config/mips/sync.md >> index 604aefa..ac953b5 100644 >> --- a/gcc/config/mips/sync.md >> +++ b/gcc/config/mips/sync.md >> @@ -607,10 +607,32 @@ >>(match_operand:GPR 1 "me

Re: [PATCH 1/3] Add atomic_compare_and_swap, atomic_exchange and atomic_fetch_add patterns.

2012-06-13 Thread Maxim Kuvyrkov
On 14/06/2012, at 6:33 AM, Richard Sandiford wrote: > Looks good, thanks. Just a couple of silly comments... > > Maxim Kuvyrkov writes: >> +/* Subroutines of the mips_process_sync_loop. >> + Emit barriers as needed for the memory MODEL. */ >> + >> +static bool >> +mips_emit_pre_atomic_barrie

Re: [PATCH 3/3] Avoid emitting useless instructions in mips_process_sync_loop.

2012-06-13 Thread Richard Sandiford
Maxim Kuvyrkov writes: > + /* Don't bother setting returns that are never used. */ > + if (cmp && find_reg_note (insn, REG_UNUSED, cmp)) > +cmp = 0; > + if (required_oldval && find_reg_note (insn, REG_UNUSED, required_oldval)) > +required_oldval = 0; required_oldval is an important in

Re: [PATCH 2/3] Add XLP-specific atomic instructions and tweaks.

2012-06-13 Thread Richard Sandiford
Maxim Kuvyrkov writes: > On 14/06/2012, at 6:50 AM, Richard Sandiford wrote: >> Maxim Kuvyrkov writes: >>> diff --git a/gcc/config/mips/sync.md b/gcc/config/mips/sync.md >>> index 604aefa..ac953b5 100644 >>> --- a/gcc/config/mips/sync.md >>> +++ b/gcc/config/mips/sync.md >>> @@ -607,10 +607,32 @@

Re: [PATCH 3/3] Avoid emitting useless instructions in mips_process_sync_loop.

2012-06-13 Thread Maxim Kuvyrkov
On 14/06/2012, at 6:59 AM, Richard Sandiford wrote: > Maxim Kuvyrkov writes: >> + /* Don't bother setting returns that are never used. */ >> + if (cmp && find_reg_note (insn, REG_UNUSED, cmp)) >> +cmp = 0; >> + if (required_oldval && find_reg_note (insn, REG_UNUSED, required_oldval)) >> +

Re: [PR debug/47624] improve value tracking in non-VTA locations

2012-06-13 Thread Richard Henderson
On 2012-06-13 01:02, Alexandre Oliva wrote: > Ping? http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01320.html Ok. r~

Re: [RFC, ivopts] fix bugs in ivopts address cost computation

2012-06-13 Thread Sandra Loosemore
On 06/06/2012 02:29 AM, Richard Guenther wrote: Pre-computing and caching things is to avoid creating RTXen over and over. As you have discarded this completely did you try to measure the cost of doing so in terms of produced garbage and compile-time cost? Did you consider changing the target i

Re: [PATCH, MIPS] Add most common atomic patterns

2012-06-13 Thread Richard Henderson
On 2012-06-12 22:50, Maxim Kuvyrkov wrote: > The third patch is a small optimization to alleviate > __atomic_compare_exchange[_n] builtins being a use-one-for-all > solutions. These builtins return both boolean "success" and "oldval" > results. As most cases use only one of the results, this > op

New Serbian PO file for 'cpplib' (version 4.7.0)

2012-06-13 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'cpplib' has been submitted by the Serbian team of translators. The file is available at: http://translationproject.org/latest/cpplib/sr.po (This file, 'cpplib-4.7.0.sr.po',

Contents of PO file 'cpplib-4.7.0.sr.po'

2012-06-13 Thread Translation Project Robot
cpplib-4.7.0.sr.po.gz Description: Binary data The Translation Project robot, in the name of your translation coordinator.

Re: [Fortran, DRAFT patch] PR 46321 - [OOP] Polymorphic deallocation

2012-06-13 Thread Alessandro Fanfarillo
Dear all, in attachment the new draft which also supports the polymorphic deallocation via INTENT(OUT). Tomorrow I'll try to realize a draft for the deallocation at the end of the scope. Regards 2012/6/12 Alessandro Fanfarillo : > I don't know if there's already a PR but I get an ICE compiling t

Re: constant that doesn't fit in 32bits in alpha.c

2012-06-13 Thread Richard Henderson
On 2012-06-12 12:44, Joseph S. Myers wrote: > I'd rather have a macro HOST_WIDE_INT_C in hwint.h (like INTMAX_C etc. in > stdint.h). HOST_WIDE_INT_1 is already defined in hwint.h to either 1L or > 1LL; I'd suggest defining HOST_WIDE_INT_C to concatenate with either L or > LL (and then HOST_WIDE

[testsuite] more gcc.dg tests: add comments to dg-error and friends

2012-06-13 Thread Janis Johnson
This patch modifies miscellaneous tests in gcc/testsuite/gcc.dg to specify comments in dg-message/dg-warning/dg-error test directives for checks for multiple messages for the same line of source code. Tested on i686-pc-linux-gnu. OK for mainline? Janis 2012-06-13 Janis Johnson * gcc.

[testsuite] scandump.exp: use printable version of regexp

2012-06-13 Thread Janis Johnson
Most scan-* procedures used in dg-final test directives use a printable version of the regular expression in the test summary. This patch makes scan-*-dump-tiles do that as well, which eliminates several duplicates in test summaries for expressions that contain a newline. Tested on i686-pc-linux-

[testsuite] scanasm: don't strip torture args from testname in summary

2012-06-13 Thread Janis Johnson
Test results in a summary file usually include the torture options used for the test run, but those options are stripped for pass/fail reports for most scan-* procedures used in dg-final test directives. This patch refrains from stripping them and adds an extra space beteween those options and the

[testsuite] lib/dg-pch.exp: distinguish between two compilations in summary

2012-06-13 Thread Janis Johnson
PCH test infrastructure compiles each test twice, with identical results in the test summary file (assuming they both pass or both fail). This patch adds an extra flag to each compile, "-Dcompile1" or "-Dcompile2", to make the summary lines unique. This is a rather lame fix but at least I added a

Re: MIPS testsuite patch for --with-synci configurations

2012-06-13 Thread Steve Ellcey
On Wed, 2012-06-13 at 18:58 +0100, Richard Sandiford wrote: > I agree with David. This is really the same kind of situation as we > already have for -m(no-)dsp, etc. There too we need to override an > explicit -mdsp (which might be added using --target_board, etc.) > when testing a target that d

Re: constant that doesn't fit in 32bits in alpha.c

2012-06-13 Thread Joseph S. Myers
On Wed, 13 Jun 2012, Richard Henderson wrote: > On 2012-06-12 12:44, Joseph S. Myers wrote: > > I'd rather have a macro HOST_WIDE_INT_C in hwint.h (like INTMAX_C etc. in > > stdint.h). HOST_WIDE_INT_1 is already defined in hwint.h to either 1L or > > 1LL; I'd suggest defining HOST_WIDE_INT_C to

Re: constant that doesn't fit in 32bits in alpha.c

2012-06-13 Thread Richard Henderson
On 2012-06-13 02:13, Pedro Alves wrote: > Related, does gcc forbid "long long" / ULL ? Normally, yes. The vmsdbgout.c file seems to use it all over though. Cleaning that up is independent of this thread though. r~

Re: [testsuite] lib/dg-pch.exp: distinguish between two compilations in summary

2012-06-13 Thread Joseph S. Myers
On Wed, 13 Jun 2012, Janis Johnson wrote: > PCH test infrastructure compiles each test twice, with identical results > in the test summary file (assuming they both pass or both fail). This > patch adds an extra flag to each compile, "-Dcompile1" or "-Dcompile2", > to make the summary lines unique

Re: [PATCH] Fix ICE in expand_cse_reciprocals (PR tree-optimization/42078)

2012-06-13 Thread Alexandre Oliva
Sorry I dropped the ball on this one. Context is here: http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00416.html On Apr 12, 2012, Richard Guenther wrote: > + /* If the conditions in which this function uses VALUE change, > + adjust gimple_replace_lhs_wants_value(). */ > + gcc_assert (gimpl

[PATCH] Some vector cost model cleanup

2012-06-13 Thread William J. Schmidt
This is just some general maintenance to the vectorizer's cost model code: * Corrects a typo in a function name; * Eliminates an unnecessary function; * Combines some duplicate inline functions. Bootstrapped and tested on powerpc64-unknown-linux-gnu, no new regressions. Ok for trunk? Thanks,

Re: [testsuite] lib/dg-pch.exp: distinguish between two compilations in summary

2012-06-13 Thread Janis Johnson
On 06/13/2012 02:37 PM, Joseph S. Myers wrote: > On Wed, 13 Jun 2012, Janis Johnson wrote: > >> PCH test infrastructure compiles each test twice, with identical results >> in the test summary file (assuming they both pass or both fail). This >> patch adds an extra flag to each compile, "-Dcompile

Re: [testsuite] lib/dg-pch.exp: distinguish between two compilations in summary

2012-06-13 Thread Joseph S. Myers
On Wed, 13 Jun 2012, Janis Johnson wrote: > The patch for PR20771 did fix the problem (so I should have closed it) > but it was undone as part of a later change to the same lines. I could > either do that again, with comments this time explaining why they are > slightly different, or use "-Dwith_

Re: debug insns in SMS

2012-06-13 Thread Alexandre Oliva
Apologies for the duplicate ping, this one is now properly addressed to the pass maintainer. On Apr 9, 2012, Alexandre Oliva wrote: > On May 4, 2011, Revital1 Eres wrote: >> Hello Alexandre >>> I think this will restore proper functioning to SMS in the presence of >>> debug insns. A while ag

Re: [testsuite] more gcc.dg tests: add comments to dg-error and friends

2012-06-13 Thread Mike Stump
On Jun 13, 2012, at 2:12 PM, Janis Johnson wrote: > This patch modifies miscellaneous tests in gcc/testsuite/gcc.dg to > specify comments in dg-message/dg-warning/dg-error test directives for > checks for multiple messages for the same line of source code. > OK for mainline? Ok. I'm fine with yo

Re: [testsuite] scandump.exp: use printable version of regexp

2012-06-13 Thread Mike Stump
On Jun 13, 2012, at 2:13 PM, Janis Johnson wrote: > Most scan-* procedures used in dg-final test directives use a printable > version of the regular expression in the test summary. This patch makes > scan-*-dump-tiles do that as well, which eliminates several duplicates > in test summaries for exp

Re: [testsuite] scanasm: don't strip torture args from testname in summary

2012-06-13 Thread Mike Stump
On Jun 13, 2012, at 2:14 PM, Janis Johnson wrote: > Test results in a summary file usually include the torture options used > for the test run, but those options are stripped for pass/fail reports > for most scan-* procedures used in dg-final test directives. This patch > refrains from stripping

[SH] PR 53568 - Add support for bswap built-ins

2012-06-13 Thread Oleg Endo
Hello, The attached patch improves code generated for byte swap expressions such as ((x & 0xFF) << 8) | ((x >> 8) & 0xFF). It seems that currently the tree optimizers only detect bswap32 and bswap64 but not bswap16 patterns. The patch adds detection for bswap16 patterns by playing along with the

Re: [testsuite] lib/dg-pch.exp: distinguish between two compilations in summary

2012-06-13 Thread Mike Stump
On Jun 13, 2012, at 2:59 PM, Joseph S. Myers wrote: > On Wed, 13 Jun 2012, Janis Johnson wrote: > >> The patch for PR20771 did fix the problem (so I should have closed it) >> but it was undone as part of a later change to the same lines. I could >> either do that again, with comments this time ex

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-13 Thread Sterling Augustine
> I lean toward -g myself, since there doesn't seem to be a strong rule one > way or the other. Unless there are further comments, I'll stick with -g then. I think that covers all the comments, so I think I will commit this Friday morning unless I hear anything further. Sterling

Go patch committed: Avoid some unnecessary interface conversions

2012-06-13 Thread Ian Lance Taylor
This patch to the Go compiler avoids some unnecessary interface conversions. I was comparing Type* pointers for equality, but that only works if the types were defined before the code being compiled. If they were defined afterward, the types will normally be forward declarations. They will wind u

Re: [SH] PR 53568 - Add support for bswap built-ins

2012-06-13 Thread Kaz Kojima
Oleg Endo wrote: > The attached patch improves code generated for byte swap expressions > such as ((x & 0xFF) << 8) | ((x >> 8) & 0xFF). > It seems that currently the tree optimizers only detect bswap32 and > bswap64 but not bswap16 patterns. The patch adds detection for bswap16 > patterns by pla

Re: [Patch][ARM] Add arm-linux-gnueabihf triplet support.

2012-06-13 Thread Zhenqiang Chen
Ping. OK for trunk? Thanks! -Zhenqiang On 7 June 2012 16:12, Zhenqiang Chen wrote: > Hi, > > The patch adds arm-linux-gnueabihf triplet support. > > No regression for arm-linux-gnueabi tests. > > There are some differences between testsuite results on softfp Natty > builders and the new hard flo

Re: [PATCH] Fix libgo testsuite

2012-06-13 Thread Ian Lance Taylor
On Fri, Jun 8, 2012 at 7:38 AM, Andreas Schwab wrote: > This fixes most of the libgo testsuite failures. Thanks. Committed to mainline. Ian

Go patch committed: Quote package paths with tabs

2012-06-13 Thread Ian Lance Taylor
In my patch yesterday to quote package paths in reflection strings, I managed to overlook the fact that quotes are already used for struct field tags in reflection strings. This patch changes the compiler and the reflect package to quote using tabs instead, since tabs will never appear in struct f

Merge several revisions to gccgo branch

2012-06-13 Thread Ian Lance Taylor
I've merged the following revisions to the gccgo branch: 188548 188547 188545 188496 188494 188482 These are intended to be committed to gcc-4_7-branch when it is open for bug fixes. Ian

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-13 Thread Jason Merrill
On 06/13/2012 04:26 PM, Sterling Augustine wrote: I lean toward -g myself, since there doesn't seem to be a strong rule one way or the other. Unless there are further comments, I'll stick with -g then. I think that covers all the comments, so I think I will commit this Friday morning unless I

Re: Make timevar phases mutually exclusive. (issue6302064)

2012-06-13 Thread Jason Merrill
OK. Jason

Re: [PATCH] Fix ICE in expand_cse_reciprocals (PR tree-optimization/42078)

2012-06-13 Thread Alexandre Oliva
On Apr 12, 2012, Richard Guenther wrote: > + /* If the conditions in which this function uses VALUE change, > + adjust gimple_replace_lhs_wants_value(). */ > + gcc_assert (gimple_replace_lhs_wants_value () > + == MAY_HAVE_DEBUG_STMTS); > + if (MAY_HAVE_DEBUG_STMTS)

Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores

2012-06-13 Thread Chung-Lin Tang
On 2012/6/14 02:18 AM, Ramana Radhakrishnan wrote: > On 29 May 2012 10:07, Yi-Hsiu Hsu wrote: >> Hi, >> >> This patch maintains Marvell PJ4 cores pipeline description. >> Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. >> >>* config/arm/marvell-pj4.md: New marvel

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-06-13 Thread Sharad Singhai
Thanks for your comments. Responses inline. On Wed, Jun 13, 2012 at 4:48 AM, Richard Guenther wrote: > On Fri, Jun 8, 2012 at 7:16 AM, Sharad Singhai wrote: >> Okay, I have updated the attached patch so that the output from >> -ftree-vectorizer-verbose is considered diagnostic information and is

Re: [PATCH] Option to build bare-metal ARM cross-compiler for arm-none-eabi target without libunwind

2012-06-13 Thread Fredrik Hederstierna
-Joseph Myers wrote: - >You need to provide a self-contained explanation of what the problem >is that your patch is fixing and why you chose that approach to >fixing it - with reference to the ARM EABI documentes (RTABI etc.) >for why your approach is valid according to the ARM EABI.

Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support

2012-06-13 Thread nick clifton
Hi Matt, Hi Xinyu, This series was written by Marvell and sent by Xinyu Qi a number of times in the last year. Sorry for the long delay in reviewing these patches. Overall they were fine, with only a few, very minor, formatting issues. I have committed the entire series of patches to the m

Re: [PATCH] Option to build bare-metal ARM cross-compiler for arm-none-eabi target without libunwind

2012-06-13 Thread Fredrik Hederstierna
This is the link to the original patch. It contains some background information and more links. http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00720.html The patch is now updated and improved by Larry Doolittle. /Fredrik

[SH] PR 53568 - Add support for bswap built-ins

2012-06-13 Thread Oleg Endo
Hello, The attached patch adds support for the bswap32 built-in on SH. Tested with make -k -j8 check RUNTESTFLAGS="--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m2a-single/-mb,-m4/-ml, -m4/-mb,-m4-single/-ml,-m4-single/-mb,-m4a-single/-ml, -m4a-single/-mb}" and no new failures. Cheers, Ol

[Patch, Fortran] PR53597 re-add SAVE constraint for modules with -std=f2003

2012-06-13 Thread Tobias Burnus
Given the very slow patch review, I intent to commit this patch in a couple of days as obvious.* Nevertheless, I wouldn't mind a patch review. The constraint check is actually present in resolve.c, it just doesn't trigger. Build and regtested on x86-64-gnu-linux. OK for the trunk - and for th

[Patch, Fortran] PR53643 Fix INTENT(OUT) for class arrays

2012-06-13 Thread Tobias Burnus
gfortran had an ICE with intent(out) class arrays - and with (polymorphic) scalar coarrays. Build and regtested on x86-64-linux. OK for the trunk? Tobias 2012-06-12 Tobias Burnus PR fortran/53643 * trans-decl.c (init_intent_out_dt): Fix for polymorphic arrays. * trans-array.c (structure_

Re: [PR52983] eliminate autoinc from debug_insn locs

2012-06-13 Thread Alexandre Oliva
On May 3, 2012, Alexandre Oliva wrote: > Here are the 3 patches that, together, are equivalent to the one posted > before, except for the visibility of cleanup_auto_inc_dec. Ping? http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00300.html -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/

[Patch, Fortran] PR53642/45170c24 Deferred-length string fixes

2012-06-13 Thread Tobias Burnus
This patch fixes issues with deferred length strings, where the new string length (= RHS len) is evaluated too late. That's fixed by calling gfc_add_block_to_block. I have no idea whether the condition makes sense or whether that function could always be called. Additionally, in the FE optimiz

Re: [PR debug/47624] improve value tracking in non-VTA locations

2012-06-13 Thread Alexandre Oliva
On Apr 22, 2012, Alexandre Oliva wrote: > for gcc/ChangeLog > from Alexandre Oliva > PR debug/47624 > * var-tracking.c (loc_exp_dep_pool): New. > (vt_emit_notes): Create and release the pool. > (compute_bb_dataflow): Use value-based locations in MO_VAL_SET. > (e

Re: debug insns in SMS

2012-06-13 Thread Alexandre Oliva
On Apr 9, 2012, Alexandre Oliva wrote: >>> I think this will restore proper functioning to SMS in the presence of >>> debug insns. A while ago, we'd never generate deps of non-debug insns >>> on debug insns. I introduced them to enable sched to adjust (reset) >>> debug insns when non-debug ins

Re: don't force debug insns after their PREV_INSNs

2012-06-13 Thread Alexandre Oliva
On Apr 9, 2012, Alexandre Oliva wrote: > The problem here is that a nondebug insn may be moved ahead of a useful > debug insn and clobber one of its inputs, rendering it useless, when > there's no good reason for the debug insn to be kept in place, other > than an accidental dependency on the pr

Re: [PR48866] three alternative fixes

2012-06-13 Thread Alexandre Oliva
On Apr 9, 2012, Alexandre Oliva wrote: > On Jun 2, 2011, Alexandre Oliva wrote: >> On May 30, 2011, Alexandre Oliva wrote: >>> On May 30, 2011, Alexandre Oliva wrote: I have 3 different, mutually exclusive patches that fix PR 48866. The problem is exponential time while dealing w

Re: [trunk<-vta] Re: [vtab] Permit coalescing of user variables

2012-06-13 Thread Alexandre Oliva
On Apr 9, 2012, Alexandre Oliva wrote: > On Jun 4, 2011, Alexandre Oliva wrote: >> On Oct 13, 2009, Alexandre Oliva wrote: >>> On Jun 1, 2009, Alexandre Oliva wrote: A long time ago, when variable tracking at assignments was just a distant dream, we ran into one of the first cont

Re: [PATCH 3/3] rs6000: Rewrite sync patterns for atomic; expand early.

2012-06-13 Thread Richard Guenther
On Tue, 12 Jun 2012, Richard Henderson wrote: > On 2012-06-11 18:40, David Edelsohn wrote: > >> > Nope. I do see the obvious mistake in the atomic_load pattern though: > >> > The mode iterator should have been INT1 not INT. > > Did you want to commit the fix for the iterator? > > > > Applied th

Re: [PR52983, PR48866] eliminate autoinc from debug_insn locs

2012-06-13 Thread Alexandre Oliva
On May 3, 2012, Alexandre Oliva wrote: > On May 3, 2012, Alexandre Oliva wrote: >> My recent patch for PR48866 > ... had some inconsistency in behavior between dce and word_dce, as you > pointed out. I couldn't find any reason for that, so I made them the > same. > Regstrapped on x86_64-lin

Re: [PR52983, PR48866] eliminate autoinc from debug_insn locs

2012-06-13 Thread Jakub Jelinek
On Wed, Jun 13, 2012 at 05:46:47AM -0300, Alexandre Oliva wrote: > On May 3, 2012, Alexandre Oliva wrote: > > > On May 3, 2012, Alexandre Oliva wrote: > >> My recent patch for PR48866 > > > ... had some inconsistency in behavior between dce and word_dce, as you > > pointed out. I couldn't fi

Re: constant that doesn't fit in 32bits in alpha.c

2012-06-13 Thread Pedro Alves
On 06/12/2012 08:44 PM, Joseph S. Myers wrote: > I'd rather have a macro HOST_WIDE_INT_C in hwint.h (like INTMAX_C etc. in > stdint.h). HOST_WIDE_INT_1 is already defined in hwint.h to either 1L or > 1LL; I'd suggest defining HOST_WIDE_INT_C to concatenate with either L or > LL (and then HOST_

Re: [PATCH, RFC] First cut at using vec_construct for strided loads

2012-06-13 Thread Richard Guenther
On Tue, 12 Jun 2012, William J. Schmidt wrote: > This patch is a follow-up to the discussion generated by > http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00546.html. I've added > vec_construct to the cost model for use in vect_model_load_cost, and > implemented a cost calculation that makes sense

Re: [trunk<-vta] Re: [vtab] Permit coalescing of user variables

2012-06-13 Thread Richard Guenther
On Wed, Jun 13, 2012 at 10:09 AM, Alexandre Oliva wrote: > On Apr  9, 2012, Alexandre Oliva wrote: > >> On Jun  4, 2011, Alexandre Oliva wrote: > >>> On Oct 13, 2009, Alexandre Oliva wrote: On Jun  1, 2009, Alexandre Oliva wrote: > A long time ago, when variable tracking at assignment

RFC/RFA: Allow targets to override the definition of FLOAT_BIT_ORDER_MISMATCH

2012-06-13 Thread Nick Clifton
Hi Guys, The RX port currently has a problem with the software implementation of 64-bit doubles - the libgcc functions produce bogus results. I tracked this down to this definition in libgcc/fp-bit.h: #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ #define FLOAT_BIT_ORDER_MISMATCH

[patch] Fix PR middle-end/53590

2012-06-13 Thread Eric Botcazou
This PR is about straight-line code not being as much vectorized in Ada as in C or C++. The problem stems from the very conservative semantics implemented under -fnon-call-exceptions for the sake of Java. We don't need it in Ada. Tested on x86_64-suse-linux, OK for the mainline? 2012-06-13

Re: [PATCH] Option to build bare-metal ARM cross-compiler for arm-none-eabi target without libunwind

2012-06-13 Thread Julian Brown
On Wed, 13 Jun 2012 09:35:42 +0200 Fredrik Hederstierna wrote: > This is the link to the original patch. > It contains some background information and more links. > > http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00720.html > > The patch is now updated and improved by Larry Doolittle. > /Fredrik

Re: [PATCH] Option to build bare-metal ARM cross-compiler for arm-none-eabi target without libunwind

2012-06-13 Thread Joseph S. Myers
On Wed, 13 Jun 2012, Fredrik Hederstierna wrote: > >You need to provide a self-contained explanation of what the problem > >is that your patch is fixing and why you chose that approach to > >fixing it - with reference to the ARM EABI documentes (RTABI etc.) > >for why your approach is valid acc

Re: [patch] Fix PR middle-end/53590

2012-06-13 Thread Richard Guenther
On Wed, Jun 13, 2012 at 12:06 PM, Eric Botcazou wrote: > This PR is about straight-line code not being as much vectorized in Ada as in > C > or C++.  The problem stems from the very conservative semantics implemented > under -fnon-call-exceptions for the sake of Java.  We don't need it in Ada. >

Re: [PATCH] Option to build bare-metal ARM cross-compiler for arm-none-eabi target without libunwind

2012-06-13 Thread Fredrik Hederstierna
-Joseph Myers wrote: - >On Wed, 13 Jun 2012, Fredrik Hederstierna wrote: > >You need to provide a self-contained explanation of what the problem > >is that your patch is fixing and why you chose that approach to > >fixing it - with reference to the ARM EABI documentes (RTABI etc.) > >f

Re: [patch] Fix PR middle-end/53590

2012-06-13 Thread Eric Botcazou
> +@item -fdelete-dead-exceptions > +@opindex fdelete-dead-exceptions > +Assume that statements that may raise exceptions but don't otherwise > contribute +to the execution of the program can be optimized away. > + > This flag is set by the frontends according to their language > specification. Pas

Re: [patch] Fix PR middle-end/53590

2012-06-13 Thread Richard Guenther
On Wed, Jun 13, 2012 at 1:08 PM, Eric Botcazou wrote: >> +@item -fdelete-dead-exceptions >> +@opindex fdelete-dead-exceptions >> +Assume that statements that may raise exceptions but don't otherwise >> contribute +to the execution of the program can be optimized away. >> + >> This flag is set by t

Re: [SH] PR 53568 - Add support for bswap built-ins

2012-06-13 Thread Kaz Kojima
Oleg Endo wrote: > The attached patch adds support for the bswap32 built-in on SH. > > Tested with > make -k -j8 check RUNTESTFLAGS="--target_board=sh-sim > \{-m2/-ml,-m2/-mb,-m2a/-mb,-m2a-single/-mb,-m4/-ml, > -m4/-mb,-m4-single/-ml,-m4-single/-mb,-m4a-single/-ml, > -m4a-single/-mb}" > > and n

Re: [patch] Fix PR middle-end/53590

2012-06-13 Thread Eric Botcazou
> Not sure if it's worth it though, is it? This can be done as a followup > anyway. If we don't do it, we'll get another PR saying "this works in LTO mode with other versions of the Ada compiler" (which is true) so I'll proceed. > The patch is otherwise ok. Thanks. -- Eric Botcazou

Re: [PATCH, RFC] First cut at using vec_construct for strided loads

2012-06-13 Thread William J. Schmidt
On Wed, 2012-06-13 at 11:26 +0200, Richard Guenther wrote: > On Tue, 12 Jun 2012, William J. Schmidt wrote: > > > This patch is a follow-up to the discussion generated by > > http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00546.html. I've added > > vec_construct to the cost model for use in vect_mo

RFA: better gimplification of compound literals

2012-06-13 Thread Michael Matz
Hi, On Tue, 12 Jun 2012, Richard Guenther wrote: > > Ok, I see the C frontend hands us this as > > > >  return  VEC_PERM_EXPR < a , b , <<< Unknown tree: compound_literal_expr > >    v4si D.1712 = { 0, 4, 1, 5 }; >>> > ; > > > > and gimplification in some way fails to gimplify it to { 0, 4, 1, 5

Re: [Patch, Fortran] PR53597 re-add SAVE constraint for modules with -std=f2003

2012-06-13 Thread Paul Richard Thomas
Dear Tobias, This one is indeed obvious! OK for trunk. Cheers Paul On 13 June 2012 09:50, Tobias Burnus wrote: > Given the very slow patch review, I intent to commit this patch in a couple > of days as obvious.* Nevertheless, I wouldn't mind a patch review. > > The constraint check is actuall

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-06-13 Thread Richard Guenther
On Fri, Jun 8, 2012 at 7:16 AM, Sharad Singhai wrote: > Okay, I have updated the attached patch so that the output from > -ftree-vectorizer-verbose is considered diagnostic information and is > always > sent to stderr. Other functionality remains unchanged. Here is some > more context about this p

Re: [PATCH] Option to build bare-metal ARM cross-compiler for arm-none-eabi target without libunwind

2012-06-13 Thread Fredrik Hederstierna
> The __aeabi_unwind_cpp_pr* personality routines are *not* libunwind >functions either, they are also functions from libgcc_eh. Anything >related to those functions should not use the term "libunwind", >whether in configure option names, or patch submissions, since it is >not libunwind. Link

  1   2   >