Re: RFA: MN10300: Add support for SETLB and Lcc instructions

2011-03-08 Thread Nick Clifton
Hi Richard, Thanks for the review. Attached is a revised patch which addresses the issues that you raised: +/* A special mode used to distinguish the Lcc branch instruction + from the Bcc branch instruction. */ +CC_MODE (CC_LCC); Why not just use an unspec on the lcc insn. I should

Re: [v3] libstdc++/47145

2011-03-08 Thread Jonathan Wakely
On 8 March 2011 00:14, Benjamin Kosnik wrote: > > Conditionally set XSL_STYLE_DIR at configure time for either debian or > fedora/RHEL based systems. As discussed in bugzilla. > > For convenience, this patch steps around the STYLESHEET_FLAG question by > just punting to the net for validation only.

[PATCH] unbreak gcc.dg/tree-ssa/ssa-ccp-33.c on m68k (PR testsuite/47954)

2011-03-08 Thread Mikael Pettersson
gcc.dg/tree-ssa/ssa-ccp-33.c fails with gcc trunk on m68k-linux: ssa-ccp-33.c:(.text+0x2a): undefined reference to `link_error' ssa-ccp-33.c:(.text+0x2a): undefined reference to `link_error' FAIL: gcc.dg/tree-ssa/ssa-ccp-33.c (test for excess errors) ssa-ccp-33.c:(.text+0x2a): undefined reference

Re: [trans-mem] PR 47952 Re: weak aliases, .tm_clone_table, and binutils confusion

2011-03-08 Thread Patrick Marlier
Hi Richard, On 03/08/2011 01:50 AM, Richard Henderson wrote: On 03/06/2011 10:54 PM, Patrick Marlier wrote: Well, I have patched trans-mem.c to update the name of the COMDAT_GROUP in ipa_tm_create_version(). I know this is not the way to do this but I hope it can at least help you. This par

Re: [PATCH] Don't warn with -Wstrict-overflow about X + C1 == C2 transformations (PR tree-optimization/48022)

2011-03-08 Thread Richard Guenther
On Mon, Mar 7, 2011 at 8:15 PM, Jakub Jelinek wrote: > Hi! > > EQ/NE comparisons don't really assume that overflow doesn't happen unlike >>/>=/etc., so it is strange that we warn about it. > As the warning happens on simple strcmp uses when using glibc string.h, > it is extra annoying. > > Fixed t

Re: [patch testsuite g++.dg]: Adjust tree-ssa/pr21082 testcase for LLP64

2011-03-08 Thread Richard Guenther
On Mon, Mar 7, 2011 at 8:42 PM, Kai Tietz wrote: > PING Ok. Thanks, Richard. > 2011/2/23 Kai Tietz : >> Hi, >> >> ChangeLog >> >> 2011-02-23  Kai Tietz >> >>        * g++.dg/tree-ssa/pr21082.C: Use __INTPTR_TYPE__ instead of 'long' >> type. >> >> Ok for apply? >> >> Regards, >> Kai >> > > > >

Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Joseph S. Myers wrote: Thank you for the prompt feedback. > On Sat, 5 Mar 2011, Jim Meyering wrote: > >> diff --git a/gcc/config/i386/gmm_malloc.h b/gcc/config/i386/gmm_malloc.h >> index 7a7e840..8993fc7 100644 >> --- a/gcc/config/i386/gmm_malloc.h >> +++ b/gcc/config/i386/gmm_malloc.h >> @@ -67,

Re: [PATCH] unbreak gcc.dg/tree-ssa/ssa-ccp-33.c on m68k (PR testsuite/47954)

2011-03-08 Thread Richard Guenther
On Tue, Mar 8, 2011 at 10:43 AM, Mikael Pettersson wrote: > gcc.dg/tree-ssa/ssa-ccp-33.c fails with gcc trunk on m68k-linux: > > ssa-ccp-33.c:(.text+0x2a): undefined reference to `link_error' > ssa-ccp-33.c:(.text+0x2a): undefined reference to `link_error' > FAIL: gcc.dg/tree-ssa/ssa-ccp-33.c (tes

[patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Kai Tietz
Hello, This patch introduce directory-separator search routines to libiberty. IMHO filename_cmp.c is suiteable for those functions, but if there are objections about that I can move it into a separate source-file. It helps to avoid a commonly used pattern about dir-separator searching in code, whi

Re: [patch testsuite g++.dg]: Adjust tree-ssa/pr21082 testcase for LLP64

2011-03-08 Thread Kai Tietz
2011/3/8 Richard Guenther : > On Mon, Mar 7, 2011 at 8:42 PM, Kai Tietz wrote: >> PING > > Ok. > > Thanks, > Richard. > >> 2011/2/23 Kai Tietz : >>> Hi, >>> >>> ChangeLog >>> >>> 2011-02-23  Kai Tietz >>> >>>        * g++.dg/tree-ssa/pr21082.C: Use __INTPTR_TYPE__ instead of 'long' >>> type. >>>

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Eli Zaretskii
> Date: Tue, 8 Mar 2011 11:56:45 +0100 > From: Kai Tietz > > +@deftypefn Extension int filename_dirchr (const char *@var{p}) > + > +The returned value is similar to what @code{strchr} would return for > +searching for a directory separator. > + > +This function does not normalize file name. Howe

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Kai Tietz
2011/3/8 Eli Zaretskii : >> Date: Tue, 8 Mar 2011 11:56:45 +0100 >> From: Kai Tietz >> >> +@deftypefn Extension int filename_dirchr (const char *@var{p}) >> + >> +The returned value is similar to what @code{strchr} would return for >> +searching for a directory separator. >> + >> +This function do

[Patch, AVR] Housekeeping: Hookize REGISTER_MOVE_COST, MEMORY_MOVE_COST

2011-03-08 Thread Georg-Johann Lay
This patch moves deprecated REGISTER_MOVE_COST resp. MEMORY_MOVE_COST from avr.h to target hook avr_register_move_cost resp. avr_memory_move_cost in avr.c. No functionality added or removed; costs are unchanged. 2011-03-08 Georg-Johann Lay * config/avr/avr.h (REGISTER_MOVE_COST, MEMO

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Eli Zaretskii
> Date: Tue, 8 Mar 2011 12:25:37 +0100 > From: Kai Tietz > Cc: binut...@sourceware.org, gdb-patc...@sourceware.org, > gcc-patches@gcc.gnu.org > > > Btw, why do we need filename_dirchr?  The use case for > > filename_dirrchr is clear, but in what situations will we need the > > other one? >

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Andreas Schwab
Eli Zaretskii writes: > NULL is comparable as any other value. Only for equality. For relational operators the operands must point to the same object. Andreas. -- Andreas Schwab, sch...@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Kai Tietz
2011/3/8 Eli Zaretskii : >> Date: Tue, 8 Mar 2011 12:25:37 +0100 >> From: Kai Tietz >> Cc: binut...@sourceware.org, gdb-patc...@sourceware.org, >>       gcc-patches@gcc.gnu.org >> >> > Btw, why do we need filename_dirchr?  The use case for >> > filename_dirrchr is clear, but in what situations wil

[PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Jakub Jelinek
Hi! On Fedora/RHEL we default to ulimit -Su 1024 (just soft-limit, to better avoid non-root for bombs apparently). goroutines.go test by default attempts to spawn 1 threads, which means not only that goroutines.go test fails (no big deal), but that random other tests that happen to be tested a

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Pedro Alves
On Tuesday 08 March 2011 12:01:24, Kai Tietz wrote: > See for example remote-fileio.c in remote_fileio_extract_ptr_w_len() > as an example. There is more then one use-case. That '/' has nothing to do with path separators. It's simply a separator between a pointer and a length fields. E.g., @it

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Kai Tietz
2011/3/8 Pedro Alves : > On Tuesday 08 March 2011 12:01:24, Kai Tietz wrote: >> See for example remote-fileio.c in remote_fileio_extract_ptr_w_len() >> as an example. There is more then one use-case. > > That '/' has nothing to do with path separators.  It's simply > a separator between a pointer a

Re: [PATCH] unbreak gcc.dg/tree-ssa/ssa-ccp-33.c on m68k (PR testsuite/47954)

2011-03-08 Thread Mikael Pettersson
Richard Guenther writes: > On Tue, Mar 8, 2011 at 10:43 AM, Mikael Pettersson wrote: > > gcc.dg/tree-ssa/ssa-ccp-33.c fails with gcc trunk on m68k-linux: > > > > ssa-ccp-33.c:(.text+0x2a): undefined reference to `link_error' > > ssa-ccp-33.c:(.text+0x2a): undefined reference to `link_error'

[PATCH] avoid memory overrun in a test leading to potential double-free

2011-03-08 Thread Jim Meyering
I ran "make check" and was dismayed to see that glibc detected a double-free. At first I thought it must be my fault, since I'd been removing useless tests before free, but no... Running "valgrind ./test-expandargv" confirmed it: ==29710== Conditional jump or move depends on uninitialised valu

Re: [PATCH] PR c++/47957

2011-03-08 Thread Jason Merrill
OK. Jason

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Pedro Alves
On Tuesday 08 March 2011 12:48:11, Kai Tietz wrote: > Well, a better example is elfstab_offset_sections() in elfread.c. /* The ELF symbol info doesn't include path names, so strip the path (if any) from the psymtab filename. */ while (0 != (p = strchr (filename, '/'))) filename = p

[PATCH] PR 47836, Some Cross Compiler can't build target-libiberty or target-zlib

2011-03-08 Thread Thomas Klein
Hello This is more generalized way to give a user the ability to override the generation of target libraries, that are enabled per default. For example with the configure switch --disable-target-zlib, target-zlib is added to the script variable noconfigdirs and this target library will not be bui

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Kai Tietz
2011/3/8 Pedro Alves : > On Tuesday 08 March 2011 12:48:11, Kai Tietz wrote: > >> Well, a better example is elfstab_offset_sections() in elfread.c. > >  /* The ELF symbol info doesn't include path names, so strip the path >     (if any) from the psymtab filename.  */ >  while (0 != (p = strchr (fil

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Rainer Orth
Jim Meyering writes: > I've taken the liberty of letting my editor remove trailing > blanks in ChangeLog files. I hope that's ok. Also in ChangeLogs, > I converted some leading 8-space (and 7-space) sequences to single TABs. Please move this to a separate patch: this is completely unrelated to

Re: [PING^2] [PR46003, C++] Fix the assertion failure in build_target_expr

2011-03-08 Thread Jason Merrill
On 03/07/2011 01:27 PM, Yufeng Zhang wrote: On 03/03/2011 11:39 PM, Jason Merrill wrote: I think rather that the problem is in build_conditional_expr; it should have a template case that just determines the appropriate type and then builds up a COND_EXPR with that type from the unconverted operan

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Kai Tietz
Hi, I update the patch and put those new function into a separate file. ChangeLog include/ 2011-03-08 Kai Tietz * filenames.h (filename_dirchr): New prototype. (filename_dirrchr): Likewise. ChangeLog libiberty/ 2011-03-08 Kai Tietz * filename_chr.c: New file.

Re: [PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Ian Lance Taylor
Jakub Jelinek writes: > 2011-03-08 Jakub Jelinek > > * go.test/go-test.exp: For goroutines.go test pass > max($[`ulimit -u`/4], 1) as first argument, or 64 as a safe > default. How about if we do this unless the environment variable GCCGO_RUN_ALL_TESTS is set, so that pe

Re: [PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 07:20:28AM -0800, Ian Lance Taylor wrote: > Jakub Jelinek writes: > > > 2011-03-08 Jakub Jelinek > > > > * go.test/go-test.exp: For goroutines.go test pass > > max($[`ulimit -u`/4], 1) as first argument, or 64 as a safe > > default. > > How about if we

Re: [PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Rainer Orth
Ian Lance Taylor writes: > Jakub Jelinek writes: > >> 2011-03-08 Jakub Jelinek >> >> * go.test/go-test.exp: For goroutines.go test pass >> max($[`ulimit -u`/4], 1) as first argument, or 64 as a safe >> default. > > How about if we do this unless the environment variable > G

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Ian Lance Taylor
Rainer Orth writes: >> I found no ChangeLog for libgo and no other libgo-related entries. >> I suspect that means I should omit this change because it belongs upstream. > > Indeed, cf. libgo/README*. I've Cc'ed Ian who maintains this part of > GCC. Yes, libgo is upstream but in any case I'd pre

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Kai Tietz
Umm, sorry. I found a wrong copy & paste. So I re-sent the corrected patch. Additionally I adjuste the changes in Makefile.in so, that alphabetic order remains. Kai Index: gcc/include/filenames.h === --- gcc.orig/include/filenames.h

[PATCH] Rerun df_analyze if delete_trivially_dead_insns deleted something during IRA (PR debug/47881)

2011-03-08 Thread Jakub Jelinek
Hi! If delete_trivially_dead_insns deletes some insn, DF state might be out of date, and, what's worse, if there are pseudos set multiple times referenced in debug_insns, where the debug_insn references were ok before the deletions, but the deletions shortened lifetime of such a pseudo in certain

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 07:28:37AM -0800, Ian Lance Taylor wrote: > Rainer Orth writes: > > >> I found no ChangeLog for libgo and no other libgo-related entries. > >> I suspect that means I should omit this change because it belongs upstream. > > > > Indeed, cf. libgo/README*. I've Cc'ed Ian who

Re: [4.7] Avoid global state in v850_handle_option

2011-03-08 Thread Nick Clifton
Hi Joseph, Tested building cc1 and xgcc for cross to v850-elf. Will commit to trunk for 4.7 in the absence of target maintainer objections. No objections - please apply. 2011-03-07 Joseph Myers * config/v850/v850-opts.h: New. * config/v850/v850.c (small_memory): Replace wi

Re: [PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 04:27:04PM +0100, Rainer Orth wrote: > >> 2011-03-08 Jakub Jelinek > >> > >>* go.test/go-test.exp: For goroutines.go test pass > >>max($[`ulimit -u`/4], 1) as first argument, or 64 as a safe > >>default. > > > > How about if we do this unless the environme

Re: [PATCH] Rerun df_analyze if delete_trivially_dead_insns deleted something during IRA (PR debug/47881)

2011-03-08 Thread Vladimir Makarov
On 03/08/2011 10:33 AM, Jakub Jelinek wrote: Hi! If delete_trivially_dead_insns deletes some insn, DF state might be out of date, and, what's worse, if there are pseudos set multiple times referenced in debug_insns, where the debug_insn references were ok before the deletions, but the deletions

Re: [PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Ian Lance Taylor
Jakub Jelinek writes: > On Tue, Mar 08, 2011 at 07:20:28AM -0800, Ian Lance Taylor wrote: >> Jakub Jelinek writes: >> >> > 2011-03-08 Jakub Jelinek >> > >> >* go.test/go-test.exp: For goroutines.go test pass >> >max($[`ulimit -u`/4], 1) as first argument, or 64 as a safe >> >

Re: [PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Ian Lance Taylor
Rainer Orth writes: > Ian Lance Taylor writes: > >> Jakub Jelinek writes: >> >>> 2011-03-08 Jakub Jelinek >>> >>> * go.test/go-test.exp: For goroutines.go test pass >>> max($[`ulimit -u`/4], 1) as first argument, or 64 as a safe >>> default. >> >> How about if we do this unle

Re: [PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Rainer Orth
Jakub Jelinek writes: > I guess [getenv GCC_TEST_RUN_EXPENSIVE] != "" could be a usable test here, > if false it could always use 64 threads or something like that, if true > it should IMNSHO still bound it to at most max($[`ulimit -u`/2], 1) > when ulimit -u is available, because running the

Re: [PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Ian Lance Taylor
Jakub Jelinek writes: > On Tue, Mar 08, 2011 at 04:27:04PM +0100, Rainer Orth wrote: >> >> 2011-03-08 Jakub Jelinek >> >> >> >> * go.test/go-test.exp: For goroutines.go test pass >> >> max($[`ulimit -u`/4], 1) as first argument, or 64 as a safe >> >> default. >> > >> > How about if w

Re: avoid useless if-before-free tests

2011-03-08 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/05/11 07:05, Jim Meyering wrote: > Hello, > > Someone asked me about this yesterday, and since I've been carrying > this patch series for over a year -- it's not high priority -- > this seems like a good time finally to post it. > > I've been r

Re: avoid useless if-before-free tests

2011-03-08 Thread Dr Andrew John Hughes
On 22:47 Mon 07 Mar , Joseph S. Myers wrote: > On Mon, 7 Mar 2011, Dr Andrew John Hughes wrote: > > > > http://gcc.gnu.org/codingconventions.html says Classpath changes should > > > go > > > via Classpath upstream, not directly into GCC. I don't know if that's > > > still accurate. > > >

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Rainer Orth wrote: > Jim Meyering writes: >> I've taken the liberty of letting my editor remove trailing >> blanks in ChangeLog files. I hope that's ok. Also in ChangeLogs, >> I converted some leading 8-space (and 7-space) sequences to single TABs. > > Please move this to a separate patch: this

Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Dr Andrew John Hughes wrote: > On 22:47 Mon 07 Mar , Joseph S. Myers wrote: >> On Mon, 7 Mar 2011, Dr Andrew John Hughes wrote: >> >> > > http://gcc.gnu.org/codingconventions.html says Classpath changes should >> > > go >> > > via Classpath upstream, not directly into GCC. I don't know if tha

C++ PATCH for c++/45651 (ICE with explicit template instantiation and unnamed namespace)

2011-03-08 Thread Jason Merrill
The linkage handling of an explicit instantiation of an undefined template in instantiate_decl was interacting badly with the linkage magic for anonymous namespaces. Fixed thus. Tested x86_64-pc-linux-gnu, applied to trunk. commit bb206a6c192120614fa6e3c78a2ba2add6f5c3f2 Author: Jason Merrill

C++ PATCH for c++/47705 (ICE with non-pointer argument to pointer template parameter)

2011-03-08 Thread Jason Merrill
We were asserting that any argument to a non-type template parameter of pointer type must be an address. Which is true of valid code (apart from null pointer values), but not necessarily of invalid code, where we should complain rather than crash. Tested x86_64-pc-linux-gnu, applied to trunk.

C++ PATCH for c++/47488 (ICE on string literal in function template signature)

2011-03-08 Thread Jason Merrill
We don't know how to mangle a STRING_CST yet, but we don't need to crash. There is a recently added mangling in the ABI document, but it is inadequate, so I'd like to get that fixed before adding it to G++. Tested x86_64-pc-linux-gnu, applied to trunk. commit 2dceb38738c4aedc2e64bf8e8aa4c621b1

Re: [v3] libstdc++/47145

2011-03-08 Thread Benjamin Kosnik
> > For convenience, this patch steps around the STYLESHEET_FLAG > > question by just punting to the net for validation only. > > But it still uses --nonet in that step, right? So it doesn't use the > network at all, the mapping from the canonical stylesheet URL to a > local file is done by the s

[Committed] bswap testcase on s390 - use -march=z900

2011-03-08 Thread Andreas Krebbel
Hi, the s390 (31 bit) bswap pattern is only available with z900 or higher. So the testcase fails without specifying -march=z900 (or higher). Committed to mainline. Bye, -Andreas- 2011-03-08 Andreas Krebbel * gcc.dg/optimize-bswapsi-1.c: Use -march=z900 on s390. Index: gcc/testsu

[PATCH v3] Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Jim Meyering wrote: > Joseph S. Myers wrote: > ... >> We definitely don't want to make local changes to zlib for this sort of >> issue, though importing a new upstream version of zlib (making sure the >> local configure code still works) should be fine for 4.7. > > Thanks again for the feedback. >

fix for pr47837

2011-03-08 Thread Xinliang David Li
Please review the attached patch, it does some simplification of the complicated logical or expressions (x1 or x2 or x3 ...) constructed from control flow analysis into simpler form. Bootstraps and works on s390x for both testcases. Bootstraps on x86-64. Regression testing is on going (it takes f

Re: fix for pr47837

2011-03-08 Thread Xinliang David Li
On Tue, Mar 8, 2011 at 9:54 AM, Xinliang David Li wrote: > Please review the attached patch, it does some simplification of the > complicated logical or expressions (x1 or x2 or x3 ...) constructed > from control flow analysis into simpler form. > > Bootstraps and works on s390x for both testcases

[PATCH] Decrease number of threads used by goroutines.go test (take 2)

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 08:04:23AM -0800, Ian Lance Taylor wrote: > I don't really care what environment variable we use, I just want some > way to run the full test, without having DejaGNU silently change the > test on me. It's perfectly reasonable to have the default check ulimit, > I just want

Re: fix for pr47837

2011-03-08 Thread Diego Novillo
On Tue, Mar 8, 2011 at 12:54, Xinliang David Li wrote: > Bootstraps on x86-64. Regression testing is on going (it takes forever > (whole night already) to finish possibly because the lto test in > c-torture ..). I don't think so. We have been having weird kernel problems in our machines when ru

Re: [Patch, AVR] Housekeeping: Hookize REGISTER_MOVE_COST, MEMORY_MOVE_COST

2011-03-08 Thread Denis Chertykov
2011/3/8 Georg-Johann Lay : > This patch moves deprecated REGISTER_MOVE_COST resp. MEMORY_MOVE_COST > from avr.h to target hook avr_register_move_cost resp. > avr_memory_move_cost in avr.c. > > No functionality added or removed; costs are unchanged. > > > 2011-03-08  Georg-Johann Lay   > >        *

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Eli Zaretskii
> Date: Tue, 8 Mar 2011 16:29:51 +0100 > From: Kai Tietz > > Umm, sorry. I found a wrong copy & paste. So I re-sent the corrected > patch. Additionally I adjuste the changes in Makefile.in so, that > alphabetic order remains. I think we don't need filename_dirchr, only filename_dirrchr. And you

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Eli Zaretskii
> From: Pedro Alves > Date: Tue, 8 Mar 2011 13:33:02 + > Cc: Kai Tietz , > gcc-patches@gcc.gnu.org, > Eli Zaretskii , > binut...@sourceware.org > > On Tuesday 08 March 2011 12:48:11, Kai Tietz wrote: > > > Well, a better example is elfstab_offset_sections() in elfread.c. > > /* The ELF

Re: [PATCH] Decrease number of threads used by goroutines.go test (take 2)

2011-03-08 Thread Rainer Orth
Jakub Jelinek writes: > Ok, here is an updated patch which uses both proposed env vars: > > GCCGO_RUN_ALL_TESTS=1 makes it fail for me as before (i.e. 1 threads) > > GCC_TEST_RUN_EXPENSIVE=1 makes it run with max($[`ulimit -u`/4], 1) > threads on Linux native, 1 everywhere else Why s

Re: [PATCH] Decrease number of threads used by goroutines.go test (take 2)

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 07:40:38PM +0100, Rainer Orth wrote: > Jakub Jelinek writes: > > > Ok, here is an updated patch which uses both proposed env vars: > > > > GCCGO_RUN_ALL_TESTS=1 makes it fail for me as before (i.e. 1 threads) > > > > GCC_TEST_RUN_EXPENSIVE=1 makes it run with max($[`ul

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Rainer Orth
Jim Meyering writes: >> the change at hand. And please don't change the alignment of entries >> with multiple email addresses. > > Changing 8-spaces to a TAB does not affect alignment when you're > looking at the ChangeLog file itself with standard tab setting. > > Perhaps you looked at a hunk l

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Pedro Alves
On Tuesday 08 March 2011 18:37:49, Eli Zaretskii wrote: > > > Another is in find_file_and_directory() in dwarf2read.c file. > > > > Workaround for Irix. Certainly that '/' should not depend > > on the host gdb is running on. > > It actually should use IS_ABSOLUTE_FILE_NAME, if any portability >

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Kai Tietz
2011/3/8 Eli Zaretskii : >> From: Pedro Alves >> Date: Tue, 8 Mar 2011 13:33:02 + >> Cc: Kai Tietz , >>  gcc-patches@gcc.gnu.org, >>  Eli Zaretskii , >>  binut...@sourceware.org >> >> On Tuesday 08 March 2011 12:48:11, Kai Tietz wrote: >> >> > Well, a better example is elfstab_offset_sections(

Re: fix for pr47837

2011-03-08 Thread Diego Novillo
On 03/08/2011 12:54 PM, Xinliang David Li wrote: Please review the attached patch, it does some simplification of the complicated logical or expressions (x1 or x2 or x3 ...) constructed from control flow analysis into simpler form. Bootstraps and works on s390x for both testcases. Bootstraps on

Re: [PATCH] Decrease number of threads used by goroutines.go test (take 2)

2011-03-08 Thread Rainer Orth
Jakub Jelinek writes: >> Why should this be Linux-specific? I think the same logic applies >> everywhere. > > Because ulimit -u is Linux specific? At least, google doesn't show any > hints about any other OSes having such limit, neither RLIMIT_NPROC nor > ulimit -u. At best, it's shell-specifi

Re: [PATCH] Decrease number of threads used by goroutines.go test (take 2)

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 07:56:38PM +0100, Rainer Orth wrote: > Jakub Jelinek writes: > At best, it's shell-specific: Solaris 11 /bin/sh (which is ksh93) does > have it, although admittedly previous Solaris/IRIX/Tru64 UNIX shells > don't. On the other hand, bash has it on all of those systems. >

Re: [PATCH] Decrease number of threads used by goroutines.go test (take 2)

2011-03-08 Thread Rainer Orth
Jakub Jelinek writes: > I'm happy to drop the [ ishost "*-linux*" ] && if you are going to look for > failures on weirdo OSes. I have no idea what ulimit -u does on anything but > Linux, while the tcl code only uses its value if it printed a number, > whether it is something similar to limit on

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Rainer Orth wrote: > Jim Meyering writes: >>> the change at hand. And please don't change the alignment of entries >>> with multiple email addresses. >> >> Changing 8-spaces to a TAB does not affect alignment when you're >> looking at the ChangeLog file itself with standard tab setting. >> >> Per

[PATCH] Decrease number of threads used by goroutines.go test (take 3)

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 08:10:31PM +0100, Rainer Orth wrote: > Jakub Jelinek writes: > > > I'm happy to drop the [ ishost "*-linux*" ] && if you are going to look for > > failures on weirdo OSes. I have no idea what ulimit -u does on anything but > > Linux, while the tcl code only uses its value

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Rainer Orth
Jim Meyering writes: >> I honestly don't see the point of this whitespace change unless done >> across all ChangeLogs, not just a few that you happen to touch. > > As I said, it's gone, now, from my patch. > If no one objects, I'll normalize all ChangeLog files. No objection per se, although it'

Re: [PATCH] avoid memory overrun in a test leading to potential double-free

2011-03-08 Thread DJ Delorie
> avoid memory overrun in a test leading to potential double-free > * testsuite/test-expandargv.c (writeout_test): Fix off-by-one error: > i.e., do copy the trailing NUL byte. Ok. Thanks!

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-03-08 Thread DJ Delorie
I'm OK with the libiberty parts.

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 08:20:22PM +0100, Rainer Orth wrote: > Jim Meyering writes: > > >> I honestly don't see the point of this whitespace change unless done > >> across all ChangeLogs, not just a few that you happen to touch. > > > > As I said, it's gone, now, from my patch. > > If no one obje

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread DJ Delorie
> I think we don't need filename_dirchr, only filename_dirrchr. I see no harm in having both, for completeness, though. One could argue they should be in separate files, but they're trivial functions on non-dos-fs systems. What bothers me about this patch is that we're adding yet another set of

Re: RFA/RFC: Enable both gold and ld in a single toolchain

2011-03-08 Thread Diego Novillo
On Tue, Aug 17, 2010 at 04:58, Nick Clifton wrote: > Hi Raymes, > >> What is the status of this patch? I see the binutils part applied but >> not the gcc part. >> >> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg00402.html > > Mark Mitchell recently posted a review of the patch and it is currently

Re: [PATCH] Decrease number of threads used by goroutines.go test (take 2)

2011-03-08 Thread Ian Lance Taylor
Jakub Jelinek writes: > 2011-03-08 Jakub Jelinek > > * go.test/go-test.exp: For goroutines.go test if GCCGO_RUN_ALL_TESTS > is not set in the environment, pass 64 as first argument when not > running expensive tests or pass max($[`ulimit -u`/4], 1) on > Linux native

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Eli Zaretskii
> Date: Tue, 8 Mar 2011 19:51:14 +0100 > From: Kai Tietz > Cc: Pedro Alves , gdb-patc...@sourceware.org, > gcc-patches@gcc.gnu.org, binut...@sourceware.org > > > In my experience, the strchr analog is not needed, only the strrchr > > one (which could be used quite a lot).  The few places t

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Eli Zaretskii
> Date: Tue, 8 Mar 2011 14:41:00 -0500 > From: DJ Delorie > CC: ktiet...@googlemail.com, binut...@sourceware.org, > gdb-patc...@sourceware.org, gcc-patches@gcc.gnu.org > > > I see no harm in having both, for completeness, though. I don't see any need for completeness in this case. But

Re: fix for pr47837

2011-03-08 Thread Xinliang David Li
On Tue, Mar 8, 2011 at 10:55 AM, Diego Novillo wrote: > On 03/08/2011 12:54 PM, Xinliang David Li wrote: >> >> Please review the attached patch, it does some simplification of the >> complicated logical or expressions (x1 or x2 or x3 ...) constructed >> from control flow analysis into simpler form

Re: [v3] libstdc++/47145

2011-03-08 Thread Jonathan Wakely
On 8 March 2011 17:30, Benjamin Kosnik wrote: > >> > For convenience, this patch steps around the STYLESHEET_FLAG >> > question by just punting to the net for validation only. >> >> But it still uses --nonet in that step, right? So it doesn't use the >> network at all, the mapping from the canonica

Re: C++ PATCH for c++/47705 (ICE with non-pointer argument to pointer template parameter)

2011-03-08 Thread Jason Merrill
On 03/08/2011 12:25 PM, Jason Merrill wrote: We were asserting that any argument to a non-type template parameter of pointer type must be an address. Which is true of valid code (apart from null pointer values), but not necessarily of invalid code, where we should complain rather than crash. Do

Re: [Patch] PR c++/26256

2011-03-08 Thread Fabien Chêne
2011/3/5 Jason Merrill : > On 03/04/2011 03:11 AM, Fabien Chêne wrote: >> >> Hmm, I've implemented what you were suggesting, and I don't understand >> the following check in supplement_binding: >> >> else if (TREE_CODE (bval) == TYPE_DECL&&  DECL_ARTIFICIAL (bval)) >>     { >>       /* The old bind

Re: fix for pr47837

2011-03-08 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/08/11 11:55, Diego Novillo wrote: > On 03/08/2011 12:54 PM, Xinliang David Li wrote: >> Please review the attached patch, it does some simplification of the >> complicated logical or expressions (x1 or x2 or x3 ...) constructed >> from control fl

[PATCH] Fix MEM_IN_STRUCT_P/MEM_SCALAR_P during expansion (PR rtl-optimization/47866)

2011-03-08 Thread Jakub Jelinek
Hi! torture/vector-2.c testcase is miscompiled on ia64, apparently because a store uses a result of POST_MODIFY, which during sched1 without cselib is considered variable and is marked as MEM_IN_STRUCT_P while all other memory stores/loads for that variable are MEM_SCALAR_P and fixed_scalar_and_va

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Pedro Alves
Actually, is there any case where lbasename wouldn't work instead of filename_dirrchr? (gdb is already making use of unix_lbasename / dos_lbasename at places where it needs to handle host vs target paths). -- Pedro Alves

Re: fix for pr47837

2011-03-08 Thread Xinliang David Li
On Tue, Mar 8, 2011 at 2:04 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/08/11 11:55, Diego Novillo wrote: >> On 03/08/2011 12:54 PM, Xinliang David Li wrote: >>> Please review the attached patch, it does some simplification of the >>> complicated logical or expr

Re: [PATCH] Decrease number of threads used by goroutines.go test (take 2)

2011-03-08 Thread Mike Stump
On Mar 8, 2011, at 10:44 AM, Jakub Jelinek wrote: > Because ulimit -u is Linux specific? Seems to work on darwin (266).

[PATCH] Re-fix PR target/47755 on powerpc VSX

2011-03-08 Thread Michael Meissner
PR 47755 fixed some bugs on VSX with V2DI constants, but the patch itself had problems. In particular, the easy_altivec_constant support assumed the largest int size was SImode. This would cause the compiler to generate VSPLTI{W,S,B} to load up a constant instead of loading it up from memory. Th

Re: [PATCH] Re-fix PR target/47755 on powerpc VSX

2011-03-08 Thread David Edelsohn
On Tue, Mar 8, 2011 at 6:56 PM, Michael Meissner wrote: > PR 47755 fixed some bugs on VSX with V2DI constants, but the patch itself had > problems.  In particular, the easy_altivec_constant support assumed the > largest > int size was SImode.  This would cause the compiler to generate VSPLTI{W,S,

Re: [PATCH] Re-fix PR target/47755 on powerpc VSX

2011-03-08 Thread Michael Meissner
On Tue, Mar 08, 2011 at 07:12:27PM -0500, David Edelsohn wrote: > On Tue, Mar 8, 2011 at 6:56 PM, Michael Meissner > wrote: > > PR 47755 fixed some bugs on VSX with V2DI constants, but the patch itself > > had > > problems.  In particular, the easy_altivec_constant support assumed the > > larges

[tree-ssa] conversion between dissimilar-sized pointers is not useless

2011-03-08 Thread DJ Delorie
Affects tpf, mips64, and m32c. Hand-checked tpf by inspection, m32c tests running now. Look OK so far? * tree-ssa.c (useless_type_conversion_p): Conversions between pointers of different modes are not useless. Index: tree-ssa.c ==

Re: RFA: MN10300: Add support for SETLB and Lcc instructions

2011-03-08 Thread Richard Henderson
> + /* If the comparison has not already been split out of the branch > + then do so now. */ > + if (REGNO (cmp_reg) != CC_REG) > +{ > + rtx cmp; > + > + cmp = emit_insn_before (gen_cmpsi (cmp_reg, XEXP (comparison, 1)), > branch); > + > + DUMP ("Extracted comparison from

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-08 Thread Eli Zaretskii
> From: Pedro Alves > Date: Tue, 8 Mar 2011 22:37:59 + > Cc: DJ Delorie , > Eli Zaretskii , > ktiet...@googlemail.com, > binut...@sourceware.org, > gcc-patches@gcc.gnu.org > > Actually, is there any case where lbasename wouldn't > work instead of filename_dirrchr? Almost: lbasename retur

libgo patch committed: Fix search for next prime

2011-03-08 Thread Ian Lance Taylor
This patch to libgo fixes the search for the next prime to use for the number of buckets. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. The problem was reported in PR 47910, which this fixes. Ian diff -r 87faad0d0c52 libgo/runtime/go-new-map.c --- a/libg

libgo patch committed: Only run net tests if GCCGO_RUN_ALL_TESTS

2011-03-08 Thread Ian Lance Taylor
This patch to libgo only runs the networking dependent tests if GCCGO_RUN_ALL_TESTS is set in the environment. This is PR 48017. In that PR Rainer suggests having the tests drop back to UNSUPPORTED or UNRESOLVED if they fail to open a network connection. That is tempting but I don't agree with i

Fix pr48032, powerpc64 -mcmodel=medium invalid ld offset

2011-03-08 Thread Alan Modra
This patch a) Moves the offsettable_ok_by_alignment call from rs6000_emit_move to legitimate_constant_pool_address_p, and b) teaches offsettable_ok_by_alignment how to handle -fsection-anchors addresses, and c) teaches offsettable_ok_by_alignment about other SYMBOL_REF_DECL trees I see the

libgo patch committed: Ignore EINTR in runtime_lock_full

2011-03-08 Thread Ian Lance Taylor
This patch to libgo ignores EINTR when calling sem_wait in runtime_lock_full. This is based on a patch from Rainer in PR 48019. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r bdcef618b22e libgo/runtime/thread.c --- a/libgo/runtime/thread.c Tue M

libgo patch committed: Ignore EINTR in connect

2011-03-08 Thread Ian Lance Taylor
This libgo patch ignores an EINTR which occurs while calling connect on a socket. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. This is for PR 48019. Ian diff -r eb43a92af99e libgo/go/net/sock.go --- a/libgo/go/net/sock.go Tue Mar 08 22:31:00 2011 -0800