[PATCH 0/13 ver5] rs6000, built-in cleanup patch series

GCC maintainers: The following is the updates to the three patches that have yet to be approved. Patches 1, 3, 5, 6, 8, 9, 10, and 12 were approved in the version 3 or earlier. Patches 7 and 11 from version 4 were approved with minor nits fixed. This leaves patches 2, 4 and 13 still to be appr

[PATCH 0/13 ver4] rs6000, built-in cleanup patch series

GCC maintainers: I have addressed the comments to the five patches in the series that have not yet been approved. The patches that have already been approved are 1, 3, 5, 6, 8, 9, 10, and 12. The remaining patches all have fairly minor fixes requested. I will just post version 4 of these patch

[PATCH 0/13 ver 3] rs6000, built-in cleanup patch series

GCC maintainers: The following is an updated patch series to remove duplicate built-ins. There are patches to extend an existing overloaded built-in to cover additional input types. A new patch, 0005-rs6000-Remove-redundant-float-double-type-conversion.patch, was added to remove built-ins

[PING} Re: [PATCH 0/13] rs6000, built-in cleanup patch series

Ping, just wondering if anyone has had a chance to look at the patch series. Thanks. Carl On 4/19/24 14:04, Carl Love wrote: > GCC maintainers: > > The following patch series removes duplicate built-ins. There are patches to > extend an existing overloaded

[PATCH 0/13] rs6000, built-in cleanup patch series

GCC maintainers: The following patch series removes duplicate built-ins. There are patches to extend an existing overloaded built-in to cover additional input types. The final patch removes built-ins to set and initialize vectors. The code generated by these built-ins with the default optimi

rs6000, built-in cleanup patch series

GCC maintainers: The following series of patches cleanup some of the rs6000 built-in support. Some of the first patches fix errors in the definition of a few of the built-ins. The built-ins are supposed to have unsigned arguments but are listed as signed. Some of the built-ins are supposed t

Re: [PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

On 1/23/19 10:31 AM, Segher Boessenkool wrote: >> (rs6000_init_hard_regno_mode_ok, direct_move_p): Use >> HARD_REGISTER_NUM_P. > > This line is too long. Fixed. > And that is the worst I see in that whole patch! Please apply it. Committed after a svn update and another self review of th

Re: [PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

Hi! On Tue, Dec 04, 2018 at 10:12:51AM -0600, Peter Bergner wrote: > We talked about replacing rs6000'c regno_or_subregno() with the generic > reg_or_subregno() function from jump.c. I agree the geberic version is > better because it has an assert that ensures we have a REG. There were > also a

Re: [PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

On 12/12/18 1:58 PM, Peter Bergner wrote: > Ping. Ping * 2. https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00212.html Peter

Re: [PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

Ping. Peter On 12/4/18 10:12 AM, Peter Bergner wrote: > Hi Segher, > > We talked about replacing rs6000'c regno_or_subregno() with the generic > reg_or_subregno() function from jump.c. I agree the geberic version is > better because it has an assert that ensures we have a REG. There were > al

[PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

Hi Segher, We talked about replacing rs6000'c regno_or_subregno() with the generic reg_or_subregno() function from jump.c. I agree the geberic version is better because it has an assert that ensures we have a REG. There were also a couple of places that could use reg_or_subregno() where we weren

Re: [PATCH] Fortran cleanup patch

On Thu, 10 May 2018 16:08:17 -0700 Steve Kargl wrote: > The attached patch removed an unused function. > OK to commit? Removing unused code, can only make things easier. Ok to commit IMHO. - Andre > > 2018-05-10 Steven G. Kargl > >* gfortran.h: Remove prototype. >* symbol.c (gfc

[PATCH] Fortran cleanup patch

The attached patch removed an unused function. OK to commit? 2018-05-10 Steven G. Kargl * gfortran.h: Remove prototype. * symbol.c (gfc_new_undo_checkpoint): Remove unused function. -- Steve Index: gcc/fortran/gfortran.h =

[nvptx] small cleanup patch

Bernd, I've applied this small patch to trunk. It removes some unused variables in the ptx md file and silences some build warnings. nathan -- Nathan Sidwell 2015-06-26 Nathan Sidwell * config/nvptx/nvptx.md (call_operation): Remove unused variables. Index: config/nvptx/nvptx.md

[PATCH] Cleanup patch for 59127

Based on comments from Richi. This patch tweaks has_abnormal_outgoing_edge to also check for EDGE_EH and changes the name in the obvious way. This allows part of patch for 59127 to go away -- specifically we don't have to check stmt_ends_bb_p and explicitly filter out GIMPLE_RETURN. Bootstr

Re: [Google] AutoFDO cleanup patch

I've added some more cleanup to make AutoFDO isolated as well as consistent wil 4.8. Bootstrapped and passed regression test and benchmark performance test. OK for google branches? Thanks, Dehao http://codereview.appspot.com/9250047 On Sat, May 11, 2013 at 9:30 PM, Xinliang David Li wrote: >

Re: [Google] AutoFDO cleanup patch

Looks good. David On Sat, May 11, 2013 at 3:53 PM, Dehao Chen wrote: > In AutoFDO, we early-inline callsites that was inlined in profiling > runs regardless of the size limit. With this change, the existing > ipa-inline tunings for AutoFDO is unnecessary: it's fine to just use > the traditional

[Google] AutoFDO cleanup patch

In AutoFDO, we early-inline callsites that was inlined in profiling runs regardless of the size limit. With this change, the existing ipa-inline tunings for AutoFDO is unnecessary: it's fine to just use the traditional FDO based heuristic. This patch cleans up the original tunings and make it easie

Re: cleanup patch

Attached patch applied 2011-06-29 François Dumont * include/debug/set.h, unordered_map, multiset.h, forward_list, unordered_set, vector, deque, string, list, multimap.h: Remove base class default constructor calls. * include/debug/map.h: Likewise and cleanup sev

Re: Ping^2 Re: Target header etc. cleanup patch

On Apr 21, 2011, "Joseph S. Myers" wrote: > * config/mn10300/mn10300-protos.h (Mmode, Cstar, Rclas): Don't > define. Expand definitions where used. Ok, thanks -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. --

Re: Ping^4 Re: Target header etc. cleanup patch

Hi Joseph, I have seen no comments from the mn10300 maintainers. I think abbreviating const char * is actively bad. Cstar - defined for mn10300, whose maintainers haven't commented Whilst I am not a maintainer for the MN10300, I am the author of that bit of code. I can say that I have no ob

Re: Ping^4 Re: Target header etc. cleanup patch

On 05/02/2011 05:27 PM, Richard Guenther wrote: > On Mon, May 2, 2011 at 5:21 PM, Joseph S. Myers > wrote: >> Ping^4. Parts of this patch >> are still >> pending review, for targets fr30, m32r, mn10300, rx, v850 (target >> maintainers CC:

Re: Ping^4 Re: Target header etc. cleanup patch

On Mon, May 2, 2011 at 5:21 PM, Joseph S. Myers wrote: > Ping^4.  Parts of this patch > are still > pending review, for targets fr30, m32r, mn10300, rx, v850 (target > maintainers CC:ed).  This version applies cleanly to current trunk. > >

Ping^4 Re: Target header etc. cleanup patch

Ping^4. Parts of this patch are still pending review, for targets fr30, m32r, mn10300, rx, v850 (target maintainers CC:ed). This version applies cleanly to current trunk. I have seen no comments from the mn10300 maintainers. For the o

Re: Ping^2 Re: Target header etc. cleanup patch

On Thu, Apr 21, 2011 at 11:56:52PM -0400, Jie Zhang wrote: >On 04/21/2011 06:06 AM, Joseph S. Myers wrote: >> On Thu, 21 Apr 2011, Richard Guenther wrote: >> >>> On Wed, Apr 20, 2011 at 11:09 PM, Joseph S. Myers >>> wrote: Ping^2. This patch

Re: Ping^3 Re: Target header etc. cleanup patch

On Tue, 26 Apr 2011, Nick Clifton wrote: > Similarly it would be nice to standard abbreviations for CUMULATIVE_ARGS, enum > rtx_code, enum reg_class and const char *. What do you think ? I suspect I think defining an abbreviation for const char * is actively bad, since const char * is a standa

Re: Ping^3 Re: Target header etc. cleanup patch

Hi Joseph, 2011-04-26 Joseph Myers * config/fr30/fr30-protos.h (Mmode): Don't define. * config/fr30/fr30.h (inhibit_libc): Don't define. * config/m32r/m32r-protos.h (Mmode): Don't define. Expand definition where used. * config/mn10300/mn10300-protos.h (

Ping^3 Re: Target header etc. cleanup patch

Ping^3. Parts of this patch are still pending review: the parts for targets fr30, m32r, mn10300, rx, v850 (target maintainers CC:ed). This version applies cleanly to current trunk. 2011-04-26 Joseph Myers * config/fr30/fr3

Re: Ping^2 Re: Target header etc. cleanup patch

On 04/21/2011 06:06 AM, Joseph S. Myers wrote: On Thu, 21 Apr 2011, Richard Guenther wrote: On Wed, Apr 20, 2011 at 11:09 PM, Joseph S. Myers wrote: Ping^2. This patch is still pending review. This version applies cleanly to curren

Re: Ping^2 Re: Target header etc. cleanup patch

Joseph, mingw part is ok, too. Thanks, Kai

Re: Ping^2 Re: Target header etc. cleanup patch

On Thu, 21 Apr 2011, Richard Guenther wrote: > On Wed, Apr 20, 2011 at 11:09 PM, Joseph S. Myers > wrote: > > Ping^2.  This patch > > is still pending > > review.  This version applies cleanly to current trunk. > > The s/struct rtx_def */

Re: Ping^2 Re: Target header etc. cleanup patch

On Wed, Apr 20, 2011 at 11:09 PM, Joseph S. Myers wrote: > Ping^2.  This patch > is still pending > review.  This version applies cleanly to current trunk. The s/struct rtx_def */rtx/ changes are all ok (in fact I'd say they are obvious).

Re: Ping^2 Re: Target header etc. cleanup patch

On Apr 20, 2011, at 5:09 PM, Joseph S. Myers wrote: > Ping^2. This patch > is still pending > review. This version applies cleanly to current trunk. > ... pdp11 is fine. Thanks! paul

Re: Ping^2 Re: Target header etc. cleanup patch

The m32c one is OK

Ping^2 Re: Target header etc. cleanup patch

Ping^2. This patch is still pending review. This version applies cleanly to current trunk. 2011-04-20 Joseph Myers * config/alpha/alpha.c (struct machine_function): Use rtx, not struct rtx_def *. * config/bfi

Re: Target header etc. cleanup patch

"Joseph S. Myers" writes: > On Mon, 11 Apr 2011, Hans-Peter Nilsson wrote: > >> A nit: you had several lines consisting of "*." (with the >> obvious expansion) in the changelogs you posted. > > Yes, that's the result of line wrapping of "struct rtx_def *" at end of > sentence. You can write "po

Re: Target header etc. cleanup patch

On Mon, 11 Apr 2011, Hans-Peter Nilsson wrote: > A nit: you had several lines consisting of "*." (with the > obvious expansion) in the changelogs you posted. Yes, that's the result of line wrapping of "struct rtx_def *" at end of sentence. -- Joseph S. Myers jos...@codesourcery.com

Re: Target header etc. cleanup patch

On Sat, 2 Apr 2011, Joseph S. Myers wrote: > * cris-protos.h had an unused STDIO_INCLUDED definition, which I > removed. Been there since the first commit, it seems. Certainly this bit is ok. A nit: you had several lines consisting of "*." (with the obvious expansion) in the changelogs you post

Re: Ping Re: Target header etc. cleanup patch

On Apr 8, 2011, at 11:46 AM, Joseph S. Myers wrote: > Ping. This patch > is pending > 011-04-02 Joseph Myers This is wrong, it should use @ instead of :. :-) I glanced at the rest (in part to see if there were any darwin bits for

Ping Re: Target header etc. cleanup patch

Ping. This patch is pending review. The updated version (with one bit that had been committed separately removed) applies cleanly to current trunk. -- Joseph S. Myers jos...@

Re: Target header etc. cleanup patch

Here's a version of the patch updated for current trunk, since the pdp11 IRA_COVER_CLASSES removal has now been committed separately. OK to commit? 2011-04-04 Joseph Myers * config/alpha/alpha.c (struct machine_function): Use rtx, not struct rtx_def *. * config/bfin/

Re: Target header etc. cleanup patch

On Apr 2, 2011, at 1:05 PM, Joseph S. Myers wrote: > In the course of trying to work out exactly what target macros there > are, I came across various oddities in target headers (and a few in > target .c files) that are fixed by this patch > > * Testing showed that IRA_COVER_CLASSES had not

Target header etc. cleanup patch

In the course of trying to work out exactly what target macros there are, I came across various oddities in target headers (and a few in target .c files) that are fixed by this patch. * Various targets use "struct rtx_def *" or "union tree_node *" in place of "rtx" or "tree". I think this must