On 05/02/2011 05:27 PM, Richard Guenther wrote: > On Mon, May 2, 2011 at 5:21 PM, Joseph S. Myers <jos...@codesourcery.com> > wrote: >> Ping^4. Parts of this patch >> <http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00130.html> are still >> pending review, for targets fr30, m32r, mn10300, rx, v850 (target >> maintainers CC:ed). This version applies cleanly to current trunk. >> >> I have seen no comments from the mn10300 maintainers. For the other >> targets, Nick wanted to keep abbreviations for certain types >> <http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02047.html> and no-one else >> has commented on that issue, though as I noted in >> <http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02048.html> I think >> abbreviating const char * is actively bad. Cstar - defined for mn10300, >> whose maintainers haven't commented - is also the macro I care most about >> getting rid of in what's left of this patch, as it's the one that shows up >> as a false positive in my target macro listing script (the point of the >> original patch was to get rid of several such false positives, plus making >> related cleanups that showed up in the process). > > Ok except for the changes the target maintainer objects to. I do agree > with Joseph and if another maintainer also says Ok I think we should > overrule him.
I'll say OK then. Bernd