Re: Ping^2 Re: Target header etc. cleanup patch

2011-05-03 Thread Alexandre Oliva
On Apr 21, 2011, "Joseph S. Myers" wrote: > * config/mn10300/mn10300-protos.h (Mmode, Cstar, Rclas): Don't > define. Expand definitions where used. Ok, thanks -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. --

Re: Ping^4 Re: Target header etc. cleanup patch

2011-05-03 Thread Nick Clifton
Hi Joseph, I have seen no comments from the mn10300 maintainers. I think abbreviating const char * is actively bad. Cstar - defined for mn10300, whose maintainers haven't commented Whilst I am not a maintainer for the MN10300, I am the author of that bit of code. I can say that I have no ob

Re: Ping^4 Re: Target header etc. cleanup patch

2011-05-02 Thread Bernd Schmidt
On 05/02/2011 05:27 PM, Richard Guenther wrote: > On Mon, May 2, 2011 at 5:21 PM, Joseph S. Myers > wrote: >> Ping^4. Parts of this patch >> are still >> pending review, for targets fr30, m32r, mn10300, rx, v850 (target >> maintainers CC:

Re: Ping^4 Re: Target header etc. cleanup patch

2011-05-02 Thread Richard Guenther
On Mon, May 2, 2011 at 5:21 PM, Joseph S. Myers wrote: > Ping^4.  Parts of this patch > are still > pending review, for targets fr30, m32r, mn10300, rx, v850 (target > maintainers CC:ed).  This version applies cleanly to current trunk. > >

Ping^4 Re: Target header etc. cleanup patch

2011-05-02 Thread Joseph S. Myers
Ping^4. Parts of this patch are still pending review, for targets fr30, m32r, mn10300, rx, v850 (target maintainers CC:ed). This version applies cleanly to current trunk. I have seen no comments from the mn10300 maintainers. For the o

Re: Ping^2 Re: Target header etc. cleanup patch

2011-04-26 Thread Christopher Faylor
On Thu, Apr 21, 2011 at 11:56:52PM -0400, Jie Zhang wrote: >On 04/21/2011 06:06 AM, Joseph S. Myers wrote: >> On Thu, 21 Apr 2011, Richard Guenther wrote: >> >>> On Wed, Apr 20, 2011 at 11:09 PM, Joseph S. Myers >>> wrote: Ping^2. This patch

Re: Ping^3 Re: Target header etc. cleanup patch

2011-04-26 Thread Joseph S. Myers
On Tue, 26 Apr 2011, Nick Clifton wrote: > Similarly it would be nice to standard abbreviations for CUMULATIVE_ARGS, enum > rtx_code, enum reg_class and const char *. What do you think ? I suspect I think defining an abbreviation for const char * is actively bad, since const char * is a standa

Re: Ping^3 Re: Target header etc. cleanup patch

2011-04-26 Thread Nick Clifton
Hi Joseph, 2011-04-26 Joseph Myers * config/fr30/fr30-protos.h (Mmode): Don't define. * config/fr30/fr30.h (inhibit_libc): Don't define. * config/m32r/m32r-protos.h (Mmode): Don't define. Expand definition where used. * config/mn10300/mn10300-protos.h (

Ping^3 Re: Target header etc. cleanup patch

2011-04-26 Thread Joseph S. Myers
Ping^3. Parts of this patch are still pending review: the parts for targets fr30, m32r, mn10300, rx, v850 (target maintainers CC:ed). This version applies cleanly to current trunk. 2011-04-26 Joseph Myers * config/fr30/fr3

Re: Ping^2 Re: Target header etc. cleanup patch

2011-04-21 Thread Jie Zhang
On 04/21/2011 06:06 AM, Joseph S. Myers wrote: On Thu, 21 Apr 2011, Richard Guenther wrote: On Wed, Apr 20, 2011 at 11:09 PM, Joseph S. Myers wrote: Ping^2. This patch is still pending review. This version applies cleanly to curren

Re: Ping^2 Re: Target header etc. cleanup patch

2011-04-21 Thread Kai Tietz
Joseph, mingw part is ok, too. Thanks, Kai

Re: Ping^2 Re: Target header etc. cleanup patch

2011-04-21 Thread Joseph S. Myers
On Thu, 21 Apr 2011, Richard Guenther wrote: > On Wed, Apr 20, 2011 at 11:09 PM, Joseph S. Myers > wrote: > > Ping^2.  This patch > > is still pending > > review.  This version applies cleanly to current trunk. > > The s/struct rtx_def */

Re: Ping^2 Re: Target header etc. cleanup patch

2011-04-21 Thread Richard Guenther
On Wed, Apr 20, 2011 at 11:09 PM, Joseph S. Myers wrote: > Ping^2.  This patch > is still pending > review.  This version applies cleanly to current trunk. The s/struct rtx_def */rtx/ changes are all ok (in fact I'd say they are obvious).

Re: Ping^2 Re: Target header etc. cleanup patch

2011-04-20 Thread Paul Koning
On Apr 20, 2011, at 5:09 PM, Joseph S. Myers wrote: > Ping^2. This patch > is still pending > review. This version applies cleanly to current trunk. > ... pdp11 is fine. Thanks! paul

Re: Ping^2 Re: Target header etc. cleanup patch

2011-04-20 Thread DJ Delorie
The m32c one is OK

Ping^2 Re: Target header etc. cleanup patch

2011-04-20 Thread Joseph S. Myers
Ping^2. This patch is still pending review. This version applies cleanly to current trunk. 2011-04-20 Joseph Myers * config/alpha/alpha.c (struct machine_function): Use rtx, not struct rtx_def *. * config/bfi

Re: Target header etc. cleanup patch

2011-04-12 Thread Andreas Schwab
"Joseph S. Myers" writes: > On Mon, 11 Apr 2011, Hans-Peter Nilsson wrote: > >> A nit: you had several lines consisting of "*." (with the >> obvious expansion) in the changelogs you posted. > > Yes, that's the result of line wrapping of "struct rtx_def *" at end of > sentence. You can write "po

Re: Target header etc. cleanup patch

2011-04-12 Thread Joseph S. Myers
On Mon, 11 Apr 2011, Hans-Peter Nilsson wrote: > A nit: you had several lines consisting of "*." (with the > obvious expansion) in the changelogs you posted. Yes, that's the result of line wrapping of "struct rtx_def *" at end of sentence. -- Joseph S. Myers jos...@codesourcery.com

Re: Target header etc. cleanup patch

2011-04-11 Thread Hans-Peter Nilsson
On Sat, 2 Apr 2011, Joseph S. Myers wrote: > * cris-protos.h had an unused STDIO_INCLUDED definition, which I > removed. Been there since the first commit, it seems. Certainly this bit is ok. A nit: you had several lines consisting of "*." (with the obvious expansion) in the changelogs you post

Re: Ping Re: Target header etc. cleanup patch

2011-04-08 Thread Mike Stump
On Apr 8, 2011, at 11:46 AM, Joseph S. Myers wrote: > Ping. This patch > is pending > 011-04-02 Joseph Myers This is wrong, it should use @ instead of :. :-) I glanced at the rest (in part to see if there were any darwin bits for

Ping Re: Target header etc. cleanup patch

2011-04-08 Thread Joseph S. Myers
Ping. This patch is pending review. The updated version (with one bit that had been committed separately removed) applies cleanly to current trunk. -- Joseph S. Myers jos...@

Re: Target header etc. cleanup patch

2011-04-04 Thread Joseph S. Myers
Here's a version of the patch updated for current trunk, since the pdp11 IRA_COVER_CLASSES removal has now been committed separately. OK to commit? 2011-04-04 Joseph Myers * config/alpha/alpha.c (struct machine_function): Use rtx, not struct rtx_def *. * config/bfin/

Re: Target header etc. cleanup patch

2011-04-02 Thread Paul Koning
On Apr 2, 2011, at 1:05 PM, Joseph S. Myers wrote: > In the course of trying to work out exactly what target macros there > are, I came across various oddities in target headers (and a few in > target .c files) that are fixed by this patch > > * Testing showed that IRA_COVER_CLASSES had not

Target header etc. cleanup patch

2011-04-02 Thread Joseph S. Myers
In the course of trying to work out exactly what target macros there are, I came across various oddities in target headers (and a few in target .c files) that are fixed by this patch. * Various targets use "struct rtx_def *" or "union tree_node *" in place of "rtx" or "tree". I think this must