Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-21 Thread Jan Hubicka
> > We already support the .blahblah syntax in the demangler in d_print_comp. > > (I think it deserve to be extended to special case some newly introduced > > mess, like .ltopriv and .local_alias) > > I wonder if we don't want to get the mangling here to be consistent, so > > users are facing the s

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-21 Thread Eric Botcazou
> We already support the .blahblah syntax in the demangler in d_print_comp. > (I think it deserve to be extended to special case some newly introduced > mess, like .ltopriv and .local_alias) > I wonder if we don't want to get the mangling here to be consistent, so > users are facing the same type o

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-20 Thread Jan Hubicka
> > Okay, just wanted to make sure. > > Understood. FWIW the patchlet has been in AdaCore's tree for some months and > works fine on Linux, Windows, Solaris, AIX, HP-UX, VMS, etc. We already support the .blahblah syntax in the demangler in d_print_comp. (I think it deserve to be extended to spe

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-20 Thread Eric Botcazou
> Okay, just wanted to make sure. Understood. FWIW the patchlet has been in AdaCore's tree for some months and works fine on Linux, Windows, Solaris, AIX, HP-UX, VMS, etc. -- Eric Botcazou

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-20 Thread David Edelsohn
On Tue, Aug 20, 2013 at 4:44 AM, Eric Botcazou wrote: >> Dollar sign is not a valid character in symbols on some platforms, such as >> AIX. > > Sure, but DECL_NAME isn't used for any symbol here, unlike > DECL_ASSEMBLER_NAME. Okay, just wanted to make sure. Thanks, David

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-20 Thread Eric Botcazou
> Dollar sign is not a valid character in symbols on some platforms, such as > AIX. Sure, but DECL_NAME isn't used for any symbol here, unlike DECL_ASSEMBLER_NAME. -- Eric Botcazou

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-19 Thread David Edelsohn
> This patchlet adjusts the DECL_NAME of the cloned functions created by cgraph_create_virtual_clone. It's currently set to a simple copy of the DECL_ASSEMBLER_NAME, which is mildly annoying because it comprises weird platform-independent tweaks, which results in a different output in error messag