Re: [PATCH] Make target_clones resolver fn static.

2020-01-27 Thread Martin Liška
On 1/26/20 6:35 PM, Jeff Law wrote: On Tue, 2020-01-21 at 13:48 +0100, Martin Liška wrote: From a3faaced989869867671ceadd89b56fabde225ff Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Thu, 16 Jan 2020 10:38:41 +0100 Subject: [PATCH] Make target_clones resolver fn static. gcc/ChangeLog: 20

Re: [PATCH] Make target_clones resolver fn static.

2020-01-27 Thread Martin Liška
On 1/23/20 2:52 PM, Alexander Monakov wrote: On Thu, 23 Jan 2020, Martin Liška wrote: So this doesn't help review including two different target changes. Making ifunc dispatchers of public functions non-public looks like an unrelated thing to the bug (sorry if I mis-suggested). So I feel com

Re: [PATCH] Make target_clones resolver fn static.

2020-01-26 Thread Jeff Law
On Tue, 2020-01-21 at 13:48 +0100, Martin Liška wrote: > From a3faaced989869867671ceadd89b56fabde225ff Mon Sep 17 00:00:00 2001 > From: Martin Liska > Date: Thu, 16 Jan 2020 10:38:41 +0100 > Subject: [PATCH] Make target_clones resolver fn static. > > gcc/ChangeLog: > > 2020-01-17 Martin Liska

Re: [PATCH] Make target_clones resolver fn static.

2020-01-23 Thread Alexander Monakov
On Thu, 23 Jan 2020, Martin Liška wrote: > > So this doesn't help review including two different target changes. Making > > ifunc dispatchers of public functions non-public looks like an unrelated > > thing > > to the bug (sorry if I mis-suggested). So I feel comfortable approving the > > earli

Re: [PATCH] Make target_clones resolver fn static.

2020-01-23 Thread Martin Liška
On 1/23/20 2:09 PM, Richard Biener wrote: On Tue, Jan 21, 2020 at 1:48 PM Martin Liška wrote: On 1/20/20 3:52 PM, Richard Biener wrote: On Mon, Jan 20, 2020 at 3:46 PM H.J. Lu wrote: On Mon, Jan 20, 2020 at 6:41 AM Alexander Monakov wrote: On Mon, 20 Jan 2020, H.J. Lu wrote: Bare IF

Re: [PATCH] Make target_clones resolver fn static.

2020-01-23 Thread Richard Biener
On Tue, Jan 21, 2020 at 1:48 PM Martin Liška wrote: > > On 1/20/20 3:52 PM, Richard Biener wrote: > > On Mon, Jan 20, 2020 at 3:46 PM H.J. Lu wrote: > >> > >> On Mon, Jan 20, 2020 at 6:41 AM Alexander Monakov > >> wrote: > >>> > >>> > >>> > >>> On Mon, 20 Jan 2020, H.J. Lu wrote: > >>> > >

Re: [PATCH] Make target_clones resolver fn static.

2020-01-21 Thread Martin Liška
On 1/20/20 3:52 PM, Richard Biener wrote: On Mon, Jan 20, 2020 at 3:46 PM H.J. Lu wrote: On Mon, Jan 20, 2020 at 6:41 AM Alexander Monakov wrote: On Mon, 20 Jan 2020, H.J. Lu wrote: Bare IFUNC's don't seem to have this restriction. Why do we want to constrain target clones this way?

Re: [PATCH] Make target_clones resolver fn static.

2020-01-20 Thread Richard Biener
On Mon, Jan 20, 2020 at 3:46 PM H.J. Lu wrote: > > On Mon, Jan 20, 2020 at 6:41 AM Alexander Monakov wrote: > > > > > > > > On Mon, 20 Jan 2020, H.J. Lu wrote: > > > > > > Bare IFUNC's don't seem to have this restriction. Why do we want to > > > > constrain target clones this way? > > > > > > > >

Re: [PATCH] Make target_clones resolver fn static.

2020-01-20 Thread H.J. Lu
On Mon, Jan 20, 2020 at 6:41 AM Alexander Monakov wrote: > > > > On Mon, 20 Jan 2020, H.J. Lu wrote: > > > > Bare IFUNC's don't seem to have this restriction. Why do we want to > > > constrain target clones this way? > > > > > > > foo's resolver acts as foo. It should have the same visibility as

Re: [PATCH] Make target_clones resolver fn static.

2020-01-20 Thread Alexander Monakov
On Mon, 20 Jan 2020, H.J. Lu wrote: > > Bare IFUNC's don't seem to have this restriction. Why do we want to > > constrain target clones this way? > > > > foo's resolver acts as foo. It should have the same visibility as foo. What do you mean by that? From the implementation standpoint, there

Re: [PATCH] Make target_clones resolver fn static.

2020-01-20 Thread H.J. Lu
On Mon, Jan 20, 2020 at 6:16 AM Alexander Monakov wrote: > > > > On Mon, 20 Jan 2020, H.J. Lu wrote: > > For, > > > > --- > > __attribute__((target_clones("avx","default"))) > > int > > foo () > > { > > return -2; > > } > > > > > > foo's resolver must be global. For > > > > --- > > __attri

Re: [PATCH] Make target_clones resolver fn static.

2020-01-20 Thread Alexander Monakov
On Mon, 20 Jan 2020, H.J. Lu wrote: > For, > > --- > __attribute__((target_clones("avx","default"))) > int > foo () > { > return -2; > } > > > foo's resolver must be global. For > > --- > __attribute__((target_clones("avx","default"))) > static int > foo () > { > return -2; > } > --

Re: [PATCH] Make target_clones resolver fn static.

2020-01-20 Thread H.J. Lu
On Mon, Jan 20, 2020 at 5:36 AM Alexander Monakov wrote: > > > > On Mon, 20 Jan 2020, H.J. Lu wrote: > > We can that only if function is static: > > > [ship asm] > > > > In this case, foo must be global. > > H.J., can you rephrase more clearly? Your response seems contradictory and > does not help

Re: [PATCH] Make target_clones resolver fn static.

2020-01-20 Thread Alexander Monakov
On Mon, 20 Jan 2020, H.J. Lu wrote: > We can that only if function is static: > [ship asm] > > In this case, foo must be global. H.J., can you rephrase more clearly? Your response seems contradictory and does not help to explain the matter. Alexander

Re: [PATCH] Make target_clones resolver fn static.

2020-01-20 Thread H.J. Lu
On Mon, Jan 20, 2020 at 2:25 AM Richard Biener wrote: > > On Fri, Jan 17, 2020 at 10:25 AM Martin Liška wrote: > > > > Hi. > > > > The patch removes need to have a gnu_indirect_function global > > symbol. That aligns the code with what ppc64 target does. > > > > Patch can bootstrap on x86_64-linu

Re: [PATCH] Make target_clones resolver fn static.

2020-01-20 Thread Richard Biener
On Fri, Jan 17, 2020 at 10:25 AM Martin Liška wrote: > > Hi. > > The patch removes need to have a gnu_indirect_function global > symbol. That aligns the code with what ppc64 target does. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Did you