Hi Uros,
On 21 Jul 2013, at 09:15, Uros Bizjak wrote:
> On Sun, Jul 21, 2013 at 9:42 AM, Iain Sandoe wrote:
>
>>>
>>
>> Sure, I can test that - do you want me to apply it assuming it reg-tests OK
>> on darwin & linux?
>> (also I can amend the back ports - since I didn't have time to get to t
On Sun, Jul 21, 2013 at 9:42 AM, Iain Sandoe wrote:
>>
>
> Sure, I can test that - do you want me to apply it assuming it reg-tests OK
> on darwin & linux?
> (also I can amend the back ports - since I didn't have time to get to them
> yesterday)
Yes, please test it on darwin. The build test o
Hi Uros,
On 21 Jul 2013, at 08:34, Uros Bizjak wrote:
>
Sure, I can test that - do you want me to apply it assuming it reg-tests OK on
darwin & linux?
(also I can amend the back ports - since I didn't have time to get to them
yesterday)
thanks
Iain
On Fri, Jul 19, 2013 at 11:00 PM, Jakub Jelinek wrote:
> On Fri, Jul 19, 2013 at 04:56:47PM +0200, Uros Bizjak wrote:
>> > OK for trunk?
>>
>> Assuming that Jakub is OK with the patch, it is OK for trunk.
>
> With the line wrapping fix and Uros' suggested improvement this is ok for
> both trunk an
On Fri, Jul 19, 2013 at 04:56:47PM +0200, Uros Bizjak wrote:
> > OK for trunk?
>
> Assuming that Jakub is OK with the patch, it is OK for trunk.
With the line wrapping fix and Uros' suggested improvement this is ok for
both trunk and branches.
Jakub
On Fri, Jul 19, 2013 at 3:47 PM, Iain Sandoe wrote:
> Hi Uros,
>
> thanks for your reviews,
>
> On 18 Jul 2013, at 12:39, Uros Bizjak wrote:
>
>> On Thu, Jul 18, 2013 at 12:12 PM, Iain Sandoe wrote:
>>>
>>> So, I think we have to use the define_insn_and_split, or am I still missing
>>> something
On Fri, Jul 19, 2013 at 02:47:51PM +0100, Iain Sandoe wrote:
> + /* Get a new pic base. */
> + emit_insn (gen_set_got_labelled (pic_offset_table_rtx, label_rtx));
> + /* Correct this with the offset from the new to the old. */
> + xops[0] = xops[1] = pic_offset_table_rtx;
> +
Hi Uros,
thanks for your reviews,
On 18 Jul 2013, at 12:39, Uros Bizjak wrote:
> On Thu, Jul 18, 2013 at 12:12 PM, Iain Sandoe wrote:
>>
>> So, I think we have to use the define_insn_and_split, or am I still missing
>> something?
>
> Just a wild guess, do you also need "&& reload_completed"
On Thu, Jul 18, 2013 at 12:12 PM, Iain Sandoe wrote:
>> This should be implemented as an expander. You also won't need
>> UNSPEC_NLGR that way.
>
> Now I reload the state from this PR, I recall why this did not work.
>
> in the case:
>
> foo ()
> {
>
> do stuff that doesn't use the pic reg
>
>
Hi Uros,
On 18 Jul 2013, at 07:31, Uros Bizjak wrote:
> This should be implemented as an expander. You also won't need
> UNSPEC_NLGR that way.
Now I reload the state from this PR, I recall why this did not work.
in the case:
foo ()
{
do stuff that doesn't use the pic reg
call nested functi
Hi Uros,
(working on a re-vamp with an expander for the nonlocal goto MD).
On 18 Jul 2013, at 08:26, Uros Bizjak wrote:
> Under assumpiton that foo and bar doesn't share the same GOT, you will
> see that g42 after the label is accessed with "clobbered" %ebx.
My understanding is that foo and ba
Hello!
> The PR is logged against Darwin, and (as Jakub points out in the PR
> thread) indeed Darwin is missing a nonlocal_goto_receiver to restore
> the PIC reg in code that uses it (most of the patch).
>
> However, there is a second issue, and (if I've understood things
> correctly) this affects
Hello!
> The PR is logged against Darwin, and (as Jakub points out in the PR thread)
> indeed Darwin is
> missing a nonlocal_goto_receiver to restore the PIC reg in code that uses it
> (most of the patch).
>
> However, there is a second issue, and (if I've understood things correctly)
> this af
On Jul 17, 2013, at 5:23 PM, Iain Sandoe wrote:
> The PR is logged against Darwin, and (as Jakub points out in the PR thread)
> indeed Darwin is missing a nonlocal_goto_receiver to restore the PIC reg in
> code that uses it (most of the patch).
Darwin bits, Ok. Thanks.
> However, there is a s
Hi,
The PR is logged against Darwin, and (as Jakub points out in the PR thread)
indeed Darwin is missing a nonlocal_goto_receiver to restore the PIC reg in
code that uses it (most of the patch).
However, there is a second issue, and (if I've understood things correctly)
this affects GOT target
15 matches
Mail list logo
