Bootstrap passed; tested under -m32, -m64, debug;
...and committed.
--
Tim Shen
Hi,
>I have to use a vector, because I need to iterate it while
>manipulating it as a stack.
Ok. Strictly speaking, you could't do that with a stack. Maybe you should say
something like we add and remove elements FILO. But don't bother for now.
Paolo
On Sun, Aug 11, 2013 at 2:12 AM, Paolo Carlini wrote:
> On 08/10/2013 06:04 PM, Paolo Carlini wrote:
>>
>> Also, in the new comment, you refer to a "stack", but in the same patch
>> you removed a std::stack and added a std::vector as data member, something
>> seems inconsistent.
>
> I had having a
On 08/10/2013 06:04 PM, Paolo Carlini wrote:
Also, in the new comment, you refer to a "stack", but in the same
patch you removed a std::stack and added a std::vector as data member,
something seems inconsistent.
I had having a closer look to this: if one looks at the code now,
without knowing t
Hi,
On 08/10/2013 12:50 PM, Tim Shen wrote:
On Sat, Aug 10, 2013 at 5:41 PM, Paolo Carlini wrote:
More important: we are adding support for a non trivial feature and not a
single comment in the new code refers to it. This is not ok, please add at
least 2 or 3.
Here it is. Two pieces of code
On Sat, Aug 10, 2013 at 5:41 PM, Paolo Carlini wrote:
> More important: we are adding support for a non trivial feature and not a
> single comment in the new code refers to it. This is not ok, please add at
> least 2 or 3.
Here it is. Two pieces of code concerning implementation logic is
commen
Hi,
Tim Shen ha scritto:
>On Sat, Aug 10, 2013 at 4:58 PM, Paolo Carlini
> wrote:
>> On 08/10/2013 10:37 AM, Tim Shen wrote:
>>>
>>> +regex_match(s, *(&s+1)-1, m, re);
>>
>> I don't like these *(&s+1)-1.
>
>As you wish :)
See wasn't that difficult, after all ;) Seriously, a modern c++ prog
On Sat, Aug 10, 2013 at 4:58 PM, Paolo Carlini wrote:
> On 08/10/2013 10:37 AM, Tim Shen wrote:
>>
>> +regex_match(s, *(&s+1)-1, m, re);
>
> I don't like these *(&s+1)-1.
As you wish :)
--
Tim Shen
changelog
Description: Binary data
backref.patch
Description: Binary data
On 08/10/2013 10:37 AM, Tim Shen wrote:
+regex_match(s, *(&s+1)-1, m, re);
I don't like these *(&s+1)-1.
Paolo.
On Sat, Aug 10, 2013 at 4:37 PM, Tim Shen wrote:
> Nothing surprising here.
>
> Bootstrap passed and tested under x86_64 and i386 Linux.
Changelog.
--
Tim Shen
changelog
Description: Binary data
Nothing surprising here.
Bootstrap passed and tested under x86_64 and i386 Linux.
--
Tim Shen
backref.patch
Description: Binary data
11 matches
Mail list logo
