Re: [Patch][Aarch64][PR target/79924] Cannot translate diagnostics

2018-06-05 Thread Steve Ellcey
On Tue, 2018-06-05 at 20:18 +0100, Richard Sandiford wrote: >  > This still has the change from "floating-point" to "floating point", > but "floating-point" preferred. > > Thanks, > Richard You are right, I missed that.  I haven't checked in the patch yet though so I will fix that before doing th

Re: [Patch][Aarch64][PR target/79924] Cannot translate diagnostics

2018-06-05 Thread Richard Sandiford
Steve Ellcey writes: > On Tue, 2018-06-05 at 13:23 +0100, Richard Sandiford wrote: >>  >> This regresses a couple of things: >> >> - before the patch, the option would be properly quoted, whereas now >>   it's unquoted.  Either keeping %qs or using %<...%> would fix that. >>   Using %qs is probab

Re: [Patch][Aarch64][PR target/79924] Cannot translate diagnostics

2018-06-05 Thread James Greenhalgh
On Tue, Jun 05, 2018 at 12:40:01PM -0500, Steve Ellcey wrote: > On Tue, 2018-06-05 at 13:23 +0100, Richard Sandiford wrote: > >  > > This regresses a couple of things: > > > > - before the patch, the option would be properly quoted, whereas now > >   it's unquoted.  Either keeping %qs or using %<.

Re: [Patch][Aarch64][PR target/79924] Cannot translate diagnostics

2018-06-05 Thread Steve Ellcey
On Tue, 2018-06-05 at 13:23 +0100, Richard Sandiford wrote: >  > This regresses a couple of things: > > - before the patch, the option would be properly quoted, whereas now >   it's unquoted.  Either keeping %qs or using %<...%> would fix that. >   Using %qs is probably nicer since we can reuse th

Re: [Patch][Aarch64][PR target/79924] Cannot translate diagnostics

2018-06-05 Thread Richard Sandiford
Steve Ellcey writes: > @@ -1029,13 +1029,18 @@ aarch64_gen_far_branch (rtx * operands, int > pos_label, const char * dest, > } > > void > -aarch64_err_no_fpadvsimd (machine_mode mode, const char *msg) > +aarch64_err_no_fpadvsimd (machine_mode mode) > { > - const char *mc = FLOAT_MODE_P (mod

Re: [Patch][Aarch64][PR target/79924] Cannot translate diagnostics

2018-06-04 Thread Steve Ellcey
Ping. Steve Ellcey sell...@cavium.com On Thu, 2018-01-11 at 15:44 -0800, Steve Ellcey wrote: > This is a patch for PR target/79924, which says the error messages > called from aarch64_err_no_fpadvsimd cannot be translated due to > how they are constructed.  To make them translatable and not chan

[Patch][Aarch64][PR target/79924] Cannot translate diagnostics

2018-01-11 Thread Steve Ellcey
This is a patch for PR target/79924, which says the error messages called from aarch64_err_no_fpadvsimd cannot be translated due to how they are constructed.  To make them translatable and not change the actual messages would have required creating 16 individual messages which seemed a bit excessiv