On Tue, Jun 05, 2018 at 12:40:01PM -0500, Steve Ellcey wrote: > On Tue, 2018-06-05 at 13:23 +0100, Richard Sandiford wrote: > > > > This regresses a couple of things: > > > > - before the patch, the option would be properly quoted, whereas now > > it's unquoted. Either keeping %qs or using %<...%> would fix that. > > Using %qs is probably nicer since we can reuse the translation for any > > other options or features that end up being incompatible. > > > > - "floating-point" is preferred for modifiers over "floating point". > > > > - some lines are now longer than 80 chars. > > > > Patch LGTM otherwise, but someone else will need to approve. > > > > Thanks, > > Richard > > Here is an updated version with the quotes put back (using %qs) and the > long lines split up. Retested with no regressions.
OK. Thanks for sticking with it over a release cycle and several iterations. Thanks, James > 2018-06-05 Steve Ellcey <sell...@cavium.com> > > PR target/79924 > * config/aarch64/aarch64-protos.h (aarch64_err_no_fpadvsimd): Remove > second argument. > * config/aarch64/aarch64-protos..c (aarch64_err_no_fpadvsimd): > Remove second argument, change how error is called. > (aarch64_layout_arg): Remove second argument from > aarch64_err_no_fpadvsimd call. > (aarch64_init_cumulative_args): Ditto. > (aarch64_gimplify_va_arg_expr): Ditto. > * config/aarch64/aarch64.md (mov<mode>): Ditto. > > 2018-06-05 Steve Ellcey <sell...@cavium.com> > > PR target/79924 > * gcc.target/aarch64/mgeneral-regs_1.c: Update error message. > * gcc.target/aarch64/mgeneral-regs_2.c: Ditto. > * gcc.target/aarch64/mgeneral-regs_3.c: Ditto. > * gcc.target/aarch64/nofp_1.c: Ditto.
