Ping. Steve Ellcey sell...@cavium.com
On Thu, 2018-01-11 at 15:44 -0800, Steve Ellcey wrote: > This is a patch for PR target/79924, which says the error messages > called from aarch64_err_no_fpadvsimd cannot be translated due to > how they are constructed. To make them translatable and not change > the actual messages would have required creating 16 individual > messages > which seemed a bit excessive so I simplified them a bit and fixed > up the test cases that scan for them. > > Instead of having 16 messages with: > > ['-mgeneral-regs-only'|'+nofp' feature modifier] is incompatible with > [vector|floating-point] [argument|return type|varargs|code] > > I changed it to four messages with > > [-mgeneral-regs-only|+nofp feature modifier] is incompatible with the > use of [vector|floating point] types > > The changes I made in the actual messages were: > > Remove the quotes from around '-mgeneral-regs-only' and '+nofp' > because error > messages I saw on other platforms did not use quotes around compiler > flags. > > Replace the specific [argument|return type|varargs|code] terms with > 'use of [vector|floating point] types. This got me from 16 to 4 > messages. I think that since the error message will point at the > actual > line where the problem is, having the message be a bit more generic > is > not a problem. Also I chose to include 'the use of' because having > these > types (and not doing anything with them) will not trigger one of > these > errors only using them in code (as an argument, return type, etc) > will > trigger the error. Also I got rid of the '-' in floating-point since > I didn't see any reason for it to be there. > > Tested with no regressions, OK to checkin? > > Steve Ellcey > sell...@cavium.com > > > 2018-01-11 Steve Ellcey <sell...@cavium.com> > > PR target/79924 > * config/aarch64/aarch64-protos.h (aarch64_err_no_fpadvsimd): > Remove > second argument. > * config/aarch64/aarch64-protos..c (aarch64_err_no_fpadvsimd): > Remove second argument, change how error is called. > (aarch64_layout_arg): Remove second argument from > aarch64_err_no_fpadvsimd call. > (aarch64_init_cumulative_args): Ditto. > (aarch64_gimplify_va_arg_expr): Ditto. > * config/aarch64/aarch64.md (mov<mode>): Ditto. > > > 2018-01-11 Steve Ellcey <sell...@cavium.com> > > PR target/79924 > * gcc.target/aarch64/mgeneral-regs_1.c: Update error message. > * gcc.target/aarch64/mgeneral-regs_2.c: Ditto. > * gcc.target/aarch64/mgeneral-regs_3.c: Ditto. > * gcc.target/aarch64/nofp_1.c: Ditto.
