I see, reverted. Thanks Robin for reminder.
Thanks!
BTW and just for open discussion, is this really a good way for such kind of
tests?
Though most of the tests are similar like this but it may hide possible
unexpected results up to a point.
Yeah we have several flaky tests and in those cas
: Wednesday, April 9, 2025 6:47 PM
To: Li, Pan2 ; Robin Dapp ;
gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; jeffreya...@gmail.com; Chen,
Ken ; Robin Dapp
Subject: Re: [PATCH v1] RISC-V: Refine the testcases for cond_widen_complicate-3
Hi Pan,
Richard committed combine
Hi Pan,
Richard committed combine patches that restored most of the previous behavior
so we shouldn't need the refinement any more.
AFAICT the tests should now pass in their previous state but definitely fail in
their current state. Do you want to revert this change?
Thanks.
--
Regards
Robi
eems no other failures from rvv.exp now.
Pan
-Original Message-
From: Robin Dapp
Sent: Thursday, March 13, 2025 5:48 PM
To: Li, Pan2 ; gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; jeffreya...@gmail.com; Chen,
Ken ; Robin Dapp
Subject: Re: [PATCH v1] RISC-V
I'm not opposed to refactoring but what's the reason for it? We have a large
number of similar tests that also include all possible types. And aren't all
the tests you touch FAILing anyway right now? (Due to the combine change...)
Yes, the cond_widen_complicate-3 need some tweak for the asm
From: Pan Li
Rearrange the test cases of cond_widen_complicate-3 by different types
into different files, instead of put all types together. Then we can
easily reduce the range when asm check fails.
The below test suites are passed locally, let's wait online CI says.
* The rv64gcv fully regress
From: Pan Li
Rearrange the test cases of cond_widen_complicate-3 by different types
into different files, instead of put all types together. Then we can
easily reduce the range when asm check fails.
I'm not opposed to refactoring but what's the reason for it? We have a large
number of simil
o meet current behavior.
Pan
-Original Message-
From: Robin Dapp
Sent: Wednesday, March 12, 2025 7:11 PM
To: Li, Pan2 ; gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; jeffreya...@gmail.com; Chen,
Ken ; Robin Dapp
Subject: Re: [PATCH v1] RISC-V: Refine the testcase
