Re: [PATCH 1/*] Fix common typos.

2013-07-22 Thread Mike Stump
On Jul 22, 2013, at 11:20 AM, Oleg Endo wrote: > On Sun, 2013-07-21 at 09:35 -0700, Mike Stump wrote: >> On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: >>> This is series of typo fixing patches. They are generated with stylepp >>> https://github.com/neleai/stylepp >>> which makes patch generati

Re: [PATCH 1/*] Fix common typos.

2013-07-22 Thread Oleg Endo
On Sun, 2013-07-21 at 09:35 -0700, Mike Stump wrote: > On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > > This is series of typo fixing patches. They are generated with stylepp > > https://github.com/neleai/stylepp > > which makes patch generation very effective. > > I've checked in most change

Re: [PATCH 1/*] Fix common typos.

2013-07-22 Thread Mike Stump
On Jul 21, 2013, at 2:09 PM, Joseph S. Myers wrote: > On Sun, 21 Jul 2013, Mike Stump wrote: > >> I've reviewed and applied the gcc/doc changes that were trivial. The >> only patches not applied were the ok->OK patches. > > *For formal documentation* such as gcc/doc, I think changing ok->OK is

Re: [PATCH 1/*] Fix common typos.

2013-07-22 Thread Mike Stump
On Jul 21, 2013, at 2:18 PM, Joseph S. Myers wrote: > On Sun, 21 Jul 2013, Mike Stump wrote: > >>> diff --git a/gcc/testsuite/c-c++-common/pr41779.c >>> b/gcc/testsuite/c-c++-common/pr41779.c >>> index 80c8e6b..f80412c 100644 >>> --- a/gcc/testsuite/c-c++-common/pr41779.c >>> +++ b/gcc/testsuite

Re: [PATCH 1/*] Fix common typos.

2013-07-22 Thread Mike Stump
On Jul 21, 2013, at 2:21 PM, Joseph S. Myers wrote: > On Sun, 21 Jul 2013, Mike Stump wrote: >> >>> - /* Now we have to go throught the whole table >>> + /* Now we have to go thought the whole table >>> >>> Again, throught -> through. >> >> Fixed. >

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Joseph S. Myers
On Sun, 21 Jul 2013, Mike Stump wrote: > > diff --git a/libiberty/regex.c b/libiberty/regex.c > > index 17091ce..8a2dd41 100644 > > --- a/libiberty/regex.c > > +++ b/libiberty/regex.c > > @@ -3396,7 +3396,7 @@ PREFIX(regex_compile) (const char > > *ARG_PREFIX(pattern), > >

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Joseph S. Myers
On Sun, 21 Jul 2013, Mike Stump wrote: > > diff --git a/gcc/testsuite/c-c++-common/pr41779.c > > b/gcc/testsuite/c-c++-common/pr41779.c > > index 80c8e6b..f80412c 100644 > > --- a/gcc/testsuite/c-c++-common/pr41779.c > > +++ b/gcc/testsuite/c-c++-common/pr41779.c > > @@ -1,4 +1,4 @@ > > -/* PR417

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Joseph S. Myers
On Sun, 21 Jul 2013, Mike Stump wrote: > I've reviewed and applied the gcc/doc changes that were trivial. The > only patches not applied were the ok->OK patches. *For formal documentation* such as gcc/doc, I think changing ok->OK is appropriate; the formal documentation should be more conserva

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
On Jul 21, 2013, at 11:31 AM, Mike Stump wrote: > On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: >> This is series of typo fixing patches. > > I reviewed gcc/[a-i]* and checked in those I thought were trivial. So, I checked in the potentially controversial thru -> through in gcc/ada. I'll l

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > This is series of typo fixing patches. I reviewed gcc/[a-i]* and checked in those I thought were trivial.

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > gcc/c/c-decl.c | 4 +- > > gcc/c/c-objc-common.c | 4 +- >

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > This is series of typo fixing patches. I checked in the fixes to gcc/[l-t]* that were trivial. (ok->OK being the usual exclusion).

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > This is series of typo fixing patches. I reviewed and checked in all that changes to gcc/tree\* that were trivial. I left out ok->OK, and --- a/gcc/tree-ssa-pre.c

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Tobias Burnus
Ondřej Bílka wrote: This is series of typo fixing patches. They are generated with stylepp https://github.com/neleai/stylepp which makes patch generation very effective. [...] Then I ran script/stylepp_fix_spell which produced following 300kb patch: http://kam.mff.cuni.cz/~ondra/0001-Fix-common

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > This is series of typo fixing patches. I checked in all the changes to gcc/cp that were trivial.

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > This is series of typo fixing patches. I reviewed and applied all the trivial patches in gcc/config. Excluded were ok->OK, and /* My current feeling is that r14 should go to the end and maybe even r12.

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Ondřej Bílka
On Sun, Jul 21, 2013 at 04:44:40PM +0200, Marc Glisse wrote: > On Sun, 21 Jul 2013, Ondřej Bílka wrote: > > >Then I ran script/stylepp_fix_spell which produced following 300kb patch: > > > >http://kam.mff.cuni.cz/~ondra/0001-Fix-common-typos.patch > > There are still some wrong fixes, humans real

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > This is series of typo fixing patches. I've reviewed and applied the gcc/doc changes that were trivial. The only patches not applied were the ok->OK patches.

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
I've applied these fixes, to ensure that they are not corrected incorrectly, thanks for the corrections. On Jul 21, 2013, at 8:37 AM, Marek Polacek wrote: > diff --git a/gcc/ipa.c b/gcc/ipa.c > index 7c0d495..d44cf38 100644 > --- a/gcc/ipa.c > +++ b/gcc/ipa.c > @@ -548,7 +548,7 @@ static bool >

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
On Jul 21, 2013, at 8:37 AM, Marek Polacek wrote: > diff --git a/gcc/ada/gcc-interface/utils2.c b/gcc/ada/gcc-interface/utils2.c > index 3f39a43..7f7f6af 100644 > --- a/gcc/ada/gcc-interface/utils2.c > +++ b/gcc/ada/gcc-interface/utils2.c > @@ -1902,7 +1902,7 @@ build_simple_component_ref (tree re

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > This is series of typo fixing patches. They are generated with stylepp > https://github.com/neleai/stylepp > which makes patch generation very effective. I've checked in most changes to Objective-C things and test suite things after reviewing al

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Ondřej Bílka
On Sun, Jul 21, 2013 at 09:09:37AM -0700, Mike Stump wrote: > On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > > + * c-c++-common/raw-string-13.c: Likewise. > > > > + * c-c++-common/raw-string-14.c: Likewis

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Ondřej Bílka
On Sun, Jul 21, 2013 at 05:37:23PM +0200, Marek Polacek wrote: > > A few comments: > snip > diff --git a/gcc/ipa.c b/gcc/ipa.c > index 7c0d495..d44cf38 100644 > --- a/gcc/ipa.c > +++ b/gcc/ipa.c > @@ -548,7 +548,7 @@ static bool > comdat_can_be_unshared_p_1 (symtab_node node) > { >/* When a

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Mike Stump
On Jul 21, 2013, at 7:32 AM, Ondřej Bílka wrote: > + * c-c++-common/raw-string-13.c: Likewise. > > + * c-c++-common/raw-string-14.c: Likewise. >

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Marek Polacek
On Sun, Jul 21, 2013 at 04:32:04PM +0200, Ondřej Bílka wrote: > Hi, > > This is series of typo fixing patches. They are generated with stylepp > https://github.com/neleai/stylepp > which makes patch generation very effective. > > This series should be applied in sequence to avoid reviewing duplic

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Joseph S. Myers
I do not believe such fixes in testsuites make sense. They are definitely inappropriate in testsuite input data (as opposed to comments) without specific rationale in the patch posting for why the change is OK. Changes to gcc/go/gofrontend/ and libgo/ have their own rules as those directories

Re: [PATCH 1/*] Fix common typos.

2013-07-21 Thread Marc Glisse
On Sun, 21 Jul 2013, Ondřej Bílka wrote: This is series of typo fixing patches. They are generated with stylepp https://github.com/neleai/stylepp which makes patch generation very effective. This series should be applied in sequence to avoid reviewing duplicates. Now I exclude those directorie

[PATCH 1/*] Fix common typos.

2013-07-21 Thread Ondřej Bílka
Hi, This is series of typo fixing patches. They are generated with stylepp https://github.com/neleai/stylepp which makes patch generation very effective. This series should be applied in sequence to avoid reviewing duplicates. Now I exclude those directories that are upstream, see file https://g