On Jul 22, 2013, at 11:20 AM, Oleg Endo <[email protected]> wrote:
> On Sun, 2013-07-21 at 09:35 -0700, Mike Stump wrote:
>> On Jul 21, 2013, at 7:32 AM, Ondřej Bílka <[email protected]> wrote:
>>> This is series of typo fixing patches. They are generated with stylepp
>>> https://github.com/neleai/stylepp
>>> which makes patch generation very effective.
>>
>> I've checked in most changes to Objective-C things and test suite things
>> after reviewing all those changes. I agreed with most of the work, except
>> ok -> OK. We don't need to scream in the source, and ok I feel is a fine
>> english word, despite what an expert might think (they would burn us (me) at
>> the grammar stake. They merely trail us in language adoption. :-)
>>
>> One part I will throw out here, in gcc/testsuite/gcc.target/sh/pr54760-4.c:
>>
>> - and its use when a function call is inbetween, when GBR is a call used
>> + and its use when a function call is between, when GBR is a call used
>>
>> I think this should be:
>>
>> - and its use when a function call is inbetween, when GBR is a call used
>> + and its use when a function call is in-between, when GBR is a call used
>>
>> If someone wants to try and counter this, please, I'd favor an expert that
>> can clarify why it would be preferable.
>
> If I remember correctly, it was me who wrote it in the first place.
> It should be 'a function call in between, when'.
Thanks.
Index: testsuite/gcc.target/sh/pr54760-4.c
===================================================================
--- testsuite/gcc.target/sh/pr54760-4.c (revision 201137)
+++ testsuite/gcc.target/sh/pr54760-4.c (working copy)
@@ -1,5 +1,5 @@
/* Check that the GBR address optimization does not combine a gbr store
- and its use when a function call is in-between, when GBR is a call used
+ and its use when a function call is in between, when GBR is a call used
register, i.e. it is invalidated by function calls. */
/* { dg-do compile { target "sh*-*-*" } } */
/* { dg-options "-O1 -fcall-used-gbr" } */
