Re: [PATCH] rs6000: Add -mdejagnu-cpu=

2019-03-04 Thread Segher Boessenkool
On Fri, Mar 01, 2019 at 07:33:27PM +0100, Jakub Jelinek wrote: > We are talking about the > http://git.savannah.gnu.org/cgit/dejagnu.git/commit/?id=5256bd82343000c76bc0e48139003f90b6184347 > change, right? That's the patch I think, yes. One thing I didn't mention is my patch fixed some ten failur

Re: [PATCH] rs6000: Add -mdejagnu-cpu=

2019-03-01 Thread Jakub Jelinek
On Fri, Mar 01, 2019 at 07:09:05PM +0100, Jakub Jelinek wrote: > > > Can't we just detect the old dejagnu and override > > > whatever tcl method is responsible for that? > > > > Not sure. We probably could. But are the new semantics actually > > better? Sometimes you want the testcase flags to

Re: [PATCH] rs6000: Add -mdejagnu-cpu=

2019-03-01 Thread Segher Boessenkool
On Fri, Mar 01, 2019 at 07:09:05PM +0100, Jakub Jelinek wrote: > > Having separate flags for the testcases that say "override the RUNTESTFLAGS" > > gives the best of both worlds. Even with with new dejagnu, where normally > > the RUNTESTFLAGS always wins. > > I thought new dejagnu behavior is RUN

Re: [PATCH] rs6000: Add -mdejagnu-cpu=

2019-03-01 Thread Jakub Jelinek
On Fri, Mar 01, 2019 at 12:00:50PM -0600, Segher Boessenkool wrote: > On Fri, Mar 01, 2019 at 06:07:57PM +0100, Jakub Jelinek wrote: > > On Fri, Mar 01, 2019 at 05:02:58PM +, Segher Boessenkool wrote: > > > This adds an option -mdejagnu-cpu=. This option simply overrides what > > > is given in

Re: [PATCH] rs6000: Add -mdejagnu-cpu=

2019-03-01 Thread Segher Boessenkool
On Fri, Mar 01, 2019 at 06:07:57PM +0100, Jakub Jelinek wrote: > On Fri, Mar 01, 2019 at 05:02:58PM +, Segher Boessenkool wrote: > > This adds an option -mdejagnu-cpu=. This option simply overrides what > > is given in -mcpu=. The reason for this is that with older versions > > of DejaGnu the

Re: [PATCH] rs6000: Add -mdejagnu-cpu=

2019-03-01 Thread Jakub Jelinek
On Fri, Mar 01, 2019 at 05:02:58PM +, Segher Boessenkool wrote: > This adds an option -mdejagnu-cpu=. This option simply overrides what > is given in -mcpu=. The reason for this is that with older versions > of DejaGnu the value given in the RUNTESTFLAGS will override the value > a testcase w

[PATCH] rs6000: Add -mdejagnu-cpu=

2019-03-01 Thread Segher Boessenkool
This adds an option -mdejagnu-cpu=. This option simply overrides what is given in -mcpu=. The reason for this is that with older versions of DejaGnu the value given in the RUNTESTFLAGS will override the value a testcase wants to have. Ill commit this patch with the first changelog, and also the