On Fri, Mar 01, 2019 at 05:02:58PM +0000, Segher Boessenkool wrote:
> This adds an option -mdejagnu-cpu=. This option simply overrides what
> is given in -mcpu=. The reason for this is that with older versions
> of DejaGnu the value given in the RUNTESTFLAGS will override the value
> a testcase wants to have.
Ugh, that is ugly. Can't we just detect the old dejagnu and override
whatever tcl method is responsible for that?
Or just document higher minimum dejagnu version requirement?
> Ill commit this patch with the first changelog, and also the result of
> these two one-liners with the second changelog:
>
> perl -ni -e 'print unless /dg-skip-if "do not override -mcpu"/' \
> $(find gcc/testsuite/gcc.target/powerpc/ -type f)
> perl -pi -e 's/(dg-options.*)-mcpu=/\1-mdejagnu-cpu=/' \
> $(find gcc/testsuite/gcc.target/powerpc/ -type f)
>
>
> Segher
>
>
> 2019-03-01 Segher Boessenkool <seg...@kernel.crashing.org>
>
> * config/rs6000/rs6000.c (rs6000_option_override_internal): If
> rs6000_dejagnu_cpu_index is set, use that to override rs6000_cpu_index.
> * config/rs6000/rs6000.opt (mdejagnu-cpu=): New option.
>
>
> 2019-03-01 Segher Boessenkool <seg...@kernel.crashing.org>
>
> gcc/testsuite/
> * gcc.target/powerpc/ throughout: Delete dg-skip-if "do not override
> -mcpu". Use -mdejagnu-cpu= in dg-options instead of -mcpu=.
Jakub
